)]}'
{"neutron/plugins/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"efbed3a4ace4fe60c7d609b55a328b5b4261d49e","unresolved":false,"context_lines":[{"line_number":862,"context_line":"                                             self.local_ip,"},{"line_number":863,"context_line":"                                             tunnel_type,"},{"line_number":864,"context_line":"                                             self.vxlan_udp_port)"},{"line_number":865,"context_line":"        if int(ofport) \u003c 0:"},{"line_number":866,"context_line":"            LOG.error(_(\"Failed to set-up %(type)s tunnel port to %(ip)s\"),"},{"line_number":867,"context_line":"                      {\u0027type\u0027: tunnel_type, \u0027ip\u0027: remote_ip})"},{"line_number":868,"context_line":"            return 0"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2F9GI%3D","line":865,"updated":"2013-10-24 16:58:35.000000000","message":"Let me clarify.\n\nAccording to the bug report, add_tunnel_port() above returns -1.  It seems to be a normal operation to call add_tunnel_port and I don\u0027t see any reason to fail so far.\n\nMy question is \"-1 means an actual error?\"\nIf it is a normal behavior, the message below is really confusing.\n\nAnyway we need to check it is an expected return value or not.","commit_id":"a90c9c33cd223b9cd7b1c044bdf062429dc6412e"},{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"94c5b789583c5dc60a8c0d96d961604de94cf155","unresolved":false,"context_lines":[{"line_number":862,"context_line":"                                             self.local_ip,"},{"line_number":863,"context_line":"                                             tunnel_type,"},{"line_number":864,"context_line":"                                             self.vxlan_udp_port)"},{"line_number":865,"context_line":"        if int(ofport) \u003c 0:"},{"line_number":866,"context_line":"            LOG.error(_(\"Failed to set-up %(type)s tunnel port to %(ip)s\"),"},{"line_number":867,"context_line":"                      {\u0027type\u0027: tunnel_type, \u0027ip\u0027: remote_ip})"},{"line_number":868,"context_line":"            return 0"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2F7fg%3D","line":865,"in_reply_to":"AAAATn%2F%2F9GI%3D","updated":"2013-10-25 03:16:46.000000000","message":"-1 means a real error. In my investigation, it is because of old kernel module (I have updated the bug report).","commit_id":"a90c9c33cd223b9cd7b1c044bdf062429dc6412e"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"e60492cca87de236b89a74afddd406ea77d9668f","unresolved":false,"context_lines":[{"line_number":862,"context_line":"                                             self.local_ip,"},{"line_number":863,"context_line":"                                             tunnel_type,"},{"line_number":864,"context_line":"                                             self.vxlan_udp_port)"},{"line_number":865,"context_line":"        if int(ofport) \u003c 0:"},{"line_number":866,"context_line":"            LOG.error(_(\"Failed to set-up %(type)s tunnel port to %(ip)s\"),"},{"line_number":867,"context_line":"                      {\u0027type\u0027: tunnel_type, \u0027ip\u0027: remote_ip})"},{"line_number":868,"context_line":"            return 0"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2FWWY%3D","line":865,"updated":"2013-11-08 15:27:20.000000000","message":"Should this have a try/catch block for if int(ofport) throws a ValueError?","commit_id":"acf97b025f97a28fcb1eed1626835948fa6b2665"},{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"21e37a429d9eb572667797b626d771f610064286","unresolved":false,"context_lines":[{"line_number":862,"context_line":"                                             self.local_ip,"},{"line_number":863,"context_line":"                                             tunnel_type,"},{"line_number":864,"context_line":"                                             self.vxlan_udp_port)"},{"line_number":865,"context_line":"        if int(ofport) \u003c 0:"},{"line_number":866,"context_line":"            LOG.error(_(\"Failed to set-up %(type)s tunnel port to %(ip)s\"),"},{"line_number":867,"context_line":"                      {\u0027type\u0027: tunnel_type, \u0027ip\u0027: remote_ip})"},{"line_number":868,"context_line":"            return 0"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2FTo8%3D","line":865,"in_reply_to":"AAAATn%2F%2FWWY%3D","updated":"2013-11-11 09:45:12.000000000","message":"Done","commit_id":"acf97b025f97a28fcb1eed1626835948fa6b2665"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"b3f011e9aa481893c11d355e6cef266e6864d7be","unresolved":false,"context_lines":[{"line_number":867,"context_line":"            ofport_int \u003d int(ofport)"},{"line_number":868,"context_line":"        except (TypeError, ValueError):"},{"line_number":869,"context_line":"            LOG.exception(_(\"ofport should have a value can be interpreted\""},{"line_number":870,"context_line":"                            \"as an integer\"))"},{"line_number":871,"context_line":"        if ofport_int \u003c 0:"},{"line_number":872,"context_line":"            LOG.error(_(\"Failed to set-up %(type)s tunnel port to %(ip)s\"),"},{"line_number":873,"context_line":"                      {\u0027type\u0027: tunnel_type, \u0027ip\u0027: remote_ip})"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2FSx8%3D","line":870,"updated":"2013-11-11 15:11:58.000000000","message":"\"... a value that can be ...\"\n\nAlso you need to add a space between \u0027interpreted\u0027 and \u0027as\u0027.","commit_id":"ef510aee2dd9d64812cd8bc91a601e95f0d4e50e"},{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"f9df79b74fe59951f3c128fa41e053393502ac36","unresolved":false,"context_lines":[{"line_number":867,"context_line":"            ofport_int \u003d int(ofport)"},{"line_number":868,"context_line":"        except (TypeError, ValueError):"},{"line_number":869,"context_line":"            LOG.exception(_(\"ofport should have a value can be interpreted\""},{"line_number":870,"context_line":"                            \"as an integer\"))"},{"line_number":871,"context_line":"        if ofport_int \u003c 0:"},{"line_number":872,"context_line":"            LOG.error(_(\"Failed to set-up %(type)s tunnel port to %(ip)s\"),"},{"line_number":873,"context_line":"                      {\u0027type\u0027: tunnel_type, \u0027ip\u0027: remote_ip})"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2FQkU%3D","line":870,"in_reply_to":"AAAATn%2F%2FSx8%3D","updated":"2013-11-12 05:40:29.000000000","message":"Done","commit_id":"ef510aee2dd9d64812cd8bc91a601e95f0d4e50e"}],"neutron/tests/unit/openvswitch/test_ovs_neutron_agent.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8c15d4bd40e977ef21c0a47498be2f6a41a93b17","unresolved":false,"context_lines":[{"line_number":593,"context_line":""},{"line_number":594,"context_line":"    def test_setup_tunnel_port_error_negative(self):"},{"line_number":595,"context_line":"        with contextlib.nested("},{"line_number":596,"context_line":"            mock.patch.object(self.agent.tun_br, \u0027add_tunnel_port\u0027),"},{"line_number":597,"context_line":"            mock.patch.object(ovs_neutron_agent.LOG, \u0027error\u0027)"},{"line_number":598,"context_line":"        ) as (add_tunnel_port_fn, log_error_fn):"},{"line_number":599,"context_line":"            add_tunnel_port_fn.return_value \u003d \u0027-1\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2FSmk%3D","line":596,"updated":"2013-11-11 15:45:16.000000000","message":"Nit: I prefer to:\n\n  mock.patch.object(self.agent.tun_br, \u0027add_tunnel_port\u0027,\n                    return_value\u003d\u0027-1\u0027)\n\nand remove L.599.","commit_id":"ef510aee2dd9d64812cd8bc91a601e95f0d4e50e"},{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"f9df79b74fe59951f3c128fa41e053393502ac36","unresolved":false,"context_lines":[{"line_number":593,"context_line":""},{"line_number":594,"context_line":"    def test_setup_tunnel_port_error_negative(self):"},{"line_number":595,"context_line":"        with contextlib.nested("},{"line_number":596,"context_line":"            mock.patch.object(self.agent.tun_br, \u0027add_tunnel_port\u0027),"},{"line_number":597,"context_line":"            mock.patch.object(ovs_neutron_agent.LOG, \u0027error\u0027)"},{"line_number":598,"context_line":"        ) as (add_tunnel_port_fn, log_error_fn):"},{"line_number":599,"context_line":"            add_tunnel_port_fn.return_value \u003d \u0027-1\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2FQlA%3D","line":596,"in_reply_to":"AAAATn%2F%2FSmk%3D","updated":"2013-11-12 05:40:29.000000000","message":"Done","commit_id":"ef510aee2dd9d64812cd8bc91a601e95f0d4e50e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8c15d4bd40e977ef21c0a47498be2f6a41a93b17","unresolved":false,"context_lines":[{"line_number":602,"context_line":"            add_tunnel_port_fn.assert_called_once_with("},{"line_number":603,"context_line":"                \u0027gre-1\u0027, \u0027remote_ip\u0027, self.agent.local_ip, constants.TYPE_GRE,"},{"line_number":604,"context_line":"                self.agent.vxlan_udp_port)"},{"line_number":605,"context_line":"            log_error_fn.asserr_called_once_with("},{"line_number":606,"context_line":"                _(\"Failed to set-up %(type)s tunnel port to %(ip)s\"),"},{"line_number":607,"context_line":"                {\u0027type\u0027: constants.TYPE_GRE, \u0027ip\u0027: \u0027remote_ip\u0027})"},{"line_number":608,"context_line":"            self.assertEqual(ofport, 0)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2FSnE%3D","line":605,"updated":"2013-11-11 15:45:16.000000000","message":"Same as the below.","commit_id":"ef510aee2dd9d64812cd8bc91a601e95f0d4e50e"},{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"f9df79b74fe59951f3c128fa41e053393502ac36","unresolved":false,"context_lines":[{"line_number":602,"context_line":"            add_tunnel_port_fn.assert_called_once_with("},{"line_number":603,"context_line":"                \u0027gre-1\u0027, \u0027remote_ip\u0027, self.agent.local_ip, constants.TYPE_GRE,"},{"line_number":604,"context_line":"                self.agent.vxlan_udp_port)"},{"line_number":605,"context_line":"            log_error_fn.asserr_called_once_with("},{"line_number":606,"context_line":"                _(\"Failed to set-up %(type)s tunnel port to %(ip)s\"),"},{"line_number":607,"context_line":"                {\u0027type\u0027: constants.TYPE_GRE, \u0027ip\u0027: \u0027remote_ip\u0027})"},{"line_number":608,"context_line":"            self.assertEqual(ofport, 0)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2FQk8%3D","line":605,"in_reply_to":"AAAATn%2F%2FSnE%3D","updated":"2013-11-12 05:40:29.000000000","message":"Done","commit_id":"ef510aee2dd9d64812cd8bc91a601e95f0d4e50e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8c15d4bd40e977ef21c0a47498be2f6a41a93b17","unresolved":false,"context_lines":[{"line_number":609,"context_line":""},{"line_number":610,"context_line":"    def test_setup_tunnel_port_error_not_int(self):"},{"line_number":611,"context_line":"        with contextlib.nested("},{"line_number":612,"context_line":"            mock.patch.object(self.agent.tun_br, \u0027add_tunnel_port\u0027),"},{"line_number":613,"context_line":"            mock.patch.object(ovs_neutron_agent.LOG, \u0027exception\u0027),"},{"line_number":614,"context_line":"            mock.patch.object(ovs_neutron_agent.LOG, \u0027error\u0027)"},{"line_number":615,"context_line":"        ) as (add_tunnel_port_fn, log_exc_fn, log_error_fn):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2FSmc%3D","line":612,"updated":"2013-11-11 15:45:16.000000000","message":"Nit: I prefer to adding \"return_value\u003dNone\" here. It is just my preference but I believe it is easier to read.","commit_id":"ef510aee2dd9d64812cd8bc91a601e95f0d4e50e"},{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"f9df79b74fe59951f3c128fa41e053393502ac36","unresolved":false,"context_lines":[{"line_number":609,"context_line":""},{"line_number":610,"context_line":"    def test_setup_tunnel_port_error_not_int(self):"},{"line_number":611,"context_line":"        with contextlib.nested("},{"line_number":612,"context_line":"            mock.patch.object(self.agent.tun_br, \u0027add_tunnel_port\u0027),"},{"line_number":613,"context_line":"            mock.patch.object(ovs_neutron_agent.LOG, \u0027exception\u0027),"},{"line_number":614,"context_line":"            mock.patch.object(ovs_neutron_agent.LOG, \u0027error\u0027)"},{"line_number":615,"context_line":"        ) as (add_tunnel_port_fn, log_exc_fn, log_error_fn):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2FQk0%3D","line":612,"in_reply_to":"AAAATn%2F%2FSmc%3D","updated":"2013-11-12 05:40:29.000000000","message":"Done","commit_id":"ef510aee2dd9d64812cd8bc91a601e95f0d4e50e"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"b3f011e9aa481893c11d355e6cef266e6864d7be","unresolved":false,"context_lines":[{"line_number":622,"context_line":"                self.agent.vxlan_udp_port)"},{"line_number":623,"context_line":"            log_exc_fn.asserr_called_once_with("},{"line_number":624,"context_line":"                _(\"ofport should have a value can be interpreted \""},{"line_number":625,"context_line":"                  \"as an integer\"))"},{"line_number":626,"context_line":"            log_error_fn.asserr_called_once_with("},{"line_number":627,"context_line":"                _(\"Failed to set-up %(type)s tunnel port to %(ip)s\"),"},{"line_number":628,"context_line":"                {\u0027type\u0027: constants.TYPE_GRE, \u0027ip\u0027: \u0027remote_ip\u0027})"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2FSug%3D","line":625,"updated":"2013-11-11 15:11:58.000000000","message":"Here you have a space between \u0027interpreted\u0027 and \u0027as\u0027 but in setup_tunnel_port() you don\u0027t, so I suspect that this test is not really testing correctly? Or the string is ignored in the test?","commit_id":"ef510aee2dd9d64812cd8bc91a601e95f0d4e50e"},{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"f9df79b74fe59951f3c128fa41e053393502ac36","unresolved":false,"context_lines":[{"line_number":622,"context_line":"                self.agent.vxlan_udp_port)"},{"line_number":623,"context_line":"            log_exc_fn.asserr_called_once_with("},{"line_number":624,"context_line":"                _(\"ofport should have a value can be interpreted \""},{"line_number":625,"context_line":"                  \"as an integer\"))"},{"line_number":626,"context_line":"            log_error_fn.asserr_called_once_with("},{"line_number":627,"context_line":"                _(\"Failed to set-up %(type)s tunnel port to %(ip)s\"),"},{"line_number":628,"context_line":"                {\u0027type\u0027: constants.TYPE_GRE, \u0027ip\u0027: \u0027remote_ip\u0027})"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2FQko%3D","line":625,"in_reply_to":"AAAATn%2F%2FSnY%3D","updated":"2013-11-12 05:40:29.000000000","message":"Done. It is surprising that the typo caused no runtime error.","commit_id":"ef510aee2dd9d64812cd8bc91a601e95f0d4e50e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8c15d4bd40e977ef21c0a47498be2f6a41a93b17","unresolved":false,"context_lines":[{"line_number":622,"context_line":"                self.agent.vxlan_udp_port)"},{"line_number":623,"context_line":"            log_exc_fn.asserr_called_once_with("},{"line_number":624,"context_line":"                _(\"ofport should have a value can be interpreted \""},{"line_number":625,"context_line":"                  \"as an integer\"))"},{"line_number":626,"context_line":"            log_error_fn.asserr_called_once_with("},{"line_number":627,"context_line":"                _(\"Failed to set-up %(type)s tunnel port to %(ip)s\"),"},{"line_number":628,"context_line":"                {\u0027type\u0027: constants.TYPE_GRE, \u0027ip\u0027: \u0027remote_ip\u0027})"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2FSnY%3D","line":625,"in_reply_to":"AAAATn%2F%2FSug%3D","updated":"2013-11-11 15:45:16.000000000","message":"Ah, Good catch!! there is a typo.\n\nasserr_called_once_with -\u003e assert_called_once_with","commit_id":"ef510aee2dd9d64812cd8bc91a601e95f0d4e50e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8c15d4bd40e977ef21c0a47498be2f6a41a93b17","unresolved":false,"context_lines":[{"line_number":623,"context_line":"            log_exc_fn.asserr_called_once_with("},{"line_number":624,"context_line":"                _(\"ofport should have a value can be interpreted \""},{"line_number":625,"context_line":"                  \"as an integer\"))"},{"line_number":626,"context_line":"            log_error_fn.asserr_called_once_with("},{"line_number":627,"context_line":"                _(\"Failed to set-up %(type)s tunnel port to %(ip)s\"),"},{"line_number":628,"context_line":"                {\u0027type\u0027: constants.TYPE_GRE, \u0027ip\u0027: \u0027remote_ip\u0027})"},{"line_number":629,"context_line":"            self.assertEqual(ofport, 0)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2FSnU%3D","line":626,"updated":"2013-11-11 15:45:16.000000000","message":"ditto","commit_id":"ef510aee2dd9d64812cd8bc91a601e95f0d4e50e"},{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"f9df79b74fe59951f3c128fa41e053393502ac36","unresolved":false,"context_lines":[{"line_number":623,"context_line":"            log_exc_fn.asserr_called_once_with("},{"line_number":624,"context_line":"                _(\"ofport should have a value can be interpreted \""},{"line_number":625,"context_line":"                  \"as an integer\"))"},{"line_number":626,"context_line":"            log_error_fn.asserr_called_once_with("},{"line_number":627,"context_line":"                _(\"Failed to set-up %(type)s tunnel port to %(ip)s\"),"},{"line_number":628,"context_line":"                {\u0027type\u0027: constants.TYPE_GRE, \u0027ip\u0027: \u0027remote_ip\u0027})"},{"line_number":629,"context_line":"            self.assertEqual(ofport, 0)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2FQks%3D","line":626,"in_reply_to":"AAAATn%2F%2FSnU%3D","updated":"2013-11-12 05:40:29.000000000","message":"Done","commit_id":"ef510aee2dd9d64812cd8bc91a601e95f0d4e50e"}]}
