)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b2ef3ca3882d448cb0336645da0f8ab1174ae640","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix race condition with enabling SG on many ports at once"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When there is many calls to enable security groups on ports there"},{"line_number":10,"context_line":"can be sometimes race contition with between refresh recource_cache"},{"line_number":11,"context_line":"with data get by \"pull\" call to neutron server and data received"},{"line_number":12,"context_line":"with \"push\" rpc message from neutron server."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f96bb07_b7f705d5","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":13},"updated":"2018-01-23 10:25:40.000000000","message":"are","commit_id":"3e9316490521b335267f9ceeb06bc71c1ecc292a"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"470c7a104eefeed92ffee764a6d9fbae9e91d5da","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix race condition with enabling SG on many ports at once"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When there is many calls to enable security groups on ports there"},{"line_number":10,"context_line":"can be sometimes race contition with between refresh recource_cache"},{"line_number":11,"context_line":"with data get by \"pull\" call to neutron server and data received"},{"line_number":12,"context_line":"with \"push\" rpc message from neutron server."},{"line_number":13,"context_line":"In such case when \"push\" message comes with information about"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f96bb07_372a15e7","line":10,"range":{"start_line":10,"start_character":22,"end_line":10,"end_character":36},"updated":"2018-01-22 13:56:15.000000000","message":"condition","commit_id":"3e9316490521b335267f9ceeb06bc71c1ecc292a"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b2ef3ca3882d448cb0336645da0f8ab1174ae640","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix race condition with enabling SG on many ports at once"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When there is many calls to enable security groups on ports there"},{"line_number":10,"context_line":"can be sometimes race contition with between refresh recource_cache"},{"line_number":11,"context_line":"with data get by \"pull\" call to neutron server and data received"},{"line_number":12,"context_line":"with \"push\" rpc message from neutron server."},{"line_number":13,"context_line":"In such case when \"push\" message comes with information about"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f96bb07_77017daf","line":10,"range":{"start_line":10,"start_character":22,"end_line":10,"end_character":31},"updated":"2018-01-23 10:25:40.000000000","message":"condition","commit_id":"3e9316490521b335267f9ceeb06bc71c1ecc292a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b3f07ce4561825a6e1207ce2593a5d76ba87153d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix race condition with enabling SG on many ports at once"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When there is many calls to enable security groups on ports there"},{"line_number":10,"context_line":"can be sometimes race contition with between refresh recource_cache"},{"line_number":11,"context_line":"with data get by \"pull\" call to neutron server and data received"},{"line_number":12,"context_line":"with \"push\" rpc message from neutron server."},{"line_number":13,"context_line":"In such case when \"push\" message comes with information about"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f96bb07_4d8e302f","line":10,"range":{"start_line":10,"start_character":22,"end_line":10,"end_character":36},"in_reply_to":"7f96bb07_372a15e7","updated":"2018-01-22 14:49:42.000000000","message":"Done","commit_id":"3e9316490521b335267f9ceeb06bc71c1ecc292a"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b2ef3ca3882d448cb0336645da0f8ab1174ae640","unresolved":false,"context_lines":[{"line_number":13,"context_line":"In such case when \"push\" message comes with information about"},{"line_number":14,"context_line":"updated port (with enabled port_security), in local cache this port"},{"line_number":15,"context_line":"is already updated so local AFTER_UPDATE call is not called for"},{"line_number":16,"context_line":"such port and it\u0027s rules in firewall are not updated."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch fixes it by changing way how items are updated resource_cache."},{"line_number":19,"context_line":"For now it is done with record_resource_update() method instead of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f96bb07_f726ed68","line":16,"range":{"start_line":16,"start_character":14,"end_line":16,"end_character":18},"updated":"2018-01-23 10:25:40.000000000","message":"its","commit_id":"3e9316490521b335267f9ceeb06bc71c1ecc292a"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"470c7a104eefeed92ffee764a6d9fbae9e91d5da","unresolved":false,"context_lines":[{"line_number":13,"context_line":"In such case when \"push\" message comes with information about"},{"line_number":14,"context_line":"updated port (with enabled port_security), in local cache this port"},{"line_number":15,"context_line":"is already updated so local AFTER_UPDATE call is not called for"},{"line_number":16,"context_line":"such port and it\u0027s rules in firewall are not updated."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch fixes it by changing way how items are updated resource_cache."},{"line_number":19,"context_line":"For now it is done with record_resource_update() method instead of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f96bb07_d723b104","line":16,"range":{"start_line":16,"start_character":14,"end_line":16,"end_character":17},"updated":"2018-01-22 13:56:15.000000000","message":"just \u0027its\u0027","commit_id":"3e9316490521b335267f9ceeb06bc71c1ecc292a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b3f07ce4561825a6e1207ce2593a5d76ba87153d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"In such case when \"push\" message comes with information about"},{"line_number":14,"context_line":"updated port (with enabled port_security), in local cache this port"},{"line_number":15,"context_line":"is already updated so local AFTER_UPDATE call is not called for"},{"line_number":16,"context_line":"such port and it\u0027s rules in firewall are not updated."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch fixes it by changing way how items are updated resource_cache."},{"line_number":19,"context_line":"For now it is done with record_resource_update() method instead of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f96bb07_ed829c00","line":16,"range":{"start_line":16,"start_character":14,"end_line":16,"end_character":17},"in_reply_to":"7f96bb07_d723b104","updated":"2018-01-22 14:49:42.000000000","message":"Done","commit_id":"3e9316490521b335267f9ceeb06bc71c1ecc292a"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"470c7a104eefeed92ffee764a6d9fbae9e91d5da","unresolved":false,"context_lines":[{"line_number":15,"context_line":"is already updated so local AFTER_UPDATE call is not called for"},{"line_number":16,"context_line":"such port and it\u0027s rules in firewall are not updated."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch fixes it by changing way how items are updated resource_cache."},{"line_number":19,"context_line":"For now it is done with record_resource_update() method instead of"},{"line_number":20,"context_line":"writing new values directly to resource_cache._type_cache dict."},{"line_number":21,"context_line":"Due to that if resource will be updated during \"pull\" call to neutron"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f96bb07_7775fdf9","line":18,"range":{"start_line":18,"start_character":50,"end_line":18,"end_character":58},"updated":"2018-01-22 13:56:15.000000000","message":"\u0027updated in\u0027","commit_id":"3e9316490521b335267f9ceeb06bc71c1ecc292a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b3f07ce4561825a6e1207ce2593a5d76ba87153d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"is already updated so local AFTER_UPDATE call is not called for"},{"line_number":16,"context_line":"such port and it\u0027s rules in firewall are not updated."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch fixes it by changing way how items are updated resource_cache."},{"line_number":19,"context_line":"For now it is done with record_resource_update() method instead of"},{"line_number":20,"context_line":"writing new values directly to resource_cache._type_cache dict."},{"line_number":21,"context_line":"Due to that if resource will be updated during \"pull\" call to neutron"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f96bb07_6d768c41","line":18,"range":{"start_line":18,"start_character":50,"end_line":18,"end_character":58},"in_reply_to":"7f96bb07_7775fdf9","updated":"2018-01-22 14:49:42.000000000","message":"Done","commit_id":"3e9316490521b335267f9ceeb06bc71c1ecc292a"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b2ef3ca3882d448cb0336645da0f8ab1174ae640","unresolved":false,"context_lines":[{"line_number":22,"context_line":"server, local AFTER_UPDATE will still be triggered for such resource."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I5a62cc5731c5ba571506a3aa26303a1b0290d37b"},{"line_number":25,"context_line":"Closes-Task: #1742401"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f96bb07_b7e5c50c","line":25,"range":{"start_line":25,"start_character":7,"end_line":25,"end_character":11},"updated":"2018-01-23 10:25:40.000000000","message":"Bug ?","commit_id":"3e9316490521b335267f9ceeb06bc71c1ecc292a"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b2ef3ca3882d448cb0336645da0f8ab1174ae640","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix race condition with enabling SG on many ports at once"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When there is many calls to enable security groups on ports there"},{"line_number":10,"context_line":"can be sometimes race contition between refresh recource_cache"},{"line_number":11,"context_line":"with data get by \"pull\" call to neutron server and data received"},{"line_number":12,"context_line":"with \"push\" rpc message from neutron server."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f96bb07_ae8c6e35","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":13},"updated":"2018-01-23 10:25:40.000000000","message":"are","commit_id":"5e25d4a7e453ac1b7e138408a164a571ab6f9d30"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fa117e0e839466aabe5a17c0df2f88019f638a05","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix race condition with enabling SG on many ports at once"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When there is many calls to enable security groups on ports there"},{"line_number":10,"context_line":"can be sometimes race contition between refresh recource_cache"},{"line_number":11,"context_line":"with data get by \"pull\" call to neutron server and data received"},{"line_number":12,"context_line":"with \"push\" rpc message from neutron server."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f96bb07_5fa7960c","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":13},"in_reply_to":"7f96bb07_ae8c6e35","updated":"2018-01-23 12:12:47.000000000","message":"Done","commit_id":"5e25d4a7e453ac1b7e138408a164a571ab6f9d30"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b2ef3ca3882d448cb0336645da0f8ab1174ae640","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix race condition with enabling SG on many ports at once"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When there is many calls to enable security groups on ports there"},{"line_number":10,"context_line":"can be sometimes race contition between refresh recource_cache"},{"line_number":11,"context_line":"with data get by \"pull\" call to neutron server and data received"},{"line_number":12,"context_line":"with \"push\" rpc message from neutron server."},{"line_number":13,"context_line":"In such case when \"push\" message comes with information about"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f96bb07_2e785e29","line":10,"range":{"start_line":10,"start_character":22,"end_line":10,"end_character":31},"updated":"2018-01-23 10:25:40.000000000","message":"condition","commit_id":"5e25d4a7e453ac1b7e138408a164a571ab6f9d30"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fa117e0e839466aabe5a17c0df2f88019f638a05","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix race condition with enabling SG on many ports at once"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When there is many calls to enable security groups on ports there"},{"line_number":10,"context_line":"can be sometimes race contition between refresh recource_cache"},{"line_number":11,"context_line":"with data get by \"pull\" call to neutron server and data received"},{"line_number":12,"context_line":"with \"push\" rpc message from neutron server."},{"line_number":13,"context_line":"In such case when \"push\" message comes with information about"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f96bb07_bfb7ba3a","line":10,"range":{"start_line":10,"start_character":22,"end_line":10,"end_character":31},"in_reply_to":"7f96bb07_2e785e29","updated":"2018-01-23 12:12:47.000000000","message":"Done","commit_id":"5e25d4a7e453ac1b7e138408a164a571ab6f9d30"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b2ef3ca3882d448cb0336645da0f8ab1174ae640","unresolved":false,"context_lines":[{"line_number":39,"context_line":"   updated (changed security groups), so it checks info about this port"},{"line_number":40,"context_line":"   in local cache,"},{"line_number":41,"context_line":"7. in local cache info about port 2 is already WITH updated security"},{"line_number":42,"context_line":"   group so RemoteResourceCache don\u0027t trigger local notification about"},{"line_number":43,"context_line":"   port AFTER UPDATE and L2 agent don\u0027t know that security groups for this"},{"line_number":44,"context_line":"   port should be changed"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f96bb07_0e6c8234","line":42,"range":{"start_line":42,"start_character":32,"end_line":42,"end_character":35},"updated":"2018-01-23 10:25:40.000000000","message":"doesn\u0027t","commit_id":"5e25d4a7e453ac1b7e138408a164a571ab6f9d30"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fa117e0e839466aabe5a17c0df2f88019f638a05","unresolved":false,"context_lines":[{"line_number":39,"context_line":"   updated (changed security groups), so it checks info about this port"},{"line_number":40,"context_line":"   in local cache,"},{"line_number":41,"context_line":"7. in local cache info about port 2 is already WITH updated security"},{"line_number":42,"context_line":"   group so RemoteResourceCache don\u0027t trigger local notification about"},{"line_number":43,"context_line":"   port AFTER UPDATE and L2 agent don\u0027t know that security groups for this"},{"line_number":44,"context_line":"   port should be changed"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f96bb07_bf901a97","line":42,"range":{"start_line":42,"start_character":32,"end_line":42,"end_character":35},"in_reply_to":"7f96bb07_0e6c8234","updated":"2018-01-23 12:12:47.000000000","message":"Done","commit_id":"5e25d4a7e453ac1b7e138408a164a571ab6f9d30"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b2ef3ca3882d448cb0336645da0f8ab1174ae640","unresolved":false,"context_lines":[{"line_number":40,"context_line":"   in local cache,"},{"line_number":41,"context_line":"7. in local cache info about port 2 is already WITH updated security"},{"line_number":42,"context_line":"   group so RemoteResourceCache don\u0027t trigger local notification about"},{"line_number":43,"context_line":"   port AFTER UPDATE and L2 agent don\u0027t know that security groups for this"},{"line_number":44,"context_line":"   port should be changed"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"This patch fixes it by changing way how items are updated in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f96bb07_8e61723c","line":43,"range":{"start_line":43,"start_character":34,"end_line":43,"end_character":37},"updated":"2018-01-23 10:25:40.000000000","message":"doesn\u0027t","commit_id":"5e25d4a7e453ac1b7e138408a164a571ab6f9d30"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fa117e0e839466aabe5a17c0df2f88019f638a05","unresolved":false,"context_lines":[{"line_number":40,"context_line":"   in local cache,"},{"line_number":41,"context_line":"7. in local cache info about port 2 is already WITH updated security"},{"line_number":42,"context_line":"   group so RemoteResourceCache don\u0027t trigger local notification about"},{"line_number":43,"context_line":"   port AFTER UPDATE and L2 agent don\u0027t know that security groups for this"},{"line_number":44,"context_line":"   port should be changed"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"This patch fixes it by changing way how items are updated in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f96bb07_7fe85215","line":43,"range":{"start_line":43,"start_character":34,"end_line":43,"end_character":37},"in_reply_to":"7f96bb07_8e61723c","updated":"2018-01-23 12:12:47.000000000","message":"Done","commit_id":"5e25d4a7e453ac1b7e138408a164a571ab6f9d30"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b2ef3ca3882d448cb0336645da0f8ab1174ae640","unresolved":false,"context_lines":[{"line_number":44,"context_line":"   port should be changed"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"This patch fixes it by changing way how items are updated in"},{"line_number":47,"context_line":"resource_cache."},{"line_number":48,"context_line":"For now it is done with record_resource_update() method instead of"},{"line_number":49,"context_line":"writing new values directly to resource_cache._type_cache dict."},{"line_number":50,"context_line":"Due to that if resource will be updated during \"pull\" call to neutron"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f96bb07_2e505e5e","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":14},"updated":"2018-01-23 10:25:40.000000000","message":"the resource_cache","commit_id":"5e25d4a7e453ac1b7e138408a164a571ab6f9d30"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fa117e0e839466aabe5a17c0df2f88019f638a05","unresolved":false,"context_lines":[{"line_number":44,"context_line":"   port should be changed"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"This patch fixes it by changing way how items are updated in"},{"line_number":47,"context_line":"resource_cache."},{"line_number":48,"context_line":"For now it is done with record_resource_update() method instead of"},{"line_number":49,"context_line":"writing new values directly to resource_cache._type_cache dict."},{"line_number":50,"context_line":"Due to that if resource will be updated during \"pull\" call to neutron"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f96bb07_ffdb027a","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":14},"in_reply_to":"7f96bb07_2e505e5e","updated":"2018-01-23 12:12:47.000000000","message":"Done","commit_id":"5e25d4a7e453ac1b7e138408a164a571ab6f9d30"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6740ebb44fc17643ff0773cbcfc9982b1679e867","unresolved":false,"context_lines":[{"line_number":51,"context_line":"server, local AFTER_UPDATE will still be triggered for such resource."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Change-Id: I5a62cc5731c5ba571506a3aa26303a1b0290d37b"},{"line_number":54,"context_line":"Closes-Task: #1742401"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f96bb07_2e5a9e4f","line":54,"range":{"start_line":54,"start_character":7,"end_line":54,"end_character":11},"updated":"2018-01-23 10:26:04.000000000","message":"Bug","commit_id":"5e25d4a7e453ac1b7e138408a164a571ab6f9d30"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fa117e0e839466aabe5a17c0df2f88019f638a05","unresolved":false,"context_lines":[{"line_number":51,"context_line":"server, local AFTER_UPDATE will still be triggered for such resource."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Change-Id: I5a62cc5731c5ba571506a3aa26303a1b0290d37b"},{"line_number":54,"context_line":"Closes-Task: #1742401"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f96bb07_1fd7ce51","line":54,"range":{"start_line":54,"start_character":7,"end_line":54,"end_character":11},"in_reply_to":"7f96bb07_2e5a9e4f","updated":"2018-01-23 12:12:47.000000000","message":"right :)","commit_id":"5e25d4a7e453ac1b7e138408a164a571ab6f9d30"}],"neutron/tests/unit/agent/test_resource_cache.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b2ef3ca3882d448cb0336645da0f8ab1174ae640","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            filter_kwargs\u003d{\u0027id\u0027: (66, 67), \u0027name\u0027: (\u0027a\u0027, \u0027b\u0027)})"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        self._pullmock.bulk_pull.reset_mock()"},{"line_number":71,"context_line":"        self._pullmock.bulk_pull.return_value \u003d [resources[0]]"},{"line_number":72,"context_line":"        self.rcache._flood_cache_for_query(\u0027goose\u0027, id\u003d(66, ), name\u003d(\u0027a\u0027, ))"},{"line_number":73,"context_line":"        self.assertFalse(self._pullmock.called)"},{"line_number":74,"context_line":"        self._pullmock.bulk_pull.return_value \u003d [resources[1]]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_ceaa1a18","line":71,"range":{"start_line":71,"start_character":8,"end_line":71,"end_character":62},"updated":"2018-01-23 10:25:40.000000000","message":"Instead of setting return_value before each call you can do:\n\n self._pullmock.bulk_pull.side_effect \u003d [\n     resources[0],\n     resources[1],\n     resources[1],\n ]","commit_id":"5e25d4a7e453ac1b7e138408a164a571ab6f9d30"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fa117e0e839466aabe5a17c0df2f88019f638a05","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            filter_kwargs\u003d{\u0027id\u0027: (66, 67), \u0027name\u0027: (\u0027a\u0027, \u0027b\u0027)})"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        self._pullmock.bulk_pull.reset_mock()"},{"line_number":71,"context_line":"        self._pullmock.bulk_pull.return_value \u003d [resources[0]]"},{"line_number":72,"context_line":"        self.rcache._flood_cache_for_query(\u0027goose\u0027, id\u003d(66, ), name\u003d(\u0027a\u0027, ))"},{"line_number":73,"context_line":"        self.assertFalse(self._pullmock.called)"},{"line_number":74,"context_line":"        self._pullmock.bulk_pull.return_value \u003d [resources[1]]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_643d25dc","line":71,"range":{"start_line":71,"start_character":8,"end_line":71,"end_character":62},"in_reply_to":"7f96bb07_ceaa1a18","updated":"2018-01-23 12:12:47.000000000","message":"right, changed","commit_id":"5e25d4a7e453ac1b7e138408a164a571ab6f9d30"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b2ef3ca3882d448cb0336645da0f8ab1174ae640","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        self._pullmock.bulk_pull.assert_called_once_with("},{"line_number":83,"context_line":"            mock.ANY, \u0027goose\u0027, filter_kwargs\u003d{\u0027id\u0027: (67, )})"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        self.assertEqual(2, len(received_kw))"},{"line_number":86,"context_line":"        self.assertEqual(resources[0], received_kw[0][\u0027updated\u0027])"},{"line_number":87,"context_line":"        self.assertEqual(resources[1], received_kw[1][\u0027updated\u0027])"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def test_bulk_pull_doesnt_wipe_out_newer_data(self):"},{"line_number":90,"context_line":"        self.rcache.record_resource_update("}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_2e713edf","line":87,"range":{"start_line":85,"start_character":0,"end_line":87,"end_character":65},"updated":"2018-01-23 10:25:40.000000000","message":"You could just do:\n\n self.assertItemsEqual(resources, [rec[\u0027updated\u0027] for rec in received_kw])","commit_id":"5e25d4a7e453ac1b7e138408a164a571ab6f9d30"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fa117e0e839466aabe5a17c0df2f88019f638a05","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        self._pullmock.bulk_pull.assert_called_once_with("},{"line_number":83,"context_line":"            mock.ANY, \u0027goose\u0027, filter_kwargs\u003d{\u0027id\u0027: (67, )})"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        self.assertEqual(2, len(received_kw))"},{"line_number":86,"context_line":"        self.assertEqual(resources[0], received_kw[0][\u0027updated\u0027])"},{"line_number":87,"context_line":"        self.assertEqual(resources[1], received_kw[1][\u0027updated\u0027])"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def test_bulk_pull_doesnt_wipe_out_newer_data(self):"},{"line_number":90,"context_line":"        self.rcache.record_resource_update("}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_84195189","line":87,"range":{"start_line":85,"start_character":0,"end_line":87,"end_character":65},"in_reply_to":"7f96bb07_2e713edf","updated":"2018-01-23 12:12:47.000000000","message":"changed, thx","commit_id":"5e25d4a7e453ac1b7e138408a164a571ab6f9d30"}]}