)]}'
{"neutron/objects/qos/qos_policy_validator.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f7fd226e2de5f1fd8e892ec2030f106f862e6d50","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    This function checks if the new rule to be associated with policy"},{"line_number":54,"context_line":"    doesn\u0027t have any duplicate rule already in policy."},{"line_number":55,"context_line":"    Raises an expection if conflict is identified."},{"line_number":56,"context_line":"    \"\"\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    for rule in policy.rules:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_3f4fb893","line":55,"range":{"start_line":55,"start_character":14,"end_line":55,"end_character":23},"updated":"2018-02-12 21:54:13.000000000","message":"nit: exception","commit_id":"4ad8e30b1503bf974f518e10eead544f062e2ba2"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"656fc30da59980ba353a91141e1afc3300d5e7e3","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    This function checks if the new rule to be associated with policy"},{"line_number":54,"context_line":"    doesn\u0027t have any duplicate rule already in policy."},{"line_number":55,"context_line":"    Raises an expection if conflict is identified."},{"line_number":56,"context_line":"    \"\"\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    for rule in policy.rules:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_00d5b143","line":55,"range":{"start_line":55,"start_character":14,"end_line":55,"end_character":23},"in_reply_to":"3fa0c359_3f4fb893","updated":"2018-02-13 09:16:16.000000000","message":"Done","commit_id":"4ad8e30b1503bf974f518e10eead544f062e2ba2"}],"neutron/objects/qos/rule.py":[{"author":{"_account_id":25618,"name":"Paweł Suder","email":"pawel@suder.info","username":"SuderPawel"},"change_message_id":"591e1f4b369bc78736132371dff8019ee64a4bb6","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    # should be redefined in subclasses"},{"line_number":67,"context_line":"    rule_type \u003d None"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    duplicates_compare_fields \u003d []"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def duplicates(self, other_rule):"},{"line_number":72,"context_line":"        \"\"\"Returns True if rules have got same values in fields defined in"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_29fb1c79","line":69,"range":{"start_line":69,"start_character":4,"end_line":69,"end_character":34},"updated":"2018-02-12 08:20:40.000000000","message":"Will be that modified? How about using tuple?","commit_id":"06e3ba6e9e23cb538b3a237fb9928fee812d8c9e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"cfe6954cefdf2a6feecb0bc77b8cccf86c9c35f9","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    # should be redefined in subclasses"},{"line_number":67,"context_line":"    rule_type \u003d None"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    duplicates_compare_fields \u003d []"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def duplicates(self, other_rule):"},{"line_number":72,"context_line":"        \"\"\"Returns True if rules have got same values in fields defined in"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_0c68ae84","line":69,"range":{"start_line":69,"start_character":4,"end_line":69,"end_character":34},"in_reply_to":"3fa0c359_29fb1c79","updated":"2018-02-12 11:06:01.000000000","message":"Done","commit_id":"06e3ba6e9e23cb538b3a237fb9928fee812d8c9e"},{"author":{"_account_id":27546,"name":"Michal Kelner Mishali","email":"mkelnermishal@vmware.com","username":"mkelnermishal"},"change_message_id":"00842f9c2d67a3a2f4cbf16ce2024988182bafc9","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        \"\"\"Returns True if rules have got same values in fields defined in"},{"line_number":73,"context_line":"        \u0027duplicates_compare_fields\u0027 list."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        In case when subclass don\u0027t have defined any field in"},{"line_number":76,"context_line":"        duplicates_compare_fields, only rule types are compared."},{"line_number":77,"context_line":"        \"\"\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        if self.rule_type !\u003d other_rule.rule_type:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_90127261","line":76,"range":{"start_line":75,"start_character":8,"end_line":76,"end_character":64},"updated":"2018-02-13 07:41:09.000000000","message":"In case there\u0027s no field defined in the duplicates_compare_fields, only rule types are compared.","commit_id":"4ad8e30b1503bf974f518e10eead544f062e2ba2"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"656fc30da59980ba353a91141e1afc3300d5e7e3","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        \"\"\"Returns True if rules have got same values in fields defined in"},{"line_number":73,"context_line":"        \u0027duplicates_compare_fields\u0027 list."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        In case when subclass don\u0027t have defined any field in"},{"line_number":76,"context_line":"        duplicates_compare_fields, only rule types are compared."},{"line_number":77,"context_line":"        \"\"\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        if self.rule_type !\u003d other_rule.rule_type:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_40909995","line":76,"range":{"start_line":75,"start_character":8,"end_line":76,"end_character":64},"in_reply_to":"3fa0c359_90127261","updated":"2018-02-13 09:16:16.000000000","message":"yes, that was my intention. For example in case of dscp_marking rule - there can be only one such rule in policy and it doesn\u0027t matter what dscp_mark value is. So in fact of You try to add rule with same type as already existing, then it\u0027s \"duplicate\" and error should be raised.\nIn case of e.g. bandwidth_limit rule where there is direction attribute it is checked because there can be one \"egress\" and one \"ingress\" rule associated to one policy","commit_id":"4ad8e30b1503bf974f518e10eead544f062e2ba2"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"33d6918cd77cddcd9a256106141c66458dc6d195","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    duplicates_compare_fields \u003d ()"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def duplicates(self, other_rule):"},{"line_number":72,"context_line":"        \"\"\"Returns True if rules have got same values in fields defined in"},{"line_number":73,"context_line":"        \u0027duplicates_compare_fields\u0027 list."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        In case when subclass don\u0027t have defined any field in"},{"line_number":76,"context_line":"        duplicates_compare_fields, only rule types are compared."}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_33060522","line":73,"range":{"start_line":72,"start_character":0,"end_line":73,"end_character":41},"updated":"2018-02-13 10:22:24.000000000","message":"nit: Maybe add that the method returns True if *all* values in duplicates_compare_fields are the same?","commit_id":"a91d84cfb44a9def517f2990d164b4972023709a"}]}
