)]}'
{"neutron/plugins/ml2/drivers/linuxbridge/agent/linuxbridge_neutron_agent.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a9bacff95e054fd8046a19451e441219d8967d44","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                try:"},{"line_number":363,"context_line":"                    int_vxlan.link.set_mtu(mtu)"},{"line_number":364,"context_line":"                except RuntimeError:"},{"line_number":365,"context_line":"                    LOG.warning(\"Cannot update MTU for VXLAN interface\")"},{"line_number":366,"context_line":"            int_vxlan.disable_ipv6()"},{"line_number":367,"context_line":"            int_vxlan.link.set_up()"},{"line_number":368,"context_line":"            LOG.debug(\"Done creating vxlan interface %s\", interface)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_ea9f1c4d","line":365,"updated":"2018-02-03 08:57:14.000000000","message":"shouldn\u0027t it be logged as error maybe?","commit_id":"211573bc500afa6241616e180f75297d7bd50312"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"1f1b5c03a9d522aa1f98405bc4beaf10e3c5735e","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                try:"},{"line_number":363,"context_line":"                    int_vxlan.link.set_mtu(mtu)"},{"line_number":364,"context_line":"                except RuntimeError:"},{"line_number":365,"context_line":"                    LOG.warning(\"Cannot update MTU for VXLAN interface\")"},{"line_number":366,"context_line":"            int_vxlan.disable_ipv6()"},{"line_number":367,"context_line":"            int_vxlan.link.set_up()"},{"line_number":368,"context_line":"            LOG.debug(\"Done creating vxlan interface %s\", interface)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_ce4c9a78","line":365,"in_reply_to":"5f93b717_ea9f1c4d","updated":"2018-02-05 18:29:37.000000000","message":"Done","commit_id":"211573bc500afa6241616e180f75297d7bd50312"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7a58d49277e2f44dd406ec96365342970e5d72a9","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                try:"},{"line_number":363,"context_line":"                    int_vxlan.link.set_mtu(mtu)"},{"line_number":364,"context_line":"                except RuntimeError:"},{"line_number":365,"context_line":"                    LOG.error(\"Cannot update MTU for VXLAN interface\")"},{"line_number":366,"context_line":"            int_vxlan.disable_ipv6()"},{"line_number":367,"context_line":"            int_vxlan.link.set_up()"},{"line_number":368,"context_line":"            LOG.debug(\"Done creating vxlan interface %s\", interface)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_1813610f","line":365,"updated":"2018-02-07 21:11:14.000000000","message":"Do you really need the try/except here?\n\nOr maybe a better question is, what happens if we fail to set the mtu correctly?  If things are unusable then it seems we should delete the device and return None?  But not having the try/except would be preferred if it\u0027s expected to succeed.","commit_id":"6c5c2fd75997185746564a2a1548348ca420d5e9"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"6adc2cec32ef7e9aca7eacdc3a6cef044942abb5","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                try:"},{"line_number":363,"context_line":"                    int_vxlan.link.set_mtu(mtu)"},{"line_number":364,"context_line":"                except RuntimeError:"},{"line_number":365,"context_line":"                    LOG.error(\"Cannot update MTU for VXLAN interface\")"},{"line_number":366,"context_line":"            int_vxlan.disable_ipv6()"},{"line_number":367,"context_line":"            int_vxlan.link.set_up()"},{"line_number":368,"context_line":"            LOG.debug(\"Done creating vxlan interface %s\", interface)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_b8258dc4","line":365,"in_reply_to":"3fa0c359_1813610f","updated":"2018-02-07 21:23:58.000000000","message":"I tested it locally. It seems that if the local_ip device has mtu 1500 and we want to set vxlan device as 9000 (or any number bigger than 1500), this will fail. The vxlan device is still usable with mtu 1500 so deleting the device and return None is an overkill.","commit_id":"6c5c2fd75997185746564a2a1548348ca420d5e9"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"29c2b6bd029fad91780474dd276f1b6d60376354","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                try:"},{"line_number":363,"context_line":"                    int_vxlan.link.set_mtu(mtu)"},{"line_number":364,"context_line":"                except RuntimeError:"},{"line_number":365,"context_line":"                    LOG.error(\"Cannot update MTU for VXLAN interface\")"},{"line_number":366,"context_line":"            int_vxlan.disable_ipv6()"},{"line_number":367,"context_line":"            int_vxlan.link.set_up()"},{"line_number":368,"context_line":"            LOG.debug(\"Done creating vxlan interface %s\", interface)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_b1071b19","line":365,"in_reply_to":"3fa0c359_8e03a00f","updated":"2018-02-15 23:47:56.000000000","message":"Done","commit_id":"6c5c2fd75997185746564a2a1548348ca420d5e9"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d78641e44492eed478bc7a5f90ba37af1e716dfb","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                try:"},{"line_number":363,"context_line":"                    int_vxlan.link.set_mtu(mtu)"},{"line_number":364,"context_line":"                except RuntimeError:"},{"line_number":365,"context_line":"                    LOG.error(\"Cannot update MTU for VXLAN interface\")"},{"line_number":366,"context_line":"            int_vxlan.disable_ipv6()"},{"line_number":367,"context_line":"            int_vxlan.link.set_up()"},{"line_number":368,"context_line":"            LOG.debug(\"Done creating vxlan interface %s\", interface)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_8e03a00f","line":365,"in_reply_to":"3fa0c359_b8258dc4","updated":"2018-02-08 09:02:11.000000000","message":"to be honest if mtu on instances is set e.g. to 9000 (via DHCP) then vxlan device with mtu\u003d1500 is not usable IMHO - it will be so slow that no one will use it","commit_id":"6c5c2fd75997185746564a2a1548348ca420d5e9"}]}
