)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"be19b932b510bce39bf3e51fe00e752047033c5c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kevin Benton \u003ckevin.benton@bigswitch.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-10-30 00:42:02 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds DHCP agent support to BigSwitch plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds support for the Neutron DHCP agent scheduler to the BigSwitch"},{"line_number":10,"context_line":"plugin to support multiple neutron DHCP agents."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAATn%2F%2Fn%2BQ%3D","line":7,"updated":"2013-10-31 09:19:36.000000000","message":"\u0027DHCP agent support\u0027 is a bit misleading - at first I thought this patch added support for interacting with the DHCP agent, and I though: \"huh?\".\n\nIt seems you\u0027re actually adding \u0027DHCP agent scheduler\u0027 support, and perhaps this should be the first line of the commit message.\n\nsorry for this pedant comment","commit_id":"c1776c9b8f6dccbbbb6902e6494fb94ffd5e0070"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"591879c213c3dd9fbd7b3bca33f26be91662ea8e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kevin Benton \u003ckevin.benton@bigswitch.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-10-30 00:42:02 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds DHCP agent support to BigSwitch plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds support for the Neutron DHCP agent scheduler to the BigSwitch"},{"line_number":10,"context_line":"plugin to support multiple neutron DHCP agents."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAATn%2F%2FlsA%3D","line":7,"in_reply_to":"AAAATn%2F%2Fn%2BQ%3D","updated":"2013-10-31 19:19:53.000000000","message":"Done","commit_id":"c1776c9b8f6dccbbbb6902e6494fb94ffd5e0070"}],"neutron/db/migration/alembic_migrations/versions/4692d074d587_agent_scheduler.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"13672ba20ee07066e8eced8dcfab4870aa3ca860","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \u0027neutron.plugins.nicira.NeutronPlugin.NvpPluginV2\u0027,"},{"line_number":36,"context_line":"    \u0027neutron.plugins.nec.nec_plugin.NECPluginV2\u0027,"},{"line_number":37,"context_line":"    \u0027neutron.plugins.brocade.NeutronPlugin.BrocadePluginV2\u0027,"},{"line_number":38,"context_line":"    \u0027neutron.plugins.bigswitch.plugin.NeutronRestProxyV2\u0027"},{"line_number":39,"context_line":"]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"from alembic import op"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FpOA%3D","line":38,"updated":"2013-10-31 00:01:10.000000000","message":"I don\u0027t think you need to add this here as this is prehavana? I think you need another migration that adds support.","commit_id":"92a2e869ec20b34d9159997aaa30b8d9249cf23b"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"4553fdca7c2510caa928c80e31f6fd16909478ee","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \u0027neutron.plugins.nicira.NeutronPlugin.NvpPluginV2\u0027,"},{"line_number":36,"context_line":"    \u0027neutron.plugins.nec.nec_plugin.NECPluginV2\u0027,"},{"line_number":37,"context_line":"    \u0027neutron.plugins.brocade.NeutronPlugin.BrocadePluginV2\u0027,"},{"line_number":38,"context_line":"    \u0027neutron.plugins.bigswitch.plugin.NeutronRestProxyV2\u0027"},{"line_number":39,"context_line":"]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"from alembic import op"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FpMQ%3D","line":38,"in_reply_to":"AAAATn%2F%2FpOA%3D","updated":"2013-10-31 00:13:49.000000000","message":"Is a migration script even necessary? When I ran through the steps to generate the script, it didn\u0027t detect any new tables. i.e. is the agents table just standard in havana?","commit_id":"92a2e869ec20b34d9159997aaa30b8d9249cf23b"}],"neutron/plugins/bigswitch/plugin.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e09c8957711c31ed2ecfe810cf1174e63eae3a6b","unresolved":false,"context_lines":[{"line_number":88,"context_line":"if not cfg.CONF.api_extensions_path:"},{"line_number":89,"context_line":"    cfg.CONF.set_override(\u0027api_extensions_path\u0027,"},{"line_number":90,"context_line":"                          EXTENSIONS_PATH)"},{"line_number":91,"context_line":"config.register_agent_state_opts_helper(cfg.CONF)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"restproxy_opts \u003d ["},{"line_number":94,"context_line":"    cfg.StrOpt(\u0027servers\u0027, default\u003d\u0027localhost:8800\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FqEQ%3D","line":91,"updated":"2013-10-30 19:01:17.000000000","message":"This is only needed client side.","commit_id":"0dbc2dbb28a3a8f35257272955eb2c151f328761"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"82e01754e4c86d10ed0146dffe2a974eebd19383","unresolved":false,"context_lines":[{"line_number":88,"context_line":"if not cfg.CONF.api_extensions_path:"},{"line_number":89,"context_line":"    cfg.CONF.set_override(\u0027api_extensions_path\u0027,"},{"line_number":90,"context_line":"                          EXTENSIONS_PATH)"},{"line_number":91,"context_line":"config.register_agent_state_opts_helper(cfg.CONF)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"restproxy_opts \u003d ["},{"line_number":94,"context_line":"    cfg.StrOpt(\u0027servers\u0027, default\u003d\u0027localhost:8800\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FqBE%3D","line":91,"in_reply_to":"AAAATn%2F%2FqCc%3D","updated":"2013-10-30 19:05:13.000000000","message":"yup","commit_id":"0dbc2dbb28a3a8f35257272955eb2c151f328761"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"6a3120b7a9abc8ca587fd5d157f969ae0cc508e4","unresolved":false,"context_lines":[{"line_number":88,"context_line":"if not cfg.CONF.api_extensions_path:"},{"line_number":89,"context_line":"    cfg.CONF.set_override(\u0027api_extensions_path\u0027,"},{"line_number":90,"context_line":"                          EXTENSIONS_PATH)"},{"line_number":91,"context_line":"config.register_agent_state_opts_helper(cfg.CONF)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"restproxy_opts \u003d ["},{"line_number":94,"context_line":"    cfg.StrOpt(\u0027servers\u0027, default\u003d\u0027localhost:8800\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FqCc%3D","line":91,"in_reply_to":"AAAATn%2F%2FqEQ%3D","updated":"2013-10-30 19:02:50.000000000","message":"Ah, do you mean in the DHCP agent?","commit_id":"0dbc2dbb28a3a8f35257272955eb2c151f328761"}],"neutron/tests/unit/bigswitch/test_restproxy_plugin.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"be19b932b510bce39bf3e51fe00e752047033c5c","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class BigSwitchProxyPluginV2TestCase(BigSwitchTestBase,"},{"line_number":58,"context_line":"                                     test_plugin.NeutronDbPluginV2TestCase):"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def setUp(self):"},{"line_number":61,"context_line":"        self.setup_config_files()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2Fn90%3D","line":58,"updated":"2013-10-31 09:19:36.000000000","message":"question: why did you have to introduce inheritance for setup_config_file and setup_patches?","commit_id":"c1776c9b8f6dccbbbb6902e6494fb94ffd5e0070"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"0737816966b69c96249fde8d7f91b20cd017c327","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class BigSwitchProxyPluginV2TestCase(BigSwitchTestBase,"},{"line_number":58,"context_line":"                                     test_plugin.NeutronDbPluginV2TestCase):"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def setUp(self):"},{"line_number":61,"context_line":"        self.setup_config_files()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2Fmz8%3D","line":58,"in_reply_to":"AAAATn%2F%2Fn90%3D","updated":"2013-10-31 14:47:20.000000000","message":"So we can inherit from the same class in other unit tests (e.g. the test_agent_scheduler test) and avoid duplicating setup code.","commit_id":"c1776c9b8f6dccbbbb6902e6494fb94ffd5e0070"}]}