)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f6637270ade939fbb81cb3ae6cb0d46f616ffacf","unresolved":false,"context_lines":[{"line_number":16,"context_line":"operations and renames relevant model classes, attributes, and"},{"line_number":17,"context_line":"functions from \u0027nvp\u0027 to \u0027nsx\u0027."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Related to blueprint nvp-async-backend-communication"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I5fa1e8f0d863b7d1fc278ffdeac8acc076a843e8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F%2FpS4%3D","line":19,"updated":"2013-10-30 23:44:06.000000000","message":"consider adding reference to blueprint: nicira-plugin-renaming","commit_id":"52ff918d2fbba81a4649fa047d56b003a3762aa2"}],"neutron/db/migration/alembic_migrations/versions/50e86cb2637a_nsx_port_mappings.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f6637270ade939fbb81cb3ae6cb0d46f616ffacf","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# Change to [\u0027*\u0027] if this migration applies to all plugins"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"migration_for_plugins \u003d ["},{"line_number":33,"context_line":"    \u0027neutron.plugins.nicira.NeutronPlugin.NvpPluginV2\u0027"},{"line_number":34,"context_line":"]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"from alembic import op"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FpUE%3D","line":33,"updated":"2013-10-30 23:44:06.000000000","message":"do we need to add the service plugin too?","commit_id":"52ff918d2fbba81a4649fa047d56b003a3762aa2"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"d24647d2d667f4fe13469d1d379b59f4315a6645","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# Change to [\u0027*\u0027] if this migration applies to all plugins"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"migration_for_plugins \u003d ["},{"line_number":33,"context_line":"    \u0027neutron.plugins.nicira.NeutronPlugin.NvpPluginV2\u0027"},{"line_number":34,"context_line":"]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"from alembic import op"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FpNc%3D","line":33,"in_reply_to":"AAAATn%2F%2FpUE%3D","updated":"2013-10-31 00:06:23.000000000","message":"Yes.\nIndeed this is not the file I planned to push (wrong name)","commit_id":"52ff918d2fbba81a4649fa047d56b003a3762aa2"}],"neutron/plugins/nicira/common/nsx_utils.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"9a79d059ff0a7c57a7dde7f6de26193382b5558b","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                         [\u0027LogicalSwitchConfig\u0027][\u0027uuid\u0027])"},{"line_number":63,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":64,"context_line":"            if nvp_port_id:"},{"line_number":65,"context_line":"                # Mapping already exists. Delete before recreating"},{"line_number":66,"context_line":"                nicira_db.delete_neutron_nsx_port_mapping("},{"line_number":67,"context_line":"                    session, neutron_port_id)"},{"line_number":68,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FpOs%3D","line":65,"updated":"2013-10-30 23:58:12.000000000","message":"why wasn\u0027t this returned from line 43 then?","commit_id":"52ff918d2fbba81a4649fa047d56b003a3762aa2"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"d24647d2d667f4fe13469d1d379b59f4315a6645","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                         [\u0027LogicalSwitchConfig\u0027][\u0027uuid\u0027])"},{"line_number":63,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":64,"context_line":"            if nvp_port_id:"},{"line_number":65,"context_line":"                # Mapping already exists. Delete before recreating"},{"line_number":66,"context_line":"                nicira_db.delete_neutron_nsx_port_mapping("},{"line_number":67,"context_line":"                    session, neutron_port_id)"},{"line_number":68,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FpNU%3D","line":65,"in_reply_to":"AAAATn%2F%2FpOs%3D","updated":"2013-10-31 00:06:23.000000000","message":"because it had the port id but not the switch id.\nThis would happen for existing data.","commit_id":"52ff918d2fbba81a4649fa047d56b003a3762aa2"}],"neutron/plugins/nicira/dbexts/nicira_models.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f6637270ade939fbb81cb3ae6cb0d46f616ffacf","unresolved":false,"context_lines":[{"line_number":60,"context_line":"class NeutronNsxPortMapping(model_base.BASEV2):"},{"line_number":61,"context_line":"    \"\"\"Represents the mapping between neutron and nvp port uuids.\"\"\""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    __tablename__ \u003d \u0027neutron_nsx_port_mappings\u0027"},{"line_number":64,"context_line":"    neutron_id \u003d Column(String(36),"},{"line_number":65,"context_line":"                        ForeignKey(\u0027ports.id\u0027, ondelete\u003d\"CASCADE\"),"},{"line_number":66,"context_line":"                        primary_key\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FpSA%3D","line":63,"updated":"2013-10-30 23:44:06.000000000","message":"uh? What about deployments upgraded to havana?","commit_id":"52ff918d2fbba81a4649fa047d56b003a3762aa2"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"d24647d2d667f4fe13469d1d379b59f4315a6645","unresolved":false,"context_lines":[{"line_number":60,"context_line":"class NeutronNsxPortMapping(model_base.BASEV2):"},{"line_number":61,"context_line":"    \"\"\"Represents the mapping between neutron and nvp port uuids.\"\"\""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    __tablename__ \u003d \u0027neutron_nsx_port_mappings\u0027"},{"line_number":64,"context_line":"    neutron_id \u003d Column(String(36),"},{"line_number":65,"context_line":"                        ForeignKey(\u0027ports.id\u0027, ondelete\u003d\"CASCADE\"),"},{"line_number":66,"context_line":"                        primary_key\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FpNI%3D","line":63,"in_reply_to":"AAAATn%2F%2FpOg%3D","updated":"2013-10-31 00:06:23.000000000","message":"Would that break anything... I tested in on an existing havana setup and the db upgrade was apparently flawless, as the rename operation correctly preserved fk relationships.","commit_id":"52ff918d2fbba81a4649fa047d56b003a3762aa2"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"9a79d059ff0a7c57a7dde7f6de26193382b5558b","unresolved":false,"context_lines":[{"line_number":60,"context_line":"class NeutronNsxPortMapping(model_base.BASEV2):"},{"line_number":61,"context_line":"    \"\"\"Represents the mapping between neutron and nvp port uuids.\"\"\""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    __tablename__ \u003d \u0027neutron_nsx_port_mappings\u0027"},{"line_number":64,"context_line":"    neutron_id \u003d Column(String(36),"},{"line_number":65,"context_line":"                        ForeignKey(\u0027ports.id\u0027, ondelete\u003d\"CASCADE\"),"},{"line_number":66,"context_line":"                        primary_key\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FpOg%3D","line":63,"in_reply_to":"AAAATn%2F%2FpSA%3D","updated":"2013-10-30 23:58:12.000000000","message":"Looks like he handles the rename as part of the migration so it\u0027s okay.","commit_id":"52ff918d2fbba81a4649fa047d56b003a3762aa2"}],"neutron/tests/unit/nicira/test_nicira_plugin.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f6637270ade939fbb81cb3ae6cb0d46f616ffacf","unresolved":false,"context_lines":[{"line_number":243,"context_line":"                self._verify_no_orphan_left(net_id)"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    def test_create_port_neutron_error_no_orphan_left(self):"},{"line_number":246,"context_line":"        with mock.patch.object(nicira_db, \u0027add_neutron_nsx_port_mapping\u0027,"},{"line_number":247,"context_line":"                               side_effect\u003dntn_exc.NeutronException):"},{"line_number":248,"context_line":"            with self.network() as net:"},{"line_number":249,"context_line":"                net_id \u003d net[\u0027network\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FpRw%3D","line":246,"updated":"2013-10-30 23:44:06.000000000","message":"it\u0027d be good to add coverage for nsx_utils.py","commit_id":"52ff918d2fbba81a4649fa047d56b003a3762aa2"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"d24647d2d667f4fe13469d1d379b59f4315a6645","unresolved":false,"context_lines":[{"line_number":243,"context_line":"                self._verify_no_orphan_left(net_id)"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    def test_create_port_neutron_error_no_orphan_left(self):"},{"line_number":246,"context_line":"        with mock.patch.object(nicira_db, \u0027add_neutron_nsx_port_mapping\u0027,"},{"line_number":247,"context_line":"                               side_effect\u003dntn_exc.NeutronException):"},{"line_number":248,"context_line":"            with self.network() as net:"},{"line_number":249,"context_line":"                net_id \u003d net[\u0027network\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FpNE%3D","line":246,"in_reply_to":"AAAATn%2F%2FpRw%3D","updated":"2013-10-31 00:06:23.000000000","message":"It\u0027s indirectly covered actually, just like _nvp_get_port_id was covered.\n\nI don\u0027t think it will cost me too much time adding a few unit tests. Test all the things!!!!","commit_id":"52ff918d2fbba81a4649fa047d56b003a3762aa2"}]}