)]}'
{"neutron/db/migration/alembic_migrations/versions/3d3cb89d84ee_nsx_switch_mappings.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b92eef3cf3aa3ab764d1a74d5a8bfe74bd2ec424","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\"\"\"nsx_switch_mappings"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Revision ID: 3d3cb89d84ee"},{"line_number":21,"context_line":"Revises: ed93525fd003"},{"line_number":22,"context_line":"Create Date: 2014-01-07 15:37:41.323020"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2FyaI%3D","line":21,"updated":"2014-01-08 13:10:47.000000000","message":"This needs to be updated.","commit_id":"894ea95f0ca09ddafd09f300b34c8958b7e64b45"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f45b280ce7ad938d617a425d9fe5e15b201fa8e8","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\"\"\"nsx_switch_mappings"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Revision ID: 3d3cb89d84ee"},{"line_number":21,"context_line":"Revises: 49f5e553f61f"},{"line_number":22,"context_line":"Create Date: 2014-01-07 15:37:41.323020"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2F0K4%3D","line":21,"updated":"2014-02-10 16:49:58.000000000","message":"I am afraid, this needs a new down revision.","commit_id":"05e719ef5a9ab96d498b7c578a255926d3ee8ef9"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0c3f237243fa5da33e8cf15f698fdace40c7e72b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2014 OpenStack Foundation"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUX%2F%2FiLs%3D","line":1,"updated":"2014-02-12 15:06:03.000000000","message":"you can delete lines 1 -3","commit_id":"c18e14fa777b11412911bf83353503e26ab2137f"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"48a20d56199cfe1a1665981b907ef35076dc9689","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2014 OpenStack Foundation"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUX%2F%2Fh7Y%3D","line":1,"in_reply_to":"AAAAUX%2F%2FiAs%3D","updated":"2014-02-12 15:23:01.000000000","message":"It\u0027ll take me a minute to do this.","commit_id":"c18e14fa777b11412911bf83353503e26ab2137f"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"22f284e5bf5cd2a81d41e906ab514aee16c78f3e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2014 OpenStack Foundation"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUX%2F%2FiAs%3D","line":1,"in_reply_to":"AAAAUX%2F%2FiLs%3D","updated":"2014-02-12 15:12:46.000000000","message":"If that\u0027s okay with you. I can do it in a sweeping patch as part of bp nicira-plugin-renaming and the sub-task of checking the license headers.","commit_id":"c18e14fa777b11412911bf83353503e26ab2137f"}],"neutron/db/migration/alembic_migrations/versions/50e86cb2637a_nsx_mappings.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"53bd4ea63ec9fa38d700b8d36ea908a779c78f18","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    # each record in routers"},{"line_number":68,"context_line":"    op.execute(\"INSERT INTO neutron_nsx_router_mappings SELECT id,id \""},{"line_number":69,"context_line":"               \"from routers\")"},{"line_number":70,"context_line":"    # Create table for network mappings"},{"line_number":71,"context_line":"    op.create_table("},{"line_number":72,"context_line":"        \u0027neutron_nsx_network_mappings\u0027,"},{"line_number":73,"context_line":"        sa.Column(\u0027neutron_id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2F1vw%3D","line":70,"updated":"2013-12-30 12:31:01.000000000","message":"same question I posted on a similar patch: how does the fact that we\u0027re bundling the db changes with an existing migration affect trunk chasers?","commit_id":"ba6d4cb1235f8973078ecfd577d1edcfbd7e4566"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"c8b161b4c6b1c5ff540c8309ddedf2c8ff1e8549","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    # each record in routers"},{"line_number":68,"context_line":"    op.execute(\"INSERT INTO neutron_nsx_router_mappings SELECT id,id \""},{"line_number":69,"context_line":"               \"from routers\")"},{"line_number":70,"context_line":"    # Create table for network mappings"},{"line_number":71,"context_line":"    op.create_table("},{"line_number":72,"context_line":"        \u0027neutron_nsx_network_mappings\u0027,"},{"line_number":73,"context_line":"        sa.Column(\u0027neutron_id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2F3og%3D","line":70,"in_reply_to":"AAAAT3%2F%2F1vw%3D","updated":"2014-01-07 12:53:24.000000000","message":"It won\u0027t be a problem splitting the changes in multiple migrations","commit_id":"ba6d4cb1235f8973078ecfd577d1edcfbd7e4566"}],"neutron/db/migration/alembic_migrations/versions/50e86cb2637a_nsx_port_mappings.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e55459aa6058b8eff07aa7285675b1c6cfa96c6b","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        \u0027neutron_nsx_network_mappings\u0027,"},{"line_number":72,"context_line":"        sa.Column(\u0027neutron_id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":73,"context_line":"        sa.Column(\u0027nsx_id\u0027, sa.String(length\u003d36), nullable\u003dTrue),"},{"line_number":74,"context_line":"        sa.ForeignKeyConstraint([\u0027neutron_id\u0027], [\u0027routers.id\u0027],"},{"line_number":75,"context_line":"                                ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":76,"context_line":"        # There might be multiple switches for a neutron network"},{"line_number":77,"context_line":"        sa.PrimaryKeyConstraint(\u0027neutron_id\u0027, \u0027nsx_id\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FpNs%3D","line":74,"updated":"2013-10-31 00:03:54.000000000","message":"typo?","commit_id":"fd1c4a77764f338945e29650cb14c69333cdedc9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ec64095f84c87282b3309ff35c54bd40ce6c5b9b","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        \u0027neutron_nsx_network_mappings\u0027,"},{"line_number":72,"context_line":"        sa.Column(\u0027neutron_id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":73,"context_line":"        sa.Column(\u0027nsx_id\u0027, sa.String(length\u003d36), nullable\u003dTrue),"},{"line_number":74,"context_line":"        sa.ForeignKeyConstraint([\u0027neutron_id\u0027], [\u0027routers.id\u0027],"},{"line_number":75,"context_line":"                                ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":76,"context_line":"        # There might be multiple switches for a neutron network"},{"line_number":77,"context_line":"        sa.PrimaryKeyConstraint(\u0027neutron_id\u0027, \u0027nsx_id\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FmQo%3D","line":74,"in_reply_to":"AAAATn%2F%2Fn2Y%3D","updated":"2013-10-31 17:08:09.000000000","message":"I mean is routers.id you mean to pull the foreign key constraint on?","commit_id":"fd1c4a77764f338945e29650cb14c69333cdedc9"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"afc12b7aa34e9131ae0ee5bef5b78936033bc72e","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        \u0027neutron_nsx_network_mappings\u0027,"},{"line_number":72,"context_line":"        sa.Column(\u0027neutron_id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":73,"context_line":"        sa.Column(\u0027nsx_id\u0027, sa.String(length\u003d36), nullable\u003dTrue),"},{"line_number":74,"context_line":"        sa.ForeignKeyConstraint([\u0027neutron_id\u0027], [\u0027routers.id\u0027],"},{"line_number":75,"context_line":"                                ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":76,"context_line":"        # There might be multiple switches for a neutron network"},{"line_number":77,"context_line":"        sa.PrimaryKeyConstraint(\u0027neutron_id\u0027, \u0027nsx_id\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2Fn2Y%3D","line":74,"in_reply_to":"AAAATn%2F%2FpNs%3D","updated":"2013-10-31 09:47:25.000000000","message":"I\u0027ll check the constraints, but at first glance it looks sane to me.","commit_id":"fd1c4a77764f338945e29650cb14c69333cdedc9"}],"neutron/plugins/nicira/NeutronPlugin.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"918ca6e5288d6a0b9da9a28f0a8c486d0fd4cdad","unresolved":false,"context_lines":[{"line_number":856,"context_line":"                    break"},{"line_number":857,"context_line":"            else:"},{"line_number":858,"context_line":"                # by construction this statement is hit if there is only one"},{"line_number":859,"context_line":"                # logical switch, so the multi_lswitch tag must be added"},{"line_number":860,"context_line":"                tags \u003d main_ls[\u0027tags\u0027]"},{"line_number":861,"context_line":"                tags.append({\u0027tag\u0027: \u0027True\u0027, \u0027scope\u0027: \u0027multi_lswitch\u0027})"},{"line_number":862,"context_line":"                nvplib.update_lswitch(cluster,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8row%3D","line":859,"updated":"2013-12-23 12:30:08.000000000","message":"one logical switch *without* the multi_lswitch tag set","commit_id":"ba6d4cb1235f8973078ecfd577d1edcfbd7e4566"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"c8b161b4c6b1c5ff540c8309ddedf2c8ff1e8549","unresolved":false,"context_lines":[{"line_number":856,"context_line":"                    break"},{"line_number":857,"context_line":"            else:"},{"line_number":858,"context_line":"                # by construction this statement is hit if there is only one"},{"line_number":859,"context_line":"                # logical switch, so the multi_lswitch tag must be added"},{"line_number":860,"context_line":"                tags \u003d main_ls[\u0027tags\u0027]"},{"line_number":861,"context_line":"                tags.append({\u0027tag\u0027: \u0027True\u0027, \u0027scope\u0027: \u0027multi_lswitch\u0027})"},{"line_number":862,"context_line":"                nvplib.update_lswitch(cluster,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2F3oQ%3D","line":859,"in_reply_to":"AAAATn%2F8row%3D","updated":"2014-01-07 12:53:24.000000000","message":"Done","commit_id":"ba6d4cb1235f8973078ecfd577d1edcfbd7e4566"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"358205b21b8564941ee22ec1b22230e5c0017338","unresolved":false,"context_lines":[{"line_number":852,"context_line":"                    break"},{"line_number":853,"context_line":"            else:"},{"line_number":854,"context_line":"                # by construction this statement is hit if there is only one"},{"line_number":855,"context_line":"                # logical switch and the multi_lswitch tag has not beeb set."},{"line_number":856,"context_line":"                # The tag must therefore be added."},{"line_number":857,"context_line":"                tags \u003d main_ls[\u0027tags\u0027]"},{"line_number":858,"context_line":"                tags.append({\u0027tag\u0027: \u0027True\u0027, \u0027scope\u0027: \u0027multi_lswitch\u0027})"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2FC94%3D","line":855,"updated":"2014-01-17 23:45:41.000000000","message":"s/beeb/been","commit_id":"34c5093190152f3e55be3c1c5f8e58e1905331ed"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"358205b21b8564941ee22ec1b22230e5c0017338","unresolved":false,"context_lines":[{"line_number":867,"context_line":"                cluster, network.id, network.tenant_id,"},{"line_number":868,"context_line":"                \"%s-ext-%s\" % (network.name, len(lswitches)),"},{"line_number":869,"context_line":"                transport_zone_config)"},{"line_number":870,"context_line":"            # add a mapgging between the neutron network and the newly"},{"line_number":871,"context_line":"            # created logical switch"},{"line_number":872,"context_line":"            nicira_db.add_neutron_nsx_network_mapping("},{"line_number":873,"context_line":"                context.session, network.id, selected_lswitch[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2FC90%3D","line":870,"updated":"2014-01-17 23:45:41.000000000","message":"mapping","commit_id":"34c5093190152f3e55be3c1c5f8e58e1905331ed"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"358205b21b8564941ee22ec1b22230e5c0017338","unresolved":false,"context_lines":[{"line_number":970,"context_line":"            self.cluster, net_data)"},{"line_number":971,"context_line":"        external \u003d net_data.get(ext_net_extn.EXTERNAL)"},{"line_number":972,"context_line":"        # NOTE(salv-orlando): Pre-generating uuid for Neutron"},{"line_number":973,"context_line":"        # nework. This will be removed once the network create operation"},{"line_number":974,"context_line":"        # becomes an asynchronous task"},{"line_number":975,"context_line":"        net_data[\u0027id\u0027] \u003d str(uuid.uuid4())"},{"line_number":976,"context_line":"        if (not attr.is_attr_set(external) or"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2FC9w%3D","line":973,"updated":"2014-01-17 23:45:41.000000000","message":"nework","commit_id":"34c5093190152f3e55be3c1c5f8e58e1905331ed"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"358205b21b8564941ee22ec1b22230e5c0017338","unresolved":false,"context_lines":[{"line_number":1031,"context_line":"        for port in router_iface_ports:"},{"line_number":1032,"context_line":"            nvp_switch_id, nvp_port_id \u003d nsx_utils.get_nsx_switch_and_port_id("},{"line_number":1033,"context_line":"                context.session, self.cluster, id)"},{"line_number":1034,"context_line":"            nvp_switch_id, nvp_port_id \u003d self._nvp_get_port_id("},{"line_number":1035,"context_line":"                context, self.cluster, port)"},{"line_number":1036,"context_line":"        # Before removing entry from Neutron DB, retrieve NSX switch"},{"line_number":1037,"context_line":"        # identifiers for removing them from backend"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2FC9Q%3D","line":1034,"updated":"2014-01-17 23:45:41.000000000","message":"Should you remove the function above as you aren\u0027t using nvp_switch_id and nvp_port_id returned from that?","commit_id":"34c5093190152f3e55be3c1c5f8e58e1905331ed"}],"neutron/plugins/nicira/NeutronServicePlugin.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"53bd4ea63ec9fa38d700b8d36ea908a779c78f18","unresolved":false,"context_lines":[{"line_number":1609,"context_line":""},{"line_number":1610,"context_line":"def _process_base_create_lswitch_args(*args, **kwargs):"},{"line_number":1611,"context_line":"    tags \u003d [{\"tag\": nvplib.NEUTRON_VERSION, \"scope\": \"quantum\"}]"},{"line_number":1612,"context_line":"    # The first argument after \u0027self\u0027 is the neutron network id"},{"line_number":1613,"context_line":"    tags.append({\"tag\": args[1],"},{"line_number":1614,"context_line":"                 \"scope\": \"quantum_net_id\"})"},{"line_number":1615,"context_line":"    if args[2]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2F1qI%3D","line":1612,"updated":"2013-12-30 12:31:01.000000000","message":"This comment might be misleading. Technically the first argument after self is \u0027cluster\u0027, then neutron_id, and then (formerly in position 1, tenant_id). self does not participate in the parameter count and the first element has position 0.","commit_id":"ba6d4cb1235f8973078ecfd577d1edcfbd7e4566"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"c8b161b4c6b1c5ff540c8309ddedf2c8ff1e8549","unresolved":false,"context_lines":[{"line_number":1609,"context_line":""},{"line_number":1610,"context_line":"def _process_base_create_lswitch_args(*args, **kwargs):"},{"line_number":1611,"context_line":"    tags \u003d [{\"tag\": nvplib.NEUTRON_VERSION, \"scope\": \"quantum\"}]"},{"line_number":1612,"context_line":"    # The first argument after \u0027self\u0027 is the neutron network id"},{"line_number":1613,"context_line":"    tags.append({\"tag\": args[1],"},{"line_number":1614,"context_line":"                 \"scope\": \"quantum_net_id\"})"},{"line_number":1615,"context_line":"    if args[2]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2F3oA%3D","line":1612,"in_reply_to":"AAAAT3%2F%2F1qI%3D","updated":"2014-01-07 12:53:24.000000000","message":"Done","commit_id":"ba6d4cb1235f8973078ecfd577d1edcfbd7e4566"}],"neutron/plugins/nicira/common/nsx_utils.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"918ca6e5288d6a0b9da9a28f0a8c486d0fd4cdad","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    \"\"\""},{"line_number":50,"context_line":"    nsx_switch_ids \u003d nicira_db.get_nsx_switch_ids("},{"line_number":51,"context_line":"        session, neutron_network_id)"},{"line_number":52,"context_line":"    if not nsx_switch_ids:"},{"line_number":53,"context_line":"        # Find logical switches from backend."},{"line_number":54,"context_line":"        # This is a rather expensive query, but it won\u0027t be executed"},{"line_number":55,"context_line":"        # more than once for each network in Neutron\u0027s lifetime"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8rEQ%3D","line":52,"updated":"2013-12-23 12:30:08.000000000","message":"i guess is this for places where mappings doesn\u0027t exist as a table yet, otherwise why would there not be mappings (pre-migration?). So if there aren\u0027t any mappings you retrieve all switches on that network, and a nsx_network_mapping added for each - i.e. all switches are nsx switches.","commit_id":"ba6d4cb1235f8973078ecfd577d1edcfbd7e4566"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"c8b161b4c6b1c5ff540c8309ddedf2c8ff1e8549","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    \"\"\""},{"line_number":50,"context_line":"    nsx_switch_ids \u003d nicira_db.get_nsx_switch_ids("},{"line_number":51,"context_line":"        session, neutron_network_id)"},{"line_number":52,"context_line":"    if not nsx_switch_ids:"},{"line_number":53,"context_line":"        # Find logical switches from backend."},{"line_number":54,"context_line":"        # This is a rather expensive query, but it won\u0027t be executed"},{"line_number":55,"context_line":"        # more than once for each network in Neutron\u0027s lifetime"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2F3ng%3D","line":52,"in_reply_to":"AAAATn%2F8rEQ%3D","updated":"2014-01-07 12:53:24.000000000","message":"The migration only added a table for the mappings but did not populate it. we did this way because of the \u0027extended\u0027 switches whose ids cannot be known without querying nvp.\n\nTherefore this routine will end up querying NSX even when the table exists, simply because the mapping does not exist yet.\nThe NSX query will be performed once for each neutron network.","commit_id":"ba6d4cb1235f8973078ecfd577d1edcfbd7e4566"}],"neutron/plugins/nicira/dbexts/nicira_models.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"429b0180a3fd3b24b782af81fb13389e47b659f7","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    for a single Neutron network."},{"line_number":65,"context_line":"    \"\"\""},{"line_number":66,"context_line":"    __tablename__ \u003d \u0027neutron_nsx_network_mappings\u0027"},{"line_number":67,"context_line":"    neutron_id \u003d Column(String(36),"},{"line_number":68,"context_line":"                        ForeignKey(\u0027networks.id\u0027, ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":69,"context_line":"                        primary_key\u003dTrue)"},{"line_number":70,"context_line":"    nsx_id \u003d Column(String(36), primary_key\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2Fx3Q%3D","line":67,"updated":"2014-01-08 15:37:37.000000000","message":"just wondering, why not \u0027network_id\u0027?","commit_id":"34c5093190152f3e55be3c1c5f8e58e1905331ed"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"aa20ee7975870b05986b607e81ca8cbcd21bbd9a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    for a single Neutron network."},{"line_number":65,"context_line":"    \"\"\""},{"line_number":66,"context_line":"    __tablename__ \u003d \u0027neutron_nsx_network_mappings\u0027"},{"line_number":67,"context_line":"    neutron_id \u003d Column(String(36),"},{"line_number":68,"context_line":"                        ForeignKey(\u0027networks.id\u0027, ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":69,"context_line":"                        primary_key\u003dTrue)"},{"line_number":70,"context_line":"    nsx_id \u003d Column(String(36), primary_key\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2FxGE%3D","line":67,"in_reply_to":"AAAAUH%2F%2Fx3Q%3D","updated":"2014-01-08 17:57:00.000000000","message":"That\u0027s because we have similar mappings pretty much for each resource.\nIn other patches you\u0027ll hopefully see soon, we have other routines which look for a \u0027neutron_id\u0027 attribute in such mappings tables.\n\nBut this is such a minor point that I can surely rename it to network_id","commit_id":"34c5093190152f3e55be3c1c5f8e58e1905331ed"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"60ac17b092d112fcc469dbf7461b361b43dde88b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    for a single Neutron network."},{"line_number":65,"context_line":"    \"\"\""},{"line_number":66,"context_line":"    __tablename__ \u003d \u0027neutron_nsx_network_mappings\u0027"},{"line_number":67,"context_line":"    neutron_id \u003d Column(String(36),"},{"line_number":68,"context_line":"                        ForeignKey(\u0027networks.id\u0027, ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":69,"context_line":"                        primary_key\u003dTrue)"},{"line_number":70,"context_line":"    nsx_id \u003d Column(String(36), primary_key\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2FxAU%3D","line":67,"in_reply_to":"AAAAUH%2F%2FxB4%3D","updated":"2014-01-08 18:15:34.000000000","message":"sure. I was just asking.","commit_id":"34c5093190152f3e55be3c1c5f8e58e1905331ed"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"92cf0e5da1df885495debe72b9616761fc100e68","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    for a single Neutron network."},{"line_number":65,"context_line":"    \"\"\""},{"line_number":66,"context_line":"    __tablename__ \u003d \u0027neutron_nsx_network_mappings\u0027"},{"line_number":67,"context_line":"    neutron_id \u003d Column(String(36),"},{"line_number":68,"context_line":"                        ForeignKey(\u0027networks.id\u0027, ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":69,"context_line":"                        primary_key\u003dTrue)"},{"line_number":70,"context_line":"    nsx_id \u003d Column(String(36), primary_key\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2FxB4%3D","line":67,"in_reply_to":"AAAAUH%2F%2FxGE%3D","updated":"2014-01-08 18:07:43.000000000","message":"well.... actually we already merged several patches with neutron_id attribute. I hope you won\u0027t mind if I keep it.","commit_id":"34c5093190152f3e55be3c1c5f8e58e1905331ed"}]}