)]}'
{"neutron/agent/l3/dvr_edge_ha_router.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f3d0efbc3be0f46d1437b279b2cf6f48097f1a7c","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        interface_name \u003d self.get_snat_external_device_interface_name("},{"line_number":62,"context_line":"                self.get_ex_gw_port())"},{"line_number":63,"context_line":"        self._add_vip(fip_cidr, interface_name)"},{"line_number":64,"context_line":"        return constants.FLOATINGIP_STATUS_ACTIVE"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def remove_centralized_floatingip(self, fip_cidr):"},{"line_number":67,"context_line":"        self._remove_vip(fip_cidr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_b917c051","line":64,"updated":"2018-03-12 23:18:47.000000000","message":"So how does this change not break something?  The super() call could add the IP to the device but now it wont.","commit_id":"b26e2b704112f9d32e337c564e3c01e251dffb1e"},{"author":{"_account_id":23430,"name":"sunzuohua","email":"zuohuasun@gmail.com","username":"ZuohuaSun"},"change_message_id":"be86e4337721d1eabb64be8660f610251305e720","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        interface_name \u003d self.get_snat_external_device_interface_name("},{"line_number":62,"context_line":"                self.get_ex_gw_port())"},{"line_number":63,"context_line":"        self._add_vip(fip_cidr, interface_name)"},{"line_number":64,"context_line":"        return constants.FLOATINGIP_STATUS_ACTIVE"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def remove_centralized_floatingip(self, fip_cidr):"},{"line_number":67,"context_line":"        self._remove_vip(fip_cidr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_c4103b5a","line":64,"in_reply_to":"df7087c5_b917c051","updated":"2018-03-15 09:18:04.000000000","message":"For ha router, the ip should be added to the device by keepalived and not be added here.","commit_id":"b26e2b704112f9d32e337c564e3c01e251dffb1e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"43ab3351b1f56f8b66196e37bbd27ccec0e56d6f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        interface_name \u003d self.get_snat_external_device_interface_name("},{"line_number":62,"context_line":"                self.get_ex_gw_port())"},{"line_number":63,"context_line":"        self._add_vip(fip_cidr, interface_name)"},{"line_number":64,"context_line":"        return constants.FLOATINGIP_STATUS_ACTIVE"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def remove_centralized_floatingip(self, fip_cidr):"},{"line_number":67,"context_line":"        self._remove_vip(fip_cidr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_372f2f8f","line":64,"in_reply_to":"df7087c5_c4103b5a","updated":"2019-04-18 08:32:45.000000000","message":"Are You sure? I think that keepalived can only add this VIP address. It will not add floating IPs to the interface.","commit_id":"b26e2b704112f9d32e337c564e3c01e251dffb1e"},{"author":{"_account_id":23430,"name":"sunzuohua","email":"zuohuasun@gmail.com","username":"ZuohuaSun"},"change_message_id":"fc3b72751122cb8dc25aa000eeb00fb89d26bbb2","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        interface_name \u003d self.get_snat_external_device_interface_name("},{"line_number":62,"context_line":"                self.get_ex_gw_port())"},{"line_number":63,"context_line":"        self._add_vip(fip_cidr, interface_name)"},{"line_number":64,"context_line":"        return constants.FLOATINGIP_STATUS_ACTIVE"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def remove_centralized_floatingip(self, fip_cidr):"},{"line_number":67,"context_line":"        self._remove_vip(fip_cidr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_dfac86ee","line":64,"in_reply_to":"df7087c5_c4103b5a","updated":"2018-03-15 09:22:53.000000000","message":"I did not find a bug here. But I think it is not suitable to do like this and something may be wrong too.","commit_id":"b26e2b704112f9d32e337c564e3c01e251dffb1e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"72446a7c6cc28d4e944d5520dab43d4a12f50657","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    def remove_centralized_floatingip(self, fip_cidr):"},{"line_number":67,"context_line":"        self._remove_vip(fip_cidr)"},{"line_number":68,"context_line":"        if self.is_router_master():"},{"line_number":69,"context_line":"            super(DvrEdgeHaRouter, self).remove_centralized_floatingip("},{"line_number":70,"context_line":"                fip_cidr)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def external_gateway_added(self, ex_gw_port, interface_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_84c63516","line":69,"updated":"2018-05-01 22:15:08.000000000","message":"So maybe this is why I\u0027m confused.  With remove we go and remove the address, but shouldn\u0027t keepalived have done that as well?  It just doesn\u0027t seem symmetrical any more.","commit_id":"b26e2b704112f9d32e337c564e3c01e251dffb1e"},{"author":{"_account_id":23430,"name":"sunzuohua","email":"zuohuasun@gmail.com","username":"ZuohuaSun"},"change_message_id":"7addaf3890cdff365c4271c53f9d8ab2836f5635","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    def remove_centralized_floatingip(self, fip_cidr):"},{"line_number":67,"context_line":"        self._remove_vip(fip_cidr)"},{"line_number":68,"context_line":"        if self.is_router_master():"},{"line_number":69,"context_line":"            super(DvrEdgeHaRouter, self).remove_centralized_floatingip("},{"line_number":70,"context_line":"                fip_cidr)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def external_gateway_added(self, ex_gw_port, interface_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_334d5172","line":69,"in_reply_to":"9f6a8fd7_84c63516","updated":"2018-05-07 12:32:09.000000000","message":"We need to delete the address along with its conntrack state when removing floatingip, so it is not symmetrical indeed.","commit_id":"b26e2b704112f9d32e337c564e3c01e251dffb1e"}]}