)]}'
{"neutron/api/rpc/handlers/dvr_rpc.py":[{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"139b6bc1282342a8d65757c28b4a2575e0437a06","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        return self.plugin.get_ports_on_host_by_subnet(context,"},{"line_number":113,"context_line":"            host, subnet)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def get_network_info_for_id(self, context, **kwargs):"},{"line_number":116,"context_line":"        \"\"\"Get network info for DVR port.\"\"\""},{"line_number":117,"context_line":"        network_id \u003d kwargs.get(\u0027network_id\u0027)"},{"line_number":118,"context_line":"        LOG.debug(\"DVR Agent requests network info %s\", network_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f9dbf25_c0c52e90","line":115,"range":{"start_line":115,"start_character":38,"end_line":115,"end_character":45},"updated":"2018-03-01 20:14:58.000000000","message":"why **kwargs? \nthis is a new method used only in one place I can tell. \nyou can just make it network_id\u003dnetwork_id","commit_id":"fbe088011e154d50885f1be0541e049fbc4cd264"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"62306223c7e652bde28698251b91a176a5fb6578","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        return self.plugin.get_ports_on_host_by_subnet(context,"},{"line_number":113,"context_line":"            host, subnet)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def get_network_info_for_id(self, context, **kwargs):"},{"line_number":116,"context_line":"        \"\"\"Get network info for DVR port.\"\"\""},{"line_number":117,"context_line":"        network_id \u003d kwargs.get(\u0027network_id\u0027)"},{"line_number":118,"context_line":"        LOG.debug(\"DVR Agent requests network info %s\", network_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f9dbf25_a0f02292","line":115,"range":{"start_line":115,"start_character":38,"end_line":115,"end_character":45},"in_reply_to":"1f9dbf25_c0c52e90","updated":"2018-03-01 20:34:26.000000000","message":"Good point I just sticked on with how it was written earlier. #L101","commit_id":"fbe088011e154d50885f1be0541e049fbc4cd264"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"63e262ea67c1f003f6b6c2a2c264a51220497b9f","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    def get_network_info_for_id(self, context, **kwargs):"},{"line_number":116,"context_line":"        \"\"\"Get network info for DVR port.\"\"\""},{"line_number":117,"context_line":"        network_id \u003d kwargs.get(\u0027network_id\u0027)"},{"line_number":118,"context_line":"        LOG.debug(\"DVR Agent requests network info %s\", network_id)"},{"line_number":119,"context_line":"        net_filter \u003d {\u0027id\u0027: [network_id]}"},{"line_number":120,"context_line":"        return self.plugin.get_networks(context, filters\u003dnet_filter)"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"df7087c5_4debb9af","line":118,"range":{"start_line":118,"start_character":46,"end_line":118,"end_character":50},"updated":"2018-03-07 04:02:06.000000000","message":"nit\n\ns/info for id","commit_id":"b5dc0d6e19425be6f04835838e7c656031b606c9"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"1c41f797c678b6168719310b393e778bc6221ac1","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    def get_network_info_for_id(self, context, **kwargs):"},{"line_number":116,"context_line":"        \"\"\"Get network info for DVR port.\"\"\""},{"line_number":117,"context_line":"        network_id \u003d kwargs.get(\u0027network_id\u0027)"},{"line_number":118,"context_line":"        LOG.debug(\"DVR Agent requests network info %s\", network_id)"},{"line_number":119,"context_line":"        net_filter \u003d {\u0027id\u0027: [network_id]}"},{"line_number":120,"context_line":"        return self.plugin.get_networks(context, filters\u003dnet_filter)"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"df7087c5_ddf509cd","line":118,"range":{"start_line":118,"start_character":46,"end_line":118,"end_character":50},"in_reply_to":"df7087c5_4debb9af","updated":"2018-03-08 19:15:15.000000000","message":"will fix it.","commit_id":"b5dc0d6e19425be6f04835838e7c656031b606c9"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"946ff503775a8ee4a16df6ec904aa3f5daf2a942","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @log_helpers.log_method_call"},{"line_number":63,"context_line":"    def get_network_info_for_id(self, context, network_id):"},{"line_number":64,"context_line":"        \"\"\"Get network info for DVR router ports.\"\"\""},{"line_number":65,"context_line":"        cctxt \u003d self.client.prepare()"},{"line_number":66,"context_line":"        return cctxt.call(context, \u0027get_network_info_for_id\u0027,"},{"line_number":67,"context_line":"                          network_id\u003dnetwork_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df7087c5_ef87d860","line":64,"range":{"start_line":64,"start_character":43,"end_line":64,"end_character":48},"updated":"2018-03-09 19:15:39.000000000","message":"You can remove comment. is redundant with the name of the method. The name of the method is pretty clear.","commit_id":"d019790fe436b72cb05b8d0ff1f3a62ebd9e9bee"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"946ff503775a8ee4a16df6ec904aa3f5daf2a942","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            host, subnet)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def get_network_info_for_id(self, context, **kwargs):"},{"line_number":116,"context_line":"        \"\"\"Get network info for DVR port.\"\"\""},{"line_number":117,"context_line":"        network_id \u003d kwargs.get(\u0027network_id\u0027)"},{"line_number":118,"context_line":"        LOG.debug(\"DVR Agent requests network info for id %s\", network_id)"},{"line_number":119,"context_line":"        net_filter \u003d {\u0027id\u0027: [network_id]}"}],"source_content_type":"text/x-python","patch_set":5,"id":"df7087c5_efecb82a","line":116,"range":{"start_line":116,"start_character":32,"end_line":116,"end_character":35},"updated":"2018-03-09 19:15:39.000000000","message":"Remove comment.","commit_id":"d019790fe436b72cb05b8d0ff1f3a62ebd9e9bee"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_dvr_neutron_agent.py":[{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"139b6bc1282342a8d65757c28b4a2575e0437a06","unresolved":false,"context_lines":[{"line_number":420,"context_line":"            br \u003d self.tun_br"},{"line_number":421,"context_line":"        # TODO(vivek) remove the IPv6 related flows once SNAT is not"},{"line_number":422,"context_line":"        # used for IPv6 DVR."},{"line_number":423,"context_line":"        # NOTE: Get network info for the port to check if shared."},{"line_number":424,"context_line":"        port_net_info \u003d ("},{"line_number":425,"context_line":"            self.plugin_rpc.get_network_info_for_id("},{"line_number":426,"context_line":"                self.context, subnet_info.get(\u0027network_id\u0027)))"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f9dbf25_80bf26fa","line":423,"range":{"start_line":423,"start_character":28,"end_line":423,"end_character":32},"updated":"2018-03-01 20:14:58.000000000","message":"Unless absolutely necessary remove the note. It just means two places to mantain code at. the code itself shows what it is doing. also the not is not very clear.","commit_id":"fbe088011e154d50885f1be0541e049fbc4cd264"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"62306223c7e652bde28698251b91a176a5fb6578","unresolved":false,"context_lines":[{"line_number":420,"context_line":"            br \u003d self.tun_br"},{"line_number":421,"context_line":"        # TODO(vivek) remove the IPv6 related flows once SNAT is not"},{"line_number":422,"context_line":"        # used for IPv6 DVR."},{"line_number":423,"context_line":"        # NOTE: Get network info for the port to check if shared."},{"line_number":424,"context_line":"        port_net_info \u003d ("},{"line_number":425,"context_line":"            self.plugin_rpc.get_network_info_for_id("},{"line_number":426,"context_line":"                self.context, subnet_info.get(\u0027network_id\u0027)))"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f9dbf25_6030da57","line":423,"range":{"start_line":423,"start_character":28,"end_line":423,"end_character":32},"in_reply_to":"1f9dbf25_80bf26fa","updated":"2018-03-01 20:34:26.000000000","message":"OK I will try to remove the NOTE: if it is not clear and does not make sense.","commit_id":"fbe088011e154d50885f1be0541e049fbc4cd264"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"139b6bc1282342a8d65757c28b4a2575e0437a06","unresolved":false,"context_lines":[{"line_number":427,"context_line":"        net_shared_only \u003d ("},{"line_number":428,"context_line":"            port_net_info[0][\u0027shared\u0027] and"},{"line_number":429,"context_line":"            not port_net_info[0][\u0027router:external\u0027])"},{"line_number":430,"context_line":"        if net_shared_only:"},{"line_number":431,"context_line":"            LOG.debug(\"Do not apply the dvr rules to tunnel bridge for \""},{"line_number":432,"context_line":"                      \"shared network\")"},{"line_number":433,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f9dbf25_c073ee7f","line":430,"range":{"start_line":430,"start_character":11,"end_line":430,"end_character":26},"updated":"2018-03-01 20:14:58.000000000","message":"Too many lines. This can be written as\nif (port_net_info[0][\u0027shared\u0027] and\n            not port_net_info[0][\u0027router:external\u0027]):","commit_id":"fbe088011e154d50885f1be0541e049fbc4cd264"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"62306223c7e652bde28698251b91a176a5fb6578","unresolved":false,"context_lines":[{"line_number":427,"context_line":"        net_shared_only \u003d ("},{"line_number":428,"context_line":"            port_net_info[0][\u0027shared\u0027] and"},{"line_number":429,"context_line":"            not port_net_info[0][\u0027router:external\u0027])"},{"line_number":430,"context_line":"        if net_shared_only:"},{"line_number":431,"context_line":"            LOG.debug(\"Do not apply the dvr rules to tunnel bridge for \""},{"line_number":432,"context_line":"                      \"shared network\")"},{"line_number":433,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f9dbf25_203ad235","line":430,"range":{"start_line":430,"start_character":11,"end_line":430,"end_character":26},"in_reply_to":"1f9dbf25_c073ee7f","updated":"2018-03-01 20:34:26.000000000","message":"I like this isolation and it was recommended to do this way for a while.","commit_id":"fbe088011e154d50885f1be0541e049fbc4cd264"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"63e262ea67c1f003f6b6c2a2c264a51220497b9f","unresolved":false,"context_lines":[{"line_number":428,"context_line":"            not port_net_info[0][\u0027router:external\u0027])"},{"line_number":429,"context_line":"        if net_shared_only:"},{"line_number":430,"context_line":"            LOG.debug(\"Do not apply the dvr rules to tunnel bridge for \""},{"line_number":431,"context_line":"                      \"shared network\")"},{"line_number":432,"context_line":"        else:"},{"line_number":433,"context_line":"            if ip_version \u003d\u003d 4:"},{"line_number":434,"context_line":"                if subnet_info[\u0027gateway_ip\u0027]:"}],"source_content_type":"text/x-python","patch_set":4,"id":"df7087c5_6def9d87","line":431,"updated":"2018-03-07 04:02:06.000000000","message":"I\u0027m not sure you even need a log message, but if you decide to keep it maybe rewrite as:\n\n\"Not applying DVR rules to tunnel bridge %s because it is a shared network\"\n\nDoes that sound correct?","commit_id":"b5dc0d6e19425be6f04835838e7c656031b606c9"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"1c41f797c678b6168719310b393e778bc6221ac1","unresolved":false,"context_lines":[{"line_number":428,"context_line":"            not port_net_info[0][\u0027router:external\u0027])"},{"line_number":429,"context_line":"        if net_shared_only:"},{"line_number":430,"context_line":"            LOG.debug(\"Do not apply the dvr rules to tunnel bridge for \""},{"line_number":431,"context_line":"                      \"shared network\")"},{"line_number":432,"context_line":"        else:"},{"line_number":433,"context_line":"            if ip_version \u003d\u003d 4:"},{"line_number":434,"context_line":"                if subnet_info[\u0027gateway_ip\u0027]:"}],"source_content_type":"text/x-python","patch_set":4,"id":"df7087c5_fd0ecde3","line":431,"in_reply_to":"df7087c5_6def9d87","updated":"2018-03-08 19:15:15.000000000","message":"Ok will rewrite the log message.","commit_id":"b5dc0d6e19425be6f04835838e7c656031b606c9"}],"neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/test_ovs_neutron_agent.py":[{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"139b6bc1282342a8d65757c28b4a2575e0437a06","unresolved":false,"context_lines":[{"line_number":2454,"context_line":"                ipvx_calls \u003d ["},{"line_number":2455,"context_line":"                    mock.call.install_dvr_process_ipv6("},{"line_number":2456,"context_line":"                        vlan_tag\u003dlvid,"},{"line_number":2457,"context_line":"                        gateway_mac\u003dgateway_mac),"},{"line_number":2458,"context_line":"                ]"},{"line_number":2459,"context_line":"            return ipvx_calls + ["},{"line_number":2460,"context_line":"                mock.call.install_dvr_process("}],"source_content_type":"text/x-python","patch_set":3,"id":"1f9dbf25_40bcbedb","line":2457,"range":{"start_line":2457,"start_character":47,"end_line":2457,"end_character":49},"updated":"2018-03-01 20:14:58.000000000","message":"why the \u0027,\u0027 ?","commit_id":"fbe088011e154d50885f1be0541e049fbc4cd264"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"62306223c7e652bde28698251b91a176a5fb6578","unresolved":false,"context_lines":[{"line_number":2454,"context_line":"                ipvx_calls \u003d ["},{"line_number":2455,"context_line":"                    mock.call.install_dvr_process_ipv6("},{"line_number":2456,"context_line":"                        vlan_tag\u003dlvid,"},{"line_number":2457,"context_line":"                        gateway_mac\u003dgateway_mac),"},{"line_number":2458,"context_line":"                ]"},{"line_number":2459,"context_line":"            return ipvx_calls + ["},{"line_number":2460,"context_line":"                mock.call.install_dvr_process("}],"source_content_type":"text/x-python","patch_set":3,"id":"1f9dbf25_c0f9ae80","line":2457,"range":{"start_line":2457,"start_character":47,"end_line":2457,"end_character":49},"in_reply_to":"1f9dbf25_40bcbedb","updated":"2018-03-01 20:34:26.000000000","message":"That is in the original code and I am not making that change in this patch.","commit_id":"fbe088011e154d50885f1be0541e049fbc4cd264"}]}
