)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f75fd6439b6750511ec6036369950239a773e1fc","unresolved":false,"context_lines":[{"line_number":10,"context_line":"were rehomed into neutron-lib with [1] and the remaining with [2]."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch consumes [1] by:"},{"line_number":13,"context_line":"- Removing the remhomed code from neutron."},{"line_number":14,"context_line":"- Removing the UTs that are no longer applicable."},{"line_number":15,"context_line":"- Moving any remining logic into a _utils module to mark it as private."},{"line_number":16,"context_line":"- Leaving the functions in [2] in neutron.plugins.common.utils until"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bf659307_ea03f740","line":13,"updated":"2018-04-11 22:22:35.000000000","message":"rehomed","commit_id":"47c3f705779dd1abd8192a6ac6832425b18bad29"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f75fd6439b6750511ec6036369950239a773e1fc","unresolved":false,"context_lines":[{"line_number":12,"context_line":"This patch consumes [1] by:"},{"line_number":13,"context_line":"- Removing the remhomed code from neutron."},{"line_number":14,"context_line":"- Removing the UTs that are no longer applicable."},{"line_number":15,"context_line":"- Moving any remining logic into a _utils module to mark it as private."},{"line_number":16,"context_line":"- Leaving the functions in [2] in neutron.plugins.common.utils until"},{"line_number":17,"context_line":"we release [2] and can consume it at which point we\u0027ll only be left with"},{"line_number":18,"context_line":"the _utils module in neutron."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bf659307_aaf97f4e","line":15,"updated":"2018-04-11 22:22:35.000000000","message":"remaining","commit_id":"47c3f705779dd1abd8192a6ac6832425b18bad29"}],"neutron/plugins/common/_utils.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c5ade62f7f56793c1bffd41491de4011a6b3cb02","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 Cisco Systems, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_e052f612","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":16},"updated":"2018-04-03 16:06:18.000000000","message":"2018 ?","commit_id":"c95a58ab5b0cb21f478465ba46e5c992688baab4"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"3bf9b85bacb8a71a91b83ad8668e879338e2eb39","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 Cisco Systems, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_0dcb8172","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":16},"in_reply_to":"bf659307_e052f612","updated":"2018-04-04 20:13:17.000000000","message":"2013 is from the original file [1]. I think we want to keep it as-is to reflect the original.\n\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/plugins/common/utils.py","commit_id":"c95a58ab5b0cb21f478465ba46e5c992688baab4"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f75fd6439b6750511ec6036369950239a773e1fc","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def get_deployment_physnet_mtu():"},{"line_number":24,"context_line":"    \"\"\"Retrieves global physical network MTU setting."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    Plugins should use this function to retrieve the MTU set by the operator"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_6a4cc79d","line":23,"updated":"2018-04-11 22:22:35.000000000","message":"this function was actually meant to be consumed by external users, so I don\u0027t agree the right final place for it is a private module. Instead, it should be part of neutron-lib. (that being said, I am not sure if we can expose functions that depend on cfg.CONF object there; thoughts?)","commit_id":"47c3f705779dd1abd8192a6ac6832425b18bad29"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"8b67d27df0c12edfc234159c7c4cdca0ddd68ef0","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def get_deployment_physnet_mtu():"},{"line_number":24,"context_line":"    \"\"\"Retrieves global physical network MTU setting."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    Plugins should use this function to retrieve the MTU set by the operator"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_f3c2f952","line":23,"in_reply_to":"bf659307_6a4cc79d","updated":"2018-04-12 15:50:18.000000000","message":"Done [1]. Using the conf in lib shouldn\u0027t be a problem as long as we note it. We already do it in a few places.\n\n\nI\u0027ll update this patch in prep for [1].\n\n\n[1] https://review.openstack.org/#/c/560950/\n[2] http://codesearch.openstack.org/?q\u003dimport%20cfg\u0026i\u003dnope\u0026files\u003d\u0026repos\u003dneutron-lib","commit_id":"47c3f705779dd1abd8192a6ac6832425b18bad29"}]}