)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4e63538055b0570a35a12b8f0d6b547290ffa3cc","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Update fip qos above bumps the revision of the floatingIp."},{"line_number":10,"context_line":"It would add floatingIp object to the session."},{"line_number":11,"context_line":"Expunge it to ensure the following get_object doesn\u0027t use"},{"line_number":12,"context_line":"the instance."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I5e708f91c70c63baeb886c5644f754d22df1637d"},{"line_number":15,"context_line":"Closes-Bug: #1750591"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff6b8bd7_63301009","line":12,"updated":"2018-03-05 09:31:51.000000000","message":"Can You maybe rephrase this commit message or at least write a comment what is the issue exactly and how to reproduce it.\nAnd also please tell me how it is related to bug which You mentioned below.","commit_id":"9ebfa7f95f4cf9522ac33847ff6ab657f8920478"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"22fc52da784858b7d3b09e10aa7d4a9a0195aac5","unresolved":false,"context_lines":[{"line_number":12,"context_line":"the instance."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I5e708f91c70c63baeb886c5644f754d22df1637d"},{"line_number":15,"context_line":"Closes-Bug: #1750591"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff6b8bd7_e3266017","line":15,"updated":"2018-03-05 09:12:33.000000000","message":"This bug already has a fix. If that fix is broken or causes a regression, please create a new bug for that showing the details and link to it here.","commit_id":"9ebfa7f95f4cf9522ac33847ff6ab657f8920478"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"38463d38c3bdb7b4faf2138cb560477c9ad50606","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Guoshuai Li \u003cligs@dtdream.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-03-07 01:51:03 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[L3] [QoS] Fixes Get old QoS policy ID when updated."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With a certain chance, updating the QoS policy ID of a floating IP does"},{"line_number":10,"context_line":"not take effect. This is because the revision will be processed."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df7087c5_b59e4405","line":7,"range":{"start_line":7,"start_character":11,"end_line":7,"end_character":52},"updated":"2018-03-08 02:46:29.000000000","message":"What about `Expunge context session during floating IP updating`, by the way, maybe the tag [QoS] can be removed.","commit_id":"0d35bd815041fa3de71aaebc7c1b96447cf17f31"},{"author":{"_account_id":24438,"name":"Guoshuai Li","email":"liguoshuai1989@gmail.com","username":"Guoshuai"},"change_message_id":"5b77b736eb62277b87e0b737e20fbf2e4c02a0b3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Guoshuai Li \u003cligs@dtdream.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-03-07 01:51:03 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[L3] [QoS] Fixes Get old QoS policy ID when updated."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With a certain chance, updating the QoS policy ID of a floating IP does"},{"line_number":10,"context_line":"not take effect. This is because the revision will be processed."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df7087c5_7b889bc5","line":7,"range":{"start_line":7,"start_character":11,"end_line":7,"end_character":52},"in_reply_to":"df7087c5_b59e4405","updated":"2018-03-08 05:58:38.000000000","message":"Done","commit_id":"0d35bd815041fa3de71aaebc7c1b96447cf17f31"}],"neutron/db/l3_db.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"38463d38c3bdb7b4faf2138cb560477c9ad50606","unresolved":false,"context_lines":[{"line_number":1391,"context_line":"                                                   floatingip_obj,"},{"line_number":1392,"context_line":"                                                   fip,"},{"line_number":1393,"context_line":"                                                   old_floatingip)"},{"line_number":1394,"context_line":"            # fetch floatingIp from db to load the fip\u0027s qos with fip model."},{"line_number":1395,"context_line":"            # Update fip qos above bumps the revision of the floatingIp."},{"line_number":1396,"context_line":"            # It would add floatingIp object to the session."},{"line_number":1397,"context_line":"            # Expunge it to ensure the following get_object doesn\u0027t"},{"line_number":1398,"context_line":"            # use the instance."}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_157e10e4","line":1395,"range":{"start_line":1394,"start_character":12,"end_line":1395,"end_character":72},"updated":"2018-03-08 02:46:29.000000000","message":"As Ihar suggested, maybe you can rewrite the comments.","commit_id":"0d35bd815041fa3de71aaebc7c1b96447cf17f31"},{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"944857190d9436d55dca5c5b1ee2fcbbbf4e17c0","unresolved":false,"context_lines":[{"line_number":1391,"context_line":"                                                   floatingip_obj,"},{"line_number":1392,"context_line":"                                                   fip,"},{"line_number":1393,"context_line":"                                                   old_floatingip)"},{"line_number":1394,"context_line":"            # fetch floatingIp from db to load the fip\u0027s qos with fip model."},{"line_number":1395,"context_line":"            # Update fip qos above bumps the revision of the floatingIp."},{"line_number":1396,"context_line":"            # It would add floatingIp object to the session."},{"line_number":1397,"context_line":"            # Expunge it to ensure the following get_object doesn\u0027t"},{"line_number":1398,"context_line":"            # use the instance."}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_1bbddfb6","line":1395,"range":{"start_line":1394,"start_character":12,"end_line":1395,"end_character":72},"in_reply_to":"df7087c5_157e10e4","updated":"2018-03-08 05:21:47.000000000","message":"+1","commit_id":"0d35bd815041fa3de71aaebc7c1b96447cf17f31"},{"author":{"_account_id":24438,"name":"Guoshuai Li","email":"liguoshuai1989@gmail.com","username":"Guoshuai"},"change_message_id":"5b77b736eb62277b87e0b737e20fbf2e4c02a0b3","unresolved":false,"context_lines":[{"line_number":1391,"context_line":"                                                   floatingip_obj,"},{"line_number":1392,"context_line":"                                                   fip,"},{"line_number":1393,"context_line":"                                                   old_floatingip)"},{"line_number":1394,"context_line":"            # fetch floatingIp from db to load the fip\u0027s qos with fip model."},{"line_number":1395,"context_line":"            # Update fip qos above bumps the revision of the floatingIp."},{"line_number":1396,"context_line":"            # It would add floatingIp object to the session."},{"line_number":1397,"context_line":"            # Expunge it to ensure the following get_object doesn\u0027t"},{"line_number":1398,"context_line":"            # use the instance."}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_3b9223f8","line":1395,"range":{"start_line":1394,"start_character":12,"end_line":1395,"end_character":72},"in_reply_to":"df7087c5_157e10e4","updated":"2018-03-08 05:58:38.000000000","message":"Done","commit_id":"0d35bd815041fa3de71aaebc7c1b96447cf17f31"},{"author":{"_account_id":24438,"name":"Guoshuai Li","email":"liguoshuai1989@gmail.com","username":"Guoshuai"},"change_message_id":"5b77b736eb62277b87e0b737e20fbf2e4c02a0b3","unresolved":false,"context_lines":[{"line_number":1391,"context_line":"                                                   floatingip_obj,"},{"line_number":1392,"context_line":"                                                   fip,"},{"line_number":1393,"context_line":"                                                   old_floatingip)"},{"line_number":1394,"context_line":"            # fetch floatingIp from db to load the fip\u0027s qos with fip model."},{"line_number":1395,"context_line":"            # Update fip qos above bumps the revision of the floatingIp."},{"line_number":1396,"context_line":"            # It would add floatingIp object to the session."},{"line_number":1397,"context_line":"            # Expunge it to ensure the following get_object doesn\u0027t"},{"line_number":1398,"context_line":"            # use the instance."}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_9b856fb0","line":1395,"range":{"start_line":1394,"start_character":12,"end_line":1395,"end_character":72},"in_reply_to":"df7087c5_1bbddfb6","updated":"2018-03-08 05:58:38.000000000","message":"Done","commit_id":"0d35bd815041fa3de71aaebc7c1b96447cf17f31"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d53c2253812bfe218ca0dcbe4ba89f352c984971","unresolved":false,"context_lines":[{"line_number":1397,"context_line":"            # Expunge it to ensure the following get_object doesn\u0027t"},{"line_number":1398,"context_line":"            # use the instance."},{"line_number":1399,"context_line":"            context.session.expunge(model_query.get_by_id("},{"line_number":1400,"context_line":"                context, l3_models.FloatingIP, floatingip_obj.id))"},{"line_number":1401,"context_line":"            floatingip_obj \u003d l3_obj.FloatingIP.get_object("},{"line_number":1402,"context_line":"                context, id\u003dfloatingip_obj.id)"},{"line_number":1403,"context_line":"            floatingip_db \u003d floatingip_obj.db_obj"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_b8f2d099","line":1400,"updated":"2018-03-07 09:53:21.000000000","message":"I wonder why we have to play with db session directly here and why we can\u0027t use floatingip_obj.update_fields(fip) instead. Shouldn\u0027t we use only OVO methods everywhere where?","commit_id":"0d35bd815041fa3de71aaebc7c1b96447cf17f31"},{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"944857190d9436d55dca5c5b1ee2fcbbbf4e17c0","unresolved":false,"context_lines":[{"line_number":1397,"context_line":"            # Expunge it to ensure the following get_object doesn\u0027t"},{"line_number":1398,"context_line":"            # use the instance."},{"line_number":1399,"context_line":"            context.session.expunge(model_query.get_by_id("},{"line_number":1400,"context_line":"                context, l3_models.FloatingIP, floatingip_obj.id))"},{"line_number":1401,"context_line":"            floatingip_obj \u003d l3_obj.FloatingIP.get_object("},{"line_number":1402,"context_line":"                context, id\u003dfloatingip_obj.id)"},{"line_number":1403,"context_line":"            floatingip_db \u003d floatingip_obj.db_obj"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_fbb7cbd7","line":1400,"in_reply_to":"df7087c5_151930d6","updated":"2018-03-08 05:21:47.000000000","message":"@Ihar, current codes run regardless of enabling fip_qos extension or not. :)","commit_id":"0d35bd815041fa3de71aaebc7c1b96447cf17f31"},{"author":{"_account_id":24438,"name":"Guoshuai Li","email":"liguoshuai1989@gmail.com","username":"Guoshuai"},"change_message_id":"5b77b736eb62277b87e0b737e20fbf2e4c02a0b3","unresolved":false,"context_lines":[{"line_number":1397,"context_line":"            # Expunge it to ensure the following get_object doesn\u0027t"},{"line_number":1398,"context_line":"            # use the instance."},{"line_number":1399,"context_line":"            context.session.expunge(model_query.get_by_id("},{"line_number":1400,"context_line":"                context, l3_models.FloatingIP, floatingip_obj.id))"},{"line_number":1401,"context_line":"            floatingip_obj \u003d l3_obj.FloatingIP.get_object("},{"line_number":1402,"context_line":"                context, id\u003dfloatingip_obj.id)"},{"line_number":1403,"context_line":"            floatingip_db \u003d floatingip_obj.db_obj"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_bbb71387","line":1400,"in_reply_to":"df7087c5_151930d6","updated":"2018-03-08 05:58:38.000000000","message":"Done","commit_id":"0d35bd815041fa3de71aaebc7c1b96447cf17f31"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1f41daf43519c0d7a2ad1b03c9eff5c78ce3bd70","unresolved":false,"context_lines":[{"line_number":1397,"context_line":"            # Expunge it to ensure the following get_object doesn\u0027t"},{"line_number":1398,"context_line":"            # use the instance."},{"line_number":1399,"context_line":"            context.session.expunge(model_query.get_by_id("},{"line_number":1400,"context_line":"                context, l3_models.FloatingIP, floatingip_obj.id))"},{"line_number":1401,"context_line":"            floatingip_obj \u003d l3_obj.FloatingIP.get_object("},{"line_number":1402,"context_line":"                context, id\u003dfloatingip_obj.id)"},{"line_number":1403,"context_line":"            floatingip_db \u003d floatingip_obj.db_obj"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_c12c649b","line":1400,"in_reply_to":"df7087c5_b8f2d099","updated":"2018-03-07 16:49:30.000000000","message":"Just calling update_fields will result in the object having changed fields, which is not ideal (I don\u0027t think consumers care too much right now, but it just doesn\u0027t sound right to pass an object with fields that are said to be not persisted while in reality they are persisted.)\nI think it\u0027s ok to expunge the object before fetching it for PRECOMMIT_UPDATE callback as proposed; at least until all extensions switch to using OVO objects that already take care of it themselves.\n\nThe only thing that I would suggest here is that instead of expunging only when fip_qos extension is enabled, it\u0027s probably better to do it regardless before FloatingIP.get_object because if not fip_qos then another extension could modify the object in some way and would require expunge for get_object to see the latest state. (Basically, move the expunge call from under if section.)","commit_id":"0d35bd815041fa3de71aaebc7c1b96447cf17f31"},{"author":{"_account_id":24438,"name":"Guoshuai Li","email":"liguoshuai1989@gmail.com","username":"Guoshuai"},"change_message_id":"adbb4366a57ea9bef26cbab1b21e57e625d223df","unresolved":false,"context_lines":[{"line_number":1397,"context_line":"            # Expunge it to ensure the following get_object doesn\u0027t"},{"line_number":1398,"context_line":"            # use the instance."},{"line_number":1399,"context_line":"            context.session.expunge(model_query.get_by_id("},{"line_number":1400,"context_line":"                context, l3_models.FloatingIP, floatingip_obj.id))"},{"line_number":1401,"context_line":"            floatingip_obj \u003d l3_obj.FloatingIP.get_object("},{"line_number":1402,"context_line":"                context, id\u003dfloatingip_obj.id)"},{"line_number":1403,"context_line":"            floatingip_db \u003d floatingip_obj.db_obj"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_36aed12e","line":1400,"in_reply_to":"df7087c5_b8f2d099","updated":"2018-03-07 11:18:30.000000000","message":"The floatingIP QoS-Policy-Id field has been updated by _process_extra_fip_qos_update.\nwhat about use floatingip_obj.update() here?","commit_id":"0d35bd815041fa3de71aaebc7c1b96447cf17f31"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ed2dd65397ea2bdfd9f842e11ef977b8cc856cf7","unresolved":false,"context_lines":[{"line_number":1397,"context_line":"            # Expunge it to ensure the following get_object doesn\u0027t"},{"line_number":1398,"context_line":"            # use the instance."},{"line_number":1399,"context_line":"            context.session.expunge(model_query.get_by_id("},{"line_number":1400,"context_line":"                context, l3_models.FloatingIP, floatingip_obj.id))"},{"line_number":1401,"context_line":"            floatingip_obj \u003d l3_obj.FloatingIP.get_object("},{"line_number":1402,"context_line":"                context, id\u003dfloatingip_obj.id)"},{"line_number":1403,"context_line":"            floatingip_db \u003d floatingip_obj.db_obj"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_04ffbc01","line":1400,"in_reply_to":"df7087c5_bbb71387","updated":"2018-03-08 08:14:22.000000000","message":"Ok, thanks. That is fine for me :)","commit_id":"0d35bd815041fa3de71aaebc7c1b96447cf17f31"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"38463d38c3bdb7b4faf2138cb560477c9ad50606","unresolved":false,"context_lines":[{"line_number":1397,"context_line":"            # Expunge it to ensure the following get_object doesn\u0027t"},{"line_number":1398,"context_line":"            # use the instance."},{"line_number":1399,"context_line":"            context.session.expunge(model_query.get_by_id("},{"line_number":1400,"context_line":"                context, l3_models.FloatingIP, floatingip_obj.id))"},{"line_number":1401,"context_line":"            floatingip_obj \u003d l3_obj.FloatingIP.get_object("},{"line_number":1402,"context_line":"                context, id\u003dfloatingip_obj.id)"},{"line_number":1403,"context_line":"            floatingip_db \u003d floatingip_obj.db_obj"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_151930d6","line":1400,"in_reply_to":"df7087c5_c12c649b","updated":"2018-03-08 02:46:29.000000000","message":"This `expunge` is not under the if `_is_fip_qos_supported` now. Right?","commit_id":"0d35bd815041fa3de71aaebc7c1b96447cf17f31"},{"author":{"_account_id":24438,"name":"Guoshuai Li","email":"liguoshuai1989@gmail.com","username":"Guoshuai"},"change_message_id":"5b77b736eb62277b87e0b737e20fbf2e4c02a0b3","unresolved":false,"context_lines":[{"line_number":1397,"context_line":"            # Expunge it to ensure the following get_object doesn\u0027t"},{"line_number":1398,"context_line":"            # use the instance."},{"line_number":1399,"context_line":"            context.session.expunge(model_query.get_by_id("},{"line_number":1400,"context_line":"                context, l3_models.FloatingIP, floatingip_obj.id))"},{"line_number":1401,"context_line":"            floatingip_obj \u003d l3_obj.FloatingIP.get_object("},{"line_number":1402,"context_line":"                context, id\u003dfloatingip_obj.id)"},{"line_number":1403,"context_line":"            floatingip_db \u003d floatingip_obj.db_obj"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_98d9f584","line":1400,"in_reply_to":"df7087c5_c12c649b","updated":"2018-03-08 05:58:38.000000000","message":"hello Ihar\nThanks for review, \nI\u0027m sorry that the original version of the email we sent you is not quite the same as this patch:\nexpunge is under in if, and the patch is outside.","commit_id":"0d35bd815041fa3de71aaebc7c1b96447cf17f31"}],"neutron/tests/unit/extensions/test_qos_fip.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"38463d38c3bdb7b4faf2138cb560477c9ad50606","unresolved":false,"context_lines":[{"line_number":339,"context_line":"            plugin \u003d (\u0027neutron.tests.unit.extensions.test_qos_fip.\u0027"},{"line_number":340,"context_line":"                      \u0027TestFloatingIPQoSIntPlugin\u0027)"},{"line_number":341,"context_line":"        service_plugins \u003d {\u0027qos\u0027: \u0027neutron.services.qos.qos_plugin.QoSPlugin\u0027,"},{"line_number":342,"context_line":"                           \u0027revision_plugin_name\u0027: \u0027revisions\u0027}"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        extraroute_db.register_db_extraroute_opts()"},{"line_number":345,"context_line":"        # for these tests we need to enable overlapping ips"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_b5d084cb","line":342,"range":{"start_line":342,"start_character":27,"end_line":342,"end_character":62},"updated":"2018-03-08 02:46:29.000000000","message":"I suggest you could add a new class with independent cases to test l3 qos with the reversions plugin. So we could have two scenarios.\n\nAnd for sub-projects, they can enable the revisions plugin in their own test code.","commit_id":"0d35bd815041fa3de71aaebc7c1b96447cf17f31"},{"author":{"_account_id":24438,"name":"Guoshuai Li","email":"liguoshuai1989@gmail.com","username":"Guoshuai"},"change_message_id":"5b77b736eb62277b87e0b737e20fbf2e4c02a0b3","unresolved":false,"context_lines":[{"line_number":339,"context_line":"            plugin \u003d (\u0027neutron.tests.unit.extensions.test_qos_fip.\u0027"},{"line_number":340,"context_line":"                      \u0027TestFloatingIPQoSIntPlugin\u0027)"},{"line_number":341,"context_line":"        service_plugins \u003d {\u0027qos\u0027: \u0027neutron.services.qos.qos_plugin.QoSPlugin\u0027,"},{"line_number":342,"context_line":"                           \u0027revision_plugin_name\u0027: \u0027revisions\u0027}"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        extraroute_db.register_db_extraroute_opts()"},{"line_number":345,"context_line":"        # for these tests we need to enable overlapping ips"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_dbbc476b","line":342,"range":{"start_line":342,"start_character":27,"end_line":342,"end_character":62},"in_reply_to":"df7087c5_b5d084cb","updated":"2018-03-08 05:58:38.000000000","message":"Done","commit_id":"0d35bd815041fa3de71aaebc7c1b96447cf17f31"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"eaf671e55e6a521ad6cf409e2aa91cc5a2a0f19a","unresolved":false,"context_lines":[{"line_number":387,"context_line":"            service_plugins\u003dservice_plugins)"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        self.setup_notification_driver()"},{"line_number":390,"context_line":"        revision_plugin.RevisionPlugin()"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"class FloatingIPQoSDBWithRevisionIntTestCase(FloatingIPQoSDBIntTestCase):"}],"source_content_type":"text/x-python","patch_set":4,"id":"df7087c5_fe7a5486","line":390,"range":{"start_line":390,"start_character":8,"end_line":390,"end_character":40},"updated":"2018-03-08 10:39:51.000000000","message":"Remove this line?","commit_id":"53689af8f9b440070381ab2e97212fa8ad3c3a4f"},{"author":{"_account_id":24438,"name":"Guoshuai Li","email":"liguoshuai1989@gmail.com","username":"Guoshuai"},"change_message_id":"2b959a0c338d4211bc20b390f47297c52a03fdf1","unresolved":false,"context_lines":[{"line_number":387,"context_line":"            service_plugins\u003dservice_plugins)"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        self.setup_notification_driver()"},{"line_number":390,"context_line":"        revision_plugin.RevisionPlugin()"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"class FloatingIPQoSDBWithRevisionIntTestCase(FloatingIPQoSDBIntTestCase):"}],"source_content_type":"text/x-python","patch_set":4,"id":"df7087c5_41ffe1a9","line":390,"range":{"start_line":390,"start_character":8,"end_line":390,"end_character":40},"in_reply_to":"df7087c5_fe7a5486","updated":"2018-03-08 11:29:35.000000000","message":"Done\nI am so sorry I missed it.","commit_id":"53689af8f9b440070381ab2e97212fa8ad3c3a4f"}]}
