)]}'
{"neutron/tests/unit/agent/dhcp/test_agent.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6488698a6b9bc245304bd010c40aa3eb9bb49ba6","unresolved":false,"context_lines":[{"line_number":1013,"context_line":"        payload \u003d dict(port\u003dfake_port2)"},{"line_number":1014,"context_line":"        self.cache.get_network_by_id.return_value \u003d fake_network"},{"line_number":1015,"context_line":"        self.cache.get_port_by_id.return_value \u003d fake_port2"},{"line_number":1016,"context_line":"        with mock.patch.object(self.dhcp, \u0027update_isolated_metadata_proxy\u0027)\\"},{"line_number":1017,"context_line":"                as ump:"},{"line_number":1018,"context_line":"            self.dhcp.port_update_end(None, payload)"},{"line_number":1019,"context_line":"            self.cache.assert_has_calls("},{"line_number":1020,"context_line":"                [mock.call.get_network_by_id(fake_port2.network_id),"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff6b8bd7_0f9284f7","line":1017,"range":{"start_line":1016,"start_character":0,"end_line":1017,"end_character":23},"updated":"2018-03-06 10:17:53.000000000","message":"Suggestion: how about\n\n with mock.patch.object(\n         self.dhcp, \u0027...\u0027) as ump:\n     self.blabla ...","commit_id":"91f185a70f7757f1ede31b2d34803e1652fbf5db"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"252e8fe7f4dcc733e47fd24db27e0e522d206538","unresolved":false,"context_lines":[{"line_number":1013,"context_line":"        payload \u003d dict(port\u003dfake_port2)"},{"line_number":1014,"context_line":"        self.cache.get_network_by_id.return_value \u003d fake_network"},{"line_number":1015,"context_line":"        self.cache.get_port_by_id.return_value \u003d fake_port2"},{"line_number":1016,"context_line":"        with mock.patch.object(self.dhcp, \u0027update_isolated_metadata_proxy\u0027)\\"},{"line_number":1017,"context_line":"                as ump:"},{"line_number":1018,"context_line":"            self.dhcp.port_update_end(None, payload)"},{"line_number":1019,"context_line":"            self.cache.assert_has_calls("},{"line_number":1020,"context_line":"                [mock.call.get_network_by_id(fake_port2.network_id),"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff6b8bd7_f2edb725","line":1017,"range":{"start_line":1016,"start_character":0,"end_line":1017,"end_character":23},"in_reply_to":"ff6b8bd7_0f9284f7","updated":"2018-03-06 10:33:38.000000000","message":"Done","commit_id":"91f185a70f7757f1ede31b2d34803e1652fbf5db"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6488698a6b9bc245304bd010c40aa3eb9bb49ba6","unresolved":false,"context_lines":[{"line_number":1018,"context_line":"            self.dhcp.port_update_end(None, payload)"},{"line_number":1019,"context_line":"            self.cache.assert_has_calls("},{"line_number":1020,"context_line":"                [mock.call.get_network_by_id(fake_port2.network_id),"},{"line_number":1021,"context_line":"                mock.call.put_port(mock.ANY)])"},{"line_number":1022,"context_line":"            self.call_driver.assert_called_once_with(\u0027reload_allocations\u0027,"},{"line_number":1023,"context_line":"                                                     fake_network)"},{"line_number":1024,"context_line":"            ump.assert_called_once_with(fake_network)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff6b8bd7_cfefac85","line":1021,"updated":"2018-03-06 10:17:53.000000000","message":"nit: indentation","commit_id":"91f185a70f7757f1ede31b2d34803e1652fbf5db"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"252e8fe7f4dcc733e47fd24db27e0e522d206538","unresolved":false,"context_lines":[{"line_number":1018,"context_line":"            self.dhcp.port_update_end(None, payload)"},{"line_number":1019,"context_line":"            self.cache.assert_has_calls("},{"line_number":1020,"context_line":"                [mock.call.get_network_by_id(fake_port2.network_id),"},{"line_number":1021,"context_line":"                mock.call.put_port(mock.ANY)])"},{"line_number":1022,"context_line":"            self.call_driver.assert_called_once_with(\u0027reload_allocations\u0027,"},{"line_number":1023,"context_line":"                                                     fake_network)"},{"line_number":1024,"context_line":"            ump.assert_called_once_with(fake_network)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff6b8bd7_92f23b06","line":1021,"in_reply_to":"ff6b8bd7_cfefac85","updated":"2018-03-06 10:33:38.000000000","message":"ops! done","commit_id":"91f185a70f7757f1ede31b2d34803e1652fbf5db"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6488698a6b9bc245304bd010c40aa3eb9bb49ba6","unresolved":false,"context_lines":[{"line_number":1021,"context_line":"                mock.call.put_port(mock.ANY)])"},{"line_number":1022,"context_line":"            self.call_driver.assert_called_once_with(\u0027reload_allocations\u0027,"},{"line_number":1023,"context_line":"                                                     fake_network)"},{"line_number":1024,"context_line":"            ump.assert_called_once_with(fake_network)"},{"line_number":1025,"context_line":""},{"line_number":1026,"context_line":"    def test_port_update_end_grabs_lock(self):"},{"line_number":1027,"context_line":"        payload \u003d dict(port\u003dfake_port2)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff6b8bd7_2ffae841","line":1024,"updated":"2018-03-06 10:17:53.000000000","message":"do we need to validate which params were passed? perhaps checking that ump was called is sufficient and will cause less headache when changing/adding new parameters to it","commit_id":"91f185a70f7757f1ede31b2d34803e1652fbf5db"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"252e8fe7f4dcc733e47fd24db27e0e522d206538","unresolved":false,"context_lines":[{"line_number":1021,"context_line":"                mock.call.put_port(mock.ANY)])"},{"line_number":1022,"context_line":"            self.call_driver.assert_called_once_with(\u0027reload_allocations\u0027,"},{"line_number":1023,"context_line":"                                                     fake_network)"},{"line_number":1024,"context_line":"            ump.assert_called_once_with(fake_network)"},{"line_number":1025,"context_line":""},{"line_number":1026,"context_line":"    def test_port_update_end_grabs_lock(self):"},{"line_number":1027,"context_line":"        payload \u003d dict(port\u003dfake_port2)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff6b8bd7_72d9a781","line":1024,"in_reply_to":"ff6b8bd7_2ffae841","updated":"2018-03-06 10:33:38.000000000","message":"Agree, i\u0027ll change it in the next PS","commit_id":"91f185a70f7757f1ede31b2d34803e1652fbf5db"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"63fba5ba36a8215048231823332381af6092933a","unresolved":false,"context_lines":[{"line_number":1100,"context_line":""},{"line_number":1101,"context_line":"        with mock.patch.object(self.dhcp, \u0027update_isolated_metadata_proxy\u0027)\\"},{"line_number":1102,"context_line":"                as ump:"},{"line_number":1103,"context_line":"           self.dhcp.port_delete_end(None, payload)"},{"line_number":1104,"context_line":"           self.cache.assert_has_calls("},{"line_number":1105,"context_line":"               [mock.call.get_port_by_id(fake_port2.id),"},{"line_number":1106,"context_line":"                mock.call.deleted_ports.add(fake_port2.id),"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff6b8bd7_cf624c17","line":1103,"range":{"start_line":1103,"start_character":8,"end_line":1103,"end_character":11},"updated":"2018-03-06 10:22:06.000000000","message":"indentations are wrong and it raise syntax error and failing UT and pep8 tests","commit_id":"91f185a70f7757f1ede31b2d34803e1652fbf5db"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"359909c4e142fcc655a57baa32b138b542cdac09","unresolved":false,"context_lines":[{"line_number":1100,"context_line":""},{"line_number":1101,"context_line":"        with mock.patch.object(self.dhcp, \u0027update_isolated_metadata_proxy\u0027)\\"},{"line_number":1102,"context_line":"                as ump:"},{"line_number":1103,"context_line":"           self.dhcp.port_delete_end(None, payload)"},{"line_number":1104,"context_line":"           self.cache.assert_has_calls("},{"line_number":1105,"context_line":"               [mock.call.get_port_by_id(fake_port2.id),"},{"line_number":1106,"context_line":"                mock.call.deleted_ports.add(fake_port2.id),"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff6b8bd7_f203770c","line":1103,"range":{"start_line":1103,"start_character":8,"end_line":1103,"end_character":11},"in_reply_to":"ff6b8bd7_cf624c17","updated":"2018-03-06 10:24:42.000000000","message":"are pep8 tests really failing? i thought we\u0027re omitting testing code for pep8 checks ...","commit_id":"91f185a70f7757f1ede31b2d34803e1652fbf5db"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"77c4fc8bc7ae3c1cce927f6bf532726ac57263cd","unresolved":false,"context_lines":[{"line_number":1100,"context_line":""},{"line_number":1101,"context_line":"        with mock.patch.object(self.dhcp, \u0027update_isolated_metadata_proxy\u0027)\\"},{"line_number":1102,"context_line":"                as ump:"},{"line_number":1103,"context_line":"           self.dhcp.port_delete_end(None, payload)"},{"line_number":1104,"context_line":"           self.cache.assert_has_calls("},{"line_number":1105,"context_line":"               [mock.call.get_port_by_id(fake_port2.id),"},{"line_number":1106,"context_line":"                mock.call.deleted_ports.add(fake_port2.id),"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff6b8bd7_b2265fb7","line":1103,"range":{"start_line":1103,"start_character":8,"end_line":1103,"end_character":11},"in_reply_to":"ff6b8bd7_f203770c","updated":"2018-03-06 10:26:19.000000000","message":"yes, both UT and pep8 failed because of that already (I checked on zuul status page and locally)","commit_id":"91f185a70f7757f1ede31b2d34803e1652fbf5db"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"91cde62a2efe999a5ef13aae2a30569ce5ca89b0","unresolved":false,"context_lines":[{"line_number":1109,"context_line":"                mock.call.remove_port(fake_port2)])"},{"line_number":1110,"context_line":"           self.call_driver.assert_has_calls("},{"line_number":1111,"context_line":"               [mock.call.call_driver(\u0027reload_allocations\u0027, fake_network)])"},{"line_number":1112,"context_line":"            ump.assert_called_once_with(fake_network)"},{"line_number":1113,"context_line":""},{"line_number":1114,"context_line":"    def test_port_delete_end_unknown_port(self):"},{"line_number":1115,"context_line":"        payload \u003d dict(port_id\u003d\u0027unknown\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff6b8bd7_afbcb869","line":1112,"updated":"2018-03-06 10:18:46.000000000","message":"nit: indentation","commit_id":"91f185a70f7757f1ede31b2d34803e1652fbf5db"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"2a24cf74059d8924913689795b791e675bad5e81","unresolved":false,"context_lines":[{"line_number":1109,"context_line":"                mock.call.remove_port(fake_port2)])"},{"line_number":1110,"context_line":"           self.call_driver.assert_has_calls("},{"line_number":1111,"context_line":"               [mock.call.call_driver(\u0027reload_allocations\u0027, fake_network)])"},{"line_number":1112,"context_line":"            ump.assert_called_once_with(fake_network)"},{"line_number":1113,"context_line":""},{"line_number":1114,"context_line":"    def test_port_delete_end_unknown_port(self):"},{"line_number":1115,"context_line":"        payload \u003d dict(port_id\u003d\u0027unknown\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff6b8bd7_12914b9a","line":1112,"range":{"start_line":1112,"start_character":11,"end_line":1112,"end_character":12},"updated":"2018-03-06 10:32:11.000000000","message":"still something here or in lines above is not good with indentations :)","commit_id":"9bd237a55ed46546e102d1eb048a5719eb4d93e9"}]}
