)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"8a7a2c7aa2ad97581c0d4305117e00934055bbd3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sławek Kapłoński \u003cslawek@kaplonski.pl\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-03-20 21:42:26 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t raise error when removing not existing IP address"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When privileged delete_ip_address function is called to delete"},{"line_number":10,"context_line":"IP address which is already not configured on device, it should"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df7087c5_e9758fcd","line":7,"range":{"start_line":7,"start_character":32,"end_line":7,"end_character":35},"updated":"2018-03-21 06:32:02.000000000","message":"nit: non","commit_id":"bbe1bac3f78eb15190289b6bc8d6b3a9ae77b412"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"8a7a2c7aa2ad97581c0d4305117e00934055bbd3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Don\u0027t raise error when removing not existing IP address"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When privileged delete_ip_address function is called to delete"},{"line_number":10,"context_line":"IP address which is already not configured on device, it should"},{"line_number":11,"context_line":"not fail with any error."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I9247ac899a76e5d9a2962d2cb81279f2d6f16c0b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df7087c5_0971e3de","line":10,"range":{"start_line":10,"start_character":20,"end_line":10,"end_character":27},"updated":"2018-03-21 06:32:02.000000000","message":"not required","commit_id":"bbe1bac3f78eb15190289b6bc8d6b3a9ae77b412"}],"neutron/privileged/agent/linux/ip_lib.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d80aec6d0f598ac540de6d27c1e52e28bcace457","unresolved":false,"context_lines":[{"line_number":139,"context_line":"def add_ip_address(ip_version, ip, prefixlen, device, namespace, scope,"},{"line_number":140,"context_line":"                   broadcast\u003dNone):"},{"line_number":141,"context_line":"    family \u003d _IP_VERSION_FAMILY_MAP[ip_version]"},{"line_number":142,"context_line":"    _run_iproute_addr(\u0027add\u0027,"},{"line_number":143,"context_line":"                      device,"},{"line_number":144,"context_line":"                      namespace,"},{"line_number":145,"context_line":"                      address\u003dip,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_596c9635","line":142,"updated":"2018-03-20 21:07:32.000000000","message":"I wonder if other commands could also trigger similar errors, f.e. here in case address is already present.","commit_id":"bbe1bac3f78eb15190289b6bc8d6b3a9ae77b412"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b5bdb3d72ce63b7104bc89ed146dbbfe6f51d327","unresolved":false,"context_lines":[{"line_number":139,"context_line":"def add_ip_address(ip_version, ip, prefixlen, device, namespace, scope,"},{"line_number":140,"context_line":"                   broadcast\u003dNone):"},{"line_number":141,"context_line":"    family \u003d _IP_VERSION_FAMILY_MAP[ip_version]"},{"line_number":142,"context_line":"    _run_iproute_addr(\u0027add\u0027,"},{"line_number":143,"context_line":"                      device,"},{"line_number":144,"context_line":"                      namespace,"},{"line_number":145,"context_line":"                      address\u003dip,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_ec8fcf2b","line":142,"in_reply_to":"df7087c5_54ae9de7","updated":"2018-03-21 15:27:20.000000000","message":"I think we should do the same what implementation with \"ip\" cli did. The behavior should be in parity","commit_id":"bbe1bac3f78eb15190289b6bc8d6b3a9ae77b412"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5589bcb8ec63454f4ed1d7b5fae5ba68c52e6d24","unresolved":false,"context_lines":[{"line_number":139,"context_line":"def add_ip_address(ip_version, ip, prefixlen, device, namespace, scope,"},{"line_number":140,"context_line":"                   broadcast\u003dNone):"},{"line_number":141,"context_line":"    family \u003d _IP_VERSION_FAMILY_MAP[ip_version]"},{"line_number":142,"context_line":"    _run_iproute_addr(\u0027add\u0027,"},{"line_number":143,"context_line":"                      device,"},{"line_number":144,"context_line":"                      namespace,"},{"line_number":145,"context_line":"                      address\u003dip,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_54ae9de7","line":142,"in_reply_to":"df7087c5_596c9635","updated":"2018-03-20 21:25:45.000000000","message":"I just checked that it will raise \"File Exists\" error in such case. Do You think that I should add similar catch for such error here?","commit_id":"bbe1bac3f78eb15190289b6bc8d6b3a9ae77b412"}]}