)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5634cbe12353ef747f2b1f4a66da5182aaa7bc8f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add error handling for get_network_info_for_id rpc call in the"},{"line_number":10,"context_line":"ovs_dvr_neutron_agent."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I44a5911554c712c89cdc8901cbc7b844c4b0a363"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf659307_6db941ca","line":11,"updated":"2018-03-29 23:20:08.000000000","message":"Brian asked about a bug# in a previous review. It was never added","commit_id":"9eef6162ab59c68c7906389781fab982598eefa7"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"96534ef5739ab90e8d6c517bc2012b8c51f1c3dd","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add error handling for get_network_info_for_id rpc call in the"},{"line_number":10,"context_line":"ovs_dvr_neutron_agent."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I44a5911554c712c89cdc8901cbc7b844c4b0a363"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf659307_1c8d47d2","line":11,"in_reply_to":"bf659307_6db941ca","updated":"2018-03-30 17:48:05.000000000","message":"Yes it was added, but in the rebase I would missed it, since it was added locally through the gerrit.","commit_id":"9eef6162ab59c68c7906389781fab982598eefa7"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_dvr_neutron_agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"57c7c6a8ce55cb5db8aa420d1b2aa905c2b39e63","unresolved":false,"context_lines":[{"line_number":433,"context_line":"            port_net_info \u003d ("},{"line_number":434,"context_line":"                self.plugin_rpc.get_network_info_for_id("},{"line_number":435,"context_line":"                    self.context, subnet_info.get(\u0027network_id\u0027)))"},{"line_number":436,"context_line":"            if len(port_net_info):"},{"line_number":437,"context_line":"                net_shared_only \u003d ("},{"line_number":438,"context_line":"                    port_net_info[0][\u0027shared\u0027] and"},{"line_number":439,"context_line":"                    not port_net_info[0][\u0027router:external\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_9022e8ff","line":436,"range":{"start_line":436,"start_character":15,"end_line":436,"end_character":33},"updated":"2018-03-28 00:43:29.000000000","message":"Why len()?  \u0027if []:\u0027 is false.\n\nAlso, I think this whole block should be after the except, since you\u0027re initializing things at L430 is should be safe.  Just to keep what\u0027s under the try/except to a minimum.","commit_id":"fab35fd20b0820ca0537e370a89177aed41b42c3"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"d4fada4fb1e15124b4ba1b6fb868555768abe02a","unresolved":false,"context_lines":[{"line_number":433,"context_line":"            port_net_info \u003d ("},{"line_number":434,"context_line":"                self.plugin_rpc.get_network_info_for_id("},{"line_number":435,"context_line":"                    self.context, subnet_info.get(\u0027network_id\u0027)))"},{"line_number":436,"context_line":"            if len(port_net_info):"},{"line_number":437,"context_line":"                net_shared_only \u003d ("},{"line_number":438,"context_line":"                    port_net_info[0][\u0027shared\u0027] and"},{"line_number":439,"context_line":"                    not port_net_info[0][\u0027router:external\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_a49f9901","line":436,"range":{"start_line":436,"start_character":15,"end_line":436,"end_character":33},"in_reply_to":"bf659307_9022e8ff","updated":"2018-03-28 17:05:04.000000000","message":"Will fix it.","commit_id":"fab35fd20b0820ca0537e370a89177aed41b42c3"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"57c7c6a8ce55cb5db8aa420d1b2aa905c2b39e63","unresolved":false,"context_lines":[{"line_number":440,"context_line":"        except oslo_messaging.RemoteError as e:"},{"line_number":441,"context_line":"            LOG.error(\u0027L2 agent cloud not get network_info_for_id \u0027"},{"line_number":442,"context_line":"                      \u0027due to RPC error. It happens when the server \u0027"},{"line_number":443,"context_line":"                      \u0027does not support this RPC API. Detailed message \u0027"},{"line_number":444,"context_line":"                      \u0027%s\u0027, e)"},{"line_number":445,"context_line":"        if net_shared_only:"},{"line_number":446,"context_line":"            LOG.debug(\"Not applying DVR rules to tunnel bridge because %s \""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_b0d60cf1","line":443,"range":{"start_line":443,"start_character":63,"end_line":443,"end_character":70},"updated":"2018-03-28 00:43:29.000000000","message":"s/message:","commit_id":"fab35fd20b0820ca0537e370a89177aed41b42c3"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"d4fada4fb1e15124b4ba1b6fb868555768abe02a","unresolved":false,"context_lines":[{"line_number":440,"context_line":"        except oslo_messaging.RemoteError as e:"},{"line_number":441,"context_line":"            LOG.error(\u0027L2 agent cloud not get network_info_for_id \u0027"},{"line_number":442,"context_line":"                      \u0027due to RPC error. It happens when the server \u0027"},{"line_number":443,"context_line":"                      \u0027does not support this RPC API. Detailed message \u0027"},{"line_number":444,"context_line":"                      \u0027%s\u0027, e)"},{"line_number":445,"context_line":"        if net_shared_only:"},{"line_number":446,"context_line":"            LOG.debug(\"Not applying DVR rules to tunnel bridge because %s \""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_648981c8","line":443,"range":{"start_line":443,"start_character":63,"end_line":443,"end_character":70},"in_reply_to":"bf659307_b0d60cf1","updated":"2018-03-28 17:05:04.000000000","message":"Will fix it.","commit_id":"fab35fd20b0820ca0537e370a89177aed41b42c3"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"343bc28623d25b79c07001f7ad107f35c396efec","unresolved":false,"context_lines":[{"line_number":427,"context_line":"            br \u003d self.tun_br"},{"line_number":428,"context_line":"        # TODO(vivek) remove the IPv6 related flows once SNAT is not"},{"line_number":429,"context_line":"        # used for IPv6 DVR."},{"line_number":430,"context_line":"        port_net_info \u003d []"},{"line_number":431,"context_line":"        net_shared_only \u003d False"},{"line_number":432,"context_line":"        try:"},{"line_number":433,"context_line":"            port_net_info \u003d ("}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_1a925c9f","line":430,"updated":"2018-03-28 17:42:37.000000000","message":"nit: since you\u0027re only using this as a flag to get to L442 it could just be initialized to None, since it\u0027s not being set as  a default return value.","commit_id":"ed5f50c02a1f4b72dfa6969e8b897c4729e424be"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"343bc28623d25b79c07001f7ad107f35c396efec","unresolved":false,"context_lines":[{"line_number":439,"context_line":"                      \u0027does not support this RPC API. Detailed message: \u0027"},{"line_number":440,"context_line":"                      \u0027%s\u0027, e)"},{"line_number":441,"context_line":"        if port_net_info:"},{"line_number":442,"context_line":"                net_shared_only \u003d ("},{"line_number":443,"context_line":"                    port_net_info[0][\u0027shared\u0027] and"},{"line_number":444,"context_line":"                    not port_net_info[0][\u0027router:external\u0027])"},{"line_number":445,"context_line":"        if net_shared_only:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_3f7cf2b3","line":442,"updated":"2018-03-28 17:42:37.000000000","message":"indented too much","commit_id":"ed5f50c02a1f4b72dfa6969e8b897c4729e424be"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5634cbe12353ef747f2b1f4a66da5182aaa7bc8f","unresolved":false,"context_lines":[{"line_number":434,"context_line":"                self.plugin_rpc.get_network_info_for_id("},{"line_number":435,"context_line":"                    self.context, subnet_info.get(\u0027network_id\u0027)))"},{"line_number":436,"context_line":"        except oslo_messaging.RemoteError as e:"},{"line_number":437,"context_line":"            LOG.error(\u0027L2 agent cloud not get network_info_for_id \u0027"},{"line_number":438,"context_line":"                      \u0027due to RPC error. It happens when the server \u0027"},{"line_number":439,"context_line":"                      \u0027does not support this RPC API. Detailed message: \u0027"},{"line_number":440,"context_line":"                      \u0027%s\u0027, e)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_4d86bd15","line":437,"range":{"start_line":437,"start_character":32,"end_line":437,"end_character":37},"updated":"2018-03-29 23:20:08.000000000","message":"could","commit_id":"9eef6162ab59c68c7906389781fab982598eefa7"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"96534ef5739ab90e8d6c517bc2012b8c51f1c3dd","unresolved":false,"context_lines":[{"line_number":434,"context_line":"                self.plugin_rpc.get_network_info_for_id("},{"line_number":435,"context_line":"                    self.context, subnet_info.get(\u0027network_id\u0027)))"},{"line_number":436,"context_line":"        except oslo_messaging.RemoteError as e:"},{"line_number":437,"context_line":"            LOG.error(\u0027L2 agent cloud not get network_info_for_id \u0027"},{"line_number":438,"context_line":"                      \u0027due to RPC error. It happens when the server \u0027"},{"line_number":439,"context_line":"                      \u0027does not support this RPC API. Detailed message: \u0027"},{"line_number":440,"context_line":"                      \u0027%s\u0027, e)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_1ca6a754","line":437,"range":{"start_line":437,"start_character":32,"end_line":437,"end_character":37},"in_reply_to":"bf659307_4d86bd15","updated":"2018-03-30 17:48:05.000000000","message":"will fix it.","commit_id":"9eef6162ab59c68c7906389781fab982598eefa7"}],"neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/test_ovs_neutron_agent.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5634cbe12353ef747f2b1f4a66da5182aaa7bc8f","unresolved":false,"context_lines":[{"line_number":2652,"context_line":"            self.assertEqual([], tun_br.mock_calls)"},{"line_number":2653,"context_line":"            self.assertEqual([], phys_br.mock_calls)"},{"line_number":2654,"context_line":""},{"line_number":2655,"context_line":"    def _test_port_bound_for_dvr_on_vlan_network_rpc_error("},{"line_number":2656,"context_line":"        self, device_owner, ip_version\u003d4):"},{"line_number":2657,"context_line":"        self._setup_for_dvr_test()"},{"line_number":2658,"context_line":"        if ip_version \u003d\u003d 4:"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_2d8109fc","line":2655,"updated":"2018-03-29 23:20:08.000000000","message":"I ran a diff between this method and the one in L2750. The diff is not much. Isn\u0027t there a way to to refactor the commonality?","commit_id":"9eef6162ab59c68c7906389781fab982598eefa7"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"96534ef5739ab90e8d6c517bc2012b8c51f1c3dd","unresolved":false,"context_lines":[{"line_number":2652,"context_line":"            self.assertEqual([], tun_br.mock_calls)"},{"line_number":2653,"context_line":"            self.assertEqual([], phys_br.mock_calls)"},{"line_number":2654,"context_line":""},{"line_number":2655,"context_line":"    def _test_port_bound_for_dvr_on_vlan_network_rpc_error("},{"line_number":2656,"context_line":"        self, device_owner, ip_version\u003d4):"},{"line_number":2657,"context_line":"        self._setup_for_dvr_test()"},{"line_number":2658,"context_line":"        if ip_version \u003d\u003d 4:"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_5c75ffc9","line":2655,"in_reply_to":"bf659307_2d8109fc","updated":"2018-03-30 17:48:05.000000000","message":"I tried to refactor it by just modifing the given test function with a \u0027side_effect\u0027 that would either provide a value or a exception, but it did not help.\nSo I have to live with this.","commit_id":"9eef6162ab59c68c7906389781fab982598eefa7"}]}
