)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"9beaaa6d1346273c7ffeb5d519ed3658bf14421b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"qg-interface in the snat_namespace, that FloatingIP is not"},{"line_number":12,"context_line":"re-configured to the qg-interface when agent starts."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The reason being, the cidr is not been retreived from the keepalived"},{"line_number":15,"context_line":"instance and only retrieved from the centralized_fip_cidr_set."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"If \u0027L3_HA\u0027 is configured we need to retreive it from the keepalived"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf659307_4dc2165b","line":14,"range":{"start_line":14,"start_character":34,"end_line":14,"end_character":38},"updated":"2018-04-02 15:45:49.000000000","message":"Nit: being","commit_id":"445a8b9647001d85910485a5bd599876a20a0af8"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"9beaaa6d1346273c7ffeb5d519ed3658bf14421b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"qg-interface in the snat_namespace, that FloatingIP is not"},{"line_number":12,"context_line":"re-configured to the qg-interface when agent starts."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The reason being, the cidr is not been retreived from the keepalived"},{"line_number":15,"context_line":"instance and only retrieved from the centralized_fip_cidr_set."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"If \u0027L3_HA\u0027 is configured we need to retreive it from the keepalived"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf659307_0db89ee2","line":14,"range":{"start_line":14,"start_character":39,"end_line":14,"end_character":48},"updated":"2018-04-02 15:45:49.000000000","message":"Nit: retrieved","commit_id":"445a8b9647001d85910485a5bd599876a20a0af8"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"182901e3e998a1797edfbfaf79ed468348095d73","unresolved":false,"context_lines":[{"line_number":11,"context_line":"qg-interface in the snat_namespace, that FloatingIP is not"},{"line_number":12,"context_line":"re-configured to the qg-interface when agent starts."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The reason being, the cidr is not been retreived from the keepalived"},{"line_number":15,"context_line":"instance and only retrieved from the centralized_fip_cidr_set."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"If \u0027L3_HA\u0027 is configured we need to retreive it from the keepalived"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf659307_c54a2b82","line":14,"range":{"start_line":14,"start_character":34,"end_line":14,"end_character":38},"in_reply_to":"bf659307_4dc2165b","updated":"2018-04-05 17:28:56.000000000","message":"Will fix it.","commit_id":"445a8b9647001d85910485a5bd599876a20a0af8"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"9beaaa6d1346273c7ffeb5d519ed3658bf14421b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"The reason being, the cidr is not been retreived from the keepalived"},{"line_number":15,"context_line":"instance and only retrieved from the centralized_fip_cidr_set."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"If \u0027L3_HA\u0027 is configured we need to retreive it from the keepalived"},{"line_number":18,"context_line":"instance."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This patch fixes the problem by retreiving the cidrs from the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf659307_cdcdc685","line":17,"range":{"start_line":17,"start_character":36,"end_line":17,"end_character":44},"updated":"2018-04-02 15:45:49.000000000","message":"Nit: retrieve","commit_id":"445a8b9647001d85910485a5bd599876a20a0af8"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"182901e3e998a1797edfbfaf79ed468348095d73","unresolved":false,"context_lines":[{"line_number":14,"context_line":"The reason being, the cidr is not been retreived from the keepalived"},{"line_number":15,"context_line":"instance and only retrieved from the centralized_fip_cidr_set."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"If \u0027L3_HA\u0027 is configured we need to retreive it from the keepalived"},{"line_number":18,"context_line":"instance."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This patch fixes the problem by retreiving the cidrs from the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf659307_e54f2f90","line":17,"range":{"start_line":17,"start_character":36,"end_line":17,"end_character":44},"in_reply_to":"bf659307_cdcdc685","updated":"2018-04-05 17:28:56.000000000","message":"will fix it.","commit_id":"445a8b9647001d85910485a5bd599876a20a0af8"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"9beaaa6d1346273c7ffeb5d519ed3658bf14421b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"If \u0027L3_HA\u0027 is configured we need to retreive it from the keepalived"},{"line_number":18,"context_line":"instance."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This patch fixes the problem by retreiving the cidrs from the"},{"line_number":21,"context_line":"keepalived instance for the qg-interface."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I848a20d06e2d344503a4cb1776dbe2617d91bc41"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf659307_4da776be","line":20,"range":{"start_line":20,"start_character":32,"end_line":20,"end_character":43},"updated":"2018-04-02 15:45:49.000000000","message":"Nit: retrieving","commit_id":"445a8b9647001d85910485a5bd599876a20a0af8"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"182901e3e998a1797edfbfaf79ed468348095d73","unresolved":false,"context_lines":[{"line_number":17,"context_line":"If \u0027L3_HA\u0027 is configured we need to retreive it from the keepalived"},{"line_number":18,"context_line":"instance."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This patch fixes the problem by retreiving the cidrs from the"},{"line_number":21,"context_line":"keepalived instance for the qg-interface."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I848a20d06e2d344503a4cb1776dbe2617d91bc41"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf659307_85443376","line":20,"range":{"start_line":20,"start_character":32,"end_line":20,"end_character":43},"in_reply_to":"bf659307_4da776be","updated":"2018-04-05 17:28:56.000000000","message":"will fix it.","commit_id":"445a8b9647001d85910485a5bd599876a20a0af8"}],"neutron/agent/l3/dvr_edge_ha_router.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"be7b872377b4de19e4b5082b97f9407ab06c0a0a","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    def _get_centralized_fip_cidr_set(self):"},{"line_number":77,"context_line":"        interface_name \u003d self.get_snat_external_device_interface_name("},{"line_number":78,"context_line":"                self.get_ex_gw_port())"},{"line_number":79,"context_line":"        keepalived_cidr \u003d set(self._get_cidrs_from_keepalived(interface_name))"},{"line_number":80,"context_line":"        return keepalived_cidr"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def external_gateway_added(self, ex_gw_port, interface_name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_70f4f45b","line":79,"range":{"start_line":79,"start_character":8,"end_line":79,"end_character":25},"updated":"2018-03-28 00:50:35.000000000","message":"s/return set(...)\n\nNo need to put it in a local var first.","commit_id":"ad2f8e94343b5591c6dedd88092272d684fd4cfe"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"170fdf5827be43be44de24fdeaea5161a42fada2","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        interface_name \u003d self.get_snat_external_device_interface_name("},{"line_number":78,"context_line":"                self.get_ex_gw_port())"},{"line_number":79,"context_line":"        keepalived_cidr \u003d set(self._get_cidrs_from_keepalived(interface_name))"},{"line_number":80,"context_line":"        return keepalived_cidr"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def external_gateway_added(self, ex_gw_port, interface_name):"},{"line_number":83,"context_line":"        super(DvrEdgeHaRouter, self).external_gateway_added("}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_e5ee3d8a","line":80,"updated":"2018-04-06 13:32:22.000000000","message":"I\u0027m just going to fix this nit of saving to a var, then returning.","commit_id":"6cd5b2484b28a029da4a4b7d0b21dd7ee56811ca"}]}
