)]}'
{"neutron/agent/l3/dvr_local_router.py":[{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"511e2b13655dc1987f3715837a9af1b78f82f094","unresolved":false,"context_lines":[{"line_number":584,"context_line":"        if self.fip_ns.agent_gateway_port and not self.rtr_fip_connect:"},{"line_number":585,"context_line":"            self.fip_ns.create_rtr_2_fip_link(self)"},{"line_number":586,"context_line":"            self.set_address_scope_interface_routes("},{"line_number":587,"context_line":"                self.fip_ns.agent_gateway_port"},{"line_number":588,"context_line":"            )"},{"line_number":589,"context_line":"            self.rtr_fip_connect \u003d True"},{"line_number":590,"context_line":"            self.routes_updated([], self.router[\u0027routes\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_73b31bea","line":587,"range":{"start_line":587,"start_character":28,"end_line":587,"end_character":46},"updated":"2018-04-03 18:21:55.000000000","message":"Both the ex_gw_port and fip_ns.agent_gateway_port belong to the same network scope.\nSo when the router-update is sent, one would assume that the port info should have the scope information for the tenant network and the external network.\n\nCan you elaborate on the issue here why we are messing up the order.","commit_id":"a3a623d333ce9435c0d69fcf15eeef4efd250aae"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"ff6054741befb29fce869aa1d33542596a0121a1","unresolved":false,"context_lines":[{"line_number":584,"context_line":"        if self.fip_ns.agent_gateway_port and not self.rtr_fip_connect:"},{"line_number":585,"context_line":"            self.fip_ns.create_rtr_2_fip_link(self)"},{"line_number":586,"context_line":"            self.set_address_scope_interface_routes("},{"line_number":587,"context_line":"                self.fip_ns.agent_gateway_port"},{"line_number":588,"context_line":"            )"},{"line_number":589,"context_line":"            self.rtr_fip_connect \u003d True"},{"line_number":590,"context_line":"            self.routes_updated([], self.router[\u0027routes\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_8a48de5b","line":587,"range":{"start_line":587,"start_character":28,"end_line":587,"end_character":46},"in_reply_to":"bf659307_4292bf58","updated":"2018-04-04 14:20:49.000000000","message":"Added another comment https://bugs.launchpad.net/neutron/+bug/1759971/comments/5\n\nThere is a race condition.","commit_id":"a3a623d333ce9435c0d69fcf15eeef4efd250aae"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"12a8f02e819ad5f86d8e2f293cd19a87c868a753","unresolved":false,"context_lines":[{"line_number":584,"context_line":"        if self.fip_ns.agent_gateway_port and not self.rtr_fip_connect:"},{"line_number":585,"context_line":"            self.fip_ns.create_rtr_2_fip_link(self)"},{"line_number":586,"context_line":"            self.set_address_scope_interface_routes("},{"line_number":587,"context_line":"                self.fip_ns.agent_gateway_port"},{"line_number":588,"context_line":"            )"},{"line_number":589,"context_line":"            self.rtr_fip_connect \u003d True"},{"line_number":590,"context_line":"            self.routes_updated([], self.router[\u0027routes\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_4292bf58","line":587,"range":{"start_line":587,"start_character":28,"end_line":587,"end_character":46},"in_reply_to":"bf659307_73b31bea","updated":"2018-04-03 23:07:19.000000000","message":"Added a comment here:\n\nhttps://bugs.launchpad.net/neutron/+bug/1759971/comments/4\n\nI am not sure what could result in that yet. There are periodic router syncs which happen in the background though.","commit_id":"a3a623d333ce9435c0d69fcf15eeef4efd250aae"}],"neutron/api/rpc/handlers/l3_rpc.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"15e91f9b2e460a9f725ecff1a3076cf07b242603","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            self.plugin, constants.PORT_BINDING_EXT_ALIAS):"},{"line_number":122,"context_line":"            self._ensure_host_set_on_ports(context, host, routers)"},{"line_number":123,"context_line":"        # refresh the data structure after ports are bound"},{"line_number":124,"context_line":"        routers \u003d self._routers_to_sync(context, router_ids, host)"},{"line_number":125,"context_line":"        return routers"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def _routers_to_sync(self, context, router_ids, host\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_f417e3a2","line":124,"updated":"2018-04-05 14:55:30.000000000","message":"Do we only need to refresh under the \u0027if\u0027 ?  Else nothing has changed, right?","commit_id":"edaa22a0dac6cf5dd1a8ccbf91b40a7f315698b1"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"e08af486ee65bd6d0d1fccb29b0f59f2f4508fe4","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            self.plugin, constants.PORT_BINDING_EXT_ALIAS):"},{"line_number":122,"context_line":"            self._ensure_host_set_on_ports(context, host, routers)"},{"line_number":123,"context_line":"        # refresh the data structure after ports are bound"},{"line_number":124,"context_line":"        routers \u003d self._routers_to_sync(context, router_ids, host)"},{"line_number":125,"context_line":"        return routers"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def _routers_to_sync(self, context, router_ids, host\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_f466032a","line":124,"in_reply_to":"bf659307_f417e3a2","updated":"2018-04-05 15:05:01.000000000","message":"Yes, that makes sense. Thanks for catching this.","commit_id":"edaa22a0dac6cf5dd1a8ccbf91b40a7f315698b1"}]}