)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"1a2066c25dffabf655256df4d3ab8ec99fabd9fa","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix potential race condition in privileged ip_lib module"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Functions like _run_iproute_{link,addr,neigh} are not atomic and"},{"line_number":10,"context_line":"works in two steps."},{"line_number":11,"context_line":"First it tries to get device index and in second step call specified"},{"line_number":12,"context_line":"command for this device."},{"line_number":13,"context_line":"It might happen sometimes that device exists during first of those"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf659307_ff55e51e","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":5},"updated":"2018-04-12 12:08:02.000000000","message":"work","commit_id":"c98ec91daf12999bcf3c878a51a1e3fbf02e8596"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"918b214ae0fc4fc2eb5623feacf94eb3ae12f2ee","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix potential race condition in privileged ip_lib module"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Functions like _run_iproute_{link,addr,neigh} are not atomic and"},{"line_number":10,"context_line":"works in two steps."},{"line_number":11,"context_line":"First it tries to get device index and in second step call specified"},{"line_number":12,"context_line":"command for this device."},{"line_number":13,"context_line":"It might happen sometimes that device exists during first of those"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf659307_5ca642c3","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":5},"in_reply_to":"bf659307_ff55e51e","updated":"2018-04-13 07:40:00.000000000","message":"Done","commit_id":"c98ec91daf12999bcf3c878a51a1e3fbf02e8596"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"1a2066c25dffabf655256df4d3ab8ec99fabd9fa","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Functions like _run_iproute_{link,addr,neigh} are not atomic and"},{"line_number":10,"context_line":"works in two steps."},{"line_number":11,"context_line":"First it tries to get device index and in second step call specified"},{"line_number":12,"context_line":"command for this device."},{"line_number":13,"context_line":"It might happen sometimes that device exists during first of those"},{"line_number":14,"context_line":"steps but not exists during second step. Such case cause raising"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf659307_df36e103","line":11,"range":{"start_line":11,"start_character":54,"end_line":11,"end_character":58},"updated":"2018-04-12 12:08:02.000000000","message":"calls","commit_id":"c98ec91daf12999bcf3c878a51a1e3fbf02e8596"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"918b214ae0fc4fc2eb5623feacf94eb3ae12f2ee","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Functions like _run_iproute_{link,addr,neigh} are not atomic and"},{"line_number":10,"context_line":"works in two steps."},{"line_number":11,"context_line":"First it tries to get device index and in second step call specified"},{"line_number":12,"context_line":"command for this device."},{"line_number":13,"context_line":"It might happen sometimes that device exists during first of those"},{"line_number":14,"context_line":"steps but not exists during second step. Such case cause raising"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf659307_fca8768c","line":11,"range":{"start_line":11,"start_character":54,"end_line":11,"end_character":58},"in_reply_to":"bf659307_df36e103","updated":"2018-04-13 07:40:00.000000000","message":"Done","commit_id":"c98ec91daf12999bcf3c878a51a1e3fbf02e8596"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"1a2066c25dffabf655256df4d3ab8ec99fabd9fa","unresolved":false,"context_lines":[{"line_number":11,"context_line":"First it tries to get device index and in second step call specified"},{"line_number":12,"context_line":"command for this device."},{"line_number":13,"context_line":"It might happen sometimes that device exists during first of those"},{"line_number":14,"context_line":"steps but not exists during second step. Such case cause raising"},{"line_number":15,"context_line":"pyroute2.NetlinkError exception which isn\u0027t properly handled in"},{"line_number":16,"context_line":"Neutron code which uses ip_lib module."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf659307_ff2ac58e","line":14,"range":{"start_line":14,"start_character":51,"end_line":14,"end_character":56},"updated":"2018-04-12 12:08:02.000000000","message":"causes","commit_id":"c98ec91daf12999bcf3c878a51a1e3fbf02e8596"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"918b214ae0fc4fc2eb5623feacf94eb3ae12f2ee","unresolved":false,"context_lines":[{"line_number":11,"context_line":"First it tries to get device index and in second step call specified"},{"line_number":12,"context_line":"command for this device."},{"line_number":13,"context_line":"It might happen sometimes that device exists during first of those"},{"line_number":14,"context_line":"steps but not exists during second step. Such case cause raising"},{"line_number":15,"context_line":"pyroute2.NetlinkError exception which isn\u0027t properly handled in"},{"line_number":16,"context_line":"Neutron code which uses ip_lib module."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf659307_1cac4a9d","line":14,"range":{"start_line":14,"start_character":51,"end_line":14,"end_character":56},"in_reply_to":"bf659307_ff2ac58e","updated":"2018-04-13 07:40:00.000000000","message":"Done","commit_id":"c98ec91daf12999bcf3c878a51a1e3fbf02e8596"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"1a2066c25dffabf655256df4d3ab8ec99fabd9fa","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch fixes it by catching pyroute2.NetlinkError exception"},{"line_number":19,"context_line":"and raising NetworkInterfaceNotFound."},{"line_number":20,"context_line":"This is child of RuntimeError and all callers of ip_lib can handle"},{"line_number":21,"context_line":"it properly is needed."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I568ef183466f5ff2f2c30ed74a7dc52db41ba577"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf659307_bf1a0d7a","line":20,"range":{"start_line":20,"start_character":8,"end_line":20,"end_character":13},"updated":"2018-04-12 12:08:02.000000000","message":"probably subclass is a better term :)","commit_id":"c98ec91daf12999bcf3c878a51a1e3fbf02e8596"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"918b214ae0fc4fc2eb5623feacf94eb3ae12f2ee","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch fixes it by catching pyroute2.NetlinkError exception"},{"line_number":19,"context_line":"and raising NetworkInterfaceNotFound."},{"line_number":20,"context_line":"This is child of RuntimeError and all callers of ip_lib can handle"},{"line_number":21,"context_line":"it properly is needed."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I568ef183466f5ff2f2c30ed74a7dc52db41ba577"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf659307_9c97fa45","line":20,"range":{"start_line":20,"start_character":8,"end_line":20,"end_character":13},"in_reply_to":"bf659307_bf1a0d7a","updated":"2018-04-13 07:40:00.000000000","message":"right. I missed this word when I was writing this comment :) Thx","commit_id":"c98ec91daf12999bcf3c878a51a1e3fbf02e8596"}],"neutron/privileged/agent/linux/ip_lib.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"1a2066c25dffabf655256df4d3ab8ec99fabd9fa","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            return ip.link(command, index\u003didx, **kwargs)"},{"line_number":124,"context_line":"    except NetlinkError as e:"},{"line_number":125,"context_line":"        if e.code \u003d\u003d errno.ENODEV:"},{"line_number":126,"context_line":"            msg \u003d _(\"Network interface %(device)s not found in namespace \""},{"line_number":127,"context_line":"                    \"%(namespace)s.\") % {\u0027device\u0027: device,"},{"line_number":128,"context_line":"                                         \u0027namespace\u0027: namespace}"},{"line_number":129,"context_line":"            raise NetworkInterfaceNotFound(msg)"},{"line_number":130,"context_line":"        raise"},{"line_number":131,"context_line":"    except OSError as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_aaff2dff","line":128,"range":{"start_line":126,"start_character":19,"end_line":128,"end_character":64},"updated":"2018-04-12 12:08:02.000000000","message":"nit: consider adding this as implicit message of the exception as the same string is used in all places.","commit_id":"c98ec91daf12999bcf3c878a51a1e3fbf02e8596"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"918b214ae0fc4fc2eb5623feacf94eb3ae12f2ee","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            return ip.link(command, index\u003didx, **kwargs)"},{"line_number":124,"context_line":"    except NetlinkError as e:"},{"line_number":125,"context_line":"        if e.code \u003d\u003d errno.ENODEV:"},{"line_number":126,"context_line":"            msg \u003d _(\"Network interface %(device)s not found in namespace \""},{"line_number":127,"context_line":"                    \"%(namespace)s.\") % {\u0027device\u0027: device,"},{"line_number":128,"context_line":"                                         \u0027namespace\u0027: namespace}"},{"line_number":129,"context_line":"            raise NetworkInterfaceNotFound(msg)"},{"line_number":130,"context_line":"        raise"},{"line_number":131,"context_line":"    except OSError as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_1cb76af7","line":128,"range":{"start_line":126,"start_character":19,"end_line":128,"end_character":64},"in_reply_to":"bf659307_aaff2dff","updated":"2018-04-13 07:40:00.000000000","message":"Done","commit_id":"c98ec91daf12999bcf3c878a51a1e3fbf02e8596"}]}
