)]}'
{"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"8a7343ff0573e05b9e94afb389eb18a7bc0fa21f","unresolved":false,"context_lines":[{"line_number":2017,"context_line":"                try:"},{"line_number":2018,"context_line":"                    recover_needed \u003d True"},{"line_number":2019,"context_line":"                    self._handle_ovs_restart(polling_manager)"},{"line_number":2020,"context_line":"                    tunnel_sync \u003d self.enable_tunneling or tunnel_sync"},{"line_number":2021,"context_line":"                    LOG.info(\"Agent successfully recovered after Open vSwitch \""},{"line_number":2022,"context_line":"                             \"restart.\")"},{"line_number":2023,"context_line":"                    recover_needed \u003d False"},{"line_number":2024,"context_line":"                except Exception:"},{"line_number":2025,"context_line":"                    LOG.exception(\"Failure while recovering agent after Open \""},{"line_number":2026,"context_line":"                                  \"vSwitch restart.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_3e38dbd1","line":2023,"range":{"start_line":2020,"start_character":0,"end_line":2023,"end_character":42},"updated":"2018-04-16 15:24:34.000000000","message":"Shall we move this code down to L2028?","commit_id":"3bfcaadc9c60f6ba16f32df2bf891e495ec87b29"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4f39fc3c6391ea78eeeedd75000c4cba92e5f3c2","unresolved":false,"context_lines":[{"line_number":2017,"context_line":"                try:"},{"line_number":2018,"context_line":"                    recover_needed \u003d True"},{"line_number":2019,"context_line":"                    self._handle_ovs_restart(polling_manager)"},{"line_number":2020,"context_line":"                    tunnel_sync \u003d self.enable_tunneling or tunnel_sync"},{"line_number":2021,"context_line":"                    LOG.info(\"Agent successfully recovered after Open vSwitch \""},{"line_number":2022,"context_line":"                             \"restart.\")"},{"line_number":2023,"context_line":"                    recover_needed \u003d False"},{"line_number":2024,"context_line":"                except Exception:"},{"line_number":2025,"context_line":"                    LOG.exception(\"Failure while recovering agent after Open \""},{"line_number":2026,"context_line":"                                  \"vSwitch restart.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_0881ee8f","line":2023,"range":{"start_line":2020,"start_character":0,"end_line":2023,"end_character":42},"in_reply_to":"9f6a8fd7_13d86851","updated":"2018-04-18 07:31:54.000000000","message":"My comment wasn\u0027t clear, sorry. I meant to move this block outside of the try-except block below L2028 on the same indent level as \u0027try\u0027. The idea was that we catch exception only from _handle_ovs_restart() and not potentially from LOG.info() - e.g. error writing to file.\n\nHaving the block outside of try block will set tunnel_sync only if _handle_ovs_restart succeeds because of the \u0027continue\u0027 on L2028","commit_id":"3bfcaadc9c60f6ba16f32df2bf891e495ec87b29"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"094bc1eebe1ea6bfb1da1b51cb1d23a6d4a53387","unresolved":false,"context_lines":[{"line_number":2017,"context_line":"                try:"},{"line_number":2018,"context_line":"                    recover_needed \u003d True"},{"line_number":2019,"context_line":"                    self._handle_ovs_restart(polling_manager)"},{"line_number":2020,"context_line":"                    tunnel_sync \u003d self.enable_tunneling or tunnel_sync"},{"line_number":2021,"context_line":"                    LOG.info(\"Agent successfully recovered after Open vSwitch \""},{"line_number":2022,"context_line":"                             \"restart.\")"},{"line_number":2023,"context_line":"                    recover_needed \u003d False"},{"line_number":2024,"context_line":"                except Exception:"},{"line_number":2025,"context_line":"                    LOG.exception(\"Failure while recovering agent after Open \""},{"line_number":2026,"context_line":"                                  \"vSwitch restart.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_13d86851","line":2023,"range":{"start_line":2020,"start_character":0,"end_line":2023,"end_character":42},"in_reply_to":"9f6a8fd7_3e38dbd1","updated":"2018-04-16 21:31:51.000000000","message":"Can you elaborate why?\n\ntunnel_sync should be reset with a new value iff _handle_ovs_restart succeeded, otherwise we would reset tunnel_sync to True and unnecessarily synchronize tunnels on each iteration.","commit_id":"3bfcaadc9c60f6ba16f32df2bf891e495ec87b29"}]}