)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"1288aef0318349414ca9cbeecbe926e709de9234","unresolved":false,"context_lines":[{"line_number":10,"context_line":"calculate IPv6 address base on IPv6 prefix and MAC"},{"line_number":11,"context_line":"address via EUI-64 specification, and assign this"},{"line_number":12,"context_line":"address to target instance. Also assume the instance"},{"line_number":13,"context_line":"will be assigned with the same IPv6 address"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Implements bp ipv6-two-attributes"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"AAAAVn%2F%2F%2FYM%3D","line":13,"updated":"2014-03-02 22:02:44.000000000","message":"I don\u0027t understand the last sentence.\nDoes \"Assume\" here mean that some other mechanisms will ensure the correct IPv6 address is assigned to the instance?","commit_id":"7043ba75558295b8582530efb1a0aa7da73e573f"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"777422c90a2e4281839ae23eeb4e2f36e6286145","unresolved":false,"context_lines":[{"line_number":10,"context_line":"calculate IPv6 address base on IPv6 prefix and MAC"},{"line_number":11,"context_line":"address via EUI-64 specification, and assign this"},{"line_number":12,"context_line":"address to target instance. Also assume the instance"},{"line_number":13,"context_line":"will be assigned with the same IPv6 address"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Implements bp ipv6-two-attributes"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"AAAAVn%2F%2F8Gs%3D","line":13,"in_reply_to":"AAAAVn%2F%2F%2FYM%3D","updated":"2014-03-03 09:51:55.000000000","message":"Salvatore, it is because instance stateless IPv6 address is generated base on the provided IPv6 prefix and MAC address via EUI-64 rule. when boot instance, before this instance active, we can not get the IPv6 address from instance, so we need to calculate the IPv6 address via same rule base on provided IPv6 prefix and MAC address. The calculated IPv6 address should be same as the actual address in instance, In here, I said \"assume\" is mean every is work well, the IPaddress  should be same.","commit_id":"7043ba75558295b8582530efb1a0aa7da73e573f"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"1288aef0318349414ca9cbeecbe926e709de9234","unresolved":false,"context_lines":[{"line_number":12,"context_line":"address to target instance. Also assume the instance"},{"line_number":13,"context_line":"will be assigned with the same IPv6 address"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Implements bp ipv6-two-attributes"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I68ccbc42388ec760d6fead242e080822ca753913"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"AAAAVn%2F%2F%2FYI%3D","line":15,"updated":"2014-03-02 22:02:44.000000000","message":"pedant comment: Partially-implements","commit_id":"7043ba75558295b8582530efb1a0aa7da73e573f"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"777422c90a2e4281839ae23eeb4e2f36e6286145","unresolved":false,"context_lines":[{"line_number":12,"context_line":"address to target instance. Also assume the instance"},{"line_number":13,"context_line":"will be assigned with the same IPv6 address"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Implements bp ipv6-two-attributes"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I68ccbc42388ec760d6fead242e080822ca753913"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"AAAAVn%2F%2F8Gc%3D","line":15,"in_reply_to":"AAAAVn%2F%2F%2FYI%3D","updated":"2014-03-03 09:51:55.000000000","message":"Will do it after Sean.s code updated","commit_id":"7043ba75558295b8582530efb1a0aa7da73e573f"}],"neutron/common/ipv6.py":[{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"9f69ec9390850268537f791b024cfc51861e8b9c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 OpenStack Foundation."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FC%2Fs%3D","line":3,"updated":"2013-11-15 07:40:28.000000000","message":"I think you also should add \"Copyright 2013 IBM Corp.\" based on legal policy.","commit_id":"1a2f603533b5fcbf9e47ffa8e115f248e4c6c614"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"d48a6f74930538939d3a292202f6809c41a8e51b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 OpenStack Foundation."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FCes%3D","line":3,"in_reply_to":"AAAATn%2F%2FC%2Fs%3D","updated":"2013-11-15 10:18:24.000000000","message":"Done","commit_id":"1a2f603533b5fcbf9e47ffa8e115f248e4c6c614"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"9f69ec9390850268537f791b024cfc51861e8b9c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# @author: Dazhao Yu, dzyu@cn.ibm.com, IBM #"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"\"\"\""},{"line_number":21,"context_line":"IPv6-related utilities and helper functions."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FC%2FE%3D","line":18,"updated":"2013-11-15 07:40:28.000000000","message":"should get rid of this line based on legal policy.","commit_id":"1a2f603533b5fcbf9e47ffa8e115f248e4c6c614"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"d48a6f74930538939d3a292202f6809c41a8e51b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# @author: Dazhao Yu, dzyu@cn.ibm.com, IBM #"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"\"\"\""},{"line_number":21,"context_line":"IPv6-related utilities and helper functions."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FCek%3D","line":18,"in_reply_to":"AAAATn%2F%2FC%2FE%3D","updated":"2013-11-15 10:18:24.000000000","message":"Done","commit_id":"1a2f603533b5fcbf9e47ffa8e115f248e4c6c614"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"2d4b6f92b0283e52b069317ff5ae1725c6aeea31","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        prefix \u003d netaddr.IPNetwork(prefix)"},{"line_number":36,"context_line":"        return netaddr.IPAddress(prefix.first + eui64 ^ (1 \u003c\u003c 57))"},{"line_number":37,"context_line":"    except netaddr.AddrFormatError:"},{"line_number":38,"context_line":"        raise TypeError(_(\u0027Bad mac for generate IPv6 address by \u0027"},{"line_number":39,"context_line":"                          \u0027EUI-64: %s\u0027) % mac)"},{"line_number":40,"context_line":"    except TypeError:"},{"line_number":41,"context_line":"        raise TypeError(_(\u0027Bad prefix for generate IPv6 address by \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FCpg%3D","line":38,"updated":"2013-11-15 09:26:06.000000000","message":"Using \u0027Bad mac ...\u0027 seems not be apropos because bad prefix can also throw AddrFormatError by above line \"prefix \u003d netaddr.IPNetwork(prefix)\"","commit_id":"1a2f603533b5fcbf9e47ffa8e115f248e4c6c614"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"d48a6f74930538939d3a292202f6809c41a8e51b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        prefix \u003d netaddr.IPNetwork(prefix)"},{"line_number":36,"context_line":"        return netaddr.IPAddress(prefix.first + eui64 ^ (1 \u003c\u003c 57))"},{"line_number":37,"context_line":"    except netaddr.AddrFormatError:"},{"line_number":38,"context_line":"        raise TypeError(_(\u0027Bad mac for generate IPv6 address by \u0027"},{"line_number":39,"context_line":"                          \u0027EUI-64: %s\u0027) % mac)"},{"line_number":40,"context_line":"    except TypeError:"},{"line_number":41,"context_line":"        raise TypeError(_(\u0027Bad prefix for generate IPv6 address by \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FCdo%3D","line":38,"in_reply_to":"AAAATn%2F%2FCpg%3D","updated":"2013-11-15 10:18:24.000000000","message":"Correct it later","commit_id":"1a2f603533b5fcbf9e47ffa8e115f248e4c6c614"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"2d4b6f92b0283e52b069317ff5ae1725c6aeea31","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        raise TypeError(_(\u0027Bad mac for generate IPv6 address by \u0027"},{"line_number":39,"context_line":"                          \u0027EUI-64: %s\u0027) % mac)"},{"line_number":40,"context_line":"    except TypeError:"},{"line_number":41,"context_line":"        raise TypeError(_(\u0027Bad prefix for generate IPv6 address by \u0027"},{"line_number":42,"context_line":"                          \u0027EUI-64: %s\u0027) % prefix)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FCps%3D","line":41,"updated":"2013-11-15 09:26:06.000000000","message":"your unit test seems not cover this branch","commit_id":"1a2f603533b5fcbf9e47ffa8e115f248e4c6c614"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"d48a6f74930538939d3a292202f6809c41a8e51b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        raise TypeError(_(\u0027Bad mac for generate IPv6 address by \u0027"},{"line_number":39,"context_line":"                          \u0027EUI-64: %s\u0027) % mac)"},{"line_number":40,"context_line":"    except TypeError:"},{"line_number":41,"context_line":"        raise TypeError(_(\u0027Bad prefix for generate IPv6 address by \u0027"},{"line_number":42,"context_line":"                          \u0027EUI-64: %s\u0027) % prefix)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FCdk%3D","line":41,"in_reply_to":"AAAATn%2F%2FCps%3D","updated":"2013-11-15 10:18:24.000000000","message":"Will correct it later","commit_id":"1a2f603533b5fcbf9e47ffa8e115f248e4c6c614"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"b5555bcceaca7da3e4d3f8fdc641298252df82ea","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        return netaddr.IPAddress(prefix.first + eui64 ^ (1 \u003c\u003c 57))"},{"line_number":35,"context_line":"    except netaddr.AddrFormatError:"},{"line_number":36,"context_line":"        raise TypeError(_(\u0027Bad mac for generate IPv6 address by \u0027"},{"line_number":37,"context_line":"                          \u0027EUI-64: %s\u0027) % mac)"},{"line_number":38,"context_line":"    except TypeError:"},{"line_number":39,"context_line":"        raise TypeError(_(\u0027Bad prefix for generate IPv6 address by \u0027"},{"line_number":40,"context_line":"                          \u0027EUI-64: %s\u0027) % prefix)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2B9bY%3D","line":37,"updated":"2013-11-18 03:29:44.000000000","message":"Still need to fix Zhang Hua\u0027s comment in previous patch. \n\nmaybe just saying Bad format for generating IPv6 address?","commit_id":"4e57748b795e471e36d20c82b81991070a5837ed"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"8eb675db10c31067a239bfd44a5c583306ea24c3","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from neutron.openstack.common import log as logging"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def get_ipv6_addr_by_EUI64(prefix, mac):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2BhMM%3D","line":27,"updated":"2013-11-25 08:21:22.000000000","message":"LOG is unused","commit_id":"d2450b7feba8fa3a6a279657e9f61724f2f4ec4b"},{"author":{"_account_id":9560,"name":"Lee Li","email":"lilinguo8212@gmail.com","username":"llg8212"},"change_message_id":"2bc33f8aed9ad71e75cac1c7f0a7b17bf150e4c6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 IBM Corp."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":21,"id":"AAAAUX%2F%2BcsA%3D","line":1,"updated":"2014-02-21 06:19:32.000000000","message":"The first line should be deleted.\nhttps://bugs.launchpad.net/ceilometer/+bug/1229324","commit_id":"ba2f7288ad1c2e66d5c842c49ebd90a6ef6ee5dd"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"1288aef0318349414ca9cbeecbe926e709de9234","unresolved":false,"context_lines":[{"line_number":17,"context_line":"IPv6-related utilities and helper functions."},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import netaddr"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def get_ipv6_addr_by_EUI64(prefix, mac):"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAVn%2F%2F%2FaY%3D","line":20,"updated":"2014-03-02 22:02:44.000000000","message":"I\u0027m +/-0 on a new module vs adding this function to neutron.common.utils\n\nHowever, I find ipv6_utils or utils_ipv6 a better module name.","commit_id":"7043ba75558295b8582530efb1a0aa7da73e573f"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"7f47b4d47fde8fbd8b373118a49e218be3e019bb","unresolved":false,"context_lines":[{"line_number":17,"context_line":"IPv6-related utilities and helper functions."},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import netaddr"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def get_ipv6_addr_by_EUI64(prefix, mac):"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAVn%2F%2F8kE%3D","line":20,"in_reply_to":"AAAAVn%2F%2F%2FaY%3D","updated":"2014-03-03 09:01:15.000000000","message":"IMHO, I think it\u0027s better to separate them, utils looks like the module where you start throwing out all sorts of functions.\n\nipv6_utils looks good.","commit_id":"7043ba75558295b8582530efb1a0aa7da73e573f"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"777422c90a2e4281839ae23eeb4e2f36e6286145","unresolved":false,"context_lines":[{"line_number":17,"context_line":"IPv6-related utilities and helper functions."},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import netaddr"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def get_ipv6_addr_by_EUI64(prefix, mac):"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAVn%2F%2F8Fc%3D","line":20,"in_reply_to":"AAAAVn%2F%2F8kE%3D","updated":"2014-03-03 09:51:55.000000000","message":"Agree, will change it later","commit_id":"7043ba75558295b8582530efb1a0aa7da73e573f"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"1288aef0318349414ca9cbeecbe926e709de9234","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    isIPv4 \u003d netaddr.valid_ipv4(prefix)"},{"line_number":26,"context_line":"    if isIPv4:"},{"line_number":27,"context_line":"        msg \u003d _(\"Unable to generate IP address by EUI64 for IPv4 prefix\")"},{"line_number":28,"context_line":"        raise TypeError(msg)"},{"line_number":29,"context_line":"    try:"},{"line_number":30,"context_line":"        eui64 \u003d int(netaddr.EUI(mac).eui64())"},{"line_number":31,"context_line":"        prefix \u003d netaddr.IPNetwork(prefix)"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAVn%2F%2F%2FaQ%3D","line":28,"updated":"2014-03-02 22:02:44.000000000","message":"nit, optional: use custom application-level exceptions where possible instead of predefined ones (this to avoid your exception being catched by mistake by some other catch clause)\n\nApplies to line 34 and 38 as well","commit_id":"7043ba75558295b8582530efb1a0aa7da73e573f"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"1288aef0318349414ca9cbeecbe926e709de9234","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        prefix \u003d netaddr.IPNetwork(prefix)"},{"line_number":32,"context_line":"        return netaddr.IPAddress(prefix.first + eui64 ^ (1 \u003c\u003c 57))"},{"line_number":33,"context_line":"    except netaddr.AddrFormatError:"},{"line_number":34,"context_line":"        raise TypeError(_(\u0027Bad prefix or mac format for generate IPv6 address \u0027"},{"line_number":35,"context_line":"                          \u0027by EUI-64: %(prefix)s, %(mac)s:\u0027)"},{"line_number":36,"context_line":"                        % {\u0027prefix\u0027: prefix, \u0027mac\u0027: mac})"},{"line_number":37,"context_line":"    except TypeError:"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAVn%2F%2F%2FZA%3D","line":34,"updated":"2014-03-02 22:02:44.000000000","message":"pedant comment: \u0027for generating\u0027\n\nHonestly, english is not my language, so I don\u0027t know.\nI\u0027ve just never seen \u0027for\u0027 with the infinitive of a verb.","commit_id":"7043ba75558295b8582530efb1a0aa7da73e573f"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"777422c90a2e4281839ae23eeb4e2f36e6286145","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        prefix \u003d netaddr.IPNetwork(prefix)"},{"line_number":32,"context_line":"        return netaddr.IPAddress(prefix.first + eui64 ^ (1 \u003c\u003c 57))"},{"line_number":33,"context_line":"    except netaddr.AddrFormatError:"},{"line_number":34,"context_line":"        raise TypeError(_(\u0027Bad prefix or mac format for generate IPv6 address \u0027"},{"line_number":35,"context_line":"                          \u0027by EUI-64: %(prefix)s, %(mac)s:\u0027)"},{"line_number":36,"context_line":"                        % {\u0027prefix\u0027: prefix, \u0027mac\u0027: mac})"},{"line_number":37,"context_line":"    except TypeError:"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAVn%2F%2F8Eo%3D","line":34,"in_reply_to":"AAAAVn%2F%2F%2FZA%3D","updated":"2014-03-03 09:51:55.000000000","message":"Hmm, thanks, will change it","commit_id":"7043ba75558295b8582530efb1a0aa7da73e573f"}],"neutron/common/ipv6_utils.py":[{"author":{"_account_id":107,"name":"Arvind Somya","email":"arvind.somya@gmail.com","username":"asomya"},"change_message_id":"67c2e011e2eb223ee228297ea746d08c760efb66","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import netaddr"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def get_ipv6_addr_by_EUI64(prefix, mac):"},{"line_number":24,"context_line":"    # Check if the prefix is IPv4 address"},{"line_number":25,"context_line":"    isIPv4 \u003d netaddr.valid_ipv4(prefix)"},{"line_number":26,"context_line":"    if isIPv4:"}],"source_content_type":"text/x-python","patch_set":34,"id":"AAAAWH%2F%2Fcyc%3D","line":23,"updated":"2014-03-17 20:42:59.000000000","message":"Add a docstring with sample inputs please.","commit_id":"7e47a3e43692930b07c90b05a777e66333916bf3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"61a91748795258ee2d1bddf0d5c09f3b92d77556","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import netaddr"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def get_ipv6_addr_by_EUI64(prefix, mac):"},{"line_number":24,"context_line":"    # Check if the prefix is IPv4 address"},{"line_number":25,"context_line":"    isIPv4 \u003d netaddr.valid_ipv4(prefix)"},{"line_number":26,"context_line":"    if isIPv4:"}],"source_content_type":"text/x-python","patch_set":34,"id":"AAAAWH%2F%2FcQc%3D","line":23,"in_reply_to":"AAAAWH%2F%2Fcyc%3D","updated":"2014-03-17 21:38:19.000000000","message":"This will be addressed via a bug fix.","commit_id":"7e47a3e43692930b07c90b05a777e66333916bf3"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"9efe728b670fedd92e83bcc4acde8a48aaebfd91","unresolved":false,"context_lines":[{"line_number":1354,"context_line":"                    ip_address \u003d ip[\u0027ip_address\u0027]"},{"line_number":1355,"context_line":"                    subnet_id \u003d ip[\u0027subnet_id\u0027]"},{"line_number":1356,"context_line":"                    if ip_address is None:"},{"line_number":1357,"context_line":"                        #Then its dhcp mode is not static, the ip address need"},{"line_number":1358,"context_line":"                        # to be genarated via EUI-64 specification"},{"line_number":1359,"context_line":"                        subnet \u003d self.get_subnet(context, subnet_id)"},{"line_number":1360,"context_line":"                        if subnet[\u0027ip_version\u0027] \u003d\u003d 6:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FLEc%3D","line":1357,"updated":"2013-11-13 11:28:05.000000000","message":"nit: needs","commit_id":"a99705eedd92a732c72346dece3d911530a1b39e"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"65e5d973e926cc67cc5e998d87337ca26cc8cfb4","unresolved":false,"context_lines":[{"line_number":1354,"context_line":"                    ip_address \u003d ip[\u0027ip_address\u0027]"},{"line_number":1355,"context_line":"                    subnet_id \u003d ip[\u0027subnet_id\u0027]"},{"line_number":1356,"context_line":"                    if ip_address is None:"},{"line_number":1357,"context_line":"                        #Then its dhcp mode is not static, the ip address need"},{"line_number":1358,"context_line":"                        # to be genarated via EUI-64 specification"},{"line_number":1359,"context_line":"                        subnet \u003d self.get_subnet(context, subnet_id)"},{"line_number":1360,"context_line":"                        if subnet[\u0027ip_version\u0027] \u003d\u003d 6:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FIWc%3D","line":1357,"in_reply_to":"AAAATn%2F%2FLEc%3D","updated":"2013-11-14 03:49:03.000000000","message":"Done","commit_id":"a99705eedd92a732c72346dece3d911530a1b39e"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"9efe728b670fedd92e83bcc4acde8a48aaebfd91","unresolved":false,"context_lines":[{"line_number":1355,"context_line":"                    subnet_id \u003d ip[\u0027subnet_id\u0027]"},{"line_number":1356,"context_line":"                    if ip_address is None:"},{"line_number":1357,"context_line":"                        #Then its dhcp mode is not static, the ip address need"},{"line_number":1358,"context_line":"                        # to be genarated via EUI-64 specification"},{"line_number":1359,"context_line":"                        subnet \u003d self.get_subnet(context, subnet_id)"},{"line_number":1360,"context_line":"                        if subnet[\u0027ip_version\u0027] \u003d\u003d 6:"},{"line_number":1361,"context_line":"                            prefix \u003d subnet[\u0027cidr\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FLHI%3D","line":1358,"updated":"2013-11-13 11:28:05.000000000","message":"typo: generated","commit_id":"a99705eedd92a732c72346dece3d911530a1b39e"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"65e5d973e926cc67cc5e998d87337ca26cc8cfb4","unresolved":false,"context_lines":[{"line_number":1355,"context_line":"                    subnet_id \u003d ip[\u0027subnet_id\u0027]"},{"line_number":1356,"context_line":"                    if ip_address is None:"},{"line_number":1357,"context_line":"                        #Then its dhcp mode is not static, the ip address need"},{"line_number":1358,"context_line":"                        # to be genarated via EUI-64 specification"},{"line_number":1359,"context_line":"                        subnet \u003d self.get_subnet(context, subnet_id)"},{"line_number":1360,"context_line":"                        if subnet[\u0027ip_version\u0027] \u003d\u003d 6:"},{"line_number":1361,"context_line":"                            prefix \u003d subnet[\u0027cidr\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FIWY%3D","line":1358,"in_reply_to":"AAAATn%2F%2FLHI%3D","updated":"2013-11-14 03:49:03.000000000","message":"Done","commit_id":"a99705eedd92a732c72346dece3d911530a1b39e"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"2d4b6f92b0283e52b069317ff5ae1725c6aeea31","unresolved":false,"context_lines":[{"line_number":457,"context_line":"                          {\u0027subnet_id\u0027: subnet[\u0027id\u0027], \u0027cidr\u0027: subnet[\u0027cidr\u0027]})"},{"line_number":458,"context_line":"                continue"},{"line_number":459,"context_line":"            if subnet[\u0027dhcp_mode\u0027] !\u003d \u0027static\u0027:"},{"line_number":460,"context_line":"                return {\u0027ip_address\u0027: None, \u0027subnet_id\u0027: subnet[\u0027id\u0027]}"},{"line_number":461,"context_line":"            ip_address \u003d range[\u0027first_ip\u0027]"},{"line_number":462,"context_line":"            LOG.debug(_(\"Allocated IP - %(ip_address)s from %(first_ip)s \""},{"line_number":463,"context_line":"                        \"to %(last_ip)s\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FCts%3D","line":460,"updated":"2013-11-15 09:26:06.000000000","message":"seems that _update_ips_for_port will aslo invoke _generate_ip, does update_port operation will update ip_address of port into None ?","commit_id":"1a2f603533b5fcbf9e47ffa8e115f248e4c6c614"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"d48a6f74930538939d3a292202f6809c41a8e51b","unresolved":false,"context_lines":[{"line_number":457,"context_line":"                          {\u0027subnet_id\u0027: subnet[\u0027id\u0027], \u0027cidr\u0027: subnet[\u0027cidr\u0027]})"},{"line_number":458,"context_line":"                continue"},{"line_number":459,"context_line":"            if subnet[\u0027dhcp_mode\u0027] !\u003d \u0027static\u0027:"},{"line_number":460,"context_line":"                return {\u0027ip_address\u0027: None, \u0027subnet_id\u0027: subnet[\u0027id\u0027]}"},{"line_number":461,"context_line":"            ip_address \u003d range[\u0027first_ip\u0027]"},{"line_number":462,"context_line":"            LOG.debug(_(\"Allocated IP - %(ip_address)s from %(first_ip)s \""},{"line_number":463,"context_line":"                        \"to %(last_ip)s\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FCiM%3D","line":460,"in_reply_to":"AAAATn%2F%2FCts%3D","updated":"2013-11-15 10:18:24.000000000","message":"Yes, I just start the first step, and have many scenarios do not consider, thanks for the reminder","commit_id":"1a2f603533b5fcbf9e47ffa8e115f248e4c6c614"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"2d4b6f92b0283e52b069317ff5ae1725c6aeea31","unresolved":false,"context_lines":[{"line_number":1353,"context_line":"                for ip in ips:"},{"line_number":1354,"context_line":"                    ip_address \u003d ip[\u0027ip_address\u0027]"},{"line_number":1355,"context_line":"                    subnet_id \u003d ip[\u0027subnet_id\u0027]"},{"line_number":1356,"context_line":"                    if ip_address is None:"},{"line_number":1357,"context_line":"                        #Then its dhcp mode is not static, the ip address needs"},{"line_number":1358,"context_line":"                        # to be generated via EUI-64 specification"},{"line_number":1359,"context_line":"                        subnet \u003d self.get_subnet(context, subnet_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FCsk%3D","line":1356,"updated":"2013-11-15 09:26:06.000000000","message":"\"if subnet[\u0027dhcp_mode\u0027] !\u003d \u0027static\u0027:\" is better","commit_id":"1a2f603533b5fcbf9e47ffa8e115f248e4c6c614"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"d48a6f74930538939d3a292202f6809c41a8e51b","unresolved":false,"context_lines":[{"line_number":1353,"context_line":"                for ip in ips:"},{"line_number":1354,"context_line":"                    ip_address \u003d ip[\u0027ip_address\u0027]"},{"line_number":1355,"context_line":"                    subnet_id \u003d ip[\u0027subnet_id\u0027]"},{"line_number":1356,"context_line":"                    if ip_address is None:"},{"line_number":1357,"context_line":"                        #Then its dhcp mode is not static, the ip address needs"},{"line_number":1358,"context_line":"                        # to be generated via EUI-64 specification"},{"line_number":1359,"context_line":"                        subnet \u003d self.get_subnet(context, subnet_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FCi8%3D","line":1356,"in_reply_to":"AAAATn%2F%2FCsk%3D","updated":"2013-11-15 10:18:24.000000000","message":"we just get the subnet_id, only if the ip_address is None, we would to call get_subnet method","commit_id":"1a2f603533b5fcbf9e47ffa8e115f248e4c6c614"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"b5555bcceaca7da3e4d3f8fdc641298252df82ea","unresolved":false,"context_lines":[{"line_number":1359,"context_line":"                        subnet \u003d self.get_subnet(context, subnet_id)"},{"line_number":1360,"context_line":"                        if subnet[\u0027ip_version\u0027] \u003d\u003d 6:"},{"line_number":1361,"context_line":"                            prefix \u003d subnet[\u0027cidr\u0027]"},{"line_number":1362,"context_line":"                            ip_address \u003d ipv6.get_ipv6_addr_by_EUI64("},{"line_number":1363,"context_line":"                                prefix, mac_address)"},{"line_number":1364,"context_line":"                    LOG.debug(_(\"Allocated IP %(ip_address)s \""},{"line_number":1365,"context_line":"                                \"(%(network_id)s/%(subnet_id)s/%(port_id)s)\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2B9bA%3D","line":1362,"updated":"2013-11-18 03:29:44.000000000","message":"should the possible exceptions be caught here?","commit_id":"4e57748b795e471e36d20c82b81991070a5837ed"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"71ae4d613200cce57ae6a6f66670a3719f618300","unresolved":false,"context_lines":[{"line_number":468,"context_line":"            dhcp_modes \u003d subnet[\u0027dhcp_modes\u0027]"},{"line_number":469,"context_line":"            ip_version \u003d subnet[\u0027ip_version\u0027]"},{"line_number":470,"context_line":"            if (not useFixedIp and ip_version \u003d\u003d 6 and"},{"line_number":471,"context_line":"                    dhcp_modes !\u003d [\u0027static\u0027]):"},{"line_number":472,"context_line":"                # (dzyu) When useFixedIP is True, does not need generate IP"},{"line_number":473,"context_line":"                # address by EUI64, just use provided fixed ip."},{"line_number":474,"context_line":"                return {\u0027ip_address\u0027: None, \u0027subnet_id\u0027: subnet[\u0027id\u0027]}"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F9HRc%3D","line":471,"updated":"2013-12-16 17:21:42.000000000","message":"This logic will not function correctly because dhcp_modes is an array of neutron.db.models_v2.DhcpMode objects.\n\nDetails:\n\nhttp://paste.openstack.org/show/55071/","commit_id":"31f56451cda3d18272178a2cac220ce603e7e095"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"6d23a379c4a0822f8186e2a2354f5aa2f16685fa","unresolved":false,"context_lines":[{"line_number":468,"context_line":"            dhcp_modes \u003d subnet[\u0027dhcp_modes\u0027]"},{"line_number":469,"context_line":"            ip_version \u003d subnet[\u0027ip_version\u0027]"},{"line_number":470,"context_line":"            if (not useFixedIp and ip_version \u003d\u003d 6 and"},{"line_number":471,"context_line":"                    dhcp_modes !\u003d [\u0027static\u0027]):"},{"line_number":472,"context_line":"                # (dzyu) When useFixedIP is True, does not need generate IP"},{"line_number":473,"context_line":"                # address by EUI64, just use provided fixed ip."},{"line_number":474,"context_line":"                return {\u0027ip_address\u0027: None, \u0027subnet_id\u0027: subnet[\u0027id\u0027]}"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F9Ehc%3D","line":471,"in_reply_to":"AAAATn%2F9HRc%3D","updated":"2013-12-17 03:38:28.000000000","message":"Hi Sean, from local verify about this patch, the dhcp_modes sometimes is one array of string, sometimes is an array of neutron.db.models_v2.DhcpMode objects,  it seems like only when use configured fixed IP information, the dhcp_modes is an array of DhcpMode objects. I added some log info in db_base_plugin_v2._generate_ip method, and run test_db_plugin for unit test, the log messages as below:\n\nhttp://paste.openstack.org/show/55102/","commit_id":"31f56451cda3d18272178a2cac220ce603e7e095"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"d19dacbe580465469845809a88005121c2d4f4f8","unresolved":false,"context_lines":[{"line_number":469,"context_line":"            ip_version \u003d subnet[\u0027ip_version\u0027]"},{"line_number":470,"context_line":"            if (not useFixedIp and ip_version \u003d\u003d 6 and"},{"line_number":471,"context_line":"                    dhcp_modes !\u003d [\u0027static\u0027]):"},{"line_number":472,"context_line":"                # (dzyu) When useFixedIP is True, does not need generate IP"},{"line_number":473,"context_line":"                # address by EUI64, just use provided fixed ip."},{"line_number":474,"context_line":"                return {\u0027ip_address\u0027: None, \u0027subnet_id\u0027: subnet[\u0027id\u0027]}"},{"line_number":475,"context_line":"            ip_address \u003d range[\u0027first_ip\u0027]"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F9I5I%3D","line":472,"updated":"2013-12-16 12:35:28.000000000","message":"does -\u003e do","commit_id":"31f56451cda3d18272178a2cac220ce603e7e095"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"6d23a379c4a0822f8186e2a2354f5aa2f16685fa","unresolved":false,"context_lines":[{"line_number":469,"context_line":"            ip_version \u003d subnet[\u0027ip_version\u0027]"},{"line_number":470,"context_line":"            if (not useFixedIp and ip_version \u003d\u003d 6 and"},{"line_number":471,"context_line":"                    dhcp_modes !\u003d [\u0027static\u0027]):"},{"line_number":472,"context_line":"                # (dzyu) When useFixedIP is True, does not need generate IP"},{"line_number":473,"context_line":"                # address by EUI64, just use provided fixed ip."},{"line_number":474,"context_line":"                return {\u0027ip_address\u0027: None, \u0027subnet_id\u0027: subnet[\u0027id\u0027]}"},{"line_number":475,"context_line":"            ip_address \u003d range[\u0027first_ip\u0027]"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F9Ei4%3D","line":472,"in_reply_to":"AAAATn%2F9I5I%3D","updated":"2013-12-17 03:38:28.000000000","message":"Done, thanks for the support,  Paul!","commit_id":"31f56451cda3d18272178a2cac220ce603e7e095"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"d19dacbe580465469845809a88005121c2d4f4f8","unresolved":false,"context_lines":[{"line_number":723,"context_line":"            version_subnets \u003d [v4, v6]"},{"line_number":724,"context_line":"            for subnets in version_subnets:"},{"line_number":725,"context_line":"                if subnets:"},{"line_number":726,"context_line":"                    # (dzyu) fixed_configured\u003dFalse, its mean does not use "},{"line_number":727,"context_line":"                    # the fixed IP addresses, so set useFixedIp\u003dFalse"},{"line_number":728,"context_line":"                    result \u003d NeutronDbPluginV2._generate_ip(context, subnets, False)"},{"line_number":729,"context_line":"                    ips.append({\u0027ip_address\u0027: result[\u0027ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F9I5A%3D","line":726,"updated":"2013-12-16 12:35:28.000000000","message":"its mean does -\u003e it means do\n\nspace at end of comment line","commit_id":"31f56451cda3d18272178a2cac220ce603e7e095"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"6d23a379c4a0822f8186e2a2354f5aa2f16685fa","unresolved":false,"context_lines":[{"line_number":723,"context_line":"            version_subnets \u003d [v4, v6]"},{"line_number":724,"context_line":"            for subnets in version_subnets:"},{"line_number":725,"context_line":"                if subnets:"},{"line_number":726,"context_line":"                    # (dzyu) fixed_configured\u003dFalse, its mean does not use "},{"line_number":727,"context_line":"                    # the fixed IP addresses, so set useFixedIp\u003dFalse"},{"line_number":728,"context_line":"                    result \u003d NeutronDbPluginV2._generate_ip(context, subnets, False)"},{"line_number":729,"context_line":"                    ips.append({\u0027ip_address\u0027: result[\u0027ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F9Ei0%3D","line":726,"in_reply_to":"AAAATn%2F9I5A%3D","updated":"2013-12-17 03:38:28.000000000","message":"Done","commit_id":"31f56451cda3d18272178a2cac220ce603e7e095"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"cf7603c2f670eb8f1ded0ef6e6fc72b5335a2d0f","unresolved":false,"context_lines":[{"line_number":1387,"context_line":"                                prefix, mac_address)"},{"line_number":1388,"context_line":"                        else:"},{"line_number":1389,"context_line":"                            msg \u003d _(\"Error IP version for generate IP \""},{"line_number":1390,"context_line":"                                    \"address by EUI64\")"},{"line_number":1391,"context_line":"                            raise Exception(msg)"},{"line_number":1392,"context_line":"                    LOG.debug(_(\"Allocated IP %(ip_address)s \""},{"line_number":1393,"context_line":"                                \"(%(network_id)s/%(subnet_id)s/%(port_id)s)\"),"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F9CwE%3D","line":1390,"updated":"2013-12-17 11:35:16.000000000","message":"Should error message be more descriptive of what is wrong? Some suggestions...\n\nUnable to generate IP address by EUI64 for IPv4\nWrong IP version for generating EUI64 IP avvress\nCannot generate EUI64 IP address for IPv4","commit_id":"22aa6716a129406e13ceafc1b7e4cec77f48b6f9"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"cf7603c2f670eb8f1ded0ef6e6fc72b5335a2d0f","unresolved":false,"context_lines":[{"line_number":1388,"context_line":"                        else:"},{"line_number":1389,"context_line":"                            msg \u003d _(\"Error IP version for generate IP \""},{"line_number":1390,"context_line":"                                    \"address by EUI64\")"},{"line_number":1391,"context_line":"                            raise Exception(msg)"},{"line_number":1392,"context_line":"                    LOG.debug(_(\"Allocated IP %(ip_address)s \""},{"line_number":1393,"context_line":"                                \"(%(network_id)s/%(subnet_id)s/%(port_id)s)\"),"},{"line_number":1394,"context_line":"                              {\u0027ip_address\u0027: ip_address,"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F9Cv8%3D","line":1391,"updated":"2013-12-17 11:35:16.000000000","message":"Do we have a test case of trying to generate EUI64 address, when IPv4, causing this exception?","commit_id":"22aa6716a129406e13ceafc1b7e4cec77f48b6f9"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"4ac99071f34bd447ff63f6c97acd349a65d8126f","unresolved":false,"context_lines":[{"line_number":468,"context_line":"            dhcp_modes \u003d subnet[\u0027dhcp_modes\u0027]"},{"line_number":469,"context_line":"            ip_version \u003d subnet[\u0027ip_version\u0027]"},{"line_number":470,"context_line":"            if (not useFixedIp and ip_version \u003d\u003d 6 and"},{"line_number":471,"context_line":"                    dhcp_modes !\u003d [\u0027static\u0027]):"},{"line_number":472,"context_line":"                # (dzyu) When useFixedIP is True, do not need generate IP"},{"line_number":473,"context_line":"                # address by EUI64, just use provided fixed ip."},{"line_number":474,"context_line":"                return {\u0027ip_address\u0027: None, \u0027subnet_id\u0027: subnet[\u0027id\u0027]}"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F87wg%3D","line":471,"updated":"2013-12-18 16:30:47.000000000","message":"\"static\" not in dhcp_modes","commit_id":"2a69b72fff6c06cb0c1698887e152e96a0aa83ab"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"8fe0a67002b96d4aa9e636e577f1d209715dc335","unresolved":false,"context_lines":[{"line_number":468,"context_line":"            dhcp_modes \u003d subnet[\u0027dhcp_modes\u0027]"},{"line_number":469,"context_line":"            ip_version \u003d subnet[\u0027ip_version\u0027]"},{"line_number":470,"context_line":"            if (not useFixedIp and ip_version \u003d\u003d 6 and"},{"line_number":471,"context_line":"                    \u0027static\u0027 not in dhcp_modes):"},{"line_number":472,"context_line":"                # (dzyu) When useFixedIP is True, do not need generate IP"},{"line_number":473,"context_line":"                # address by EUI64, just use provided fixed ip."},{"line_number":474,"context_line":"                return {\u0027ip_address\u0027: None, \u0027subnet_id\u0027: subnet[\u0027id\u0027]}"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAATn%2F845w%3D","line":471,"updated":"2013-12-19 05:56:24.000000000","message":"Agree with that calculated IPv6 address should only work with slaac mode address. But what about the cases DHCP address and slaac address are allowed at the same time? For example: dnsmasq working at slaac mode and dhcp_range is also specified. According to the man page, the client will get both DHCP and slaac address. I think we can allow both fixed IP and calculated IP being used in such cases.\n\nBTW, I think we should check when dhcp_modes is assigned to a subnet, if fixed IP can be specified. For example, when slaac is used for dhcp_mode, we should not allow fixed ip as the input of nova boot. Maybe write up some error messages for such cases?","commit_id":"bcaa8fe99fa0e8403a788ba8a5b87e1ac7fee30d"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"45a96b1f4afd0f6ca2104dcf0426b47c246fe17f","unresolved":false,"context_lines":[{"line_number":468,"context_line":"            dhcp_modes \u003d subnet[\u0027dhcp_modes\u0027]"},{"line_number":469,"context_line":"            ip_version \u003d subnet[\u0027ip_version\u0027]"},{"line_number":470,"context_line":"            if (not useFixedIp and ip_version \u003d\u003d 6 and"},{"line_number":471,"context_line":"                    \u0027static\u0027 not in dhcp_modes):"},{"line_number":472,"context_line":"                # (dzyu) When useFixedIP is True, do not need generate IP"},{"line_number":473,"context_line":"                # address by EUI64, just use provided fixed ip."},{"line_number":474,"context_line":"                return {\u0027ip_address\u0027: None, \u0027subnet_id\u0027: subnet[\u0027id\u0027]}"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAATn%2F8nxg%3D","line":471,"in_reply_to":"AAAATn%2F845w%3D","updated":"2013-12-24 07:39:20.000000000","message":"For first question: when the dhcp_modes like [\u0027static\u0027, \u0027slaac\u0027],  it is difficult to judge which IP should be used, the dnsmasq man page also very confuse for this case. The best method is ask dnsmasq guys, then design our code logic.\n\nAnd second question: I agree with your comment,  should check fixed ip when create port, since nova boot just have \"v4_fixed_ip\" as corresponding input.","commit_id":"bcaa8fe99fa0e8403a788ba8a5b87e1ac7fee30d"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"fd39852b9b7801fad214d23b3b031b66931e20f1","unresolved":false,"context_lines":[{"line_number":468,"context_line":"            dhcp_modes \u003d subnet[\u0027dhcp_modes\u0027]"},{"line_number":469,"context_line":"            ip_version \u003d subnet[\u0027ip_version\u0027]"},{"line_number":470,"context_line":"            if (not useFixedIp and ip_version \u003d\u003d 6 and"},{"line_number":471,"context_line":"                    \u0027static\u0027 not in dhcp_modes):"},{"line_number":472,"context_line":"                # (dzyu) When useFixedIP is True, do not need generate IP"},{"line_number":473,"context_line":"                # address by EUI64, just use provided fixed ip."},{"line_number":474,"context_line":"                return {\u0027ip_address\u0027: None, \u0027subnet_id\u0027: subnet[\u0027id\u0027]}"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAATn%2F8nRg%3D","line":471,"in_reply_to":"AAAATn%2F8nxg%3D","updated":"2013-12-24 10:10:03.000000000","message":"Thought more, if we create one port with fixed ip address. Then we use \u0027nova boot\u0027 to deploy one instance, ant specify the nic to the targeted port-id, it mean we will use fixed ip address which provided by targeted port, it mean will do not need to calculate one new IP address to use.","commit_id":"bcaa8fe99fa0e8403a788ba8a5b87e1ac7fee30d"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"8fe0a67002b96d4aa9e636e577f1d209715dc335","unresolved":false,"context_lines":[{"line_number":723,"context_line":"            version_subnets \u003d [v4, v6]"},{"line_number":724,"context_line":"            for subnets in version_subnets:"},{"line_number":725,"context_line":"                if subnets:"},{"line_number":726,"context_line":"                    # (dzyu) fixed_configured\u003dFalse, its mean does not use"},{"line_number":727,"context_line":"                    # the fixed IP addresses, so set useFixedIp\u003dFalse"},{"line_number":728,"context_line":"                    result \u003d NeutronDbPluginV2._generate_ip(context,"},{"line_number":729,"context_line":"                                                            subnets, False)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAATn%2F85Kw%3D","line":726,"updated":"2013-12-19 05:56:24.000000000","message":"its mean-\u003e it means","commit_id":"bcaa8fe99fa0e8403a788ba8a5b87e1ac7fee30d"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"45a96b1f4afd0f6ca2104dcf0426b47c246fe17f","unresolved":false,"context_lines":[{"line_number":723,"context_line":"            version_subnets \u003d [v4, v6]"},{"line_number":724,"context_line":"            for subnets in version_subnets:"},{"line_number":725,"context_line":"                if subnets:"},{"line_number":726,"context_line":"                    # (dzyu) fixed_configured\u003dFalse, its mean does not use"},{"line_number":727,"context_line":"                    # the fixed IP addresses, so set useFixedIp\u003dFalse"},{"line_number":728,"context_line":"                    result \u003d NeutronDbPluginV2._generate_ip(context,"},{"line_number":729,"context_line":"                                                            subnets, False)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAATn%2F8nzs%3D","line":726,"in_reply_to":"AAAATn%2F85Kw%3D","updated":"2013-12-24 07:39:20.000000000","message":"Done","commit_id":"bcaa8fe99fa0e8403a788ba8a5b87e1ac7fee30d"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"8fe0a67002b96d4aa9e636e577f1d209715dc335","unresolved":false,"context_lines":[{"line_number":1377,"context_line":"                    ip_address \u003d ip[\u0027ip_address\u0027]"},{"line_number":1378,"context_line":"                    subnet_id \u003d ip[\u0027subnet_id\u0027]"},{"line_number":1379,"context_line":"                    if ip_address is None:"},{"line_number":1380,"context_line":"                        # (dzyu)it mean the dhcp modes is not static, the IP"},{"line_number":1381,"context_line":"                        # address needs to be generated via EUI-64 rule"},{"line_number":1382,"context_line":"                        subnet \u003d self.get_subnet(context, subnet_id)"},{"line_number":1383,"context_line":"                        prefix \u003d subnet[\u0027cidr\u0027]"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAATn%2F85Lg%3D","line":1380,"updated":"2013-12-19 05:56:24.000000000","message":"it mean -\u003e means","commit_id":"bcaa8fe99fa0e8403a788ba8a5b87e1ac7fee30d"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"45a96b1f4afd0f6ca2104dcf0426b47c246fe17f","unresolved":false,"context_lines":[{"line_number":1377,"context_line":"                    ip_address \u003d ip[\u0027ip_address\u0027]"},{"line_number":1378,"context_line":"                    subnet_id \u003d ip[\u0027subnet_id\u0027]"},{"line_number":1379,"context_line":"                    if ip_address is None:"},{"line_number":1380,"context_line":"                        # (dzyu)it mean the dhcp modes is not static, the IP"},{"line_number":1381,"context_line":"                        # address needs to be generated via EUI-64 rule"},{"line_number":1382,"context_line":"                        subnet \u003d self.get_subnet(context, subnet_id)"},{"line_number":1383,"context_line":"                        prefix \u003d subnet[\u0027cidr\u0027]"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAATn%2F8nzo%3D","line":1380,"in_reply_to":"AAAATn%2F85Lg%3D","updated":"2013-12-24 07:39:20.000000000","message":"Done","commit_id":"bcaa8fe99fa0e8403a788ba8a5b87e1ac7fee30d"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"7c83afda9c761e501b8188246cbd1fe3e8e5af54","unresolved":false,"context_lines":[{"line_number":397,"context_line":"                ipv6_address_mode \u003d subnet[\u0027ipv6_address_mode\u0027]"},{"line_number":398,"context_line":"                mode_values \u003d [ipv6_ra_mode, ipv6_address_mode]"},{"line_number":399,"context_line":"                if any(value in mode_values for value in"},{"line_number":400,"context_line":"                       [constants.DHCPV6_STATELESS, constants.IPV6_SLAAC]):"},{"line_number":401,"context_line":"                    return {\u0027ip_address\u0027: None, \u0027subnet_id\u0027: subnet[\u0027id\u0027]}"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"            ip_address \u003d range[\u0027first_ip\u0027]"}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAAUX%2F%2ByKw%3D","line":400,"updated":"2014-02-19 03:43:05.000000000","message":"I think we also need to add condition that both ipv6_ra_mode and ipv6_address_mode are \"None\" values here. In this case, the ip address is still a \"calculated\" value since VM obtains IPv6 address from external router using SLAAC.\n\nI also would like to hear other reviewers\u0027 opinions on this.","commit_id":"e6c6001dc00c426387cba71c020802ffe0df8615"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"aeede1371be5152744f19e5aee59168ce77e9444","unresolved":false,"context_lines":[{"line_number":397,"context_line":"                ipv6_address_mode \u003d subnet[\u0027ipv6_address_mode\u0027]"},{"line_number":398,"context_line":"                mode_values \u003d [ipv6_ra_mode, ipv6_address_mode]"},{"line_number":399,"context_line":"                if any(value in mode_values for value in"},{"line_number":400,"context_line":"                       [constants.DHCPV6_STATELESS, constants.IPV6_SLAAC]):"},{"line_number":401,"context_line":"                    return {\u0027ip_address\u0027: None, \u0027subnet_id\u0027: subnet[\u0027id\u0027]}"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"            ip_address \u003d range[\u0027first_ip\u0027]"}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAAUX%2F%2Bxb4%3D","line":400,"in_reply_to":"AAAAUX%2F%2ByKw%3D","updated":"2014-02-19 06:19:18.000000000","message":"Both ipv6_ra_mode and ipv6_address_mode are \"None\", its meaning OpenStack do not launch dnsmasq, in this case, the ip address maybe is a \"calculated\" address, but it is not controlled by OpenStack. Just like IPv4, when \"--enable-dhcp\" is false, then OpenStack do not launch dnsmasq,  the booted instance maybe can obtain ip address, if enabled external router that have dhcp enabled.","commit_id":"e6c6001dc00c426387cba71c020802ffe0df8615"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"7c83afda9c761e501b8188246cbd1fe3e8e5af54","unresolved":false,"context_lines":[{"line_number":1347,"context_line":"                    ip_address \u003d ip[\u0027ip_address\u0027]"},{"line_number":1348,"context_line":"                    subnet_id \u003d ip[\u0027subnet_id\u0027]"},{"line_number":1349,"context_line":"                    if ip_address is None:"},{"line_number":1350,"context_line":"                        # (dzyu)it means the dhcp modes is not static, the IP"},{"line_number":1351,"context_line":"                        # address needs to be generated via EUI-64 rule"},{"line_number":1352,"context_line":"                        subnet \u003d self.get_subnet(context, subnet_id)"},{"line_number":1353,"context_line":"                        prefix \u003d subnet[\u0027cidr\u0027]"}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAAUX%2F%2ByNA%3D","line":1350,"updated":"2014-02-19 03:43:05.000000000","message":"Suggest to change \"dhcp modes is not static\" to \"IPv6 address is stateless\", since we don\u0027t have static value for ipv6 mode attributes anymore.","commit_id":"e6c6001dc00c426387cba71c020802ffe0df8615"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"aeede1371be5152744f19e5aee59168ce77e9444","unresolved":false,"context_lines":[{"line_number":1347,"context_line":"                    ip_address \u003d ip[\u0027ip_address\u0027]"},{"line_number":1348,"context_line":"                    subnet_id \u003d ip[\u0027subnet_id\u0027]"},{"line_number":1349,"context_line":"                    if ip_address is None:"},{"line_number":1350,"context_line":"                        # (dzyu)it means the dhcp modes is not static, the IP"},{"line_number":1351,"context_line":"                        # address needs to be generated via EUI-64 rule"},{"line_number":1352,"context_line":"                        subnet \u003d self.get_subnet(context, subnet_id)"},{"line_number":1353,"context_line":"                        prefix \u003d subnet[\u0027cidr\u0027]"}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAAUX%2F%2Bxbo%3D","line":1350,"in_reply_to":"AAAAUX%2F%2ByNA%3D","updated":"2014-02-19 06:19:18.000000000","message":"Will do it","commit_id":"e6c6001dc00c426387cba71c020802ffe0df8615"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"afb665c76261e70c9a5d688a16807b98d65a5adb","unresolved":false,"context_lines":[{"line_number":397,"context_line":"                ipv6_address_mode \u003d subnet[\u0027ipv6_address_mode\u0027]"},{"line_number":398,"context_line":"                mode_values \u003d [ipv6_ra_mode, ipv6_address_mode]"},{"line_number":399,"context_line":"                if any(value in mode_values for value in"},{"line_number":400,"context_line":"                       [constants.DHCPV6_STATELESS, constants.IPV6_SLAAC]):"},{"line_number":401,"context_line":"                    return {\u0027ip_address\u0027: None, \u0027subnet_id\u0027: subnet[\u0027id\u0027]}"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"            ip_address \u003d range[\u0027first_ip\u0027]"}],"source_content_type":"text/x-python","patch_set":21,"id":"AAAAUX%2F%2Bc3Q%3D","line":400,"updated":"2014-02-21 03:44:45.000000000","message":"Even if we don\u0027t need to start dnsmasq and pass the IP to dnsmasq when both mode is \"OFF\", we still need a IPv6 address generated for neutron. I think we need to do the calculation if not \"fix IP\" or \"DHCP stateful\". Thoughts?","commit_id":"ba2f7288ad1c2e66d5c842c49ebd90a6ef6ee5dd"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"1288aef0318349414ca9cbeecbe926e709de9234","unresolved":false,"context_lines":[{"line_number":385,"context_line":"                ipv6_address_mode \u003d subnet[\u0027ipv6_address_mode\u0027]"},{"line_number":386,"context_line":"                mode_values \u003d [ipv6_ra_mode, ipv6_address_mode]"},{"line_number":387,"context_line":"                if constants.DHCPV6_STATEFUL not in mode_values:"},{"line_number":388,"context_line":"                    return {\u0027ip_address\u0027: None, \u0027subnet_id\u0027: subnet[\u0027id\u0027]}"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"            ip_address \u003d range[\u0027first_ip\u0027]"},{"line_number":391,"context_line":"            LOG.debug(_(\"Allocated IP - %(ip_address)s from %(first_ip)s \""}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAVn%2F%2F%2FXo%3D","line":388,"updated":"2014-03-02 22:02:44.000000000","message":"I\u0027m not entirely sure it would be a good idea to return without letting the routine complete management of IP allocation ranges.\n\nI understand you\u0027re not generating anything here, and you\u0027re not using the ranges at all.\n\nThen perhaps having a completely different method would be better, as you wont\u0027 have for instance to execute a locking query for a table which you would not use anyway.","commit_id":"7043ba75558295b8582530efb1a0aa7da73e573f"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"ee8918a6fda06b8eac577f4802db0fcb6f16cb63","unresolved":false,"context_lines":[{"line_number":385,"context_line":"                ipv6_address_mode \u003d subnet[\u0027ipv6_address_mode\u0027]"},{"line_number":386,"context_line":"                mode_values \u003d [ipv6_ra_mode, ipv6_address_mode]"},{"line_number":387,"context_line":"                if constants.DHCPV6_STATEFUL not in mode_values:"},{"line_number":388,"context_line":"                    return {\u0027ip_address\u0027: None, \u0027subnet_id\u0027: subnet[\u0027id\u0027]}"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"            ip_address \u003d range[\u0027first_ip\u0027]"},{"line_number":391,"context_line":"            LOG.debug(_(\"Allocated IP - %(ip_address)s from %(first_ip)s \""}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAVn%2F%2FkbY%3D","line":388,"in_reply_to":"AAAAVn%2F%2F%2FXo%3D","updated":"2014-03-05 10:20:53.000000000","message":"Agreed. The IP address is not \"generated\" and this part of code is inside \"_try_generate_ip\" method. Suggest to write a different method and call that instead in line 688.","commit_id":"7043ba75558295b8582530efb1a0aa7da73e573f"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"1852fd8122b30e11474a642d8f576b5a92c75da3","unresolved":false,"context_lines":[{"line_number":1353,"context_line":"                        # address needs to be generated via EUI-64 rule"},{"line_number":1354,"context_line":"                        subnet \u003d self.get_subnet(context, subnet_id)"},{"line_number":1355,"context_line":"                        prefix \u003d subnet[\u0027cidr\u0027]"},{"line_number":1356,"context_line":"                        ip_address \u003d ipv6.get_ipv6_addr_by_EUI64("},{"line_number":1357,"context_line":"                            prefix, mac_address)"},{"line_number":1358,"context_line":"                    LOG.debug(_(\"Allocated IP %(ip_address)s \""},{"line_number":1359,"context_line":"                                \"(%(network_id)s/%(subnet_id)s/%(port_id)s)\"),"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAVn%2F%2FkfY%3D","line":1356,"updated":"2014-03-05 10:13:11.000000000","message":"The ip_address here is IPAddress object and it is passed to IPAllocation directly in lin 1364. The creation of IPAllocation will fail and this is causing many jenkins failures.","commit_id":"b1a444f1a73abe42319f0e47d443a6efc7428f55"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"41bb47d3960a442a2499630152a7d1a2b9863668","unresolved":false,"context_lines":[{"line_number":835,"context_line":"        if ra_mode !\u003d address_mode:"},{"line_number":836,"context_line":"            msg \u003d _(\"IPV6_RA_MODE of \u0027%(ra_mode)s\u0027 and IPV6_ADDRESS_MODE of \""},{"line_number":837,"context_line":"                    \"\u0027%(addr_mode)s\u0027 is not a valid combination.\")"},{"line_number":838,"context_line":"            return msg % {\u0027ra_mode\u0027: ra_mode, \u0027addr_mode\u0027: address_mode}"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":"    def _validate_ipv6_mode_combination(self, ra_mode, address_mode):"},{"line_number":841,"context_line":"        # If both attributes are set, they must be the same."}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAVn%2F%2FZL0%3D","side":"PARENT","line":838,"updated":"2014-03-06 11:49:51.000000000","message":"is it related to this change?","commit_id":"3d8423b77c29ce3990e03657ef4e4a90c1e40715"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"273c9c20e0a13434643286c8aeb3c7f88328dd76","unresolved":false,"context_lines":[{"line_number":835,"context_line":"        if ra_mode !\u003d address_mode:"},{"line_number":836,"context_line":"            msg \u003d _(\"IPV6_RA_MODE of \u0027%(ra_mode)s\u0027 and IPV6_ADDRESS_MODE of \""},{"line_number":837,"context_line":"                    \"\u0027%(addr_mode)s\u0027 is not a valid combination.\")"},{"line_number":838,"context_line":"            return msg % {\u0027ra_mode\u0027: ra_mode, \u0027addr_mode\u0027: address_mode}"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":"    def _validate_ipv6_mode_combination(self, ra_mode, address_mode):"},{"line_number":841,"context_line":"        # If both attributes are set, they must be the same."}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAVn%2F%2FSRw%3D","side":"PARENT","line":838,"in_reply_to":"AAAAVn%2F%2FZL0%3D","updated":"2014-03-07 02:11:53.000000000","message":"I found this method is same as next method in L840, so remove it to avoid error","commit_id":"3d8423b77c29ce3990e03657ef4e4a90c1e40715"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"14d5b431fcb92340e822c9018949d3db015a0831","unresolved":false,"context_lines":[{"line_number":835,"context_line":"        if ra_mode !\u003d address_mode:"},{"line_number":836,"context_line":"            msg \u003d _(\"IPV6_RA_MODE of \u0027%(ra_mode)s\u0027 and IPV6_ADDRESS_MODE of \""},{"line_number":837,"context_line":"                    \"\u0027%(addr_mode)s\u0027 is not a valid combination.\")"},{"line_number":838,"context_line":"            return msg % {\u0027ra_mode\u0027: ra_mode, \u0027addr_mode\u0027: address_mode}"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":"    def _validate_ipv6_mode_combination(self, ra_mode, address_mode):"},{"line_number":841,"context_line":"        # If both attributes are set, they must be the same."}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAVn%2F%2FSLU%3D","side":"PARENT","line":838,"in_reply_to":"AAAAVn%2F%2FZL0%3D","updated":"2014-03-07 02:37:56.000000000","message":"Should be a mistake when rebase the parent patch.","commit_id":"3d8423b77c29ce3990e03657ef4e4a90c1e40715"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"41bb47d3960a442a2499630152a7d1a2b9863668","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        return NeutronDbPluginV2._try_generate_ip(context, subnets, useFixedIp)"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    @staticmethod"},{"line_number":363,"context_line":"    def _try_generate_ip(context, subnets, useFixedIp):"},{"line_number":364,"context_line":"        \"\"\"Generate an IP address."},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        The IP address will be generated from one of the subnets defined on"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAVn%2F%2FZJU%3D","line":363,"updated":"2014-03-06 11:49:51.000000000","message":"As described below, argument name \u0027useFixedIp\u0027 looks confusing.\nIt is because (1) there is a case where fixed IP address is assigned even if useFixedIp is False and (2) \"fixed IP address\" in OpenStack context is an IP address which is allocated to an instance (port) and is not change until the instance is deleted.\n\nIn my understanding, IP address assigned by EUI64 rule is also \"fixed IP\" (in the OpenStack context described above). Is it correct?","commit_id":"e8817bc92ca6b576600da50ac2a1402cf19858a7"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"14d5b431fcb92340e822c9018949d3db015a0831","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        return NeutronDbPluginV2._try_generate_ip(context, subnets, useFixedIp)"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    @staticmethod"},{"line_number":363,"context_line":"    def _try_generate_ip(context, subnets, useFixedIp):"},{"line_number":364,"context_line":"        \"\"\"Generate an IP address."},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        The IP address will be generated from one of the subnets defined on"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAVn%2F%2FSMU%3D","line":363,"in_reply_to":"AAAAVn%2F%2FZJU%3D","updated":"2014-03-07 02:37:56.000000000","message":"Akihiro, agreed, this param has been moved in the following patch. \n\nBTW, I am not sure if we should call stateless auto configuration IP address \"Fixed IP\".","commit_id":"e8817bc92ca6b576600da50ac2a1402cf19858a7"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"273c9c20e0a13434643286c8aeb3c7f88328dd76","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        return NeutronDbPluginV2._try_generate_ip(context, subnets, useFixedIp)"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    @staticmethod"},{"line_number":363,"context_line":"    def _try_generate_ip(context, subnets, useFixedIp):"},{"line_number":364,"context_line":"        \"\"\"Generate an IP address."},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        The IP address will be generated from one of the subnets defined on"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAVn%2F%2FSRo%3D","line":363,"in_reply_to":"AAAAVn%2F%2FZJU%3D","updated":"2014-03-07 02:11:53.000000000","message":"Will change the logic","commit_id":"e8817bc92ca6b576600da50ac2a1402cf19858a7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"41bb47d3960a442a2499630152a7d1a2b9863668","unresolved":false,"context_lines":[{"line_number":378,"context_line":"                continue"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"            ip_version \u003d subnet[\u0027ip_version\u0027]"},{"line_number":381,"context_line":"            if not useFixedIp and ip_version \u003d\u003d 6:"},{"line_number":382,"context_line":"                # (dzyu) When useFixedIP is True, do not need generate IP"},{"line_number":383,"context_line":"                # address by EUI64, just use provided fixed ip."},{"line_number":384,"context_line":"                ipv6_ra_mode \u003d subnet[\u0027ipv6_ra_mode\u0027]"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAVn%2F%2FZPc%3D","line":381,"updated":"2014-03-06 11:49:51.000000000","message":"I have two questions on this logic:\n\n(1)\nIs there a case where one network has multiple IPv6 subnets and these IPv6 subnets have different configuration IPv6 RA/address modes? We cannot know the order of the subnets because it depends on a result of db query.\n\nIf we allow different IPv6 address modes for subnets on a network, the behavior depends on db query result and it can vary case by case. It leads to inconsistent behavior. \n\nIn a case where we don\u0027t allow it, subnet_id varies depending on db query result. Is it okay?\n\n(2)\nThis logic is placed after range_query at L.373. It means that if all IPs of a subnet are used this logic isn\u0027t called. Is it an intended behavior? I am not sure it is intended or not.","commit_id":"e8817bc92ca6b576600da50ac2a1402cf19858a7"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"14d5b431fcb92340e822c9018949d3db015a0831","unresolved":false,"context_lines":[{"line_number":378,"context_line":"                continue"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"            ip_version \u003d subnet[\u0027ip_version\u0027]"},{"line_number":381,"context_line":"            if not useFixedIp and ip_version \u003d\u003d 6:"},{"line_number":382,"context_line":"                # (dzyu) When useFixedIP is True, do not need generate IP"},{"line_number":383,"context_line":"                # address by EUI64, just use provided fixed ip."},{"line_number":384,"context_line":"                ipv6_ra_mode \u003d subnet[\u0027ipv6_ra_mode\u0027]"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAVn%2F%2FSLw%3D","line":381,"in_reply_to":"AAAAVn%2F%2FZPc%3D","updated":"2014-03-07 02:37:56.000000000","message":"Akihiro, the code has been refactored in the following patch and now line 373 is not called before IPv6 stateless IP is calculated.\n\nTo your question (1):\nYes. this is a case where multiple subnet has different RA/address mode in one network. Therefore the code has been changed to decide if need calculation based on subnet\u0027s RA/address mode instead of useFixedIP.","commit_id":"e8817bc92ca6b576600da50ac2a1402cf19858a7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"41bb47d3960a442a2499630152a7d1a2b9863668","unresolved":false,"context_lines":[{"line_number":385,"context_line":"                ipv6_address_mode \u003d subnet[\u0027ipv6_address_mode\u0027]"},{"line_number":386,"context_line":"                mode_values \u003d [ipv6_ra_mode, ipv6_address_mode]"},{"line_number":387,"context_line":"                if constants.DHCPV6_STATEFUL not in mode_values:"},{"line_number":388,"context_line":"                    return {\u0027ip_address\u0027: None, \u0027subnet_id\u0027: subnet[\u0027id\u0027]}"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"            ip_address \u003d range[\u0027first_ip\u0027]"},{"line_number":391,"context_line":"            LOG.debug(_(\"Allocated IP - %(ip_address)s from %(first_ip)s \""}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAVn%2F%2FZUA%3D","line":388,"updated":"2014-03-06 11:49:51.000000000","message":"I think we cannot return immediately here. It is inside of subnet for-loop. If it returns here, the remaining subnets are not processed.","commit_id":"e8817bc92ca6b576600da50ac2a1402cf19858a7"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"14d5b431fcb92340e822c9018949d3db015a0831","unresolved":false,"context_lines":[{"line_number":385,"context_line":"                ipv6_address_mode \u003d subnet[\u0027ipv6_address_mode\u0027]"},{"line_number":386,"context_line":"                mode_values \u003d [ipv6_ra_mode, ipv6_address_mode]"},{"line_number":387,"context_line":"                if constants.DHCPV6_STATEFUL not in mode_values:"},{"line_number":388,"context_line":"                    return {\u0027ip_address\u0027: None, \u0027subnet_id\u0027: subnet[\u0027id\u0027]}"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"            ip_address \u003d range[\u0027first_ip\u0027]"},{"line_number":391,"context_line":"            LOG.debug(_(\"Allocated IP - %(ip_address)s from %(first_ip)s \""}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAVn%2F%2FSLg%3D","line":388,"in_reply_to":"AAAAVn%2F%2FZUA%3D","updated":"2014-03-07 02:37:56.000000000","message":"Agreed. This has been taken care of.","commit_id":"e8817bc92ca6b576600da50ac2a1402cf19858a7"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"273c9c20e0a13434643286c8aeb3c7f88328dd76","unresolved":false,"context_lines":[{"line_number":385,"context_line":"                ipv6_address_mode \u003d subnet[\u0027ipv6_address_mode\u0027]"},{"line_number":386,"context_line":"                mode_values \u003d [ipv6_ra_mode, ipv6_address_mode]"},{"line_number":387,"context_line":"                if constants.DHCPV6_STATEFUL not in mode_values:"},{"line_number":388,"context_line":"                    return {\u0027ip_address\u0027: None, \u0027subnet_id\u0027: subnet[\u0027id\u0027]}"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"            ip_address \u003d range[\u0027first_ip\u0027]"},{"line_number":391,"context_line":"            LOG.debug(_(\"Allocated IP - %(ip_address)s from %(first_ip)s \""}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAVn%2F%2FSRU%3D","line":388,"in_reply_to":"AAAAVn%2F%2FZUA%3D","updated":"2014-03-07 02:11:53.000000000","message":"will change it","commit_id":"e8817bc92ca6b576600da50ac2a1402cf19858a7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"41bb47d3960a442a2499630152a7d1a2b9863668","unresolved":false,"context_lines":[{"line_number":684,"context_line":"            for subnets in version_subnets:"},{"line_number":685,"context_line":"                if subnets:"},{"line_number":686,"context_line":"                    # (dzyu) fixed_configured\u003dFalse, it means does not use"},{"line_number":687,"context_line":"                    # the fixed IP addresses, so set useFixedIp\u003dFalse"},{"line_number":688,"context_line":"                    result \u003d NeutronDbPluginV2._generate_ip(context,"},{"line_number":689,"context_line":"                                                            subnets, False)"},{"line_number":690,"context_line":"                    ips.append({\u0027ip_address\u0027: result[\u0027ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAVn%2F%2FZNQ%3D","line":687,"updated":"2014-03-06 11:49:51.000000000","message":"At a glance, this comment looks incorrect.\n\nIn OpenStack context, fixed IP address is an IP address assigned to an instance. It is a contrast to floating IP. Thus IP address allocated by _generate_ip() at L.689 is also an fixed IP address.\n\u0027fixed_configured\u0027 above just means that a user request a specific fixed address in a request. It does not mean that fixed IP address is not used, so naming of \u0027useFixedIp\u0027 looks strange.","commit_id":"e8817bc92ca6b576600da50ac2a1402cf19858a7"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"273c9c20e0a13434643286c8aeb3c7f88328dd76","unresolved":false,"context_lines":[{"line_number":684,"context_line":"            for subnets in version_subnets:"},{"line_number":685,"context_line":"                if subnets:"},{"line_number":686,"context_line":"                    # (dzyu) fixed_configured\u003dFalse, it means does not use"},{"line_number":687,"context_line":"                    # the fixed IP addresses, so set useFixedIp\u003dFalse"},{"line_number":688,"context_line":"                    result \u003d NeutronDbPluginV2._generate_ip(context,"},{"line_number":689,"context_line":"                                                            subnets, False)"},{"line_number":690,"context_line":"                    ips.append({\u0027ip_address\u0027: result[\u0027ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAVn%2F%2FSRc%3D","line":687,"in_reply_to":"AAAAVn%2F%2FZNQ%3D","updated":"2014-03-07 02:11:53.000000000","message":"Will change the logic","commit_id":"e8817bc92ca6b576600da50ac2a1402cf19858a7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"41bb47d3960a442a2499630152a7d1a2b9863668","unresolved":false,"context_lines":[{"line_number":1349,"context_line":"                    ip_address \u003d ip[\u0027ip_address\u0027]"},{"line_number":1350,"context_line":"                    subnet_id \u003d ip[\u0027subnet_id\u0027]"},{"line_number":1351,"context_line":"                    if ip_address is None:"},{"line_number":1352,"context_line":"                        # (dzyu)it means the dhcp modes is not static, the IP"},{"line_number":1353,"context_line":"                        # address needs to be generated via EUI-64 rule"},{"line_number":1354,"context_line":"                        subnet \u003d self.get_subnet(context, subnet_id)"},{"line_number":1355,"context_line":"                        prefix \u003d subnet[\u0027cidr\u0027]"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAVn%2F%2FZMc%3D","line":1352,"updated":"2014-03-06 11:49:51.000000000","message":"Please mention it is related to IPv6 address allocation, e.g., IPv6 dhcp mode is not static.","commit_id":"e8817bc92ca6b576600da50ac2a1402cf19858a7"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"273c9c20e0a13434643286c8aeb3c7f88328dd76","unresolved":false,"context_lines":[{"line_number":1349,"context_line":"                    ip_address \u003d ip[\u0027ip_address\u0027]"},{"line_number":1350,"context_line":"                    subnet_id \u003d ip[\u0027subnet_id\u0027]"},{"line_number":1351,"context_line":"                    if ip_address is None:"},{"line_number":1352,"context_line":"                        # (dzyu)it means the dhcp modes is not static, the IP"},{"line_number":1353,"context_line":"                        # address needs to be generated via EUI-64 rule"},{"line_number":1354,"context_line":"                        subnet \u003d self.get_subnet(context, subnet_id)"},{"line_number":1355,"context_line":"                        prefix \u003d subnet[\u0027cidr\u0027]"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAVn%2F%2FSRk%3D","line":1352,"in_reply_to":"AAAAVn%2F%2FZMc%3D","updated":"2014-03-07 02:11:53.000000000","message":"Will done","commit_id":"e8817bc92ca6b576600da50ac2a1402cf19858a7"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"e9a23c579e29a66ee8b0b934797d71859ee86e2a","unresolved":false,"context_lines":[{"line_number":351,"context_line":""},{"line_number":352,"context_line":"    @staticmethod"},{"line_number":353,"context_line":"    def _check_if_need_calculate(subnet):"},{"line_number":354,"context_line":"        \"\"\"Validate that ipv6 address if need to be calculated by"},{"line_number":355,"context_line":"            mac address and network prefix."},{"line_number":356,"context_line":"        \"\"\""},{"line_number":357,"context_line":"        if subnet[\u0027ip_version\u0027] \u003d\u003d 6:"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAVn%2F%2FYhc%3D","line":354,"updated":"2014-03-06 13:46:27.000000000","message":"Nit: PEP257, one line summary docstring with period and then blank line and any additional docstring lines.","commit_id":"c9c5cd8d331947aec0abc8f8249906bd82a72eb4"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"ba247ed868f8c5b0dc960f98a186244fc2f2e008","unresolved":false,"context_lines":[{"line_number":351,"context_line":""},{"line_number":352,"context_line":"    @staticmethod"},{"line_number":353,"context_line":"    def _check_if_need_calculate(subnet):"},{"line_number":354,"context_line":"        \"\"\"Validate that ipv6 address if need to be calculated by"},{"line_number":355,"context_line":"            mac address and network prefix."},{"line_number":356,"context_line":"        \"\"\""},{"line_number":357,"context_line":"        if subnet[\u0027ip_version\u0027] \u003d\u003d 6:"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAVn%2F%2FSQA%3D","line":354,"in_reply_to":"AAAAVn%2F%2FYhc%3D","updated":"2014-03-07 05:53:06.000000000","message":"Will do it","commit_id":"c9c5cd8d331947aec0abc8f8249906bd82a72eb4"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"b38a9a982da3ee45b775c3fd20baa6dfcd5ef4dd","unresolved":false,"context_lines":[{"line_number":684,"context_line":"            version_subnets \u003d [v4, v6]"},{"line_number":685,"context_line":"            for subnets in version_subnets:"},{"line_number":686,"context_line":"                if subnets:"},{"line_number":687,"context_line":"                    for subnet in subnets:"},{"line_number":688,"context_line":"                        needCalculate \u003d self._check_if_need_calculate(subnet)"},{"line_number":689,"context_line":"                        if needCalculate:"},{"line_number":690,"context_line":"                            #(dzyu) If is true, need calculate ip v6 address"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAVn%2F%2FSNU%3D","line":687,"updated":"2014-03-07 02:45:39.000000000","message":"Since we need calculation only for v6 network, I think we can move the following added code above to between line 684 and 685 and only loop the v6 subnets.","commit_id":"c9c5cd8d331947aec0abc8f8249906bd82a72eb4"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"e9a23c579e29a66ee8b0b934797d71859ee86e2a","unresolved":false,"context_lines":[{"line_number":686,"context_line":"                if subnets:"},{"line_number":687,"context_line":"                    for subnet in subnets:"},{"line_number":688,"context_line":"                        needCalculate \u003d self._check_if_need_calculate(subnet)"},{"line_number":689,"context_line":"                        if needCalculate:"},{"line_number":690,"context_line":"                            #(dzyu) If is true, need calculate ip v6 address"},{"line_number":691,"context_line":"                            # by mac address and prefix, then remove this"},{"line_number":692,"context_line":"                            # subnet from subnets array to generate ip address"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAVn%2F%2FYhI%3D","line":689,"updated":"2014-03-06 13:46:27.000000000","message":"Could eliminate temp variable as your method is pretty descriptive.","commit_id":"c9c5cd8d331947aec0abc8f8249906bd82a72eb4"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"b38a9a982da3ee45b775c3fd20baa6dfcd5ef4dd","unresolved":false,"context_lines":[{"line_number":686,"context_line":"                if subnets:"},{"line_number":687,"context_line":"                    for subnet in subnets:"},{"line_number":688,"context_line":"                        needCalculate \u003d self._check_if_need_calculate(subnet)"},{"line_number":689,"context_line":"                        if needCalculate:"},{"line_number":690,"context_line":"                            #(dzyu) If is true, need calculate ip v6 address"},{"line_number":691,"context_line":"                            # by mac address and prefix, then remove this"},{"line_number":692,"context_line":"                            # subnet from subnets array to generate ip address"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAVn%2F%2FSJU%3D","line":689,"in_reply_to":"AAAAVn%2F%2FYhI%3D","updated":"2014-03-07 02:45:39.000000000","message":"We need some new test cases to cover the address calculation when RA/address mode is specified. \n\nConsider something like test_ip_allocation_for_ipv6_subnet_ra_mode_xxx and test_ip_allocation_for_ipv6_subnet_address_mode_xxx, which has port creation in the case.","commit_id":"c9c5cd8d331947aec0abc8f8249906bd82a72eb4"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"ba247ed868f8c5b0dc960f98a186244fc2f2e008","unresolved":false,"context_lines":[{"line_number":686,"context_line":"                if subnets:"},{"line_number":687,"context_line":"                    for subnet in subnets:"},{"line_number":688,"context_line":"                        needCalculate \u003d self._check_if_need_calculate(subnet)"},{"line_number":689,"context_line":"                        if needCalculate:"},{"line_number":690,"context_line":"                            #(dzyu) If is true, need calculate ip v6 address"},{"line_number":691,"context_line":"                            # by mac address and prefix, then remove this"},{"line_number":692,"context_line":"                            # subnet from subnets array to generate ip address"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAVn%2F%2FSP8%3D","line":689,"in_reply_to":"AAAAVn%2F%2FYhI%3D","updated":"2014-03-07 05:53:06.000000000","message":"Will do it","commit_id":"c9c5cd8d331947aec0abc8f8249906bd82a72eb4"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"e9a23c579e29a66ee8b0b934797d71859ee86e2a","unresolved":false,"context_lines":[{"line_number":691,"context_line":"                            # by mac address and prefix, then remove this"},{"line_number":692,"context_line":"                            # subnet from subnets array to generate ip address"},{"line_number":693,"context_line":"                            # for other subnets."},{"line_number":694,"context_line":"                            mac \u003d p[\u0027mac_address\u0027]"},{"line_number":695,"context_line":"                            prefix \u003d subnet[\u0027cidr\u0027]"},{"line_number":696,"context_line":"                            ip_address \u003d ipv6_utils.get_ipv6_addr_by_EUI64("},{"line_number":697,"context_line":"                                                                prefix, mac)"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAVn%2F%2FYew%3D","line":694,"updated":"2014-03-06 13:46:27.000000000","message":"Is there a unit test that covers this case?","commit_id":"c9c5cd8d331947aec0abc8f8249906bd82a72eb4"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"ba247ed868f8c5b0dc960f98a186244fc2f2e008","unresolved":false,"context_lines":[{"line_number":691,"context_line":"                            # by mac address and prefix, then remove this"},{"line_number":692,"context_line":"                            # subnet from subnets array to generate ip address"},{"line_number":693,"context_line":"                            # for other subnets."},{"line_number":694,"context_line":"                            mac \u003d p[\u0027mac_address\u0027]"},{"line_number":695,"context_line":"                            prefix \u003d subnet[\u0027cidr\u0027]"},{"line_number":696,"context_line":"                            ip_address \u003d ipv6_utils.get_ipv6_addr_by_EUI64("},{"line_number":697,"context_line":"                                                                prefix, mac)"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAVn%2F%2FSPw%3D","line":694,"in_reply_to":"AAAAVn%2F%2FYew%3D","updated":"2014-03-07 05:53:06.000000000","message":"I will add the unit test","commit_id":"c9c5cd8d331947aec0abc8f8249906bd82a72eb4"}],"neutron/openstack/common/network_utils.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"224e4de463923de73d5736170fca34aa1625e596","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    return (host, None if port is None else int(port))"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"def get_ipv6_addr_by_EUI64(prefix, mac):"},{"line_number":75,"context_line":"    try:"},{"line_number":76,"context_line":"        mac64 \u003d netaddr.EUI(mac).eui64().words"},{"line_number":77,"context_line":"        int_addr \u003d int(\u0027\u0027.join([\u0027%02x\u0027 % i for i in mac64]), 16)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FJCU%3D","line":74,"updated":"2013-11-13 22:38:49.000000000","message":"Please do not add code to openstack.common libs without ensuring the code is properly upstreamed to oslo-incubator first.","commit_id":"a99705eedd92a732c72346dece3d911530a1b39e"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"65e5d973e926cc67cc5e998d87337ca26cc8cfb4","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    return (host, None if port is None else int(port))"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"def get_ipv6_addr_by_EUI64(prefix, mac):"},{"line_number":75,"context_line":"    try:"},{"line_number":76,"context_line":"        mac64 \u003d netaddr.EUI(mac).eui64().words"},{"line_number":77,"context_line":"        int_addr \u003d int(\u0027\u0027.join([\u0027%02x\u0027 % i for i in mac64]), 16)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FIPE%3D","line":74,"in_reply_to":"AAAATn%2F%2FJCU%3D","updated":"2013-11-14 03:49:03.000000000","message":"Thanks, Mark.\nSo you suggest we should create one new class such like neutron.common.ipv6 to handle ipv6 operations, is it right?\nAnd can you tell me how to apply add code to openstack.commom libs? I do not know much about oslo-incubator.","commit_id":"a99705eedd92a732c72346dece3d911530a1b39e"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"224e4de463923de73d5736170fca34aa1625e596","unresolved":false,"context_lines":[{"line_number":74,"context_line":"def get_ipv6_addr_by_EUI64(prefix, mac):"},{"line_number":75,"context_line":"    try:"},{"line_number":76,"context_line":"        mac64 \u003d netaddr.EUI(mac).eui64().words"},{"line_number":77,"context_line":"        int_addr \u003d int(\u0027\u0027.join([\u0027%02x\u0027 % i for i in mac64]), 16)"},{"line_number":78,"context_line":"        mac64_addr \u003d netaddr.IPAddress(int_addr)"},{"line_number":79,"context_line":"        maskIP \u003d netaddr.IPNetwork(prefix).ip"},{"line_number":80,"context_line":"        return (mac64_addr ^ netaddr.IPAddress(\u0027::0200:0:0:0\u0027) |"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FI7s%3D","line":77,"updated":"2013-11-13 22:38:49.000000000","message":"For wherever this code ends up... consider replacing 76-80:\n\neui64 \u003d int(netaddr.EUI(mac).eui64())\n\nprefix \u003d netaddr.IPNetwork(prefix)\n\nreturn netaddr.IPAddress(prefix.first + eui64 ^ (1\u003c\u003c57))","commit_id":"a99705eedd92a732c72346dece3d911530a1b39e"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"65e5d973e926cc67cc5e998d87337ca26cc8cfb4","unresolved":false,"context_lines":[{"line_number":74,"context_line":"def get_ipv6_addr_by_EUI64(prefix, mac):"},{"line_number":75,"context_line":"    try:"},{"line_number":76,"context_line":"        mac64 \u003d netaddr.EUI(mac).eui64().words"},{"line_number":77,"context_line":"        int_addr \u003d int(\u0027\u0027.join([\u0027%02x\u0027 % i for i in mac64]), 16)"},{"line_number":78,"context_line":"        mac64_addr \u003d netaddr.IPAddress(int_addr)"},{"line_number":79,"context_line":"        maskIP \u003d netaddr.IPNetwork(prefix).ip"},{"line_number":80,"context_line":"        return (mac64_addr ^ netaddr.IPAddress(\u0027::0200:0:0:0\u0027) |"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FIXc%3D","line":77,"in_reply_to":"AAAATn%2F%2FI7s%3D","updated":"2013-11-14 03:49:03.000000000","message":"Done, Mark, thanks for the reminder, that\u0027s more clear!","commit_id":"a99705eedd92a732c72346dece3d911530a1b39e"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"3bdeaa2acf31281a07072886c5c9ccc611781192","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        return (mac64_addr ^ netaddr.IPAddress(\u0027::0200:0:0:0\u0027) |"},{"line_number":81,"context_line":"                maskIP).format()"},{"line_number":82,"context_line":"    except netaddr.AddrFormatError:"},{"line_number":83,"context_line":"        raise TypeError(_(\u0027Bad mac for generate IPv6 address by\u0027"},{"line_number":84,"context_line":"                          \u0027EUI-64: %s\u0027) % mac)"},{"line_number":85,"context_line":"    except TypeError:"},{"line_number":86,"context_line":"        raise TypeError(_(\u0027Bad prefix for generate IPv6 address by\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FKzQ%3D","line":83,"updated":"2013-11-13 13:01:53.000000000","message":"Add space after \"by\"","commit_id":"a99705eedd92a732c72346dece3d911530a1b39e"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"65e5d973e926cc67cc5e998d87337ca26cc8cfb4","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        return (mac64_addr ^ netaddr.IPAddress(\u0027::0200:0:0:0\u0027) |"},{"line_number":81,"context_line":"                maskIP).format()"},{"line_number":82,"context_line":"    except netaddr.AddrFormatError:"},{"line_number":83,"context_line":"        raise TypeError(_(\u0027Bad mac for generate IPv6 address by\u0027"},{"line_number":84,"context_line":"                          \u0027EUI-64: %s\u0027) % mac)"},{"line_number":85,"context_line":"    except TypeError:"},{"line_number":86,"context_line":"        raise TypeError(_(\u0027Bad prefix for generate IPv6 address by\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FIb0%3D","line":83,"in_reply_to":"AAAATn%2F%2FKzQ%3D","updated":"2013-11-14 03:49:03.000000000","message":"Done","commit_id":"a99705eedd92a732c72346dece3d911530a1b39e"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"3bdeaa2acf31281a07072886c5c9ccc611781192","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        raise TypeError(_(\u0027Bad mac for generate IPv6 address by\u0027"},{"line_number":84,"context_line":"                          \u0027EUI-64: %s\u0027) % mac)"},{"line_number":85,"context_line":"    except TypeError:"},{"line_number":86,"context_line":"        raise TypeError(_(\u0027Bad prefix for generate IPv6 address by\u0027"},{"line_number":87,"context_line":"                          \u0027EUI-64: %s\u0027) % prefix)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FKzM%3D","line":86,"updated":"2013-11-13 13:01:53.000000000","message":"Add space after \"by\"","commit_id":"a99705eedd92a732c72346dece3d911530a1b39e"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"65e5d973e926cc67cc5e998d87337ca26cc8cfb4","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        raise TypeError(_(\u0027Bad mac for generate IPv6 address by\u0027"},{"line_number":84,"context_line":"                          \u0027EUI-64: %s\u0027) % mac)"},{"line_number":85,"context_line":"    except TypeError:"},{"line_number":86,"context_line":"        raise TypeError(_(\u0027Bad prefix for generate IPv6 address by\u0027"},{"line_number":87,"context_line":"                          \u0027EUI-64: %s\u0027) % prefix)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FIbs%3D","line":86,"in_reply_to":"AAAATn%2F%2FKzM%3D","updated":"2013-11-14 03:49:03.000000000","message":"Done","commit_id":"a99705eedd92a732c72346dece3d911530a1b39e"}],"neutron/tests/unit/oneconvergence/test_nvsd_plugin.py":[{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"9ac4629850505518e02ce1fd788dc18485d0f06d","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        self.skipTest(\"NVSD Plugin does not support IPV6.\")"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test_ip_allocation_for_ipv6_subnet_ra_mode(self):"},{"line_number":92,"context_line":"        self.skipTest(\"NVSD Plugin does not support IPV6.\")"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_ip_allocation_for_ipv6_subnet_address_mode(self):"},{"line_number":95,"context_line":"        self.skipTest(\"NVSD Plugin does not support IPV6.\")"}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAAVn%2F%2ByG0%3D","line":92,"updated":"2014-03-12 07:13:54.000000000","message":"These two skip tests should be put under TestOneConvergencePluginPortsV2, because in test_db_plugin, these two tests are created under TestPortsV2","commit_id":"0561ee16925d330fe799c97aa724801e6c36126e"}],"neutron/tests/unit/test_db_plugin.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"5f38e6151e019133e29e1e380a33d8aa9c85f45d","unresolved":false,"context_lines":[{"line_number":1430,"context_line":"                                       ipv6_address_mode\u003dNone)"},{"line_number":1431,"context_line":"        mac \u003d \u002712:34:56:78:ab:cd\u0027"},{"line_number":1432,"context_line":"        kwargs \u003d {\"mac_address\": mac}"},{"line_number":1433,"context_line":"        port \u003d self._make_port(self.fmt, network[\u0027network\u0027][\u0027id\u0027], **kwargs)"},{"line_number":1434,"context_line":"        # Check if ipv6 address are allocated correctly"},{"line_number":1435,"context_line":"        ips \u003d port[\u0027port\u0027][\u0027fixed_ips\u0027]"},{"line_number":1436,"context_line":"        self.assertEqual(len(ips), 2)"}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAAVn%2F%2FEBQ%3D","line":1433,"updated":"2014-03-10 09:36:17.000000000","message":"nit: why not simply  mac\u003d\u002712:34:56:78:ab:cd\u0027 ?","commit_id":"0561ee16925d330fe799c97aa724801e6c36126e"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"0f8d4a8554f071f140cf8d1d886de86257dd82cf","unresolved":false,"context_lines":[{"line_number":1430,"context_line":"                                       ipv6_address_mode\u003dNone)"},{"line_number":1431,"context_line":"        mac \u003d \u002712:34:56:78:ab:cd\u0027"},{"line_number":1432,"context_line":"        kwargs \u003d {\"mac_address\": mac}"},{"line_number":1433,"context_line":"        port \u003d self._make_port(self.fmt, network[\u0027network\u0027][\u0027id\u0027], **kwargs)"},{"line_number":1434,"context_line":"        # Check if ipv6 address are allocated correctly"},{"line_number":1435,"context_line":"        ips \u003d port[\u0027port\u0027][\u0027fixed_ips\u0027]"},{"line_number":1436,"context_line":"        self.assertEqual(len(ips), 2)"}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAAWH%2F%2F3ag%3D","line":1433,"in_reply_to":"AAAAVn%2F%2ByLg%3D","updated":"2014-03-13 09:37:52.000000000","message":"Shouldn\u0027t it work even if it\u0027s not a predefined parameter, it would be put in the kw args of the _make_port?,\n\nCould you try it?.","commit_id":"0561ee16925d330fe799c97aa724801e6c36126e"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"c50a97beae1321e2ad72c702e5d7fcc96ffe040c","unresolved":false,"context_lines":[{"line_number":1430,"context_line":"                                       ipv6_address_mode\u003dNone)"},{"line_number":1431,"context_line":"        mac \u003d \u002712:34:56:78:ab:cd\u0027"},{"line_number":1432,"context_line":"        kwargs \u003d {\"mac_address\": mac}"},{"line_number":1433,"context_line":"        port \u003d self._make_port(self.fmt, network[\u0027network\u0027][\u0027id\u0027], **kwargs)"},{"line_number":1434,"context_line":"        # Check if ipv6 address are allocated correctly"},{"line_number":1435,"context_line":"        ips \u003d port[\u0027port\u0027][\u0027fixed_ips\u0027]"},{"line_number":1436,"context_line":"        self.assertEqual(len(ips), 2)"}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAAVn%2F%2ByLg%3D","line":1433,"in_reply_to":"AAAAVn%2F%2FEBQ%3D","updated":"2014-03-12 06:53:58.000000000","message":"you mean by passing mac\u003d\u002712:34:56:78:ab:cd\u0027  to _make_port?  I don\u0027t think mac is a defined parameter of _make_port. Will that work?","commit_id":"0561ee16925d330fe799c97aa724801e6c36126e"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"5f38e6151e019133e29e1e380a33d8aa9c85f45d","unresolved":false,"context_lines":[{"line_number":1460,"context_line":"            ipv6_address_mode\u003dconstants.DHCPV6_STATEFUL)"},{"line_number":1461,"context_line":"        mac \u003d \u002712:34:56:78:ab:cd\u0027"},{"line_number":1462,"context_line":"        kwargs \u003d {\"mac_address\": mac}"},{"line_number":1463,"context_line":"        port \u003d self._make_port(self.fmt, network[\u0027network\u0027][\u0027id\u0027], **kwargs)"},{"line_number":1464,"context_line":"        # Check if ipv6 address are allocated correctly"},{"line_number":1465,"context_line":"        ips \u003d port[\u0027port\u0027][\u0027fixed_ips\u0027]"},{"line_number":1466,"context_line":"        self.assertEqual(len(ips), 2)"}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAAVn%2F%2FEAE%3D","line":1463,"updated":"2014-03-10 09:36:17.000000000","message":"same nit.","commit_id":"0561ee16925d330fe799c97aa724801e6c36126e"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"406dc6125af381b0287915f64042d48c5fc7f0da","unresolved":false,"context_lines":[{"line_number":1430,"context_line":"                                       ipv6_address_mode\u003dNone)"},{"line_number":1431,"context_line":"        mac \u003d \u002712:34:56:78:ab:cd\u0027"},{"line_number":1432,"context_line":"        kwargs \u003d {\"mac_address\": mac}"},{"line_number":1433,"context_line":"        port \u003d self._make_port(self.fmt, network[\u0027network\u0027][\u0027id\u0027], **kwargs)"},{"line_number":1434,"context_line":"        # Check if ipv6 address are allocated correctly"},{"line_number":1435,"context_line":"        ips \u003d port[\u0027port\u0027][\u0027fixed_ips\u0027]"},{"line_number":1436,"context_line":"        self.assertEqual(len(ips), 2)"}],"source_content_type":"text/x-python","patch_set":33,"id":"AAAAWH%2F%2FiuE%3D","line":1433,"updated":"2014-03-17 07:36:40.000000000","message":"You can really omit the \nmac \u003d \nkwargs \u003d \n**kwargs \nsteps...\n\n\n\u003e\u003e\u003e def test_kwargs(a,**kwargs):\n\n...     print a,kwargs\n\n... \n\n\u003e\u003e\u003e test_kwargs(\u0027a\u0027,mac\u003d\u002711:22:33:44:55:66\u0027,test\u003d\u0027abcde\u0027)\n\na {\u0027test\u0027: \u0027abcde\u0027, \u0027mac\u0027: \u002711:22:33:44:55:66\u0027}\n\n\n\nNot enough for a -1, you\u0027re doing a good work, but less lines generally \u003d more clear tests.","commit_id":"dbe08cde6ce28ab5a8c4ef66c4f82e41ac2f0019"}],"neutron/tests/unit/test_ipv6.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"9efe728b670fedd92e83bcc4acde8a48aaebfd91","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright (c) 2012 OpenStack Foundation."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FLGE%3D","line":3,"updated":"2013-11-13 11:28:05.000000000","message":"nit: 2013","commit_id":"a99705eedd92a732c72346dece3d911530a1b39e"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"65e5d973e926cc67cc5e998d87337ca26cc8cfb4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright (c) 2012 OpenStack Foundation."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FIcI%3D","line":3,"in_reply_to":"AAAATn%2F%2FLGE%3D","updated":"2013-11-14 03:49:03.000000000","message":"Done","commit_id":"a99705eedd92a732c72346dece3d911530a1b39e"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"3bdeaa2acf31281a07072886c5c9ccc611781192","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class IPv6byEUI64TestCase(base.BaseTestCase):"},{"line_number":25,"context_line":"    \"\"\"Unit tests for generate IPv6 by EUI-64 operations.\"\"\""},{"line_number":26,"context_line":"    def setUp(self):"},{"line_number":27,"context_line":"        super(IPv6byEUI64TestCase, self).setUp()"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FKyk%3D","line":25,"updated":"2013-11-13 13:01:53.000000000","message":"Nit: PEP257, add space before and after docstring for a class.","commit_id":"a99705eedd92a732c72346dece3d911530a1b39e"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"65e5d973e926cc67cc5e998d87337ca26cc8cfb4","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class IPv6byEUI64TestCase(base.BaseTestCase):"},{"line_number":25,"context_line":"    \"\"\"Unit tests for generate IPv6 by EUI-64 operations.\"\"\""},{"line_number":26,"context_line":"    def setUp(self):"},{"line_number":27,"context_line":"        super(IPv6byEUI64TestCase, self).setUp()"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FIcA%3D","line":25,"in_reply_to":"AAAATn%2F%2FKyk%3D","updated":"2013-11-14 03:49:03.000000000","message":"Done","commit_id":"a99705eedd92a732c72346dece3d911530a1b39e"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"9efe728b670fedd92e83bcc4acde8a48aaebfd91","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class IPv6byEUI64TestCase(base.BaseTestCase):"},{"line_number":25,"context_line":"    \"\"\"Unit tests for generate IPv6 by EUI-64 operations.\"\"\""},{"line_number":26,"context_line":"    def setUp(self):"},{"line_number":27,"context_line":"        super(IPv6byEUI64TestCase, self).setUp()"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def test_generate_IPv6_by_EUI64(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FLF4%3D","line":26,"updated":"2013-11-13 11:28:05.000000000","message":"seems setUp() is not needed","commit_id":"a99705eedd92a732c72346dece3d911530a1b39e"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"65e5d973e926cc67cc5e998d87337ca26cc8cfb4","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class IPv6byEUI64TestCase(base.BaseTestCase):"},{"line_number":25,"context_line":"    \"\"\"Unit tests for generate IPv6 by EUI-64 operations.\"\"\""},{"line_number":26,"context_line":"    def setUp(self):"},{"line_number":27,"context_line":"        super(IPv6byEUI64TestCase, self).setUp()"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def test_generate_IPv6_by_EUI64(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FIb4%3D","line":26,"in_reply_to":"AAAATn%2F%2FLF4%3D","updated":"2013-11-14 03:49:03.000000000","message":"Done","commit_id":"a99705eedd92a732c72346dece3d911530a1b39e"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"9efe728b670fedd92e83bcc4acde8a48aaebfd91","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    def test_generate_IPv6_by_EUI64(self):"},{"line_number":30,"context_line":"        addr \u003d network_utils.get_ipv6_addr_by_EUI64(\u00272001:db8::\u0027,"},{"line_number":31,"context_line":"                                                    \u002702:16:3e:33:44:55\u0027)"},{"line_number":32,"context_line":"        self.assertEquals(addr, \u00272001:db8::16:3eff:fe33:4455\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def test_generate_IPv6_with_bad_mac(self):"},{"line_number":35,"context_line":"        bad_mac \u003d \u002702:16:3e:33:44:5Z\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FLFw%3D","line":32,"updated":"2013-11-13 11:28:05.000000000","message":"assertEquals is deprecated, please use assertEqual. Also please put expected value as the first parameter for proper assertion failure messages.","commit_id":"a99705eedd92a732c72346dece3d911530a1b39e"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"65e5d973e926cc67cc5e998d87337ca26cc8cfb4","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    def test_generate_IPv6_by_EUI64(self):"},{"line_number":30,"context_line":"        addr \u003d network_utils.get_ipv6_addr_by_EUI64(\u00272001:db8::\u0027,"},{"line_number":31,"context_line":"                                                    \u002702:16:3e:33:44:55\u0027)"},{"line_number":32,"context_line":"        self.assertEquals(addr, \u00272001:db8::16:3eff:fe33:4455\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def test_generate_IPv6_with_bad_mac(self):"},{"line_number":35,"context_line":"        bad_mac \u003d \u002702:16:3e:33:44:5Z\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FIb8%3D","line":32,"in_reply_to":"AAAATn%2F%2FLFw%3D","updated":"2013-11-14 03:49:03.000000000","message":"Done","commit_id":"a99705eedd92a732c72346dece3d911530a1b39e"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"9f69ec9390850268537f791b024cfc51861e8b9c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright (c) 2013 OpenStack Foundation."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FC%2Fo%3D","line":3,"updated":"2013-11-15 07:40:28.000000000","message":"ditto","commit_id":"1a2f603533b5fcbf9e47ffa8e115f248e4c6c614"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"d48a6f74930538939d3a292202f6809c41a8e51b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright (c) 2013 OpenStack Foundation."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FCh4%3D","line":3,"in_reply_to":"AAAATn%2F%2FC%2Fo%3D","updated":"2013-11-15 10:18:24.000000000","message":"Done","commit_id":"1a2f603533b5fcbf9e47ffa8e115f248e4c6c614"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"9f69ec9390850268537f791b024cfc51861e8b9c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# @author: Dazhao Yu, dzyu@cn.ibm.com, IBM #"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron.common import ipv6"},{"line_number":21,"context_line":"from neutron.tests import base"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FC%2Bs%3D","line":18,"updated":"2013-11-15 07:40:28.000000000","message":"ditto","commit_id":"1a2f603533b5fcbf9e47ffa8e115f248e4c6c614"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"d48a6f74930538939d3a292202f6809c41a8e51b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# @author: Dazhao Yu, dzyu@cn.ibm.com, IBM #"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron.common import ipv6"},{"line_number":21,"context_line":"from neutron.tests import base"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FChw%3D","line":18,"in_reply_to":"AAAATn%2F%2FC%2Bs%3D","updated":"2013-11-15 10:18:24.000000000","message":"Done","commit_id":"1a2f603533b5fcbf9e47ffa8e115f248e4c6c614"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"2d4b6f92b0283e52b069317ff5ae1725c6aeea31","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def test_generate_IPv6_by_EUI64(self):"},{"line_number":28,"context_line":"        addr \u003d ipv6.get_ipv6_addr_by_EUI64(\u00272001:db8::\u0027,"},{"line_number":29,"context_line":"                                            \u002702:16:3e:33:44:55\u0027)"},{"line_number":30,"context_line":"        self.assertEqual(\u00272001:db8::16:3eff:fe33:4455\u0027, addr.format())"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def test_generate_IPv6_with_bad_mac(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FCoA%3D","line":29,"updated":"2013-11-15 09:26:06.000000000","message":"need to test mac address like \u002700:16:3e:33:44:55\u0027 to cover if Universal/Local (U/L) bit is set when generating EUI64 address.","commit_id":"1a2f603533b5fcbf9e47ffa8e115f248e4c6c614"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"7d8d00eef5bd7540d8f0330a963889a97d72f053","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        self.assertRaises(TypeError, ipv6.get_ipv6_addr_by_EUI64,"},{"line_number":40,"context_line":"                          prefix, bad_mac)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def test_geneate_IPv6_with_bad_prefix(self):"},{"line_number":43,"context_line":"        mac \u003d \u002700:16:3e:33:44:55\u0027"},{"line_number":44,"context_line":"        bad_prefix \u003d \u0027bb\u0027"},{"line_number":45,"context_line":"        self.assertRaises(TypeError, ipv6.get_ipv6_addr_by_EUI64,"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F89P4%3D","line":42,"updated":"2013-12-18 12:16:08.000000000","message":"geneate-\u003egenerate","commit_id":"2a69b72fff6c06cb0c1698887e152e96a0aa83ab"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c3df3362c88f994730914c45259782950e72f891","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 IBM Corp."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":21,"id":"AAAAUX%2F%2Bh34%3D","line":1,"updated":"2014-02-20 17:27:47.000000000","message":"Remove VIM line, update copyright date on new file. Author info?","commit_id":"ba2f7288ad1c2e66d5c842c49ebd90a6ef6ee5dd"},{"author":{"_account_id":9560,"name":"Lee Li","email":"lilinguo8212@gmail.com","username":"llg8212"},"change_message_id":"2bc33f8aed9ad71e75cac1c7f0a7b17bf150e4c6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 IBM Corp."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":21,"id":"AAAAUX%2F%2Bb3Q%3D","line":1,"in_reply_to":"AAAAUX%2F%2Bh34%3D","updated":"2014-02-21 06:19:32.000000000","message":"Yes, it doesn\u0027t needed.","commit_id":"ba2f7288ad1c2e66d5c842c49ebd90a6ef6ee5dd"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"5211d94af6bdb05a7175eebd441bfc99f1214a9b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        ipv4_prefix \u003d \u002710.0.8\u0027"},{"line_number":30,"context_line":"        mac \u003d \u002700:16:3e:33:44:55\u0027"},{"line_number":31,"context_line":"        self.assertRaises(TypeError, ipv6.get_ipv6_addr_by_EUI64,"},{"line_number":32,"context_line":"                          ipv4_prefix, mac)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def test_generate_IPv6_with_bad_mac(self):"},{"line_number":35,"context_line":"        bad_mac \u003d \u002700:16:3e:33:44:5Z\u0027"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAVX%2F%2FyWs%3D","line":32,"updated":"2014-02-28 09:44:00.000000000","message":"The context approach is more clear:\nwith self.assertRaises(TypeError):\n    ipv6.get_ipv6_addr_by_EUI64(ipv4_prefix,mac)\n\nBut I believe it doesn\u0027t work for py26, right? , what a pitty... :]\n\nNot sure if in py26 this works:\n\nself.assertRaises(TypeError, lambda: \n                                ipv6.get_ipv6_addr_by_EUI64(ipv4_prefix,mac)  )","commit_id":"7043ba75558295b8582530efb1a0aa7da73e573f"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"1288aef0318349414ca9cbeecbe926e709de9234","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        ipv4_prefix \u003d \u002710.0.8\u0027"},{"line_number":30,"context_line":"        mac \u003d \u002700:16:3e:33:44:55\u0027"},{"line_number":31,"context_line":"        self.assertRaises(TypeError, ipv6.get_ipv6_addr_by_EUI64,"},{"line_number":32,"context_line":"                          ipv4_prefix, mac)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def test_generate_IPv6_with_bad_mac(self):"},{"line_number":35,"context_line":"        bad_mac \u003d \u002700:16:3e:33:44:5Z\u0027"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAVn%2F%2F%2FX8%3D","line":32,"in_reply_to":"AAAAVX%2F%2FyWs%3D","updated":"2014-03-02 22:02:44.000000000","message":"Agreed, but for single line statements I would say that there is hardly any difference.","commit_id":"7043ba75558295b8582530efb1a0aa7da73e573f"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"7f47b4d47fde8fbd8b373118a49e218be3e019bb","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        ipv4_prefix \u003d \u002710.0.8\u0027"},{"line_number":30,"context_line":"        mac \u003d \u002700:16:3e:33:44:55\u0027"},{"line_number":31,"context_line":"        self.assertRaises(TypeError, ipv6.get_ipv6_addr_by_EUI64,"},{"line_number":32,"context_line":"                          ipv4_prefix, mac)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def test_generate_IPv6_with_bad_mac(self):"},{"line_number":35,"context_line":"        bad_mac \u003d \u002700:16:3e:33:44:5Z\u0027"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAVn%2F%2F8io%3D","line":32,"in_reply_to":"AAAAVn%2F%2F%2FX8%3D","updated":"2014-03-03 09:01:15.000000000","message":"yes, for one line you\u0027re right, there\u0027s very little difference,\n\nIt seems like more intuitive \"ipv6.get_ipv6_addr_by_EUI64(ipv4_prefix,mac) \" than being a bunch of parameters into assertRaises.\n\nBut the lambda could be confusing if you\u0027re not used to lambdas.","commit_id":"7043ba75558295b8582530efb1a0aa7da73e573f"}]}
