)]}'
{"neutron/agent/linux/keepalived.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"319ecaf51db18b508abdc73f6855032de41941a3","unresolved":false,"context_lines":[{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    \"\"\""},{"line_number":369,"context_line":"    def __init__(self, resource_id, config, process_monitor,"},{"line_number":370,"context_line":"                 conf_path\u003dtempfile.mkdtemp(), namespace\u003dNone,"},{"line_number":371,"context_line":"                 throttle_restart_value\u003dNone):"},{"line_number":372,"context_line":"        self.resource_id \u003d resource_id"},{"line_number":373,"context_line":"        self.config \u003d config"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_f76c8e37","line":370,"updated":"2018-04-18 14:13:36.000000000","message":"All callers pass conf_path, so /tmp was never being used.  I think it would be better to make this a required argument without a default value.","commit_id":"6fd0ed730773a1f6b7ab32ab9b56648652ed9169"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"af40145ee55fc14227d53f30505ba2f4241ea5d4","unresolved":false,"context_lines":[{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    \"\"\""},{"line_number":369,"context_line":"    def __init__(self, resource_id, config, process_monitor,"},{"line_number":370,"context_line":"                 conf_path\u003dtempfile.mkdtemp(), namespace\u003dNone,"},{"line_number":371,"context_line":"                 throttle_restart_value\u003dNone):"},{"line_number":372,"context_line":"        self.resource_id \u003d resource_id"},{"line_number":373,"context_line":"        self.config \u003d config"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_ba911b9c","line":370,"in_reply_to":"9f6a8fd7_f76c8e37","updated":"2018-04-18 14:25:12.000000000","message":"Max - I\u0027m saying just make this \"conf_path\", no default value.  I tried that and it passed pep8 and py27 tests as all callers were already passing a value.","commit_id":"6fd0ed730773a1f6b7ab32ab9b56648652ed9169"}],"tox.ini":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"319ecaf51db18b508abdc73f6855032de41941a3","unresolved":false,"context_lines":[{"line_number":149,"context_line":"# E402 module level import not at top of file"},{"line_number":150,"context_line":"# E731 do not assign a lambda expression, use a def"},{"line_number":151,"context_line":"# W503 line break before binary operator"},{"line_number":152,"context_line":"ignore \u003d E125,E126,E128,E129,E265,E402,E731,W503,H404,H405,N530,N534,N536"},{"line_number":153,"context_line":"# H106: Don\u0027t put vim configuration in source files"},{"line_number":154,"context_line":"# H203: Use assertIs(Not)None to check for None"},{"line_number":155,"context_line":"# H204: Use assert(Not)Equal to check for equality"}],"source_content_type":"text/x-properties","patch_set":1,"id":"9f6a8fd7_b74ff6bb","line":152,"updated":"2018-04-18 14:13:36.000000000","message":"unrelated change?","commit_id":"6fd0ed730773a1f6b7ab32ab9b56648652ed9169"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d2880797ba7192d6f8de1f7dc35181e97f8a2229","unresolved":false,"context_lines":[{"line_number":148,"context_line":"# TODO(amotoki) check the following new rules should be fixed or ignored"},{"line_number":149,"context_line":"# E402 module level import not at top of file"},{"line_number":150,"context_line":"# E731 do not assign a lambda expression, use a def"},{"line_number":151,"context_line":"ignore \u003d E125,E126,E128,E129,E265,E402,E731,W503,H404,H405,N530,N534,N536"},{"line_number":152,"context_line":"# H106: Don\u0027t put vim configuration in source files"},{"line_number":153,"context_line":"# H203: Use assertIs(Not)None to check for None"},{"line_number":154,"context_line":"# H204: Use assert(Not)Equal to check for equality"}],"source_content_type":"text/x-properties","patch_set":2,"id":"9f6a8fd7_a9ce842a","line":151,"range":{"start_line":151,"start_character":44,"end_line":151,"end_character":48},"updated":"2018-04-20 11:47:39.000000000","message":"this is also unrelated probably","commit_id":"bea7f2b78e5604879cb31758fee9be8f1a89c741"}]}
