)]}'
{"neutron/agent/common/ovs_lib.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"07bf9f4d11b3bcb0cb85559479cdd066807aaec2","unresolved":false,"context_lines":[{"line_number":286,"context_line":"                                          *interface_attr_tuples))"},{"line_number":287,"context_line":"        return self.get_port_ofport(port_name)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    def replace_port(self, port_name, *attr_tuples):"},{"line_number":290,"context_line":"        \"\"\"Replace existing port or create it, and configure port interface.\"\"\""},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        # NOTE(xiaohhui): If del_port is inside the transaction, there will"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_22fe5d05","line":289,"range":{"start_line":289,"start_character":38,"end_line":289,"end_character":50},"updated":"2018-04-30 11:05:25.000000000","message":"maybe You should split it into two lists like: \"port_attrs\" and \"interface_attrs\"?","commit_id":"783e0988ee9ac20100baf1707bf6a29060c2b7cd"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"de9a52d4c5d382b3764be1a743072eb965f12f6c","unresolved":false,"context_lines":[{"line_number":286,"context_line":"                                          *interface_attr_tuples))"},{"line_number":287,"context_line":"        return self.get_port_ofport(port_name)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    def replace_port(self, port_name, *attr_tuples):"},{"line_number":290,"context_line":"        \"\"\"Replace existing port or create it, and configure port interface.\"\"\""},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        # NOTE(xiaohhui): If del_port is inside the transaction, there will"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_02d0f94f","line":289,"range":{"start_line":289,"start_character":38,"end_line":289,"end_character":50},"in_reply_to":"9f6a8fd7_025b192e","updated":"2018-04-30 11:18:48.000000000","message":"I looks that no one except neutron use it but we can\u0027t be sure e.g. if there wasn\u0027t someone who used it in stable/queens for example.\nMaybe You can than propose it with this workaround to not break compatibility now (as You did) but add some TODO to change it later to some \"better\" solution. Than You will be able to backport patch and not breaks compatibility and we will have it fixed in future releases :) What You think?","commit_id":"783e0988ee9ac20100baf1707bf6a29060c2b7cd"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"918891521d3b14b4afe3126ce78d5241588a1231","unresolved":false,"context_lines":[{"line_number":286,"context_line":"                                          *interface_attr_tuples))"},{"line_number":287,"context_line":"        return self.get_port_ofport(port_name)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    def replace_port(self, port_name, *attr_tuples):"},{"line_number":290,"context_line":"        \"\"\"Replace existing port or create it, and configure port interface.\"\"\""},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        # NOTE(xiaohhui): If del_port is inside the transaction, there will"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_22041dc6","line":289,"range":{"start_line":289,"start_character":38,"end_line":289,"end_character":50},"in_reply_to":"9f6a8fd7_02d0f94f","updated":"2018-04-30 11:39:54.000000000","message":"That sounds like a good compromise. I will reference this conversation in the TODO","commit_id":"783e0988ee9ac20100baf1707bf6a29060c2b7cd"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"8ba70fc88e31032dbd986f8b7679fef71810c024","unresolved":false,"context_lines":[{"line_number":286,"context_line":"                                          *interface_attr_tuples))"},{"line_number":287,"context_line":"        return self.get_port_ofport(port_name)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    def replace_port(self, port_name, *attr_tuples):"},{"line_number":290,"context_line":"        \"\"\"Replace existing port or create it, and configure port interface.\"\"\""},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        # NOTE(xiaohhui): If del_port is inside the transaction, there will"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_025b192e","line":289,"range":{"start_line":289,"start_character":38,"end_line":289,"end_character":50},"in_reply_to":"9f6a8fd7_22fe5d05","updated":"2018-04-30 11:09:59.000000000","message":"I didn\u0027t want to break compatibility, but it seems like it\u0027s not super used everywhere:\n\nhttp://codesearch.openstack.org/?q\u003d.replace_port\u0026i\u003dnope\u0026files\u003d\u0026repos\u003d\n\nWhat do you think?\n\nspecially since we\u0027re backporting, I was trying to avoid API change. Are we sure nobody outside the openstack repos would be using that function?","commit_id":"783e0988ee9ac20100baf1707bf6a29060c2b7cd"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"07bf9f4d11b3bcb0cb85559479cdd066807aaec2","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        with self.ovsdb.transaction() as txn:"},{"line_number":297,"context_line":"            txn.add(self.ovsdb.add_port(self.br_name, port_name,"},{"line_number":298,"context_line":"                                        may_exist\u003dFalse))"},{"line_number":299,"context_line":"            if \u0027tag\u0027 in attr_tuples:"},{"line_number":300,"context_line":"                txn.add(self.ovsdb.db_set("},{"line_number":301,"context_line":"                    \u0027Port\u0027, port_name,"},{"line_number":302,"context_line":"                    (\u0027tag\u0027, attr_tuples.pop(\u0027tag\u0027))))"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_6706a723","line":299,"updated":"2018-04-30 11:05:25.000000000","message":"will it find \"tag\" inside (\"tag\", 4095) value passed in list of attr_tupples?","commit_id":"783e0988ee9ac20100baf1707bf6a29060c2b7cd"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"8ba70fc88e31032dbd986f8b7679fef71810c024","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        with self.ovsdb.transaction() as txn:"},{"line_number":297,"context_line":"            txn.add(self.ovsdb.add_port(self.br_name, port_name,"},{"line_number":298,"context_line":"                                        may_exist\u003dFalse))"},{"line_number":299,"context_line":"            if \u0027tag\u0027 in attr_tuples:"},{"line_number":300,"context_line":"                txn.add(self.ovsdb.db_set("},{"line_number":301,"context_line":"                    \u0027Port\u0027, port_name,"},{"line_number":302,"context_line":"                    (\u0027tag\u0027, attr_tuples.pop(\u0027tag\u0027))))"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_c23c41c1","line":299,"in_reply_to":"9f6a8fd7_6706a723","updated":"2018-04-30 11:09:59.000000000","message":"It will not :]","commit_id":"783e0988ee9ac20100baf1707bf6a29060c2b7cd"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"aed978c79c37a7e40c07962b5dd2eb753406250a","unresolved":false,"context_lines":[{"line_number":302,"context_line":"            # and also triggers issues on ovs-vswitchd related to the"},{"line_number":303,"context_line":"            # datapath flow revalidator thread, see lp#1767422"},{"line_number":304,"context_line":"            txn.add(self.ovsdb.db_set("},{"line_number":305,"context_line":"                    \u0027Port\u0027, port_name, (\u0027tag\u0027, constants.DEAD_VLAN_TAG)))"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"            # TODO(mangelajo): We could accept attr tuples for the Port too"},{"line_number":308,"context_line":"            # but, that could potentially break usage of this function in"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_ceb3f94c","line":305,"updated":"2018-05-08 12:07:44.000000000","message":"maybe it could be good idea to add check if this tag is configured to https://github.com/openstack/neutron/blob/master/neutron/tests/functional/agent/test_ovs_lib.py#L82 ?","commit_id":"d3793643ac326d180630a10308ee52f922c363ef"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"d9af8f0a77672a5301c19ba0d2dc54e9e043313c","unresolved":false,"context_lines":[{"line_number":302,"context_line":"            # and also triggers issues on ovs-vswitchd related to the"},{"line_number":303,"context_line":"            # datapath flow revalidator thread, see lp#1767422"},{"line_number":304,"context_line":"            txn.add(self.ovsdb.db_set("},{"line_number":305,"context_line":"                    \u0027Port\u0027, port_name, (\u0027tag\u0027, constants.DEAD_VLAN_TAG)))"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"            # TODO(mangelajo): We could accept attr tuples for the Port too"},{"line_number":308,"context_line":"            # but, that could potentially break usage of this function in"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_4e81294a","line":305,"in_reply_to":"5f7c97a3_ceb3f94c","updated":"2018-05-08 12:10:23.000000000","message":"Makes sense! +1","commit_id":"d3793643ac326d180630a10308ee52f922c363ef"}],"neutron/agent/l3/router_info.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"ca6d389e18003504683ea0976d4cc4426933fd1f","unresolved":false,"context_lines":[{"line_number":640,"context_line":"                         namespace\u003dns_name,"},{"line_number":641,"context_line":"                         prefix\u003dEXTERNAL_DEV_PREFIX,"},{"line_number":642,"context_line":"                         mtu\u003dex_gw_port.get(\u0027mtu\u0027))"},{"line_number":643,"context_line":"        if self.agent_conf.external_network_bridge:"},{"line_number":644,"context_line":"            self.driver.remove_vlan_tag("},{"line_number":645,"context_line":"                self.agent_conf.external_network_bridge, interface_name)"},{"line_number":646,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_e3b6f5fa","line":643,"updated":"2018-05-09 12:00:04.000000000","message":"I would add a comment referencing the lp# bug as for on the other places :)","commit_id":"2a1ebdb9c6e89a094f6cc0a797bec5ba778ae8f7"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e0160f0569546d096a2c0480f11d3721df24baa3","unresolved":false,"context_lines":[{"line_number":640,"context_line":"                         namespace\u003dns_name,"},{"line_number":641,"context_line":"                         prefix\u003dEXTERNAL_DEV_PREFIX,"},{"line_number":642,"context_line":"                         mtu\u003dex_gw_port.get(\u0027mtu\u0027))"},{"line_number":643,"context_line":"        if self.agent_conf.external_network_bridge:"},{"line_number":644,"context_line":"            self.driver.remove_vlan_tag("},{"line_number":645,"context_line":"                self.agent_conf.external_network_bridge, interface_name)"},{"line_number":646,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_0339b13f","line":643,"in_reply_to":"5f7c97a3_e3b6f5fa","updated":"2018-05-09 12:08:42.000000000","message":"Done","commit_id":"2a1ebdb9c6e89a094f6cc0a797bec5ba778ae8f7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9f72fd2b370a55f3f5f805dc5ca27e7d8a9efeff","unresolved":false,"context_lines":[{"line_number":640,"context_line":"                         namespace\u003dns_name,"},{"line_number":641,"context_line":"                         prefix\u003dEXTERNAL_DEV_PREFIX,"},{"line_number":642,"context_line":"                         mtu\u003dex_gw_port.get(\u0027mtu\u0027))"},{"line_number":643,"context_line":"        if self.agent_conf.external_network_bridge:"},{"line_number":644,"context_line":"            # NOTE(slaweq): for OVS implementations remove the DEAD VLAN tag"},{"line_number":645,"context_line":"            # on ports. DEAD VLAN tag is added to each newly created port"},{"line_number":646,"context_line":"            # and should be removed by L2 agent but if"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_bc68f7b8","line":643,"updated":"2018-05-10 20:36:43.000000000","message":"Slawek - luckily this will go away when we finally remove external_network_bridge","commit_id":"88f5e11d8bf820b0124be0f6ec3c2d96011592d9"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"89dcc5d79c5fa6b9b47b4562bf75a1dc39688ae0","unresolved":false,"context_lines":[{"line_number":648,"context_line":"            # created in this bridge and will not be touched by L2 agent."},{"line_number":649,"context_line":"            # This is related to lp#1767422"},{"line_number":650,"context_line":"            self.driver.remove_vlan_tag("},{"line_number":651,"context_line":"                self.agent_conf.external_network_bridge, interface_name)"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"    def _get_external_gw_ips(self, ex_gw_port):"},{"line_number":654,"context_line":"        gateway_ips \u003d []"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f79a3b5_7008177e","line":651,"updated":"2018-11-26 11:52:22.000000000","message":"has this been tested? bug 1799737","commit_id":"88f5e11d8bf820b0124be0f6ec3c2d96011592d9"}],"neutron/agent/linux/interface.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"52fd9682db4eae58245b69c8723b0eb8b16fa2d9","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        attrs \u003d [(\u0027external_ids\u0027, {\u0027iface-id\u0027: port_id,"},{"line_number":319,"context_line":"                                   \u0027iface-status\u0027: \u0027active\u0027,"},{"line_number":320,"context_line":"                                   \u0027attached-mac\u0027: mac_address}),"},{"line_number":321,"context_line":"                 (\u0027tag\u0027, 4095)]"},{"line_number":322,"context_line":"        # NOTE(mangelajo): Port is added to dead vlan (4095) by default until"},{"line_number":323,"context_line":"        # it\u0027s handled by the neutron-openvswitch-agent. Otherwise it becomes"},{"line_number":324,"context_line":"        # a trunk port on br-int (receiving traffic for all vlans), and"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_99233706","line":321,"range":{"start_line":321,"start_character":25,"end_line":321,"end_character":29},"updated":"2018-04-27 16:24:21.000000000","message":"DEAD_VLAN_TAG from neutron/plugins/ml2/drivers/openvswitch/agent/common/constants.py\n\nPerhaps we should also make sure there is an openflow rule on provided bridge to drop packets with this vlan id.","commit_id":"093f1b2bf3b93a824756bf68773d5b40fd9ea6eb"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"5f6309fa4cd879ca29f6d9431a9c7cc221d72d53","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        attrs \u003d [(\u0027external_ids\u0027, {\u0027iface-id\u0027: port_id,"},{"line_number":319,"context_line":"                                   \u0027iface-status\u0027: \u0027active\u0027,"},{"line_number":320,"context_line":"                                   \u0027attached-mac\u0027: mac_address}),"},{"line_number":321,"context_line":"                 (\u0027tag\u0027, 4095)]"},{"line_number":322,"context_line":"        # NOTE(mangelajo): Port is added to dead vlan (4095) by default until"},{"line_number":323,"context_line":"        # it\u0027s handled by the neutron-openvswitch-agent. Otherwise it becomes"},{"line_number":324,"context_line":"        # a trunk port on br-int (receiving traffic for all vlans), and"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_b9e87b7c","line":321,"range":{"start_line":321,"start_character":25,"end_line":321,"end_character":29},"in_reply_to":"9f6a8fd7_99233706","updated":"2018-04-27 16:27:42.000000000","message":"Oh, thanks I searched for 4095 in the code without success, I see now why ( MAX_VLAN+1 .. ) \n\nOh, so openvswitch will propagate dead vlan too?","commit_id":"093f1b2bf3b93a824756bf68773d5b40fd9ea6eb"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"90e4cb8cf21540b64d1baa157c6ee6284be87538","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        attrs \u003d [(\u0027external_ids\u0027, {\u0027iface-id\u0027: port_id,"},{"line_number":319,"context_line":"                                   \u0027iface-status\u0027: \u0027active\u0027,"},{"line_number":320,"context_line":"                                   \u0027attached-mac\u0027: mac_address}),"},{"line_number":321,"context_line":"                 (\u0027tag\u0027, 4095)]"},{"line_number":322,"context_line":"        # NOTE(mangelajo): Port is added to dead vlan (4095) by default until"},{"line_number":323,"context_line":"        # it\u0027s handled by the neutron-openvswitch-agent. Otherwise it becomes"},{"line_number":324,"context_line":"        # a trunk port on br-int (receiving traffic for all vlans), and"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_7c3ad1cd","line":321,"range":{"start_line":321,"start_character":25,"end_line":321,"end_character":29},"in_reply_to":"9f6a8fd7_b9e87b7c","updated":"2018-04-27 16:59:28.000000000","message":"Having a direct constant would be way to easy to find :)\n\nNo, I think for ovs it\u0027s just yet another tag. It\u0027s Neutron who considers this vlan dead, ovs agent drops traffic from port marked as dead. Perhaps we should do it here as well?","commit_id":"093f1b2bf3b93a824756bf68773d5b40fd9ea6eb"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"df523340d54e79a8dfab811c558f2c98b56b0aba","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from neutron.common import constants as n_const"},{"line_number":29,"context_line":"from neutron.common import exceptions"},{"line_number":30,"context_line":"from neutron.plugins.ml2.drivers.openvswitch.agent.common \\"},{"line_number":31,"context_line":"    import constants as ovs_constants"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_191e4770","line":31,"updated":"2018-04-27 16:34:07.000000000","message":"We should probably move the constant to neutron_lib constants, but, I prefer to leave it here for backportability reasons.\n\nI can follow up if that makes sense.","commit_id":"285b660398aa1ba140f6f0ddcc16e13653b82d00"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"6873a2c704739eecdc16c93e28cc48699e89f8fa","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        attrs \u003d [(\u0027external_ids\u0027, {\u0027iface-id\u0027: port_id,"},{"line_number":322,"context_line":"                                   \u0027iface-status\u0027: \u0027active\u0027,"},{"line_number":323,"context_line":"                                   \u0027attached-mac\u0027: mac_address}),"},{"line_number":324,"context_line":"                 (\u0027tag\u0027, ovs_constants.DEAD_VLAN_TAG)]"},{"line_number":325,"context_line":"        # NOTE(mangelajo): Port is added to dead vlan (4095) by default until"},{"line_number":326,"context_line":"        # it\u0027s handled by the neutron-openvswitch-agent. Otherwise it becomes"},{"line_number":327,"context_line":"        # a trunk port on br-int (receiving traffic for all vlans), and"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_0ebca867","line":324,"updated":"2018-04-30 08:34:38.000000000","message":"Ok,  those will be set as Interface attributes, but the tag is a Port attribute. Fixing it on the right place now:\n\nhttps://github.com/openstack/neutron/blob/master/neutron/agent/common/ovs_lib.py#L297","commit_id":"285b660398aa1ba140f6f0ddcc16e13653b82d00"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"533f4ac216b1333b819ce7d4eb7274b9d1cd346c","unresolved":false,"context_lines":[{"line_number":326,"context_line":"        # it\u0027s handled by the neutron-openvswitch-agent. Otherwise it becomes"},{"line_number":327,"context_line":"        # a trunk port on br-int (receiving traffic for all vlans), and"},{"line_number":328,"context_line":"        # also triggers issues on ovs-vswitchd related to the revalidator"},{"line_number":329,"context_line":"        # thread, see lp#1767422"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        if internal:"},{"line_number":332,"context_line":"            attrs.insert(0, (\u0027type\u0027, \u0027internal\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_46729313","line":329,"updated":"2018-04-28 10:40:47.000000000","message":"What about ports created by os-vif library, e.g. when hybrid connection is used? Shouldn\u0027t You also patch it to create such ports with DEAD_VLAN-TAG at the beginning? I know that such ports are created for instances and (probably) will not work yet until ovs agent will not configure it properly. But in some cases (like instance reboot for example) it could be probably possible that instance will start and receive same unwanted traffic as other untagged ports.","commit_id":"285b660398aa1ba140f6f0ddcc16e13653b82d00"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"6873a2c704739eecdc16c93e28cc48699e89f8fa","unresolved":false,"context_lines":[{"line_number":326,"context_line":"        # it\u0027s handled by the neutron-openvswitch-agent. Otherwise it becomes"},{"line_number":327,"context_line":"        # a trunk port on br-int (receiving traffic for all vlans), and"},{"line_number":328,"context_line":"        # also triggers issues on ovs-vswitchd related to the revalidator"},{"line_number":329,"context_line":"        # thread, see lp#1767422"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        if internal:"},{"line_number":332,"context_line":"            attrs.insert(0, (\u0027type\u0027, \u0027internal\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_8e8e78ce","line":329,"in_reply_to":"9f6a8fd7_46729313","updated":"2018-04-30 08:34:38.000000000","message":"Yeah, see the other related bug. You\u0027re right.","commit_id":"285b660398aa1ba140f6f0ddcc16e13653b82d00"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"263f209376a4b9fa182efcc68f20c61c878b4c4f","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        if not ip_lib.device_exists(device_name,"},{"line_number":261,"context_line":"                                    namespace\u003dnamespace):"},{"line_number":262,"context_line":"            self.plug_new(network_id, port_id, device_name, mac_address,"},{"line_number":263,"context_line":"                          bridge, namespace, prefix, mtu)"},{"line_number":264,"context_line":"        else:"},{"line_number":265,"context_line":"            LOG.info(\"Device %s already exists\", device_name)"},{"line_number":266,"context_line":"            if mtu:"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_d8839fcb","line":263,"updated":"2018-05-09 16:45:27.000000000","message":"I think if we add a flow here to drop all traffic for in_port\u003d\"device_name\", it would increase security a lot. Then just blindly try to remove such flow from the bridge when adding a local vlan tag.","commit_id":"88f5e11d8bf820b0124be0f6ec3c2d96011592d9"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"0e58b52ec3374a94fded4d605104250e322a7bf0","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        if not ip_lib.device_exists(device_name,"},{"line_number":261,"context_line":"                                    namespace\u003dnamespace):"},{"line_number":262,"context_line":"            self.plug_new(network_id, port_id, device_name, mac_address,"},{"line_number":263,"context_line":"                          bridge, namespace, prefix, mtu)"},{"line_number":264,"context_line":"        else:"},{"line_number":265,"context_line":"            LOG.info(\"Device %s already exists\", device_name)"},{"line_number":266,"context_line":"            if mtu:"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_91cf2f55","line":263,"in_reply_to":"5f7c97a3_b9ec978f","updated":"2018-05-10 13:27:19.000000000","message":"I agree with doing via ovs-ofctl, but I prefer follow up if possible, the ovs-vswitchd bug because of untagged ports is just horrible horrible :] :)","commit_id":"88f5e11d8bf820b0124be0f6ec3c2d96011592d9"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"baa60ce9a27053e9bc27e497056ddcb469819c57","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        if not ip_lib.device_exists(device_name,"},{"line_number":261,"context_line":"                                    namespace\u003dnamespace):"},{"line_number":262,"context_line":"            self.plug_new(network_id, port_id, device_name, mac_address,"},{"line_number":263,"context_line":"                          bridge, namespace, prefix, mtu)"},{"line_number":264,"context_line":"        else:"},{"line_number":265,"context_line":"            LOG.info(\"Device %s already exists\", device_name)"},{"line_number":266,"context_line":"            if mtu:"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_b9ec978f","line":263,"in_reply_to":"5f7c97a3_d8839fcb","updated":"2018-05-10 09:03:18.000000000","message":"As was discussed on IRC, it can be done by follow-up patch also, right?","commit_id":"88f5e11d8bf820b0124be0f6ec3c2d96011592d9"}],"neutron/tests/common/net_helpers.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"aed978c79c37a7e40c07962b5dd2eb753406250a","unresolved":false,"context_lines":[{"line_number":784,"context_line":"            namespace\u003dself.namespace)"},{"line_number":785,"context_line":"        # NOTE(mangelajo): for OVS implementations remove the DEAD VLAN tag"},{"line_number":786,"context_line":"        # on ports that we intend to use as fake vm interfaces, they"},{"line_number":787,"context_line":"        # need tobe flat. This is related to lp#1767422"},{"line_number":788,"context_line":"        self.bridge.clear_db_attribute(\"Port\", port_name, \"tag\")"},{"line_number":789,"context_line":"        self.addCleanup(self.bridge.delete_port, port_name)"},{"line_number":790,"context_line":"        self.port \u003d ip_lib.IPDevice(port_name, self.namespace)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_ee127558","line":787,"range":{"start_line":787,"start_character":15,"end_line":787,"end_character":19},"updated":"2018-05-08 12:07:44.000000000","message":"nitty nit: missing space between","commit_id":"d3793643ac326d180630a10308ee52f922c363ef"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"d9af8f0a77672a5301c19ba0d2dc54e9e043313c","unresolved":false,"context_lines":[{"line_number":784,"context_line":"            namespace\u003dself.namespace)"},{"line_number":785,"context_line":"        # NOTE(mangelajo): for OVS implementations remove the DEAD VLAN tag"},{"line_number":786,"context_line":"        # on ports that we intend to use as fake vm interfaces, they"},{"line_number":787,"context_line":"        # need tobe flat. This is related to lp#1767422"},{"line_number":788,"context_line":"        self.bridge.clear_db_attribute(\"Port\", port_name, \"tag\")"},{"line_number":789,"context_line":"        self.addCleanup(self.bridge.delete_port, port_name)"},{"line_number":790,"context_line":"        self.port \u003d ip_lib.IPDevice(port_name, self.namespace)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_ee97d58f","line":787,"range":{"start_line":787,"start_character":15,"end_line":787,"end_character":19},"in_reply_to":"5f7c97a3_ee127558","updated":"2018-05-08 12:10:23.000000000","message":"oops thanks :","commit_id":"d3793643ac326d180630a10308ee52f922c363ef"}],"neutron/tests/functional/agent/l2/base.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"aed978c79c37a7e40c07962b5dd2eb753406250a","unresolved":false,"context_lines":[{"line_number":396,"context_line":"                         namespace\u003dnamespace)"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"        if network_type \u003d\u003d \u0027flat\u0027:"},{"line_number":399,"context_line":"            for port in ports:"},{"line_number":400,"context_line":"                phys_br.clear_db_attribute(\"Port\", port[\u0027vif_name\u0027], \"tag\")"},{"line_number":401,"context_line":"        elif phys_segmentation_id and network_type \u003d\u003d \u0027vlan\u0027:"},{"line_number":402,"context_line":"            for port in ports:"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_6e28a585","line":399,"updated":"2018-05-08 12:07:44.000000000","message":"shouldn\u0027t You add here similar comment like in neutron/tests/common/net_helpers.py ?","commit_id":"d3793643ac326d180630a10308ee52f922c363ef"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"d9af8f0a77672a5301c19ba0d2dc54e9e043313c","unresolved":false,"context_lines":[{"line_number":396,"context_line":"                         namespace\u003dnamespace)"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"        if network_type \u003d\u003d \u0027flat\u0027:"},{"line_number":399,"context_line":"            for port in ports:"},{"line_number":400,"context_line":"                phys_br.clear_db_attribute(\"Port\", port[\u0027vif_name\u0027], \"tag\")"},{"line_number":401,"context_line":"        elif phys_segmentation_id and network_type \u003d\u003d \u0027vlan\u0027:"},{"line_number":402,"context_line":"            for port in ports:"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_4ef609fc","line":399,"in_reply_to":"5f7c97a3_6e28a585","updated":"2018-05-08 12:10:23.000000000","message":"Yeah, I thought of that. But it seemed more self explainative in this case \"flat\" \u003d\u003e ensuring no tag... :)\n\nBut let\u0027s add if for consistency.","commit_id":"d3793643ac326d180630a10308ee52f922c363ef"}],"neutron/tests/functional/agent/l3/framework.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9f72fd2b370a55f3f5f805dc5ca27e7d8a9efeff","unresolved":false,"context_lines":[{"line_number":338,"context_line":"            ovsbr \u003d ovs_lib.OVSBridge(bridge)"},{"line_number":339,"context_line":"            ovsbr.clear_db_attribute(\u0027Port\u0027, device_name, \u0027tag\u0027)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        with mock.patch(OVS_INTERFACE_DRIVER + \u0027.plug_new\u0027, autospec\u003dTrue) as ("},{"line_number":342,"context_line":"                ovs_plug):"},{"line_number":343,"context_line":"            ovs_plug.side_effect \u003d new_ovs_plug"},{"line_number":344,"context_line":"            agent._process_added_router(router)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_dc57f3c9","line":341,"updated":"2018-05-10 20:36:43.000000000","message":"nit: could this have been self.INTERFACE_DRIVER ?  I guess it\u0027s not clear what the new OVS_INTERFACE_DRIVER gets us.","commit_id":"88f5e11d8bf820b0124be0f6ec3c2d96011592d9"}]}
