)]}'
{"neutron/wsgi.py":[{"author":{"_account_id":7203,"name":"yuuichi fujioka","email":"fujioka.yuuichi@gmail.com","username":"FujiokaYuuichi"},"change_message_id":"55c6d9a3a98fd0b584552611a1ec940e320a4d55","unresolved":false,"context_lines":[{"line_number":32,"context_line":"import eventlet.wsgi"},{"line_number":33,"context_line":"eventlet.patcher.monkey_patch(all\u003dFalse, socket\u003dTrue)"},{"line_number":34,"context_line":"# Raise the default from 8192 to accommodate large tokens"},{"line_number":35,"context_line":"eventlet.wsgi.MAX_HEADER_LINE \u003d 16384"},{"line_number":36,"context_line":"from oslo.config import cfg"},{"line_number":37,"context_line":"import routes.middleware"},{"line_number":38,"context_line":"import webob.dec"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FDak%3D","line":35,"updated":"2013-11-15 05:01:31.000000000","message":"If the size of the Token is increase, we need to re-fix similar to this patch.\nI think the value should be written in the configuration file. e.g. etc/neutron.conf","commit_id":"adcacf71a86a1df13777891a8ae53d10e18fab11"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"b2614100f5fc81b15c237ffc018915bf9c6489dd","unresolved":false,"context_lines":[{"line_number":32,"context_line":"import eventlet.wsgi"},{"line_number":33,"context_line":"eventlet.patcher.monkey_patch(all\u003dFalse, socket\u003dTrue)"},{"line_number":34,"context_line":"# Raise the default from 8192 to accommodate large tokens"},{"line_number":35,"context_line":"eventlet.wsgi.MAX_HEADER_LINE \u003d 16384"},{"line_number":36,"context_line":"from oslo.config import cfg"},{"line_number":37,"context_line":"import routes.middleware"},{"line_number":38,"context_line":"import webob.dec"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BxoE%3D","line":35,"in_reply_to":"AAAATn%2F%2B8Go%3D","updated":"2013-11-20 11:20:37.000000000","message":"hi Yuuichi, the token length can\u0027t be greater than 16384 as my test result in the comment, and I just did the same update with the following patch:\nhttps://review.openstack.org/#/c/33362/1/nova/wsgi.py\nhttps://review.openstack.org/#/c/39882/1/keystone/common/environment/__init__.py","commit_id":"adcacf71a86a1df13777891a8ae53d10e18fab11"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"60fc8228f2930aaa2af4c37387a6c519b48a0df7","unresolved":false,"context_lines":[{"line_number":32,"context_line":"import eventlet.wsgi"},{"line_number":33,"context_line":"eventlet.patcher.monkey_patch(all\u003dFalse, socket\u003dTrue)"},{"line_number":34,"context_line":"# Raise the default from 8192 to accommodate large tokens"},{"line_number":35,"context_line":"eventlet.wsgi.MAX_HEADER_LINE \u003d 16384"},{"line_number":36,"context_line":"from oslo.config import cfg"},{"line_number":37,"context_line":"import routes.middleware"},{"line_number":38,"context_line":"import webob.dec"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BtJQ%3D","line":35,"in_reply_to":"AAAATn%2F%2BxeA%3D","updated":"2013-11-21 10:02:35.000000000","message":"Done, now this value can be configured in the configuration file, and also move the code logic into __init__ method in order to get it from configuration file. \nmeanwhile use 17160 written in https://bugs.launchpad.net/keystone/+bug/1186177 as the default value. Yuuichi, thanks for your review.","commit_id":"adcacf71a86a1df13777891a8ae53d10e18fab11"},{"author":{"_account_id":7203,"name":"yuuichi fujioka","email":"fujioka.yuuichi@gmail.com","username":"FujiokaYuuichi"},"change_message_id":"505835ce1d91b3c24b88e68ca45ffab22f085fc8","unresolved":false,"context_lines":[{"line_number":32,"context_line":"import eventlet.wsgi"},{"line_number":33,"context_line":"eventlet.patcher.monkey_patch(all\u003dFalse, socket\u003dTrue)"},{"line_number":34,"context_line":"# Raise the default from 8192 to accommodate large tokens"},{"line_number":35,"context_line":"eventlet.wsgi.MAX_HEADER_LINE \u003d 16384"},{"line_number":36,"context_line":"from oslo.config import cfg"},{"line_number":37,"context_line":"import routes.middleware"},{"line_number":38,"context_line":"import webob.dec"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BxeA%3D","line":35,"in_reply_to":"AAAATn%2F%2BxoE%3D","updated":"2013-11-20 11:51:57.000000000","message":"I have seen those patch.\n\nI think PKI Token length is not fixed. PKI Token has catalog.\nI think the Token length exceeds 16384 depending on the environment.\n\nWhat do you think about this?","commit_id":"adcacf71a86a1df13777891a8ae53d10e18fab11"},{"author":{"_account_id":7203,"name":"yuuichi fujioka","email":"fujioka.yuuichi@gmail.com","username":"FujiokaYuuichi"},"change_message_id":"88240437550168ebf21d21d7960d3069169e12ad","unresolved":false,"context_lines":[{"line_number":32,"context_line":"import eventlet.wsgi"},{"line_number":33,"context_line":"eventlet.patcher.monkey_patch(all\u003dFalse, socket\u003dTrue)"},{"line_number":34,"context_line":"# Raise the default from 8192 to accommodate large tokens"},{"line_number":35,"context_line":"eventlet.wsgi.MAX_HEADER_LINE \u003d 16384"},{"line_number":36,"context_line":"from oslo.config import cfg"},{"line_number":37,"context_line":"import routes.middleware"},{"line_number":38,"context_line":"import webob.dec"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2B8Go%3D","line":35,"in_reply_to":"AAAATn%2F%2FDH0%3D","updated":"2013-11-18 11:09:55.000000000","message":"Sorry for late response.\n\nToken length will be over 16384.\nThat is written in https://bugs.launchpad.net/keystone/+bug/1186177.","commit_id":"adcacf71a86a1df13777891a8ae53d10e18fab11"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"0c9141a5b0a161fdb8a4edfd208f4f0703892a94","unresolved":false,"context_lines":[{"line_number":32,"context_line":"import eventlet.wsgi"},{"line_number":33,"context_line":"eventlet.patcher.monkey_patch(all\u003dFalse, socket\u003dTrue)"},{"line_number":34,"context_line":"# Raise the default from 8192 to accommodate large tokens"},{"line_number":35,"context_line":"eventlet.wsgi.MAX_HEADER_LINE \u003d 16384"},{"line_number":36,"context_line":"from oslo.config import cfg"},{"line_number":37,"context_line":"import routes.middleware"},{"line_number":38,"context_line":"import webob.dec"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FDH0%3D","line":35,"in_reply_to":"AAAATn%2F%2FDak%3D","updated":"2013-11-15 06:42:07.000000000","message":"both keystone and nova compents have the same changes as bellow:\n\n$ git show 260c534e\ncommit 260c534e7536406cbf4a759f923f039d8e34481c\nAuthor: Steve Baker \u003csbaker@redhat.com\u003e\nDate:   Tue Jun 18 10:14:21 2013 +1200\n\n    Raise max header size to accommodate large tokens.\n    \n    The max header is exceeded in the following scenario\n    - Auth tokens built with a keystone v3 API catalog\n    - A catalog with approximately 8 or more endpoints defined\n    \n    Specifically, when heat is enabled in tempest gating, the following\n    tests are failing:\n    - tempest.api.compute.test_auth_token.AuthTokenTestJSON.test_v3_token\n    - tempest.api.compute.test_auth_token.AuthTokenTestXML.test_v3_token\n    \n    An equivalent fix will be required for all projects which use\n    eventlet.wsgi.\n    \n    Fixes bug: #1190149\n    \n    Change-Id: Ia0a2a48461593fdc0f5be57bcc9f364c3e3f8b66\n\ndiff --git a/nova/wsgi.py b/nova/wsgi.py\nindex 72e4649..2e3f66f 100644\n--- a/nova/wsgi.py\n+++ b/nova/wsgi.py\n@@ -37,6 +37,9 @@ from nova import exception\n from nova.openstack.common import excutils\n from nova.openstack.common import log as logging\n \n+# Raise the default from 8192 to accommodate large tokens\n+eventlet.wsgi.MAX_HEADER_LINE \u003d 16384\n+\n wsgi_opts \u003d [\n     cfg.StrOpt(\u0027api_paste_config\u0027,\n                default\u003d\"api-paste.ini\",","commit_id":"adcacf71a86a1df13777891a8ae53d10e18fab11"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"59e7a36bef1dc2024cc8641455fc927240b5f4e1","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def __init__(self, name, threads\u003d1000):"},{"line_number":121,"context_line":"        # Raise the default from 8192 to accommodate large tokens"},{"line_number":122,"context_line":"        eventlet.wsgi.MAX_HEADER_LINE \u003d CONF.max_header_line"},{"line_number":123,"context_line":"        self.pool \u003d eventlet.GreenPool(threads)"},{"line_number":124,"context_line":"        self.name \u003d name"},{"line_number":125,"context_line":"        self._launcher \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BWFQ%3D","line":122,"updated":"2013-11-27 05:08:40.000000000","message":"Reaching into another module and redefining a constant is suboptimal.  I know this fixes the issue, but I wonder if we\u0027re approaching this the wrong way.  How was this number determined?","commit_id":"8feec202d8a3e9ba13a75c65dca73718d7a33432"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"cd112a0925bcea59b296bcc5b364a3bd8ed558f4","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def __init__(self, name, threads\u003d1000):"},{"line_number":121,"context_line":"        # Raise the default from 8192 to accommodate large tokens"},{"line_number":122,"context_line":"        eventlet.wsgi.MAX_HEADER_LINE \u003d CONF.max_header_line"},{"line_number":123,"context_line":"        self.pool \u003d eventlet.GreenPool(threads)"},{"line_number":124,"context_line":"        self.name \u003d name"},{"line_number":125,"context_line":"        self._launcher \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9Vig%3D","line":122,"in_reply_to":"AAAATn%2F%2BKfs%3D","updated":"2013-12-12 14:46:42.000000000","message":"If the token is 17160 long, wouldn\u0027t the header be a bit longer than that?  It isn\u0027t clear from reading the bug report whether the number 17160 is including the header name in the header line.  (e.g. \"X-Auth-Token: \")  Are you sure this is the right number to allow such a token?","commit_id":"8feec202d8a3e9ba13a75c65dca73718d7a33432"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"ce423261abaddc85e0c4a9ad1a59941c5d0d790e","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def __init__(self, name, threads\u003d1000):"},{"line_number":121,"context_line":"        # Raise the default from 8192 to accommodate large tokens"},{"line_number":122,"context_line":"        eventlet.wsgi.MAX_HEADER_LINE \u003d CONF.max_header_line"},{"line_number":123,"context_line":"        self.pool \u003d eventlet.GreenPool(threads)"},{"line_number":124,"context_line":"        self.name \u003d name"},{"line_number":125,"context_line":"        self._launcher \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BKfs%3D","line":122,"in_reply_to":"AAAATn%2F%2BWFQ%3D","updated":"2013-11-30 07:19:33.000000000","message":"Hi mark, the number 17160 comes from the link https://bugs.launchpad.net/keystone/+bug/1186177 that said a PKI token with token length is 17160 chars has been generated by v3 api. so we think maybe token length will be over 17160, and Yuuichi suggest me write this value in the configuration. However, if so, I have to reach into another module to redefine this constant because only in this way this value can be read from configuration file. thanks for your review.","commit_id":"8feec202d8a3e9ba13a75c65dca73718d7a33432"},{"author":{"_account_id":8996,"name":"Florent Flament","email":"contact@florentflament.com","username":"florent"},"change_message_id":"32b13b6c905942e8399a690e0ca7c70c169d2591","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def __init__(self, name, threads\u003d1000):"},{"line_number":121,"context_line":"        # Raise the default from 8192 to accommodate large tokens"},{"line_number":122,"context_line":"        eventlet.wsgi.MAX_HEADER_LINE \u003d CONF.max_header_line"},{"line_number":123,"context_line":"        self.pool \u003d eventlet.GreenPool(threads)"},{"line_number":124,"context_line":"        self.name \u003d name"},{"line_number":125,"context_line":"        self._launcher \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2FHV4%3D","line":122,"in_reply_to":"AAAATn%2F%2BWFQ%3D","updated":"2014-01-17 09:57:10.000000000","message":"I agree. I don\u0027t like very much redefining constants neither, but I don\u0027t see any better solution..","commit_id":"8feec202d8a3e9ba13a75c65dca73718d7a33432"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"397ab3c16653207133d821ee97991eab3823a161","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def __init__(self, name, threads\u003d1000):"},{"line_number":121,"context_line":"        # Raise the default from 8192 to accommodate large tokens"},{"line_number":122,"context_line":"        eventlet.wsgi.MAX_HEADER_LINE \u003d CONF.max_header_line"},{"line_number":123,"context_line":"        self.pool \u003d eventlet.GreenPool(threads)"},{"line_number":124,"context_line":"        self.name \u003d name"},{"line_number":125,"context_line":"        self._launcher \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2FOmI%3D","line":122,"in_reply_to":"AAAATn%2F9Vig%3D","updated":"2014-01-16 06:08:21.000000000","message":"Hi Carl, do you hope me to update the MAX_HEADER_LINE default value to 16384 to be coherent with other projects as Florent\u0027s comment mentioned ?","commit_id":"8feec202d8a3e9ba13a75c65dca73718d7a33432"}]}