)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f8be03e4ae44abf58324676168ddc6ea1454bfaa","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In case when external bridge configured in OVS agent\u0027s bridge_mappings"},{"line_number":10,"context_line":"will be destroyed and created again (for example by running ifup-ovs"},{"line_number":11,"context_line":"script on Centos) bride wasn\u0027t configured by OVS agent."},{"line_number":12,"context_line":"That might cause broken connectivity for OpenStack\u0027s dataplane if"},{"line_number":13,"context_line":"dataplane network also uses same bridge."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_fd29df9a","line":11,"range":{"start_line":11,"start_character":18,"end_line":11,"end_character":23},"updated":"2018-05-07 18:29:12.000000000","message":"s/bridge","commit_id":"ead92e786fd407b23d92324e43f76b20371a4706"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a46d2e4a21f637293c8f894938d3e3cfd4853433","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In case when external bridge configured in OVS agent\u0027s bridge_mappings"},{"line_number":10,"context_line":"will be destroyed and created again (for example by running ifup-ovs"},{"line_number":11,"context_line":"script on Centos) bride wasn\u0027t configured by OVS agent."},{"line_number":12,"context_line":"That might cause broken connectivity for OpenStack\u0027s dataplane if"},{"line_number":13,"context_line":"dataplane network also uses same bridge."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_9144541d","line":11,"range":{"start_line":11,"start_character":18,"end_line":11,"end_character":23},"in_reply_to":"5f7c97a3_fd29df9a","updated":"2018-05-07 20:53:28.000000000","message":"Done","commit_id":"ead92e786fd407b23d92324e43f76b20371a4706"}],"neutron/agent/linux/ovsdb_monitor.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ae6aa8eac0341e7de37713119e4b5b6e8dcc7c50","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        for row in self.iter_stdout():"},{"line_number":175,"context_line":"            json \u003d jsonutils.loads(row).get(\u0027data\u0027)"},{"line_number":176,"context_line":"            for ovs_id, action, name in json:"},{"line_number":177,"context_line":"                if name not in self.bridges:"},{"line_number":178,"context_line":"                    continue"},{"line_number":179,"context_line":"                if action \u003d\u003d OVSDB_ACTION_INSERT:"},{"line_number":180,"context_line":"                    bridges_added.append(name)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        self.new_events[\u0027added\u0027].extend(bridges_added)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_62cd515c","line":179,"range":{"start_line":177,"start_character":0,"end_line":179,"end_character":49},"updated":"2018-05-04 07:22:31.000000000","message":"How about squashing these two into:\n\n if name in self.bridges and actions \u003d\u003d OVSDB_ACTION_INSERT:","commit_id":"21962b9721affdb503070cdb3f1c013e8cc14cab"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"59c488c763b02d41292c869b7a0fb811255d4275","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        for row in self.iter_stdout():"},{"line_number":175,"context_line":"            json \u003d jsonutils.loads(row).get(\u0027data\u0027)"},{"line_number":176,"context_line":"            for ovs_id, action, name in json:"},{"line_number":177,"context_line":"                if name not in self.bridges:"},{"line_number":178,"context_line":"                    continue"},{"line_number":179,"context_line":"                if action \u003d\u003d OVSDB_ACTION_INSERT:"},{"line_number":180,"context_line":"                    bridges_added.append(name)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        self.new_events[\u0027added\u0027].extend(bridges_added)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_c5046fc9","line":179,"range":{"start_line":177,"start_character":0,"end_line":179,"end_character":49},"in_reply_to":"5f7c97a3_62cd515c","updated":"2018-05-04 11:40:06.000000000","message":"Done","commit_id":"21962b9721affdb503070cdb3f1c013e8cc14cab"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f8be03e4ae44abf58324676168ddc6ea1454bfaa","unresolved":false,"context_lines":[{"line_number":149,"context_line":"class SimpleBridgesMonitor(OvsdbMonitor):"},{"line_number":150,"context_line":"    \"\"\"Monitors the Bridge table of the local host\u0027s ovsdb for changes."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    The has_updates() method indicates whether changes to the ovsdb"},{"line_number":153,"context_line":"    Bridge table have been detected since the monitor started or"},{"line_number":154,"context_line":"    since the previous access."},{"line_number":155,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_c02bd87f","line":152,"range":{"start_line":152,"start_character":8,"end_line":152,"end_character":19},"updated":"2018-05-07 18:29:12.000000000","message":"has_updates() is a method in the SimpleInterfaceMonitor class, so this comment doesn\u0027t apply here, maybe you meant to change this to bridges_added() and change the comment slightly?","commit_id":"ead92e786fd407b23d92324e43f76b20371a4706"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a46d2e4a21f637293c8f894938d3e3cfd4853433","unresolved":false,"context_lines":[{"line_number":149,"context_line":"class SimpleBridgesMonitor(OvsdbMonitor):"},{"line_number":150,"context_line":"    \"\"\"Monitors the Bridge table of the local host\u0027s ovsdb for changes."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    The has_updates() method indicates whether changes to the ovsdb"},{"line_number":153,"context_line":"    Bridge table have been detected since the monitor started or"},{"line_number":154,"context_line":"    since the previous access."},{"line_number":155,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_a631140e","line":152,"range":{"start_line":152,"start_character":8,"end_line":152,"end_character":19},"in_reply_to":"5f7c97a3_c02bd87f","updated":"2018-05-07 20:53:28.000000000","message":"right, changed","commit_id":"ead92e786fd407b23d92324e43f76b20371a4706"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ae6aa8eac0341e7de37713119e4b5b6e8dcc7c50","unresolved":false,"context_lines":[{"line_number":2040,"context_line":"                continue"},{"line_number":2041,"context_line":"            # Check if any physical bridge wasn\u0027t recreated recently"},{"line_number":2042,"context_line":"            if bridges_monitor:"},{"line_number":2043,"context_line":"                sync \u003d self._reconfigure_physical_bridges("},{"line_number":2044,"context_line":"                    bridges_monitor.bridges_added)"},{"line_number":2045,"context_line":"            # Notify the plugin of tunnel IP"},{"line_number":2046,"context_line":"            if self.enable_tunneling and tunnel_sync:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_423e152a","line":2043,"range":{"start_line":2043,"start_character":16,"end_line":2043,"end_character":22},"updated":"2018-05-04 07:22:31.000000000","message":"Should it be |\u003d ?\n\nIf sync is set to True on L2023, it can be changed here to False losing the previous value.","commit_id":"21962b9721affdb503070cdb3f1c013e8cc14cab"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"59c488c763b02d41292c869b7a0fb811255d4275","unresolved":false,"context_lines":[{"line_number":2040,"context_line":"                continue"},{"line_number":2041,"context_line":"            # Check if any physical bridge wasn\u0027t recreated recently"},{"line_number":2042,"context_line":"            if bridges_monitor:"},{"line_number":2043,"context_line":"                sync \u003d self._reconfigure_physical_bridges("},{"line_number":2044,"context_line":"                    bridges_monitor.bridges_added)"},{"line_number":2045,"context_line":"            # Notify the plugin of tunnel IP"},{"line_number":2046,"context_line":"            if self.enable_tunneling and tunnel_sync:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_a52cd347","line":2043,"range":{"start_line":2043,"start_character":16,"end_line":2043,"end_character":22},"in_reply_to":"5f7c97a3_423e152a","updated":"2018-05-04 11:40:06.000000000","message":"Done","commit_id":"21962b9721affdb503070cdb3f1c013e8cc14cab"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f8be03e4ae44abf58324676168ddc6ea1454bfaa","unresolved":false,"context_lines":[{"line_number":1069,"context_line":"        sync \u003d False"},{"line_number":1070,"context_line":"        bridge_mappings \u003d {}"},{"line_number":1071,"context_line":"        for bridge in bridges:"},{"line_number":1072,"context_line":"            LOG.warning(\"Physical bridge %s was just created.\", bridge)"},{"line_number":1073,"context_line":"            for phys_net, phys_br in self.bridge_mappings.items():"},{"line_number":1074,"context_line":"                if bridge \u003d\u003d phys_br:"},{"line_number":1075,"context_line":"                    bridge_mappings[phys_net] \u003d bridge"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_c0799893","line":1072,"range":{"start_line":1072,"start_character":16,"end_line":1072,"end_character":23},"updated":"2018-05-07 18:29:12.000000000","message":"I\u0027m not familiar with the bug, but should this be info?","commit_id":"ead92e786fd407b23d92324e43f76b20371a4706"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f8be03e4ae44abf58324676168ddc6ea1454bfaa","unresolved":false,"context_lines":[{"line_number":1069,"context_line":"        sync \u003d False"},{"line_number":1070,"context_line":"        bridge_mappings \u003d {}"},{"line_number":1071,"context_line":"        for bridge in bridges:"},{"line_number":1072,"context_line":"            LOG.warning(\"Physical bridge %s was just created.\", bridge)"},{"line_number":1073,"context_line":"            for phys_net, phys_br in self.bridge_mappings.items():"},{"line_number":1074,"context_line":"                if bridge \u003d\u003d phys_br:"},{"line_number":1075,"context_line":"                    bridge_mappings[phys_net] \u003d bridge"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_8073a0b1","line":1072,"range":{"start_line":1072,"start_character":53,"end_line":1072,"end_character":60},"updated":"2018-05-07 18:29:12.000000000","message":"s/re-created (?)","commit_id":"ead92e786fd407b23d92324e43f76b20371a4706"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a46d2e4a21f637293c8f894938d3e3cfd4853433","unresolved":false,"context_lines":[{"line_number":1069,"context_line":"        sync \u003d False"},{"line_number":1070,"context_line":"        bridge_mappings \u003d {}"},{"line_number":1071,"context_line":"        for bridge in bridges:"},{"line_number":1072,"context_line":"            LOG.warning(\"Physical bridge %s was just created.\", bridge)"},{"line_number":1073,"context_line":"            for phys_net, phys_br in self.bridge_mappings.items():"},{"line_number":1074,"context_line":"                if bridge \u003d\u003d phys_br:"},{"line_number":1075,"context_line":"                    bridge_mappings[phys_net] \u003d bridge"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_e62e2ca4","line":1072,"range":{"start_line":1072,"start_character":53,"end_line":1072,"end_character":60},"in_reply_to":"5f7c97a3_8073a0b1","updated":"2018-05-07 20:53:28.000000000","message":"In fact it will detect creation of bridge but as it monitors only bridges which we want, it guarantee that those bridges existed before so we can write \"re-created\" here.","commit_id":"ead92e786fd407b23d92324e43f76b20371a4706"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a46d2e4a21f637293c8f894938d3e3cfd4853433","unresolved":false,"context_lines":[{"line_number":1069,"context_line":"        sync \u003d False"},{"line_number":1070,"context_line":"        bridge_mappings \u003d {}"},{"line_number":1071,"context_line":"        for bridge in bridges:"},{"line_number":1072,"context_line":"            LOG.warning(\"Physical bridge %s was just created.\", bridge)"},{"line_number":1073,"context_line":"            for phys_net, phys_br in self.bridge_mappings.items():"},{"line_number":1074,"context_line":"                if bridge \u003d\u003d phys_br:"},{"line_number":1075,"context_line":"                    bridge_mappings[phys_net] \u003d bridge"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_a61a747a","line":1072,"range":{"start_line":1072,"start_character":16,"end_line":1072,"end_character":23},"in_reply_to":"5f7c97a3_c0799893","updated":"2018-05-07 20:53:28.000000000","message":"Maybe it\u0027s better to log it as INFO, changed :)","commit_id":"ead92e786fd407b23d92324e43f76b20371a4706"}]}
