)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"470f9539008f80661c99d1f3a1e185472e2928f4","unresolved":false,"context_lines":[{"line_number":16,"context_line":"* name: the name of the availability zone"},{"line_number":17,"context_line":"* state: the value is either \u0027available\u0027 or \u0027unavailable\u0027"},{"line_number":18,"context_line":"* resource: the value is either \u0027network\u0027 or \u0027router\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Needed-By: Icbf427f20ca912a40d68e8042abeeabffeb3005f"},{"line_number":21,"context_line":"Change-Id: Id882f949cc73a34290c311f3ce3d69d1b809c29f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_7206fa88","line":19,"updated":"2018-05-29 07:21:27.000000000","message":"This is API change so please add APIImpact tag here.","commit_id":"fc2ded122ddbf2436cdee5f57d55dae9af2b2261"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"53a1dfc0d8e45f9c3d2c29eb681080fb84f67f4a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"* name: the name of the availability zone"},{"line_number":17,"context_line":"* state: the value is either \u0027available\u0027 or \u0027unavailable\u0027"},{"line_number":18,"context_line":"* resource: the value is either \u0027network\u0027 or \u0027router\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Needed-By: Icbf427f20ca912a40d68e8042abeeabffeb3005f"},{"line_number":21,"context_line":"Change-Id: Id882f949cc73a34290c311f3ce3d69d1b809c29f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_e019c2d6","line":19,"in_reply_to":"5f7c97a3_7206fa88","updated":"2018-05-29 22:10:05.000000000","message":"Done","commit_id":"fc2ded122ddbf2436cdee5f57d55dae9af2b2261"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"1a3578dc60dcbe3ad23c2eec39b140b33408c2d5","unresolved":false,"context_lines":[{"line_number":17,"context_line":"* state: the value is either \u0027available\u0027 or \u0027unavailable\u0027"},{"line_number":18,"context_line":"* resource: the value is either \u0027network\u0027 or \u0027router\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"@APIImpact"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Needed-By: Icbf427f20ca912a40d68e8042abeeabffeb3005f"},{"line_number":23,"context_line":"Change-Id: Id882f949cc73a34290c311f3ce3d69d1b809c29f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_f13196ee","line":20,"updated":"2018-05-30 01:45:13.000000000","message":"nit: There is a rule of APIImpact flag[1]. How about following?\n\n APIImpact: Add some API filters to specify attributes of availability zones\n\n[1]: https://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references","commit_id":"331baf8fde43ca6ac7f819ac7f8f96c21c816838"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"6b4451623723c2024f67bebf9027c802964c4345","unresolved":false,"context_lines":[{"line_number":17,"context_line":"* state: the value is either \u0027available\u0027 or \u0027unavailable\u0027"},{"line_number":18,"context_line":"* resource: the value is either \u0027network\u0027 or \u0027router\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"@APIImpact"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Needed-By: Icbf427f20ca912a40d68e8042abeeabffeb3005f"},{"line_number":23,"context_line":"Change-Id: Id882f949cc73a34290c311f3ce3d69d1b809c29f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_b63d46bc","line":20,"in_reply_to":"5f7c97a3_f13196ee","updated":"2018-05-30 14:55:08.000000000","message":"Done","commit_id":"331baf8fde43ca6ac7f819ac7f8f96c21c816838"}],"neutron/db/agents_db.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"470f9539008f80661c99d1f3a1e185472e2928f4","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        \u0027agent_key\u0027: \u0027agent_type\u0027,"},{"line_number":77,"context_line":"        \u0027convert_to\u0027: lambda x: RESOURCE_AGENT_TYPE_MAP.get(x, x),"},{"line_number":78,"context_line":"    },"},{"line_number":79,"context_line":"    \u0027state\u0027: {"},{"line_number":80,"context_line":"        \u0027agent_key\u0027: \u0027admin_state_up\u0027,"},{"line_number":81,"context_line":"        \u0027convert_to\u0027: lambda x: STATE_ADMIN_STATE_UP_MAP.get(x, x),"},{"line_number":82,"context_line":"    }"},{"line_number":83,"context_line":"}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_d2a58ea0","line":82,"range":{"start_line":79,"start_character":4,"end_line":82,"end_character":5},"updated":"2018-05-29 07:21:27.000000000","message":"The admin_state_up of agent doesn\u0027t directly mean available or unavailable of state. Please look at a logic on L112. And also I added a comment about the example on test.","commit_id":"fc2ded122ddbf2436cdee5f57d55dae9af2b2261"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"53a1dfc0d8e45f9c3d2c29eb681080fb84f67f4a","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        \u0027agent_key\u0027: \u0027agent_type\u0027,"},{"line_number":77,"context_line":"        \u0027convert_to\u0027: lambda x: RESOURCE_AGENT_TYPE_MAP.get(x, x),"},{"line_number":78,"context_line":"    },"},{"line_number":79,"context_line":"    \u0027state\u0027: {"},{"line_number":80,"context_line":"        \u0027agent_key\u0027: \u0027admin_state_up\u0027,"},{"line_number":81,"context_line":"        \u0027convert_to\u0027: lambda x: STATE_ADMIN_STATE_UP_MAP.get(x, x),"},{"line_number":82,"context_line":"    }"},{"line_number":83,"context_line":"}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_c02b66e8","line":82,"range":{"start_line":79,"start_character":4,"end_line":82,"end_character":5},"in_reply_to":"5f7c97a3_d2a58ea0","updated":"2018-05-29 22:10:05.000000000","message":"Done","commit_id":"fc2ded122ddbf2436cdee5f57d55dae9af2b2261"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"81a23aa3f7630caf5289ed8031802f3c829ffbc4","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def _adjust_az_filters(self, filters):"},{"line_number":108,"context_line":"        az_filters \u003d {}"},{"line_number":109,"context_line":"        # The intersect of sets gets us applicable filter keys (others ignored)"},{"line_number":110,"context_line":"        common_keys \u003d six.viewkeys(filters) \u0026 six.viewkeys(AZ_ATTRIBUTE_MAP)"},{"line_number":111,"context_line":"        for key in common_keys:"},{"line_number":112,"context_line":"            filter_vals \u003d filters[key]"},{"line_number":113,"context_line":"            if filter_vals:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_c085745b","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":76},"updated":"2018-06-01 04:07:12.000000000","message":"This means that current API filters are not available, for example, there may be users which get AZs with \"/v2.0/availability_zones?availability_zone\u003dnova\". We must support backward compatibility. Therefore, it\u0027s better to support both keys.","commit_id":"30aff5c714b5287d9c0d62c60821f8d3252ed2d6"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"7e354f7e2f05ef3778da62f106bc9a61fbcf30cd","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def _adjust_az_filters(self, filters):"},{"line_number":108,"context_line":"        az_filters \u003d {}"},{"line_number":109,"context_line":"        # The intersect of sets gets us applicable filter keys (others ignored)"},{"line_number":110,"context_line":"        common_keys \u003d six.viewkeys(filters) \u0026 six.viewkeys(AZ_ATTRIBUTE_MAP)"},{"line_number":111,"context_line":"        for key in common_keys:"},{"line_number":112,"context_line":"            filter_vals \u003d filters[key]"},{"line_number":113,"context_line":"            if filter_vals:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_785c27ed","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":76},"in_reply_to":"5f7c97a3_2b0bd67c","updated":"2018-06-04 20:06:35.000000000","message":"Done","commit_id":"30aff5c714b5287d9c0d62c60821f8d3252ed2d6"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"0c116ed8c7a43c78c82da2a210a30542026d1f47","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def _adjust_az_filters(self, filters):"},{"line_number":108,"context_line":"        az_filters \u003d {}"},{"line_number":109,"context_line":"        # The intersect of sets gets us applicable filter keys (others ignored)"},{"line_number":110,"context_line":"        common_keys \u003d six.viewkeys(filters) \u0026 six.viewkeys(AZ_ATTRIBUTE_MAP)"},{"line_number":111,"context_line":"        for key in common_keys:"},{"line_number":112,"context_line":"            filter_vals \u003d filters[key]"},{"line_number":113,"context_line":"            if filter_vals:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_2b0bd67c","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":76},"in_reply_to":"5f7c97a3_2eda094a","updated":"2018-06-02 00:23:36.000000000","message":"I know the bug and patch. I thought that OVO caused the issue because the filters worked fine when I implemented AZ[1]. I\u0027m not sure when is it broken. I can see it\u0027s wrong before OVO. Therefore, there mgiht have been users used the filter.\n\n[1]: https://review.openstack.org/#/c/183369/40/neutron/db/agents_db.py","commit_id":"30aff5c714b5287d9c0d62c60821f8d3252ed2d6"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"57887e58a8fabd15cdf31e86ee38131f08d161df","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def _adjust_az_filters(self, filters):"},{"line_number":108,"context_line":"        az_filters \u003d {}"},{"line_number":109,"context_line":"        # The intersect of sets gets us applicable filter keys (others ignored)"},{"line_number":110,"context_line":"        common_keys \u003d six.viewkeys(filters) \u0026 six.viewkeys(AZ_ATTRIBUTE_MAP)"},{"line_number":111,"context_line":"        for key in common_keys:"},{"line_number":112,"context_line":"            filter_vals \u003d filters[key]"},{"line_number":113,"context_line":"            if filter_vals:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_d2e5890b","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":76},"in_reply_to":"5f7c97a3_c085745b","updated":"2018-06-11 15:10:01.000000000","message":"Done. We support both keys now, which should be backward-compatible. The new filter keys will be documented in the API reference. The old filter keys will be still supported (until a point in time that we might be confident to drop support for them).","commit_id":"30aff5c714b5287d9c0d62c60821f8d3252ed2d6"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"3fb5b8da026f36bc543b12ba4055e4a8e025856d","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def _adjust_az_filters(self, filters):"},{"line_number":108,"context_line":"        az_filters \u003d {}"},{"line_number":109,"context_line":"        # The intersect of sets gets us applicable filter keys (others ignored)"},{"line_number":110,"context_line":"        common_keys \u003d six.viewkeys(filters) \u0026 six.viewkeys(AZ_ATTRIBUTE_MAP)"},{"line_number":111,"context_line":"        for key in common_keys:"},{"line_number":112,"context_line":"            filter_vals \u003d filters[key]"},{"line_number":113,"context_line":"            if filter_vals:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_2eda094a","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":76},"in_reply_to":"5f7c97a3_c085745b","updated":"2018-06-01 20:49:55.000000000","message":"I tried what you said in master branch and got the following error:\n\n  $ curl -s -g -X GET \"http://10.0.0.15:9696/v2.0/availability_zones?availability_zone\u003dnova\" -H \"Accept: application/json\" -H \"X-Auth-Token: $TOKEN\"\n  {\"NeutronError\": {\"message\": \"Request Failed: internal server error while processing your request.\", \"type\": \"HTTPInternalServerError\", \"detail\": \"\"}}\n\nIt looks it is related to bug https://bugs.launchpad.net/neutron/+bug/1768952 . Anyway, back to your comments, if there are users which get AZs in that way, they will hit bug #1768952 and received 500 response. In this case, must we support backward compatibility?","commit_id":"30aff5c714b5287d9c0d62c60821f8d3252ed2d6"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"7b5c27667ed9cb811d0447c6c6615d661478c88f","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            if filter_vals:"},{"line_number":114,"context_line":"                filter_vals \u003d [AZ_ATTRIBUTE_MAP[key][\u0027convert_to\u0027](v)"},{"line_number":115,"context_line":"                               for v in filter_vals]"},{"line_number":116,"context_line":"            filters[filter_key] \u003d filter_vals"},{"line_number":117,"context_line":"        return filters"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    @db_api.retry_if_session_inactive()"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_2bece0b9","line":116,"updated":"2018-06-19 07:00:37.000000000","message":"There is a nit bug. For example, when \"/availability_zones?resource\u003drouter\u0026agent_type\u003dDHCP%20agent\" is passed, it overwrites filters[\u0027agent_type\u0027] and then users get an AZ with resource\u003drouter only. I think that it\u0027s very corner case so I\u0027m OK. If you respin this patch, please fix it. It\u0027s not difficult fix.","commit_id":"e7502fdf79ec9f7730e6b23bb937e80657a96561"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c22d93e4ef10007a60d97eb4c52c8129bb913304","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def _list_availability_zones(self, context, filters\u003dNone):"},{"line_number":90,"context_line":"        result \u003d {}"},{"line_number":91,"context_line":"        filters \u003d self._adjust_az_filters(filters or {})"},{"line_number":92,"context_line":"        agents \u003d agent_obj.Agent.get_objects(context, **filters)"},{"line_number":93,"context_line":"        for agent in agents:"},{"line_number":94,"context_line":"            if not agent.availability_zone:"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_a7ac1b35","line":91,"updated":"2018-06-26 06:47:26.000000000","message":"You should check if Your new API extension is really loaded and if it\u0027s not (other plugin then ML2 might not support it), fallback to old behavior IMO","commit_id":"bc6bfb97ecc8672a4ea3b5016b33cf8e866da851"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"8908e2b15ccc6e3c5ae1fda3a6898ce10988adff","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    def _list_availability_zones(self, context, filters\u003dNone):"},{"line_number":107,"context_line":"        result \u003d {}"},{"line_number":108,"context_line":"        filters \u003d filters or {}"},{"line_number":109,"context_line":"        if self.is_az_filter_supported:"},{"line_number":110,"context_line":"            filters \u003d self._adjust_az_filters(filters)"},{"line_number":111,"context_line":"        agents \u003d agent_obj.Agent.get_objects(context, **filters)"},{"line_number":112,"context_line":"        for agent in agents:"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_a95ef74e","line":109,"range":{"start_line":109,"start_character":11,"end_line":109,"end_character":38},"updated":"2018-06-28 05:25:50.000000000","message":"The self._is_az_filter_supported is better.","commit_id":"7454f37edd7c9c067953e99adbc6aafebe248620"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"cafad0469c294b2ef44f7af818cd877235d6b863","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    def _list_availability_zones(self, context, filters\u003dNone):"},{"line_number":107,"context_line":"        result \u003d {}"},{"line_number":108,"context_line":"        filters \u003d filters or {}"},{"line_number":109,"context_line":"        if self.is_az_filter_supported:"},{"line_number":110,"context_line":"            filters \u003d self._adjust_az_filters(filters)"},{"line_number":111,"context_line":"        agents \u003d agent_obj.Agent.get_objects(context, **filters)"},{"line_number":112,"context_line":"        for agent in agents:"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_5138fcc9","line":109,"range":{"start_line":109,"start_character":11,"end_line":109,"end_character":38},"in_reply_to":"5f7c97a3_168b711e","updated":"2018-06-29 19:25:00.000000000","message":"So, this is an optimization in the case that self._is_az_filter_supported is True and it does attribute access instead of method call? Frankly, I am not sure if such optimization is significant, but anyway I did what you suggested. Please check.","commit_id":"7454f37edd7c9c067953e99adbc6aafebe248620"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"3cacb6aa949cd5cacb42592b96babddfccfe7ba4","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    def _list_availability_zones(self, context, filters\u003dNone):"},{"line_number":107,"context_line":"        result \u003d {}"},{"line_number":108,"context_line":"        filters \u003d filters or {}"},{"line_number":109,"context_line":"        if self.is_az_filter_supported:"},{"line_number":110,"context_line":"            filters \u003d self._adjust_az_filters(filters)"},{"line_number":111,"context_line":"        agents \u003d agent_obj.Agent.get_objects(context, **filters)"},{"line_number":112,"context_line":"        for agent in agents:"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_d83208c1","line":109,"range":{"start_line":109,"start_character":11,"end_line":109,"end_character":38},"in_reply_to":"5f7c97a3_a95ef74e","updated":"2018-06-28 21:20:05.000000000","message":"Could you elaborate please? Why self._is_az_filter_supported is better?","commit_id":"7454f37edd7c9c067953e99adbc6aafebe248620"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"e0da2cd2291489846c9a7b1f64b606337f6a40f9","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    def _list_availability_zones(self, context, filters\u003dNone):"},{"line_number":107,"context_line":"        result \u003d {}"},{"line_number":108,"context_line":"        filters \u003d filters or {}"},{"line_number":109,"context_line":"        if self.is_az_filter_supported:"},{"line_number":110,"context_line":"            filters \u003d self._adjust_az_filters(filters)"},{"line_number":111,"context_line":"        agents \u003d agent_obj.Agent.get_objects(context, **filters)"},{"line_number":112,"context_line":"        for agent in agents:"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_168b711e","line":109,"range":{"start_line":109,"start_character":11,"end_line":109,"end_character":38},"in_reply_to":"5f7c97a3_d83208c1","updated":"2018-06-29 00:00:11.000000000","message":"Because this method is called from get_availability_zones only and it calls self.is_az_filter_supportted() before calling this method. And also we should reduce unused method call. If you hope this call is safer, the following may be better as same as L144\u0027 comment.\n\n if self._is_az_filter_supported or self.is_az_filter_supported","commit_id":"7454f37edd7c9c067953e99adbc6aafebe248620"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"8908e2b15ccc6e3c5ae1fda3a6898ce10988adff","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                               sorts\u003dNone, limit\u003dNone, marker\u003dNone,"},{"line_number":142,"context_line":"                               page_reverse\u003dFalse):"},{"line_number":143,"context_line":"        \"\"\"Return a list of availability zones.\"\"\""},{"line_number":144,"context_line":"        if self.is_az_filter_supported:"},{"line_number":145,"context_line":"            filter_states \u003d filters.pop(\u0027state\u0027, [])"},{"line_number":146,"context_line":"            # NOTE(hichihara): \u0027tenant_id\u0027 is dummy for policy check."},{"line_number":147,"context_line":"            # it is not visible via API."}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_2972e7e5","line":144,"range":{"start_line":144,"start_character":8,"end_line":144,"end_character":38},"updated":"2018-06-28 05:25:50.000000000","message":"The following is better.\n\n  if self._is_az_filter_supported or self.is_az_filter_supported:","commit_id":"7454f37edd7c9c067953e99adbc6aafebe248620"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8816ce888d4f8a9efdf941aec8cf2f9311713986","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    def _list_availability_zones(self, context, filters\u003dNone):"},{"line_number":107,"context_line":"        result \u003d {}"},{"line_number":108,"context_line":"        filters \u003d filters or {}"},{"line_number":109,"context_line":"        if self._is_az_filter_supported or self.is_az_filter_supported:"},{"line_number":110,"context_line":"            filters \u003d self._adjust_az_filters(filters)"},{"line_number":111,"context_line":"        agents \u003d agent_obj.Agent.get_objects(context, **filters)"},{"line_number":112,"context_line":"        for agent in agents:"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_7eefdcb0","line":109,"updated":"2018-07-16 08:44:01.000000000","message":"why You need this \"or\" here? Isn\u0027t calling self.is_az_filter_supported enough?","commit_id":"7899ef26714d4cfa0e077db40d5e7ee80df08864"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"2f675e69f671f7e8ed4831e67b71bfde995f1a56","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    def _list_availability_zones(self, context, filters\u003dNone):"},{"line_number":107,"context_line":"        result \u003d {}"},{"line_number":108,"context_line":"        filters \u003d filters or {}"},{"line_number":109,"context_line":"        if self._is_az_filter_supported or self.is_az_filter_supported:"},{"line_number":110,"context_line":"            filters \u003d self._adjust_az_filters(filters)"},{"line_number":111,"context_line":"        agents \u003d agent_obj.Agent.get_objects(context, **filters)"},{"line_number":112,"context_line":"        for agent in agents:"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_cefbc712","line":109,"in_reply_to":"5f7c97a3_03ec4890","updated":"2018-07-17 01:12:30.000000000","message":"It just reduces method call and 4 steps cost.","commit_id":"7899ef26714d4cfa0e077db40d5e7ee80df08864"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"b9ffc699aa4b026b1371ae826dd59b810d79adee","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    def _list_availability_zones(self, context, filters\u003dNone):"},{"line_number":107,"context_line":"        result \u003d {}"},{"line_number":108,"context_line":"        filters \u003d filters or {}"},{"line_number":109,"context_line":"        if self._is_az_filter_supported or self.is_az_filter_supported:"},{"line_number":110,"context_line":"            filters \u003d self._adjust_az_filters(filters)"},{"line_number":111,"context_line":"        agents \u003d agent_obj.Agent.get_objects(context, **filters)"},{"line_number":112,"context_line":"        for agent in agents:"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_03ec4890","line":109,"in_reply_to":"5f7c97a3_7eefdcb0","updated":"2018-07-16 14:49:36.000000000","message":"This is an optimization suggested by Hirofumi Ichihara in patchset #9. I will leave it to Hirofumi Ichihara to answer since I don\u0027t have strong opinion on this.","commit_id":"7899ef26714d4cfa0e077db40d5e7ee80df08864"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8816ce888d4f8a9efdf941aec8cf2f9311713986","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                               sorts\u003dNone, limit\u003dNone, marker\u003dNone,"},{"line_number":142,"context_line":"                               page_reverse\u003dFalse):"},{"line_number":143,"context_line":"        \"\"\"Return a list of availability zones.\"\"\""},{"line_number":144,"context_line":"        if self._is_az_filter_supported or self.is_az_filter_supported:"},{"line_number":145,"context_line":"            filter_states \u003d filters.pop(\u0027state\u0027, [])"},{"line_number":146,"context_line":"            # NOTE(hichihara): \u0027tenant_id\u0027 is dummy for policy check."},{"line_number":147,"context_line":"            # it is not visible via API."}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_9eeaf89d","line":144,"updated":"2018-07-16 08:44:01.000000000","message":"same question here","commit_id":"7899ef26714d4cfa0e077db40d5e7ee80df08864"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"b9ffc699aa4b026b1371ae826dd59b810d79adee","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                               sorts\u003dNone, limit\u003dNone, marker\u003dNone,"},{"line_number":142,"context_line":"                               page_reverse\u003dFalse):"},{"line_number":143,"context_line":"        \"\"\"Return a list of availability zones.\"\"\""},{"line_number":144,"context_line":"        if self._is_az_filter_supported or self.is_az_filter_supported:"},{"line_number":145,"context_line":"            filter_states \u003d filters.pop(\u0027state\u0027, [])"},{"line_number":146,"context_line":"            # NOTE(hichihara): \u0027tenant_id\u0027 is dummy for policy check."},{"line_number":147,"context_line":"            # it is not visible via API."}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_c3e5f0a5","line":144,"in_reply_to":"5f7c97a3_9eeaf89d","updated":"2018-07-16 14:49:36.000000000","message":"Ditto","commit_id":"7899ef26714d4cfa0e077db40d5e7ee80df08864"}],"neutron/tests/unit/extensions/test_availability_zone.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"470f9539008f80661c99d1f3a1e185472e2928f4","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                         query_params\u003d\"state\u003davailable\")"},{"line_number":104,"context_line":"        azs \u003d res[\u0027availability_zones\u0027]"},{"line_number":105,"context_line":"        self.assertItemsEqual(expected[:3], azs)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def test_list_agent_with_az(self):"},{"line_number":108,"context_line":"        helpers.register_dhcp_agent(host\u003d\u0027host1\u0027, az\u003d\u0027nova1\u0027)"},{"line_number":109,"context_line":"        res \u003d self._list(\u0027agents\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_52b3bee9","line":106,"updated":"2018-05-29 07:21:27.000000000","message":"Could you add the following test?\n\n        res \u003d self._list(\u0027availability_zones\u0027,\n                         query_params\u003d\"state\u003dunavailable\")\n        azs \u003d res[\u0027availability_zones\u0027]\n        self.assertItemsEqual(expected[-1:], azs)","commit_id":"fc2ded122ddbf2436cdee5f57d55dae9af2b2261"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"53a1dfc0d8e45f9c3d2c29eb681080fb84f67f4a","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                         query_params\u003d\"state\u003davailable\")"},{"line_number":104,"context_line":"        azs \u003d res[\u0027availability_zones\u0027]"},{"line_number":105,"context_line":"        self.assertItemsEqual(expected[:3], azs)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def test_list_agent_with_az(self):"},{"line_number":108,"context_line":"        helpers.register_dhcp_agent(host\u003d\u0027host1\u0027, az\u003d\u0027nova1\u0027)"},{"line_number":109,"context_line":"        res \u003d self._list(\u0027agents\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_e030e258","line":106,"in_reply_to":"5f7c97a3_52b3bee9","updated":"2018-05-29 22:10:05.000000000","message":"Done","commit_id":"fc2ded122ddbf2436cdee5f57d55dae9af2b2261"}]}
