)]}'
{"neutron/tests/unit/extensions/test_l3.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"aaa9e26a6d6290c813d70b9144cbfabb9b6987b2","unresolved":false,"context_lines":[{"line_number":350,"context_line":"            data[\u0027router\u0027][\u0027name\u0027] \u003d name"},{"line_number":351,"context_line":"        if admin_state_up is not None:"},{"line_number":352,"context_line":"            data[\u0027router\u0027][\u0027admin_state_up\u0027] \u003d admin_state_up"},{"line_number":353,"context_line":"        flavor_id \u003d kwargs.pop(\u0027flavor_id\u0027, None)"},{"line_number":354,"context_line":"        if flavor_id:"},{"line_number":355,"context_line":"            data[\u0027router\u0027][\u0027flavor_id\u0027] \u003d flavor_id"},{"line_number":356,"context_line":"        for arg in ((\u0027admin_state_up\u0027, \u0027tenant_id\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_a9629cac","line":353,"range":{"start_line":353,"start_character":27,"end_line":353,"end_character":30},"updated":"2018-05-16 00:02:23.000000000","message":"kwargs shouldn\u0027t be modified.\nso use dict.get() instead of dict.pop().","commit_id":"561e0337846e058f36d909002d069502e97e2c60"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"50c2faaee777f62e0f8fe03f8d6fee4dc048af15","unresolved":false,"context_lines":[{"line_number":350,"context_line":"            data[\u0027router\u0027][\u0027name\u0027] \u003d name"},{"line_number":351,"context_line":"        if admin_state_up is not None:"},{"line_number":352,"context_line":"            data[\u0027router\u0027][\u0027admin_state_up\u0027] \u003d admin_state_up"},{"line_number":353,"context_line":"        flavor_id \u003d kwargs.pop(\u0027flavor_id\u0027, None)"},{"line_number":354,"context_line":"        if flavor_id:"},{"line_number":355,"context_line":"            data[\u0027router\u0027][\u0027flavor_id\u0027] \u003d flavor_id"},{"line_number":356,"context_line":"        for arg in ((\u0027admin_state_up\u0027, \u0027tenant_id\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_edf5eecb","line":353,"range":{"start_line":353,"start_character":27,"end_line":353,"end_character":30},"in_reply_to":"5f7c97a3_a9629cac","updated":"2018-05-16 17:18:12.000000000","message":"done","commit_id":"561e0337846e058f36d909002d069502e97e2c60"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"aaa9e26a6d6290c813d70b9144cbfabb9b6987b2","unresolved":false,"context_lines":[{"line_number":488,"context_line":"    @contextlib.contextmanager"},{"line_number":489,"context_line":"    def floatingip_with_assoc(self, port_id\u003dNone, fmt\u003dNone, fixed_ip\u003dNone,"},{"line_number":490,"context_line":"                              public_cidr\u003d\u002711.0.0.0/24\u0027, set_context\u003dFalse,"},{"line_number":491,"context_line":"                              tenant_id\u003dNone, **kwargs):"},{"line_number":492,"context_line":"        with self.subnet(cidr\u003dpublic_cidr,"},{"line_number":493,"context_line":"                         set_context\u003dset_context,"},{"line_number":494,"context_line":"                         tenant_id\u003dtenant_id) as public_sub:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_a907fcc9","line":491,"range":{"start_line":491,"start_character":46,"end_line":491,"end_character":54},"updated":"2018-05-16 00:02:23.000000000","message":"kwargs is used for argument to floating ip.\nOther argument is passed as explicit agument.\nso we should add flavor_id\u003dNone.","commit_id":"561e0337846e058f36d909002d069502e97e2c60"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"50c2faaee777f62e0f8fe03f8d6fee4dc048af15","unresolved":false,"context_lines":[{"line_number":488,"context_line":"    @contextlib.contextmanager"},{"line_number":489,"context_line":"    def floatingip_with_assoc(self, port_id\u003dNone, fmt\u003dNone, fixed_ip\u003dNone,"},{"line_number":490,"context_line":"                              public_cidr\u003d\u002711.0.0.0/24\u0027, set_context\u003dFalse,"},{"line_number":491,"context_line":"                              tenant_id\u003dNone, **kwargs):"},{"line_number":492,"context_line":"        with self.subnet(cidr\u003dpublic_cidr,"},{"line_number":493,"context_line":"                         set_context\u003dset_context,"},{"line_number":494,"context_line":"                         tenant_id\u003dtenant_id) as public_sub:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_7233ffab","line":491,"range":{"start_line":491,"start_character":46,"end_line":491,"end_character":54},"in_reply_to":"5f7c97a3_a907fcc9","updated":"2018-05-16 17:18:12.000000000","message":"Done","commit_id":"561e0337846e058f36d909002d069502e97e2c60"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"aaa9e26a6d6290c813d70b9144cbfabb9b6987b2","unresolved":false,"context_lines":[{"line_number":534,"context_line":"    @contextlib.contextmanager"},{"line_number":535,"context_line":"    def floatingip_no_assoc_with_public_sub("},{"line_number":536,"context_line":"        self, private_sub, fmt\u003dNone, set_context\u003dFalse,"},{"line_number":537,"context_line":"        public_sub\u003dNone, **kwargs):"},{"line_number":538,"context_line":"        self._set_net_external(public_sub[\u0027subnet\u0027][\u0027network_id\u0027])"},{"line_number":539,"context_line":"        args_list \u003d {}"},{"line_number":540,"context_line":"        flavor_id \u003d kwargs.pop(\u0027flavor_id\u0027, None)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_49f668d9","line":537,"range":{"start_line":537,"start_character":25,"end_line":537,"end_character":34},"updated":"2018-05-16 00:02:23.000000000","message":"ditto.","commit_id":"561e0337846e058f36d909002d069502e97e2c60"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"50c2faaee777f62e0f8fe03f8d6fee4dc048af15","unresolved":false,"context_lines":[{"line_number":534,"context_line":"    @contextlib.contextmanager"},{"line_number":535,"context_line":"    def floatingip_no_assoc_with_public_sub("},{"line_number":536,"context_line":"        self, private_sub, fmt\u003dNone, set_context\u003dFalse,"},{"line_number":537,"context_line":"        public_sub\u003dNone, **kwargs):"},{"line_number":538,"context_line":"        self._set_net_external(public_sub[\u0027subnet\u0027][\u0027network_id\u0027])"},{"line_number":539,"context_line":"        args_list \u003d {}"},{"line_number":540,"context_line":"        flavor_id \u003d kwargs.pop(\u0027flavor_id\u0027, None)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_adfb76bb","line":537,"range":{"start_line":537,"start_character":25,"end_line":537,"end_character":34},"in_reply_to":"5f7c97a3_49f668d9","updated":"2018-05-16 17:18:12.000000000","message":"Done","commit_id":"561e0337846e058f36d909002d069502e97e2c60"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"96d05cd79b8ac6a8e800e6f522ef27b62cbe1f76","unresolved":false,"context_lines":[{"line_number":343,"context_line":"    def _create_router(self, fmt, tenant_id, name\u003dNone,"},{"line_number":344,"context_line":"                       admin_state_up\u003dNone, set_context\u003dFalse,"},{"line_number":345,"context_line":"                       arg_list\u003dNone, **kwargs):"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"        tenant_id \u003d tenant_id or _uuid()"},{"line_number":348,"context_line":"        data \u003d {\u0027router\u0027: {\u0027tenant_id\u0027: tenant_id}}"},{"line_number":349,"context_line":"        if name:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_ede069fd","line":346,"updated":"2018-05-18 05:45:42.000000000","message":"nit: extra change","commit_id":"025bd21a4443438cebfb18a8c962800e5f086ea7"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"453f4966d1a4fea4328acf22da9fd996bc851c8f","unresolved":false,"context_lines":[{"line_number":343,"context_line":"    def _create_router(self, fmt, tenant_id, name\u003dNone,"},{"line_number":344,"context_line":"                       admin_state_up\u003dNone, set_context\u003dFalse,"},{"line_number":345,"context_line":"                       arg_list\u003dNone, **kwargs):"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"        tenant_id \u003d tenant_id or _uuid()"},{"line_number":348,"context_line":"        data \u003d {\u0027router\u0027: {\u0027tenant_id\u0027: tenant_id}}"},{"line_number":349,"context_line":"        if name:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_67030c0f","line":346,"in_reply_to":"5f7c97a3_ede069fd","updated":"2018-05-18 16:01:26.000000000","message":"Done","commit_id":"025bd21a4443438cebfb18a8c962800e5f086ea7"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"2f5e38599e2a5f9eee8f9933e9c80aae9c6d617b","unresolved":false,"context_lines":[{"line_number":350,"context_line":"            data[\u0027router\u0027][\u0027name\u0027] \u003d name"},{"line_number":351,"context_line":"        if admin_state_up is not None:"},{"line_number":352,"context_line":"            data[\u0027router\u0027][\u0027admin_state_up\u0027] \u003d admin_state_up"},{"line_number":353,"context_line":"        flavor_id \u003d kwargs.get(\u0027flavor_id\u0027, None)"},{"line_number":354,"context_line":"        if flavor_id:"},{"line_number":355,"context_line":"            data[\u0027router\u0027][\u0027flavor_id\u0027] \u003d flavor_id"},{"line_number":356,"context_line":"        for arg in ((\u0027admin_state_up\u0027, \u0027tenant_id\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_8c078419","line":353,"range":{"start_line":353,"start_character":42,"end_line":353,"end_character":48},"updated":"2018-05-17 16:52:09.000000000","message":"None is not needed as the default value.\nMaybe update the list of line 356-357?","commit_id":"025bd21a4443438cebfb18a8c962800e5f086ea7"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"d7a92bcd157e9bba976e1002855e169ce139ec05","unresolved":false,"context_lines":[{"line_number":350,"context_line":"            data[\u0027router\u0027][\u0027name\u0027] \u003d name"},{"line_number":351,"context_line":"        if admin_state_up is not None:"},{"line_number":352,"context_line":"            data[\u0027router\u0027][\u0027admin_state_up\u0027] \u003d admin_state_up"},{"line_number":353,"context_line":"        flavor_id \u003d kwargs.get(\u0027flavor_id\u0027, None)"},{"line_number":354,"context_line":"        if flavor_id:"},{"line_number":355,"context_line":"            data[\u0027router\u0027][\u0027flavor_id\u0027] \u003d flavor_id"},{"line_number":356,"context_line":"        for arg in ((\u0027admin_state_up\u0027, \u0027tenant_id\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_a7b4c436","line":353,"range":{"start_line":353,"start_character":42,"end_line":353,"end_character":48},"in_reply_to":"5f7c97a3_47037110","updated":"2018-05-18 16:08:12.000000000","message":"i recall it, now it was to avoid None thing, if there\u0027s flavor None in kwargs it will set flavor: None and None value for flavor emits error","commit_id":"025bd21a4443438cebfb18a8c962800e5f086ea7"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"453f4966d1a4fea4328acf22da9fd996bc851c8f","unresolved":false,"context_lines":[{"line_number":350,"context_line":"            data[\u0027router\u0027][\u0027name\u0027] \u003d name"},{"line_number":351,"context_line":"        if admin_state_up is not None:"},{"line_number":352,"context_line":"            data[\u0027router\u0027][\u0027admin_state_up\u0027] \u003d admin_state_up"},{"line_number":353,"context_line":"        flavor_id \u003d kwargs.get(\u0027flavor_id\u0027, None)"},{"line_number":354,"context_line":"        if flavor_id:"},{"line_number":355,"context_line":"            data[\u0027router\u0027][\u0027flavor_id\u0027] \u003d flavor_id"},{"line_number":356,"context_line":"        for arg in ((\u0027admin_state_up\u0027, \u0027tenant_id\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_47037110","line":353,"range":{"start_line":353,"start_character":42,"end_line":353,"end_character":48},"in_reply_to":"5f7c97a3_8c078419","updated":"2018-05-18 16:01:26.000000000","message":"either way works !","commit_id":"025bd21a4443438cebfb18a8c962800e5f086ea7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"96d05cd79b8ac6a8e800e6f522ef27b62cbe1f76","unresolved":false,"context_lines":[{"line_number":540,"context_line":"            # NOTE(manjeets) Flavor id None is not accepted"},{"line_number":541,"context_line":"            # and return Flavor None not found error. So for"},{"line_number":542,"context_line":"            # neutron testing this argument should not be passed"},{"line_number":543,"context_line":"            # at all to router."},{"line_number":544,"context_line":"            args_list[\u0027flavor_id\u0027] \u003d flavor_id"},{"line_number":545,"context_line":"        with self.router(**args_list) as r:"},{"line_number":546,"context_line":"            floatingip \u003d None"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_ad903150","line":543,"updated":"2018-05-18 05:45:42.000000000","message":"I guess this applies to the other cases above as well?","commit_id":"025bd21a4443438cebfb18a8c962800e5f086ea7"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"453f4966d1a4fea4328acf22da9fd996bc851c8f","unresolved":false,"context_lines":[{"line_number":540,"context_line":"            # NOTE(manjeets) Flavor id None is not accepted"},{"line_number":541,"context_line":"            # and return Flavor None not found error. So for"},{"line_number":542,"context_line":"            # neutron testing this argument should not be passed"},{"line_number":543,"context_line":"            # at all to router."},{"line_number":544,"context_line":"            args_list[\u0027flavor_id\u0027] \u003d flavor_id"},{"line_number":545,"context_line":"        with self.router(**args_list) as r:"},{"line_number":546,"context_line":"            floatingip \u003d None"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_071ed96f","line":543,"in_reply_to":"5f7c97a3_ad903150","updated":"2018-05-18 16:01:26.000000000","message":"yes ! that\u0027s why args_list separate dict is being used.\nshould I leave note everywhere where its applicable ? or this is fine ?","commit_id":"025bd21a4443438cebfb18a8c962800e5f086ea7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d83ecd9c94deb2d63f4cff008883421125a588dc","unresolved":false,"context_lines":[{"line_number":502,"context_line":"                    set_context\u003dset_context,"},{"line_number":503,"context_line":"                    tenant_id\u003dtenant_id) as private_port:"},{"line_number":504,"context_line":"                if flavor_id:"},{"line_number":505,"context_line":"                    args_list[\u0027flavor_id\u0027] \u003d flavor_id"},{"line_number":506,"context_line":"                with self.router(**args_list) as r:"},{"line_number":507,"context_line":"                    sid \u003d private_port[\u0027port\u0027][\u0027fixed_ips\u0027][0][\u0027subnet_id\u0027]"},{"line_number":508,"context_line":"                    private_sub \u003d {\u0027subnet\u0027: {\u0027id\u0027: sid}}"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_8d7527fd","line":505,"updated":"2018-05-18 18:26:54.000000000","message":"Seems like it should be right below L496","commit_id":"15b49fac8dde9400371206315dbc4684ae38e50d"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"b7ddba4eeb28cb8f186faad29b1a7ead4aa0755b","unresolved":false,"context_lines":[{"line_number":502,"context_line":"                    set_context\u003dset_context,"},{"line_number":503,"context_line":"                    tenant_id\u003dtenant_id) as private_port:"},{"line_number":504,"context_line":"                if flavor_id:"},{"line_number":505,"context_line":"                    args_list[\u0027flavor_id\u0027] \u003d flavor_id"},{"line_number":506,"context_line":"                with self.router(**args_list) as r:"},{"line_number":507,"context_line":"                    sid \u003d private_port[\u0027port\u0027][\u0027fixed_ips\u0027][0][\u0027subnet_id\u0027]"},{"line_number":508,"context_line":"                    private_sub \u003d {\u0027subnet\u0027: {\u0027id\u0027: sid}}"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_bb729d7b","line":505,"in_reply_to":"5f7c97a3_8d7527fd","updated":"2018-05-18 19:58:27.000000000","message":"Done","commit_id":"15b49fac8dde9400371206315dbc4684ae38e50d"}]}
