)]}'
{"neutron/agent/dhcp/agent.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9ab2084255eab4c761f63090dbc2a25d34fadd8d","unresolved":false,"context_lines":[{"line_number":379,"context_line":"        with _net_lock(network_id):"},{"line_number":380,"context_line":"            self.refresh_dhcp_helper(network_id)"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"    _subnet_create_end \u003d _subnet_update_end"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    def _subnet_delete_end(self, payload):"},{"line_number":385,"context_line":"        subnet_id \u003d payload[\u0027subnet_id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_b0e04a98","line":382,"updated":"2018-05-09 08:01:19.000000000","message":"I don\u0027t think that this is necessary, as subnet_create_end is already defined to be the same as subnet_update_end then it will already call _subnet_update_end, right?","commit_id":"90bfdf6eb9862fc70c15f691164206441216d472"},{"author":{"_account_id":28182,"name":"Jiaping LI","email":"lijiaping@yovole.com","username":"lijiaping"},"change_message_id":"f4a95157daf277ac46eb6bbb0741bcfebb3455c7","unresolved":false,"context_lines":[{"line_number":379,"context_line":"        with _net_lock(network_id):"},{"line_number":380,"context_line":"            self.refresh_dhcp_helper(network_id)"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"    _subnet_create_end \u003d _subnet_update_end"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    def _subnet_delete_end(self, payload):"},{"line_number":385,"context_line":"        subnet_id \u003d payload[\u0027subnet_id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_43ce7b82","line":382,"in_reply_to":"5f7c97a3_b0e04a98","updated":"2018-05-15 06:53:50.000000000","message":"Thanks for the review. Yes, you are right. Actually, I have used this code just for the unit test case more convenient. I will re modify the unit test case and abandon this line.","commit_id":"90bfdf6eb9862fc70c15f691164206441216d472"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9ab2084255eab4c761f63090dbc2a25d34fadd8d","unresolved":false,"context_lines":[{"line_number":435,"context_line":"            port[\u0027network_id\u0027], self.conf.host)"},{"line_number":436,"context_line":"        return port[\u0027device_id\u0027] \u003d\u003d thishost"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    _port_create_end \u003d _port_update_end"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"    def _port_delete_end(self, payload):"},{"line_number":441,"context_line":"        port \u003d self.cache.get_port_by_id(payload[\u0027port_id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_70f4f25b","line":438,"updated":"2018-05-09 08:01:19.000000000","message":"same here","commit_id":"90bfdf6eb9862fc70c15f691164206441216d472"}],"neutron/tests/unit/agent/dhcp/test_agent.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9ab2084255eab4c761f63090dbc2a25d34fadd8d","unresolved":false,"context_lines":[{"line_number":889,"context_line":"            self.dhcp._network_create_end(payload)"},{"line_number":890,"context_line":"            enable.assert_called_once_with(fake_network.id)"},{"line_number":891,"context_line":""},{"line_number":892,"context_line":"        pool \u003d dhcp_agent.eventlet.GreenPool"},{"line_number":893,"context_line":"        with mock.patch.object(pool, \u0027spawn\u0027) as spawn:"},{"line_number":894,"context_line":"            self.dhcp.network_create_end(None, payload)"},{"line_number":895,"context_line":"            spawn.assert_called_once_with(self.dhcp._network_create_end,"},{"line_number":896,"context_line":"                                          payload)"},{"line_number":897,"context_line":""},{"line_number":898,"context_line":"    def test_network_update_end_admin_state_up(self):"},{"line_number":899,"context_line":"        payload \u003d dict(network\u003ddict(id\u003dfake_network.id, admin_state_up\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_70c2b2eb","line":896,"range":{"start_line":892,"start_character":0,"end_line":896,"end_character":50},"updated":"2018-05-09 08:01:19.000000000","message":"IMO this should be separate test. So You can do something like:\n\n    test__network_create_end()\n\nwhich will test what is now in L886 to 890 and then:\n\n   test_network_create_end()\n\nwhich will be this new test. And please, apply this comment to all other tests in this file :)","commit_id":"90bfdf6eb9862fc70c15f691164206441216d472"},{"author":{"_account_id":28182,"name":"Jiaping LI","email":"lijiaping@yovole.com","username":"lijiaping"},"change_message_id":"f4a95157daf277ac46eb6bbb0741bcfebb3455c7","unresolved":false,"context_lines":[{"line_number":889,"context_line":"            self.dhcp._network_create_end(payload)"},{"line_number":890,"context_line":"            enable.assert_called_once_with(fake_network.id)"},{"line_number":891,"context_line":""},{"line_number":892,"context_line":"        pool \u003d dhcp_agent.eventlet.GreenPool"},{"line_number":893,"context_line":"        with mock.patch.object(pool, \u0027spawn\u0027) as spawn:"},{"line_number":894,"context_line":"            self.dhcp.network_create_end(None, payload)"},{"line_number":895,"context_line":"            spawn.assert_called_once_with(self.dhcp._network_create_end,"},{"line_number":896,"context_line":"                                          payload)"},{"line_number":897,"context_line":""},{"line_number":898,"context_line":"    def test_network_update_end_admin_state_up(self):"},{"line_number":899,"context_line":"        payload \u003d dict(network\u003ddict(id\u003dfake_network.id, admin_state_up\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_4393db5b","line":896,"range":{"start_line":892,"start_character":0,"end_line":896,"end_character":50},"in_reply_to":"5f7c97a3_70c2b2eb","updated":"2018-05-15 06:53:50.000000000","message":"Thanks for the review. I will modify the test case again.","commit_id":"90bfdf6eb9862fc70c15f691164206441216d472"}]}