)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"7b997fde4880f6564b274d11fda6a30c9fcb6428","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Change defaults in tools/configure_for_func_testing.sh"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The defaults in tools/configure_for_func_testing.sh don\u0027t"},{"line_number":10,"context_line":"match what devstack uses, so running it while a stack is"},{"line_number":11,"context_line":"running breaks all database access.  Changing the defaults"},{"line_number":12,"context_line":"should be less destructive."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_9bdbef19","line":10,"range":{"start_line":10,"start_character":6,"end_line":10,"end_character":25},"updated":"2018-05-09 08:28:58.000000000","message":"Well, there are no defaults for these values in devstack. :)","commit_id":"c01bb73aa3943a02395484d1a96aee812cfc58ce"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"cf1092fe93358b1428fa3fc91f687caef3bd18d6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Change defaults in tools/configure_for_func_testing.sh"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The defaults in tools/configure_for_func_testing.sh don\u0027t"},{"line_number":10,"context_line":"match what devstack uses, so running it while a stack is"},{"line_number":11,"context_line":"running breaks all database access.  Changing the defaults"},{"line_number":12,"context_line":"should be less destructive."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_0feb10b0","line":10,"range":{"start_line":10,"start_character":6,"end_line":10,"end_character":25},"in_reply_to":"5f7c97a3_4fbca8ba","updated":"2018-05-09 14:29:35.000000000","message":"Or I should just stick to whats in the sample file ... :)","commit_id":"c01bb73aa3943a02395484d1a96aee812cfc58ce"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b6aeff3568917d23c4bea1a2b7a5d17e2dcd2119","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Change defaults in tools/configure_for_func_testing.sh"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The defaults in tools/configure_for_func_testing.sh don\u0027t"},{"line_number":10,"context_line":"match what devstack uses, so running it while a stack is"},{"line_number":11,"context_line":"running breaks all database access.  Changing the defaults"},{"line_number":12,"context_line":"should be less destructive."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_4fbca8ba","line":10,"range":{"start_line":10,"start_character":6,"end_line":10,"end_character":25},"in_reply_to":"5f7c97a3_6f4ba458","updated":"2018-05-09 14:27:33.000000000","message":"I thought so, I\u0027m thinking if we should source local.conf in the script. We already have the path to devstack. Or maybe it will be an overkill and waste of time implementing it, I was just thinking if there is some other solution. Cause now people that use different passwords than those in local.conf (e.g. me) will get dev environment screwed when running functional or fullstack tests :-/","commit_id":"c01bb73aa3943a02395484d1a96aee812cfc58ce"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3a890d47d70923444091d0f90a2b3ccf3bd937bc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Change defaults in tools/configure_for_func_testing.sh"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The defaults in tools/configure_for_func_testing.sh don\u0027t"},{"line_number":10,"context_line":"match what devstack uses, so running it while a stack is"},{"line_number":11,"context_line":"running breaks all database access.  Changing the defaults"},{"line_number":12,"context_line":"should be less destructive."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_6f4ba458","line":10,"range":{"start_line":10,"start_character":6,"end_line":10,"end_character":25},"in_reply_to":"5f7c97a3_9bdbef19","updated":"2018-05-09 14:14:04.000000000","message":"Well, I could say use what\u0027s in the samples/local.conf file, which is I think where the one I use started life :)","commit_id":"c01bb73aa3943a02395484d1a96aee812cfc58ce"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"616aee99fafe36bd3891136ec09dffb1274b2d51","unresolved":false,"context_lines":[{"line_number":11,"context_line":"running breaks all database access.  Changing the defaults"},{"line_number":12,"context_line":"should be less destructive."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Also change the Postgres default to False since it\u0027s not"},{"line_number":15,"context_line":"a typical choice either, and can cause package installation"},{"line_number":16,"context_line":"issues when it\u0027s not available, even if it isn\u0027t needed."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I2d2a7ef034f670f3927ecc7b7706876872a01c77"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_ee7c8384","line":16,"range":{"start_line":14,"start_character":0,"end_line":16,"end_character":56},"updated":"2018-05-10 07:16:08.000000000","message":"You had old PS locally because of editing patchset via gerrit UI? :)","commit_id":"475bb8ab87abf08653231cdc5f45acf600695dcd"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"397a0f4793381ff4090dbe2ad47a41cb9677d87a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"running breaks all database access.  Changing the defaults"},{"line_number":12,"context_line":"should be less destructive."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Also change the Postgres default to False since it\u0027s not"},{"line_number":15,"context_line":"a typical choice either, and can cause package installation"},{"line_number":16,"context_line":"issues when it\u0027s not available, even if it isn\u0027t needed."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I2d2a7ef034f670f3927ecc7b7706876872a01c77"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_bc5eb741","line":16,"range":{"start_line":14,"start_character":0,"end_line":16,"end_character":56},"in_reply_to":"5f7c97a3_ee7c8384","updated":"2018-05-10 21:03:06.000000000","message":"Yes, that\u0027s the problem :(","commit_id":"475bb8ab87abf08653231cdc5f45acf600695dcd"}],"tools/configure_for_func_testing.sh":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ef6b99ea12a45ba9f5d4e337a8685597c579d4e4","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"# _install_databases [install_pg]"},{"line_number":115,"context_line":"function _install_databases {"},{"line_number":116,"context_line":"    local install_pg\u003d${1:-False}"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    echo_summary \"Installing databases\""},{"line_number":119,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"5f7c97a3_cafd1c3b","line":116,"updated":"2018-05-08 18:58:33.000000000","message":"I guess this wasn\u0027t a good idea...","commit_id":"11aad66028afe03dc32576a8e6a12d25bf09335c"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"52d579598edcca5cae513d98cf1d15b3bbbf4eb1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5f7c97a3_982527c5","updated":"2018-05-09 16:52:00.000000000","message":"as it will have path to devstack while running, would it be possible to have a conditional source of local.conf ? I mean source local.conf if it exists and use these password variables from there in case it exists.","commit_id":"c01bb73aa3943a02395484d1a96aee812cfc58ce"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6f7ca890db8295aadd6b64faac725cf81823bc8f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5f7c97a3_febc43dd","in_reply_to":"5f7c97a3_982527c5","updated":"2018-05-09 18:21:13.000000000","message":"Yes, that might be an option, and shouldn\u0027t interfere with the gate, etc.","commit_id":"c01bb73aa3943a02395484d1a96aee812cfc58ce"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"cf1092fe93358b1428fa3fc91f687caef3bd18d6","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Warning: This script relies on devstack to perform extensive"},{"line_number":34,"context_line":"modification to the underlying host.  It is recommended that it be"},{"line_number":35,"context_line":"invoked only on a throw-away VM.\""},{"line_number":36,"context_line":"    exit 1"},{"line_number":37,"context_line":"fi"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"5f7c97a3_affa1c72","line":35,"updated":"2018-05-09 14:29:35.000000000","message":"Maybe we could write a sentence here that by default script sets passwords for rabbit and database to values from devstack sample local.conf file. At least we\u0027ll know where those passwords come from. Nowadays they are just \"some passwords\".","commit_id":"c01bb73aa3943a02395484d1a96aee812cfc58ce"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6f7ca890db8295aadd6b64faac725cf81823bc8f","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Warning: This script relies on devstack to perform extensive"},{"line_number":34,"context_line":"modification to the underlying host.  It is recommended that it be"},{"line_number":35,"context_line":"invoked only on a throw-away VM.\""},{"line_number":36,"context_line":"    exit 1"},{"line_number":37,"context_line":"fi"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"5f7c97a3_3ecabb6c","line":35,"in_reply_to":"5f7c97a3_38673328","updated":"2018-05-09 18:21:13.000000000","message":"I\u0027ll add some text around where the defaults are from.","commit_id":"c01bb73aa3943a02395484d1a96aee812cfc58ce"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"52d579598edcca5cae513d98cf1d15b3bbbf4eb1","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Warning: This script relies on devstack to perform extensive"},{"line_number":34,"context_line":"modification to the underlying host.  It is recommended that it be"},{"line_number":35,"context_line":"invoked only on a throw-away VM.\""},{"line_number":36,"context_line":"    exit 1"},{"line_number":37,"context_line":"fi"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"5f7c97a3_38673328","line":35,"in_reply_to":"5f7c97a3_affa1c72","updated":"2018-05-09 16:52:00.000000000","message":"i think it would be worth adding the note here for passwords, so that it doesn\u0027t look like magic to new comers or people testing it for first time","commit_id":"c01bb73aa3943a02395484d1a96aee812cfc58ce"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3f7575ffe40acf0566df94eb3e24b87de6b2108d","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"# _install_databases [install_pg]"},{"line_number":123,"context_line":"function _install_databases {"},{"line_number":124,"context_line":"    local install_pg\u003d${1:-False}"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    echo_summary \"Installing databases\""},{"line_number":127,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"5f7c97a3_11648db8","line":124,"updated":"2018-05-09 22:11:17.000000000","message":"strange, i thought i fixed this last ps","commit_id":"891947ffdda40ad8c01e9297492d2956581c522c"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"616aee99fafe36bd3891136ec09dffb1274b2d51","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    TOP_DIR\u003d$DEVSTACK_PATH"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    if [ -f source $DEVSTACK_PATH/local.conf ]; then"},{"line_number":82,"context_line":"        source $DEVSTACK_PATH/local.conf"},{"line_number":83,"context_line":"    fi"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    source $DEVSTACK_PATH/stackrc"}],"source_content_type":"text/x-sh","patch_set":4,"id":"5f7c97a3_ce7747a0","line":82,"updated":"2018-05-10 07:16:08.000000000","message":"On my env it generates errors because some functions are not available and because there are snippets from logs. I don\u0027t think this can cause any issues, so maybe using \"2\u003e /dev/null\" would be good to avoid generating misleading errors.","commit_id":"475bb8ab87abf08653231cdc5f45acf600695dcd"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"397a0f4793381ff4090dbe2ad47a41cb9677d87a","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    TOP_DIR\u003d$DEVSTACK_PATH"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    if [ -f source $DEVSTACK_PATH/local.conf ]; then"},{"line_number":82,"context_line":"        source $DEVSTACK_PATH/local.conf"},{"line_number":83,"context_line":"    fi"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    source $DEVSTACK_PATH/stackrc"}],"source_content_type":"text/x-sh","patch_set":4,"id":"5f7c97a3_3c2147b1","line":82,"in_reply_to":"5f7c97a3_ce7747a0","updated":"2018-05-10 21:03:06.000000000","message":"Done","commit_id":"475bb8ab87abf08653231cdc5f45acf600695dcd"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c7681949679d304300cb3336e4679e01636069f2","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"# _install_databases [install_pg]"},{"line_number":123,"context_line":"function _install_databases {"},{"line_number":124,"context_line":"    local install_pg\u003d${1:-False}"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    echo_summary \"Installing databases\""},{"line_number":127,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"5f7c97a3_822912e7","line":124,"updated":"2018-05-10 22:55:28.000000000","message":"the gift that keeps on giving :)","commit_id":"aea641ba228db66bd7401ae4f92f1b6abbceb236"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"388f74ec8357c75314c1234eeb68b6eed94c74ad","unresolved":false,"context_lines":[{"line_number":35,"context_line":"invoked only on a throw-away VM."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"NOTE: Default values in this file, such as passwords, have been taken"},{"line_number":38,"context_line":"from the devstack samples/local.conf file, but can be over-ridden by"},{"line_number":39,"context_line":"setting them in your environment if necessary.\""},{"line_number":40,"context_line":"    exit 1"},{"line_number":41,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":6,"id":"5f7c97a3_0138973a","line":38,"range":{"start_line":38,"start_character":54,"end_line":38,"end_character":65},"updated":"2018-05-11 12:36:40.000000000","message":"nit: shouldn\u0027t be \"overridden\" ?","commit_id":"ec07a63ec14a7ed91c227536986f9ad5a9892127"}]}