)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"7dbb20d5f58438797e8e603972bc639cb0346d26","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hamdy Khader \u003chamdyk@mellanox.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-05-10 15:59:47 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use Param DHCP_OPT_CLIENT_ID_NUMBER"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-On: Id8272ecfac41670693482f11d6bcb6ad211b993f"},{"line_number":10,"context_line":"Change-Id: I9728354d5f9e08a0dc23900b2bc22b4a0aedb737"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_316bbb85","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":35},"updated":"2018-05-10 13:11:59.000000000","message":"we should expain why we need to do the change and open a bug for it and release notes","commit_id":"51b74f3e518f8e34e90c0144985b15e93ccc3b36"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"f3472743181d689fa2561c29feee26a2ca4bc5dd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hamdy Khader \u003chamdyk@mellanox.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-05-10 15:59:47 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use Param DHCP_OPT_CLIENT_ID_NUMBER"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-On: Id8272ecfac41670693482f11d6bcb6ad211b993f"},{"line_number":10,"context_line":"Change-Id: I9728354d5f9e08a0dc23900b2bc22b4a0aedb737"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_c02cc603","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":35},"in_reply_to":"5f7c97a3_316bbb85","updated":"2018-05-13 12:36:19.000000000","message":"Done","commit_id":"51b74f3e518f8e34e90c0144985b15e93ccc3b36"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"cef1d8e5a41367f77324e88d854698e2a4825e90","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use Param DHCP_OPT_CLIENT_ID_NUMBER"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-On: Id8272ecfac41670693482f11d6bcb6ad211b993f"},{"line_number":10,"context_line":"Change-Id: I9728354d5f9e08a0dc23900b2bc22b4a0aedb737"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_1c16cba9","line":9,"updated":"2018-05-10 20:51:05.000000000","message":"Not sure you can do this as neutron-lib is a library.  Typically you would put the constant locally with a note that it can go away once neutron-lib with the constant is available.","commit_id":"51b74f3e518f8e34e90c0144985b15e93ccc3b36"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"f3472743181d689fa2561c29feee26a2ca4bc5dd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use Param DHCP_OPT_CLIENT_ID_NUMBER"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-On: Id8272ecfac41670693482f11d6bcb6ad211b993f"},{"line_number":10,"context_line":"Change-Id: I9728354d5f9e08a0dc23900b2bc22b4a0aedb737"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_60cff255","line":9,"in_reply_to":"5f7c97a3_1c16cba9","updated":"2018-05-13 12:36:19.000000000","message":"Done","commit_id":"51b74f3e518f8e34e90c0144985b15e93ccc3b36"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"39d1893a7a632a4352075dbe632a56f1731b53ab","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use Param DHCP_OPT_CLIENT_ID_NUM"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"DHCP option used to be \u0027client-id\u0027 and that causes issues with infiniband."},{"line_number":10,"context_line":"For infiniband we need to add \u0027client-id\u0027 DHCP option to get IP address,"},{"line_number":11,"context_line":"neutron change \u0027client-id\u0027 to number 61 to meet rfc4776."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5f7c97a3_0527f0cb","line":9,"range":{"start_line":9,"start_character":43,"end_line":9,"end_character":72},"updated":"2018-05-16 08:07:16.000000000","message":"you can point to the ironic commit that send Clinet-ID as 61. and explaining that due to that change. the neutron dhcp should support is as well","commit_id":"74919221811d4f81b5ce45063028a59c8a87a72d"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"91596ba735a60439f8445b65954b7d8acec58cc3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use Param DHCP_OPT_CLIENT_ID_NUM"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"DHCP option used to be \u0027client-id\u0027 and that causes issues with infiniband."},{"line_number":10,"context_line":"For infiniband we need to add \u0027client-id\u0027 DHCP option to get IP address,"},{"line_number":11,"context_line":"neutron change \u0027client-id\u0027 to number 61 to meet rfc4776."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5f7c97a3_8e679d4d","line":9,"range":{"start_line":9,"start_character":43,"end_line":9,"end_character":72},"in_reply_to":"5f7c97a3_0527f0cb","updated":"2018-05-16 10:05:29.000000000","message":"Done","commit_id":"74919221811d4f81b5ce45063028a59c8a87a72d"}],"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"7dbb20d5f58438797e8e603972bc639cb0346d26","unresolved":false,"context_lines":[{"line_number":733,"context_line":"    def _get_client_id(self, port):"},{"line_number":734,"context_line":"        if self._get_port_extra_dhcp_opts(port):"},{"line_number":735,"context_line":"            for opt in port.extra_dhcp_opts:"},{"line_number":736,"context_line":"                if opt.opt_name \u003d\u003d edo_ext.DHCP_OPT_CLIENT_ID \\"},{"line_number":737,"context_line":"                        or opt.opt_name \u003d\u003d edo_ext.DHCP_OPT_CLIENT_ID_NUMBER:"},{"line_number":738,"context_line":"                    return opt.opt_value"},{"line_number":739,"context_line":""},{"line_number":740,"context_line":"    def _read_hosts_file_leases(self, filename):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_514f5733","line":737,"range":{"start_line":736,"start_character":15,"end_line":737,"end_character":77},"updated":"2018-05-10 13:11:59.000000000","message":"just do if opt.opt_name in (edo_ext.DHCP_OPT_CLIENT_ID, edo_ext.DHCP_OPT_CLIENT_ID_NUMBER)","commit_id":"51b74f3e518f8e34e90c0144985b15e93ccc3b36"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"f3472743181d689fa2561c29feee26a2ca4bc5dd","unresolved":false,"context_lines":[{"line_number":733,"context_line":"    def _get_client_id(self, port):"},{"line_number":734,"context_line":"        if self._get_port_extra_dhcp_opts(port):"},{"line_number":735,"context_line":"            for opt in port.extra_dhcp_opts:"},{"line_number":736,"context_line":"                if opt.opt_name \u003d\u003d edo_ext.DHCP_OPT_CLIENT_ID \\"},{"line_number":737,"context_line":"                        or opt.opt_name \u003d\u003d edo_ext.DHCP_OPT_CLIENT_ID_NUMBER:"},{"line_number":738,"context_line":"                    return opt.opt_value"},{"line_number":739,"context_line":""},{"line_number":740,"context_line":"    def _read_hosts_file_leases(self, filename):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_c02fe63c","line":737,"range":{"start_line":736,"start_character":15,"end_line":737,"end_character":77},"in_reply_to":"5f7c97a3_514f5733","updated":"2018-05-13 12:36:19.000000000","message":"Done","commit_id":"51b74f3e518f8e34e90c0144985b15e93ccc3b36"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"04c55d9ab1080e9c1a9aa8171f174f9ce36b7656","unresolved":false,"context_lines":[{"line_number":733,"context_line":"    def _get_client_id(self, port):"},{"line_number":734,"context_line":"        if self._get_port_extra_dhcp_opts(port):"},{"line_number":735,"context_line":"            for opt in port.extra_dhcp_opts:"},{"line_number":736,"context_line":"                if opt.opt_name in [edo_ext.DHCP_OPT_CLIENT_ID,"},{"line_number":737,"context_line":"                                    n_const.DHCP_OPT_CLIENT_ID_NUM]:"},{"line_number":738,"context_line":"                    return opt.opt_value"},{"line_number":739,"context_line":""},{"line_number":740,"context_line":"    def _read_hosts_file_leases(self, filename):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_800b2e7b","line":737,"range":{"start_line":736,"start_character":34,"end_line":737,"end_character":67},"updated":"2018-05-13 12:52:56.000000000","message":"instead of list use set ()","commit_id":"acbcad205e5cd1ba6003ae4bc5f9f302ce6f5078"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"93a565c9fa0044906f8baba8790c06914c03c6ac","unresolved":false,"context_lines":[{"line_number":733,"context_line":"    def _get_client_id(self, port):"},{"line_number":734,"context_line":"        if self._get_port_extra_dhcp_opts(port):"},{"line_number":735,"context_line":"            for opt in port.extra_dhcp_opts:"},{"line_number":736,"context_line":"                if opt.opt_name in [edo_ext.DHCP_OPT_CLIENT_ID,"},{"line_number":737,"context_line":"                                    n_const.DHCP_OPT_CLIENT_ID_NUM]:"},{"line_number":738,"context_line":"                    return opt.opt_value"},{"line_number":739,"context_line":""},{"line_number":740,"context_line":"    def _read_hosts_file_leases(self, filename):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_a0d3cad4","line":737,"range":{"start_line":736,"start_character":34,"end_line":737,"end_character":67},"in_reply_to":"5f7c97a3_800b2e7b","updated":"2018-05-14 08:20:41.000000000","message":"Done","commit_id":"acbcad205e5cd1ba6003ae4bc5f9f302ce6f5078"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1238720be1678aa27f68c1d12182646be29ee6f6","unresolved":false,"context_lines":[{"line_number":60,"context_line":"DNSMASQ_SERVICE_NAME \u003d \u0027dnsmasq\u0027"},{"line_number":61,"context_line":"DHCP_RELEASE_TRIES \u003d 3"},{"line_number":62,"context_line":"DHCP_RELEASE_TRIES_SLEEP \u003d 0.3"},{"line_number":63,"context_line":"DHCP_OPT_CLIENT_ID_NUM \u003d 61"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"class DictModel(dict):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_15339464","line":63,"updated":"2018-05-16 18:23:14.000000000","message":"Please add a note saying this can be removed when neutron-lib is updated with this value.","commit_id":"bdc2edf43ebaab1b098d94a3277396e29613e5ee"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"dc48c63240bcdfdb2490d3a5243ff8a9c6eda13e","unresolved":false,"context_lines":[{"line_number":60,"context_line":"DNSMASQ_SERVICE_NAME \u003d \u0027dnsmasq\u0027"},{"line_number":61,"context_line":"DHCP_RELEASE_TRIES \u003d 3"},{"line_number":62,"context_line":"DHCP_RELEASE_TRIES_SLEEP \u003d 0.3"},{"line_number":63,"context_line":"DHCP_OPT_CLIENT_ID_NUM \u003d 61"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"class DictModel(dict):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_973a3f96","line":63,"in_reply_to":"5f7c97a3_15339464","updated":"2018-05-17 07:19:54.000000000","message":"Done","commit_id":"bdc2edf43ebaab1b098d94a3277396e29613e5ee"}],"neutron/common/constants.py":[{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"04c55d9ab1080e9c1a9aa8171f174f9ce36b7656","unresolved":false,"context_lines":[{"line_number":228,"context_line":"SI_BASE \u003d 1000"},{"line_number":229,"context_line":"IEC_BASE \u003d 1024"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"DHCP_OPT_CLIENT_ID_NUM \u003d 61"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_60261218","line":231,"range":{"start_line":231,"start_character":0,"end_line":231,"end_character":27},"updated":"2018-05-13 12:52:56.000000000","message":"put it in the dhcp file for now, it merged we can move it to neutron-lib","commit_id":"acbcad205e5cd1ba6003ae4bc5f9f302ce6f5078"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"93a565c9fa0044906f8baba8790c06914c03c6ac","unresolved":false,"context_lines":[{"line_number":228,"context_line":"SI_BASE \u003d 1000"},{"line_number":229,"context_line":"IEC_BASE \u003d 1024"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"DHCP_OPT_CLIENT_ID_NUM \u003d 61"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_40575659","line":231,"range":{"start_line":231,"start_character":0,"end_line":231,"end_character":27},"in_reply_to":"5f7c97a3_60261218","updated":"2018-05-14 08:20:41.000000000","message":"Done","commit_id":"acbcad205e5cd1ba6003ae4bc5f9f302ce6f5078"}],"neutron/tests/unit/agent/linux/test_dhcp.py":[{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"6919a1251c6d38eb829fbcb1595cd9aa68cc330d","unresolved":false,"context_lines":[{"line_number":358,"context_line":""},{"line_number":359,"context_line":"class FakePortIB(object):"},{"line_number":360,"context_line":"    def __init__(self):"},{"line_number":361,"context_line":"        # self.id \u003d \u0027eeeeeeee-eeee-eeee-eeee-eeeeeeeeeee\u0027"},{"line_number":362,"context_line":"        # self.admin_state_up \u003d True"},{"line_number":363,"context_line":"        # self.device_owner \u003d \u0027foo5\u0027"},{"line_number":364,"context_line":"        # self.fixed_ips \u003d ["},{"line_number":365,"context_line":"        #     FakeIPAllocation(\u0027192.168.0.5\u0027,"},{"line_number":366,"context_line":"        #                      \u0027dddddddd-dddd-dddd-dddd-dddddddddddd\u0027)]"},{"line_number":367,"context_line":"        # self.dns_assignment \u003d [FakeDNSAssignment(\u0027192.168.0.5\u0027)]"},{"line_number":368,"context_line":"        # self.mac_address \u003d \u002700:00:0f:aa:bb:55\u0027"},{"line_number":369,"context_line":"        # self.device_id \u003d \u0027fake_port5\u0027"},{"line_number":370,"context_line":"        self.extra_dhcp_opts \u003d ["},{"line_number":371,"context_line":"            DhcpOpt(opt_name\u003ddhcp.DHCP_OPT_CLIENT_ID_NUM,"},{"line_number":372,"context_line":"                    opt_value\u003d\u0027test_ib\u0027)]"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_adc97559","line":369,"range":{"start_line":361,"start_character":0,"end_line":369,"end_character":39},"updated":"2018-05-14 12:00:27.000000000","message":"why is it in comment?","commit_id":"d1bfbf2aaea8cac513c552a5c25fc78d9d2bcf24"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"bb5dcce2f771be0bb4f96d10c77687c0d45bc92e","unresolved":false,"context_lines":[{"line_number":358,"context_line":""},{"line_number":359,"context_line":"class FakePortIB(object):"},{"line_number":360,"context_line":"    def __init__(self):"},{"line_number":361,"context_line":"        # self.id \u003d \u0027eeeeeeee-eeee-eeee-eeee-eeeeeeeeeee\u0027"},{"line_number":362,"context_line":"        # self.admin_state_up \u003d True"},{"line_number":363,"context_line":"        # self.device_owner \u003d \u0027foo5\u0027"},{"line_number":364,"context_line":"        # self.fixed_ips \u003d ["},{"line_number":365,"context_line":"        #     FakeIPAllocation(\u0027192.168.0.5\u0027,"},{"line_number":366,"context_line":"        #                      \u0027dddddddd-dddd-dddd-dddd-dddddddddddd\u0027)]"},{"line_number":367,"context_line":"        # self.dns_assignment \u003d [FakeDNSAssignment(\u0027192.168.0.5\u0027)]"},{"line_number":368,"context_line":"        # self.mac_address \u003d \u002700:00:0f:aa:bb:55\u0027"},{"line_number":369,"context_line":"        # self.device_id \u003d \u0027fake_port5\u0027"},{"line_number":370,"context_line":"        self.extra_dhcp_opts \u003d ["},{"line_number":371,"context_line":"            DhcpOpt(opt_name\u003ddhcp.DHCP_OPT_CLIENT_ID_NUM,"},{"line_number":372,"context_line":"                    opt_value\u003d\u0027test_ib\u0027)]"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_8516a0a7","line":369,"range":{"start_line":361,"start_character":0,"end_line":369,"end_character":39},"in_reply_to":"5f7c97a3_adc97559","updated":"2018-05-16 07:59:26.000000000","message":"Done","commit_id":"d1bfbf2aaea8cac513c552a5c25fc78d9d2bcf24"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"6919a1251c6d38eb829fbcb1595cd9aa68cc330d","unresolved":false,"context_lines":[{"line_number":639,"context_line":"        self.namespace \u003d \u0027qdhcp-ns\u0027"},{"line_number":640,"context_line":""},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"class FakeV4NetworkClientIdWithIB(object):"},{"line_number":643,"context_line":"    def __init__(self):"},{"line_number":644,"context_line":"        self.id \u003d \u0027aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa\u0027"},{"line_number":645,"context_line":"        self.subnets \u003d [FakeV4Subnet()]"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_6dd4bde9","line":642,"range":{"start_line":642,"start_character":6,"end_line":642,"end_character":33},"updated":"2018-05-14 12:00:27.000000000","message":"you should have Client-ID with PARM_NUMA or Clien-id string. (IB is just the use case you shouldn\u0027t mention it in the test","commit_id":"d1bfbf2aaea8cac513c552a5c25fc78d9d2bcf24"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"bb5dcce2f771be0bb4f96d10c77687c0d45bc92e","unresolved":false,"context_lines":[{"line_number":639,"context_line":"        self.namespace \u003d \u0027qdhcp-ns\u0027"},{"line_number":640,"context_line":""},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"class FakeV4NetworkClientIdWithIB(object):"},{"line_number":643,"context_line":"    def __init__(self):"},{"line_number":644,"context_line":"        self.id \u003d \u0027aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa\u0027"},{"line_number":645,"context_line":"        self.subnets \u003d [FakeV4Subnet()]"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_650fc487","line":642,"range":{"start_line":642,"start_character":6,"end_line":642,"end_character":33},"in_reply_to":"5f7c97a3_6dd4bde9","updated":"2018-05-16 07:59:26.000000000","message":"Done","commit_id":"d1bfbf2aaea8cac513c552a5c25fc78d9d2bcf24"}],"releasenotes/notes/ib-dhcp-allocation-fix-a4ebe8b55bb2c065.yaml":[{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"39d1893a7a632a4352075dbe632a56f1731b53ab","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    DHCP option used to be \u0027client-id\u0027 and that causes issues with"},{"line_number":5,"context_line":"    infiniband. For infiniband we need to add \u0027client-id\u0027 DHCP "},{"line_number":6,"context_line":"    option to get IP address, neutron change \u0027client-id\u0027 to "},{"line_number":7,"context_line":"    number 61 to meet rfc4776. Bug info"},{"line_number":8,"context_line":"    `1770932 \u003chttps://bugs.launchpad.net/neutron/+bug/1770932\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f7c97a3_a5363c02","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":62},"updated":"2018-05-16 08:07:16.000000000","message":"you should mentioned that ironic is sending client-id as numner (for infinband baremtal provision) so we should support it in the neutron dhcp agent","commit_id":"74919221811d4f81b5ce45063028a59c8a87a72d"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"91596ba735a60439f8445b65954b7d8acec58cc3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    DHCP option used to be \u0027client-id\u0027 and that causes issues with"},{"line_number":5,"context_line":"    infiniband. For infiniband we need to add \u0027client-id\u0027 DHCP "},{"line_number":6,"context_line":"    option to get IP address, neutron change \u0027client-id\u0027 to "},{"line_number":7,"context_line":"    number 61 to meet rfc4776. Bug info"},{"line_number":8,"context_line":"    `1770932 \u003chttps://bugs.launchpad.net/neutron/+bug/1770932\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f7c97a3_0ecdcd83","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":62},"in_reply_to":"5f7c97a3_a5363c02","updated":"2018-05-16 10:05:29.000000000","message":"Done","commit_id":"74919221811d4f81b5ce45063028a59c8a87a72d"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"39d1893a7a632a4352075dbe632a56f1731b53ab","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    DHCP option used to be \u0027client-id\u0027 and that causes issues with"},{"line_number":5,"context_line":"    infiniband. For infiniband we need to add \u0027client-id\u0027 DHCP "},{"line_number":6,"context_line":"    option to get IP address, neutron change \u0027client-id\u0027 to "},{"line_number":7,"context_line":"    number 61 to meet rfc4776. Bug info"},{"line_number":8,"context_line":"    `1770932 \u003chttps://bugs.launchpad.net/neutron/+bug/1770932\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f7c97a3_255d4c46","line":6,"range":{"start_line":6,"start_character":59,"end_line":6,"end_character":60},"updated":"2018-05-16 08:07:16.000000000","message":"white space","commit_id":"74919221811d4f81b5ce45063028a59c8a87a72d"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"91596ba735a60439f8445b65954b7d8acec58cc3","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    DHCP option used to be \u0027client-id\u0027 and that causes issues with"},{"line_number":5,"context_line":"    infiniband. For infiniband we need to add \u0027client-id\u0027 DHCP "},{"line_number":6,"context_line":"    option to get IP address, neutron change \u0027client-id\u0027 to "},{"line_number":7,"context_line":"    number 61 to meet rfc4776. Bug info"},{"line_number":8,"context_line":"    `1770932 \u003chttps://bugs.launchpad.net/neutron/+bug/1770932\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f7c97a3_c874ad00","line":6,"range":{"start_line":6,"start_character":59,"end_line":6,"end_character":60},"in_reply_to":"5f7c97a3_255d4c46","updated":"2018-05-16 10:05:29.000000000","message":"Done","commit_id":"74919221811d4f81b5ce45063028a59c8a87a72d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1238720be1678aa27f68c1d12182646be29ee6f6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Ironic is sending client-id as number (also for infinband baremtal"},{"line_number":5,"context_line":"    provision) so neutron dhcp agent should support it."},{"line_number":6,"context_line":"    For infiniband we need to add \u0027client-id\u0027 DHCP option to get"},{"line_number":7,"context_line":"    IP address, neutron change \u0027client-id\u0027 to number 61 to meet rfc4776."},{"line_number":8,"context_line":"    Bug info"},{"line_number":9,"context_line":"    `1770932 \u003chttps://bugs.launchpad.net/neutron/+bug/1770932\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f7c97a3_35ea50ac","line":7,"updated":"2018-05-16 18:23:14.000000000","message":"These two sentences seem to be saying the same thing, and there is a typo in the first.  Perhaps:\n\nFor Infiniband support, Ironic needs to send the \u0027client-id\u0027 DHCP option as a number in order for IP address assignment to work.  This is now supported in Neutron, and can be specified as option number 61 as defined in RFC 4776.  For more information see bug\n`1770932 \u003chttps://bugs.launchpad.net/neutron/+bug/1770932\u003e`_","commit_id":"bdc2edf43ebaab1b098d94a3277396e29613e5ee"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"dc48c63240bcdfdb2490d3a5243ff8a9c6eda13e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Ironic is sending client-id as number (also for infinband baremtal"},{"line_number":5,"context_line":"    provision) so neutron dhcp agent should support it."},{"line_number":6,"context_line":"    For infiniband we need to add \u0027client-id\u0027 DHCP option to get"},{"line_number":7,"context_line":"    IP address, neutron change \u0027client-id\u0027 to number 61 to meet rfc4776."},{"line_number":8,"context_line":"    Bug info"},{"line_number":9,"context_line":"    `1770932 \u003chttps://bugs.launchpad.net/neutron/+bug/1770932\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f7c97a3_37db2b50","line":7,"in_reply_to":"5f7c97a3_35ea50ac","updated":"2018-05-17 07:19:54.000000000","message":"thanks","commit_id":"bdc2edf43ebaab1b098d94a3277396e29613e5ee"}]}
