)]}'
{"neutron/db/loadbalancer/loadbalancer_db.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"14b600bb6233c36141894d2890c7415ec70e9711","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from sqlalchemy import orm"},{"line_number":20,"context_line":"from sqlalchemy.orm import exc"},{"line_number":21,"context_line":"from sqlalchemy.orm import validates"},{"line_number":22,"context_line":"from sqlalchemy.schema import UniqueConstraint"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from neutron.api.v2 import attributes"},{"line_number":25,"context_line":"from neutron.common import exceptions as q_exc"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2B%2BNA%3D","line":22,"updated":"2013-11-17 18:05:33.000000000","message":"not really needed.","commit_id":"77200c24fdbaf6c46981322ddf7767673b184232"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"14b600bb6233c36141894d2890c7415ec70e9711","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    protocol_port \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":105,"context_line":"    weight \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":106,"context_line":"    admin_state_up \u003d sa.Column(sa.Boolean(), nullable\u003dFalse)"},{"line_number":107,"context_line":"    UniqueConstraint(\u0027pool_id\u0027, \u0027address\u0027, \u0027protocol_port\u0027,"},{"line_number":108,"context_line":"                     name\u003d\u0027uniq_member0pool_id0address0port\u0027)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2B%2BM0%3D","line":107,"updated":"2013-11-17 18:05:33.000000000","message":"Consider:\n 1. sa.UniqueConstraint()\n 2. wrap it in __table_args__:\n__table_args__ \u003d (sa.Uniq...() )","commit_id":"77200c24fdbaf6c46981322ddf7767673b184232"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d09138f1fea514db77fe51453b482d44d214fc8f","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    __table_args__ \u003d ("},{"line_number":101,"context_line":"        sa.schema.UniqueConstraint(\u0027pool_id\u0027, \u0027address\u0027, \u0027protocol_port\u0027,"},{"line_number":102,"context_line":"                                    name\u003d\u0027uniq_member0pool_id0address0port\u0027)"},{"line_number":103,"context_line":"    )"},{"line_number":104,"context_line":"    pool_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"pools.id\"),"},{"line_number":105,"context_line":"                        nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2B2k8%3D","line":102,"updated":"2013-11-19 11:00:54.000000000","message":"looks like you need a comma after this closing bracket.\nThat was the reason of those sqla failures","commit_id":"6e9701f872147029010ba081aba898d857089dcb"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e6dcdac02d332ce52d234898f84ab77c3b1a9ee0","unresolved":false,"context_lines":[{"line_number":686,"context_line":"            try:"},{"line_number":687,"context_line":"                context.session.add(member_db)"},{"line_number":688,"context_line":"            except exc.IntegrityError, e:"},{"line_number":689,"context_line":"                raise loadbalancer.DuplicateMember("},{"line_number":690,"context_line":"                    address\u003dv[\u0027address\u0027],"},{"line_number":691,"context_line":"                    port\u003dv[\u0027protocol_port\u0027],"},{"line_number":692,"context_line":"                    pool\u003dv[\u0027pool_id\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2B2xk%3D","line":689,"updated":"2013-11-19 10:15:52.000000000","message":"can IntegrityError be caused by any other reason (for ex pool_id not found in pools table)? Then raising DuplicateMember in such cases is not correct.","commit_id":"6e9701f872147029010ba081aba898d857089dcb"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d09138f1fea514db77fe51453b482d44d214fc8f","unresolved":false,"context_lines":[{"line_number":686,"context_line":"            try:"},{"line_number":687,"context_line":"                context.session.add(member_db)"},{"line_number":688,"context_line":"            except exc.IntegrityError, e:"},{"line_number":689,"context_line":"                raise loadbalancer.DuplicateMember("},{"line_number":690,"context_line":"                    address\u003dv[\u0027address\u0027],"},{"line_number":691,"context_line":"                    port\u003dv[\u0027protocol_port\u0027],"},{"line_number":692,"context_line":"                    pool\u003dv[\u0027pool_id\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2B2kg%3D","line":689,"in_reply_to":"AAAATn%2F%2B2xk%3D","updated":"2013-11-19 11:00:54.000000000","message":"In fact checking for the member uniqueness might be an overkill in this case.\nI think more generic exception could be considered here.","commit_id":"6e9701f872147029010ba081aba898d857089dcb"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e6dcdac02d332ce52d234898f84ab77c3b1a9ee0","unresolved":false,"context_lines":[{"line_number":703,"context_line":"                try:"},{"line_number":704,"context_line":"                    member_db.update(v)"},{"line_number":705,"context_line":"                except exc.IntegrityError, e:"},{"line_number":706,"context_line":"                    raise loadbalancer.DuplicateMember("},{"line_number":707,"context_line":"                        address\u003dv[\u0027address\u0027],"},{"line_number":708,"context_line":"                        port\u003dv[\u0027protocol_port\u0027],"},{"line_number":709,"context_line":"                        pool\u003dv[\u0027pool_id\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2B2xU%3D","line":706,"updated":"2013-11-19 10:15:52.000000000","message":"ditto","commit_id":"6e9701f872147029010ba081aba898d857089dcb"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"9e1801bb4802bf3d900ec91862e33f6c890f4958","unresolved":false,"context_lines":[{"line_number":701,"context_line":"            self.assert_modification_allowed(member_db)"},{"line_number":702,"context_line":"            if v:"},{"line_number":703,"context_line":"                try:"},{"line_number":704,"context_line":"                    member_db.update(v)"},{"line_number":705,"context_line":"                except exception.DBDuplicateEntry:"},{"line_number":706,"context_line":"                    raise loadbalancer.MemberExists("},{"line_number":707,"context_line":"                        address\u003dv[\u0027address\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2B0PU%3D","line":704,"updated":"2013-11-19 19:18:03.000000000","message":"I guess you need to flush the session here to, similar to L688, or otherwise you\u0027ll not be able to catch DBDuplicateEntry.","commit_id":"6ee7580356c4567be58a7664402be95d06f3f023"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"9e1801bb4802bf3d900ec91862e33f6c890f4958","unresolved":false,"context_lines":[{"line_number":704,"context_line":"                    member_db.update(v)"},{"line_number":705,"context_line":"                except exception.DBDuplicateEntry:"},{"line_number":706,"context_line":"                    raise loadbalancer.MemberExists("},{"line_number":707,"context_line":"                        address\u003dv[\u0027address\u0027],"},{"line_number":708,"context_line":"                        port\u003dv[\u0027protocol_port\u0027],"},{"line_number":709,"context_line":"                        pool\u003dv[\u0027pool_id\u0027])"},{"line_number":710,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2B0Ok%3D","line":707,"updated":"2013-11-19 19:18:03.000000000","message":"It\u0027s not safe to use these fields like this. They are not necessary provided in the input, e.g. in v.\nUse member_db instead.","commit_id":"6ee7580356c4567be58a7664402be95d06f3f023"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"7ae604eb93d2814f5f42ca782ca47a576e9341d1","unresolved":false,"context_lines":[{"line_number":686,"context_line":"                                   admin_state_up\u003dv[\u0027admin_state_up\u0027],"},{"line_number":687,"context_line":"                                   status\u003dconstants.PENDING_CREATE)"},{"line_number":688,"context_line":"                context.session.add(member_db)"},{"line_number":689,"context_line":"                context.session.flush()"},{"line_number":690,"context_line":"                return self._make_member_dict(member_db)"},{"line_number":691,"context_line":"            except exception.DBDuplicateEntry:"},{"line_number":692,"context_line":"                raise loadbalancer.MemberExists("}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2BZg4%3D","line":689,"updated":"2013-11-26 14:46:09.000000000","message":"What would be the need for moving data to the transaction buffer with a flush?\nI guess you want to see is you\u0027re violating the unique constraint. That would happen anyway on commit, so perhaps you can wrap the with block in the try...catch block and avoid the explicit flush","commit_id":"1df2906e34db8a056ef385e595d1989f6c211725"},{"author":{"_account_id":6624,"name":"Stephen Gran","email":"sgran@debian.org","username":"sgran"},"change_message_id":"eeb4aed03b7d8140590b92246240b7586c364dbc","unresolved":false,"context_lines":[{"line_number":686,"context_line":"                                   admin_state_up\u003dv[\u0027admin_state_up\u0027],"},{"line_number":687,"context_line":"                                   status\u003dconstants.PENDING_CREATE)"},{"line_number":688,"context_line":"                context.session.add(member_db)"},{"line_number":689,"context_line":"                context.session.flush()"},{"line_number":690,"context_line":"                return self._make_member_dict(member_db)"},{"line_number":691,"context_line":"            except exception.DBDuplicateEntry:"},{"line_number":692,"context_line":"                raise loadbalancer.MemberExists("}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2BY0M%3D","line":689,"in_reply_to":"AAAATn%2F%2BZQ4%3D","updated":"2013-11-26 16:23:37.000000000","message":"No, I wasn\u0027t seeing that - I just wasn\u0027t wrapping the with statement.  I\u0027ve moved it that way around and it seems fine now.","commit_id":"1df2906e34db8a056ef385e595d1989f6c211725"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"e253371eff744992429fd49d08cb330f9c2d3592","unresolved":false,"context_lines":[{"line_number":686,"context_line":"                                   admin_state_up\u003dv[\u0027admin_state_up\u0027],"},{"line_number":687,"context_line":"                                   status\u003dconstants.PENDING_CREATE)"},{"line_number":688,"context_line":"                context.session.add(member_db)"},{"line_number":689,"context_line":"                context.session.flush()"},{"line_number":690,"context_line":"                return self._make_member_dict(member_db)"},{"line_number":691,"context_line":"            except exception.DBDuplicateEntry:"},{"line_number":692,"context_line":"                raise loadbalancer.MemberExists("}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2BZQ4%3D","line":689,"in_reply_to":"AAAATn%2F%2BZg4%3D","updated":"2013-11-26 15:23:33.000000000","message":"I think that was done to avoid \u0027NoneType exception blabla\u0027 issue that happens if whole with-block is wrapped in try-except","commit_id":"1df2906e34db8a056ef385e595d1989f6c211725"}],"neutron/db/migration/alembic_migrations/versions/e197124d4b9_add_unique_constrain.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"e1f8ec66f755836c8e616318645b526d2a4d95a9","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# Change to [\u0027*\u0027] if this migration applies to all plugins"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"migration_for_plugins \u003d ["},{"line_number":33,"context_line":"    \u0027neutron.services.loadbalancer.plugin.LoadBalancerPlugin\u0027,"},{"line_number":34,"context_line":"]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"from alembic import op"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2B%2BYE%3D","line":33,"updated":"2013-11-17 11:47:58.000000000","message":"i think it also applies to neutron.plugins.nicira.NeutronServicePlugin.NvpAdvancedPlugin","commit_id":"7eac66f3125830373590c3db13315348b9fbc497"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"27cb08570404ffa1f6141f1df2db6ac826a8febb","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# Change to [\u0027*\u0027] if this migration applies to all plugins"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"migration_for_plugins \u003d ["},{"line_number":33,"context_line":"    \u0027neutron.services.loadbalancer.plugin.LoadBalancerPlugin\u0027,"},{"line_number":34,"context_line":"]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"from alembic import op"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2B%2BMo%3D","line":33,"updated":"2013-11-17 18:10:01.000000000","message":"still NiciraServicePlugin is missing.","commit_id":"77200c24fdbaf6c46981322ddf7767673b184232"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"27cb08570404ffa1f6141f1df2db6ac826a8febb","unresolved":false,"context_lines":[{"line_number":37,"context_line":"from neutron.db import migration"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"CONSTRAINT_NAME \u003d \u0027uniq_member0pool_id0address0port\u0027"},{"line_number":41,"context_line":"TABLE_NAME \u003d \u0027members\u0027"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2B%2BMk%3D","line":40,"updated":"2013-11-17 18:10:01.000000000","message":"uniq_members0...?","commit_id":"77200c24fdbaf6c46981322ddf7767673b184232"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"9e1801bb4802bf3d900ec91862e33f6c890f4958","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# Change to [\u0027*\u0027] if this migration applies to all plugins"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"migration_for_plugins \u003d ["},{"line_number":33,"context_line":"    \u0027neutron.services.loadbalancer.plugin.LoadBalancerPlugin\u0027,"},{"line_number":34,"context_line":"]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"from alembic import op"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2B0QI%3D","line":33,"updated":"2013-11-19 19:18:03.000000000","message":"still nicira plugin is missing. please add","commit_id":"6ee7580356c4567be58a7664402be95d06f3f023"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f1489540b32f2955719dd538e2a0b4b68a3b305b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    \u0027neutron.services.loadbalancer.plugin.LoadBalancerPlugin\u0027,"},{"line_number":34,"context_line":"]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"from alembic import op"},{"line_number":37,"context_line":"from neutron.db import migration"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2ByPs%3D","line":36,"updated":"2013-11-20 08:33:10.000000000","message":"please put an empty line after this in respect to HACKING rules","commit_id":"6ee7580356c4567be58a7664402be95d06f3f023"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"04432fa2f1b80dfb926745cb6c6fb0d4744cfa3a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# Change to [\u0027*\u0027] if this migration applies to all plugins"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"migration_for_plugins \u003d ["},{"line_number":33,"context_line":"    \u0027neutron.services.loadbalancer.plugin.LoadBalancerPlugin\u0027,"},{"line_number":34,"context_line":"]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"from alembic import op"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2Bjo0%3D","line":33,"updated":"2013-11-23 17:43:10.000000000","message":"please don\u0027t forget to add nicira service plugin to this list","commit_id":"ccafa8d02c7662c7385f5bf5417f451625c5cf1e"}],"neutron/extensions/loadbalancer.py":[{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"8d7cb0a66dc2f563a46acaa5fc8830d67bdfa277","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"class MemberExists(qexception.NeutronException):"},{"line_number":80,"context_line":"    message \u003d _(\"Member with address %(address)s and port %(port)s \""},{"line_number":81,"context_line":"                \"already present in pool %(pool)s\")"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2BavI%3D","line":81,"updated":"2013-11-26 10:30:11.000000000","message":"nit: present -\u003e exist ?","commit_id":"1df2906e34db8a056ef385e595d1989f6c211725"},{"author":{"_account_id":6624,"name":"Stephen Gran","email":"sgran@debian.org","username":"sgran"},"change_message_id":"a4b84186f6890606d8785409022b4ff2d659a693","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"class MemberExists(qexception.NeutronException):"},{"line_number":80,"context_line":"    message \u003d _(\"Member with address %(address)s and port %(port)s \""},{"line_number":81,"context_line":"                \"already present in pool %(pool)s\")"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2BadA%3D","line":81,"in_reply_to":"AAAATn%2F%2BavI%3D","updated":"2013-11-26 11:26:39.000000000","message":"I think the wording is debatable.  I chose \u0027present\u0027 because the same backend ip/port can be present in several pools.  That being said, I don\u0027t mind and I\u0027m happy to change it if you feel strongly.","commit_id":"1df2906e34db8a056ef385e595d1989f6c211725"}],"neutron/tests/unit/db/loadbalancer/test_db_loadbalancer.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e6dcdac02d332ce52d234898f84ab77c3b1a9ee0","unresolved":false,"context_lines":[{"line_number":762,"context_line":"                    self.assertIn(member2[\u0027member\u0027][\u0027id\u0027],"},{"line_number":763,"context_line":"                                  pool_update[\u0027pool\u0027][\u0027members\u0027])"},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"    def test_create_member_twice_for_same_pool(self):"},{"line_number":766,"context_line":"        with self.subnet() as subnet:"},{"line_number":767,"context_line":"            with self.pool(name\u003d\"pool1\") as pool:"},{"line_number":768,"context_line":"                pool_id \u003d pool[\u0027pool\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2B2wo%3D","line":765,"updated":"2013-11-19 10:15:52.000000000","message":"consider test_create_same_member_twice_for_same_pool","commit_id":"6e9701f872147029010ba081aba898d857089dcb"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"7ae604eb93d2814f5f42ca782ca47a576e9341d1","unresolved":false,"context_lines":[{"line_number":819,"context_line":"                    self.assertIn(member2[\u0027member\u0027][\u0027id\u0027],"},{"line_number":820,"context_line":"                                  pool_update[\u0027pool\u0027][\u0027members\u0027])"},{"line_number":821,"context_line":""},{"line_number":822,"context_line":"    def test_create_same_member_twice_for_same_pool(self):"},{"line_number":823,"context_line":"        with self.subnet():"},{"line_number":824,"context_line":"            with self.pool(name\u003d\"pool1\") as pool:"},{"line_number":825,"context_line":"                pool_id \u003d pool[\u0027pool\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2BZf4%3D","line":822,"updated":"2013-11-26 14:46:09.000000000","message":"nit - make explicit the test expects a failure\n\neg: test_create_member_twice_on_same_pool_raises","commit_id":"1df2906e34db8a056ef385e595d1989f6c211725"},{"author":{"_account_id":6624,"name":"Stephen Gran","email":"sgran@debian.org","username":"sgran"},"change_message_id":"eeb4aed03b7d8140590b92246240b7586c364dbc","unresolved":false,"context_lines":[{"line_number":819,"context_line":"                    self.assertIn(member2[\u0027member\u0027][\u0027id\u0027],"},{"line_number":820,"context_line":"                                  pool_update[\u0027pool\u0027][\u0027members\u0027])"},{"line_number":821,"context_line":""},{"line_number":822,"context_line":"    def test_create_same_member_twice_for_same_pool(self):"},{"line_number":823,"context_line":"        with self.subnet():"},{"line_number":824,"context_line":"            with self.pool(name\u003d\"pool1\") as pool:"},{"line_number":825,"context_line":"                pool_id \u003d pool[\u0027pool\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2BY0A%3D","line":822,"in_reply_to":"AAAATn%2F%2BZQQ%3D","updated":"2013-11-26 16:23:37.000000000","message":"Done","commit_id":"1df2906e34db8a056ef385e595d1989f6c211725"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"e253371eff744992429fd49d08cb330f9c2d3592","unresolved":false,"context_lines":[{"line_number":819,"context_line":"                    self.assertIn(member2[\u0027member\u0027][\u0027id\u0027],"},{"line_number":820,"context_line":"                                  pool_update[\u0027pool\u0027][\u0027members\u0027])"},{"line_number":821,"context_line":""},{"line_number":822,"context_line":"    def test_create_same_member_twice_for_same_pool(self):"},{"line_number":823,"context_line":"        with self.subnet():"},{"line_number":824,"context_line":"            with self.pool(name\u003d\"pool1\") as pool:"},{"line_number":825,"context_line":"                pool_id \u003d pool[\u0027pool\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2BZQQ%3D","line":822,"in_reply_to":"AAAATn%2F%2BZf4%3D","updated":"2013-11-26 15:23:33.000000000","message":"agree","commit_id":"1df2906e34db8a056ef385e595d1989f6c211725"}]}
