)]}'
{"neutron/agent/common/ovs_lib.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f034ea5412ba25660580edfc878bfbbb782cd126","unresolved":false,"context_lines":[{"line_number":862,"context_line":"            max_bw_in_bytes \u003d other_config.get(\"cir\")"},{"line_number":863,"context_line":"            if max_bw_in_bytes is not None:"},{"line_number":864,"context_line":"                max_kbps \u003d common_utils.bits_to_kilobits("},{"line_number":865,"context_line":"                    common_utils.bytes_to_bits(int(float(max_bw_in_bytes))),"},{"line_number":866,"context_line":"                    common_constants.SI_BASE)"},{"line_number":867,"context_line":"            max_burst_in_bytes \u003d other_config.get(\"cbs\")"},{"line_number":868,"context_line":"            if max_burst_in_bytes is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_3d3c8e2d","line":865,"updated":"2018-05-15 20:01:03.000000000","message":"should we fix this in bytes_to_bits() ?\n\nreturn int(float(value) * 8)","commit_id":"f3f2436d6db724126e5611d632b7d1efe309a2af"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"7ccf2933ad940c3910a66db6cc04a72441e5b2eb","unresolved":false,"context_lines":[{"line_number":862,"context_line":"            max_bw_in_bytes \u003d other_config.get(\"cir\")"},{"line_number":863,"context_line":"            if max_bw_in_bytes is not None:"},{"line_number":864,"context_line":"                max_kbps \u003d common_utils.bits_to_kilobits("},{"line_number":865,"context_line":"                    common_utils.bytes_to_bits(int(float(max_bw_in_bytes))),"},{"line_number":866,"context_line":"                    common_constants.SI_BASE)"},{"line_number":867,"context_line":"            max_burst_in_bytes \u003d other_config.get(\"cbs\")"},{"line_number":868,"context_line":"            if max_burst_in_bytes is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_5d12aa63","line":865,"in_reply_to":"5f7c97a3_3d3c8e2d","updated":"2018-05-15 20:14:38.000000000","message":"Done","commit_id":"f3f2436d6db724126e5611d632b7d1efe309a2af"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"86452cb426e4601982a4e317e6a37f256daa1406","unresolved":false,"context_lines":[{"line_number":862,"context_line":"            max_bw_in_bytes \u003d other_config.get(\"cir\")"},{"line_number":863,"context_line":"            if max_bw_in_bytes is not None:"},{"line_number":864,"context_line":"                max_kbps \u003d common_utils.bits_to_kilobits("},{"line_number":865,"context_line":"                    common_utils.bytes_to_bits(int(float(max_bw_in_bytes))),"},{"line_number":866,"context_line":"                    common_constants.SI_BASE)"},{"line_number":867,"context_line":"            max_burst_in_bytes \u003d other_config.get(\"cbs\")"},{"line_number":868,"context_line":"            if max_burst_in_bytes is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_90d5891e","line":865,"in_reply_to":"5f7c97a3_506e11c9","updated":"2018-05-15 20:33:23.000000000","message":"Yeah, I guess you\u0027re right, I had looked at bits_to_kilobits() right below it but it\u0027s returning int(*) since the result might have been a float.  Unless we always pass float(*) and have it return int(*), but then i\u0027m starting to over-think this.","commit_id":"f3f2436d6db724126e5611d632b7d1efe309a2af"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"7de9d19499d6eee7bce781909416d1e1eac73a41","unresolved":false,"context_lines":[{"line_number":862,"context_line":"            max_bw_in_bytes \u003d other_config.get(\"cir\")"},{"line_number":863,"context_line":"            if max_bw_in_bytes is not None:"},{"line_number":864,"context_line":"                max_kbps \u003d common_utils.bits_to_kilobits("},{"line_number":865,"context_line":"                    common_utils.bytes_to_bits(int(float(max_bw_in_bytes))),"},{"line_number":866,"context_line":"                    common_constants.SI_BASE)"},{"line_number":867,"context_line":"            max_burst_in_bytes \u003d other_config.get(\"cbs\")"},{"line_number":868,"context_line":"            if max_burst_in_bytes is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_506e11c9","line":865,"in_reply_to":"5f7c97a3_5d12aa63","updated":"2018-05-15 20:18:58.000000000","message":"Thinking about it, I don\u0027t think it\u0027s semantically correct to pass string to bytes_to_bits() function. I think it should just accept int. What do you think?","commit_id":"f3f2436d6db724126e5611d632b7d1efe309a2af"}]}
