)]}'
{"neutron/tests/unit/extensions/test_segment.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"11e1463dd272649518b25bb7e9effad0fab7387c","unresolved":false,"context_lines":[{"line_number":61,"context_line":"HTTP_NOT_FOUND \u003d 404"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"def is_new_keystoneauth(version\u003d\u00273.7.0\u0027):"},{"line_number":65,"context_line":"    ksa_version \u003d du_version.StrictVersion(keystoneauth1.__version__)"},{"line_number":66,"context_line":"    target \u003d du_version.StrictVersion(version)"},{"line_number":67,"context_line":"    return ksa_version \u003e\u003d target"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_9f1ba8c8","line":64,"range":{"start_line":64,"start_character":4,"end_line":64,"end_character":23},"updated":"2018-05-28 08:41:57.000000000","message":"I don\u0027t think that this name is good here. Maybe something like \"keystoneauth_version()\" which would return real version of ksa would be better?\nThen You can just do something like:\n    if keystoneauth_version() \u003e\u003d \u00273.7.0\u0027:\n        do_somethinng_new()\n\nIMO that would be more clear for future readers :)","commit_id":"ea757b7092e6266aa794828be6550107b8fa6e9d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"11e1463dd272649518b25bb7e9effad0fab7387c","unresolved":false,"context_lines":[{"line_number":61,"context_line":"HTTP_NOT_FOUND \u003d 404"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"def is_new_keystoneauth(version\u003d\u00273.7.0\u0027):"},{"line_number":65,"context_line":"    ksa_version \u003d du_version.StrictVersion(keystoneauth1.__version__)"},{"line_number":66,"context_line":"    target \u003d du_version.StrictVersion(version)"},{"line_number":67,"context_line":"    return ksa_version \u003e\u003d target"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_5f1af0cb","line":64,"updated":"2018-05-28 08:41:57.000000000","message":"maybe move this function to neutron.tests.base and reuse it where is\u0027t necessary would be better idea than duplicate it in different files?","commit_id":"ea757b7092e6266aa794828be6550107b8fa6e9d"}]}
