)]}'
{"neutron/tests/unit/agent/linux/test_bridge_lib.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"285a16b25bca561d79dadfe4d6085ffe776cbdf1","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        super(BridgeLibTest, self).setUp()"},{"line_number":32,"context_line":"        is_ipv6_enabled_mock \u003d mock.patch("},{"line_number":33,"context_line":"            \u0027neutron.common.ipv6_utils.is_enabled_and_bind_by_default\u0027).start()"},{"line_number":34,"context_line":"        is_ipv6_enabled_mock.return_value \u003d True"},{"line_number":35,"context_line":"        self.addCleanup(is_ipv6_enabled_mock.stop)"},{"line_number":36,"context_line":"        ip_wrapper \u003d mock.patch(\u0027neutron.agent.linux.ip_lib.IPWrapper\u0027).start()"},{"line_number":37,"context_line":"        self.addCleanup(ip_wrapper.stop)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_19172fa6","line":34,"range":{"start_line":34,"start_character":29,"end_line":34,"end_character":41},"updated":"2018-06-05 07:54:47.000000000","message":"nit: You can pass this as a parameter to patch() function.","commit_id":"2056a3551b588708018924b39fd30385ff62e7a5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a63bd8705f0fa787a9d237bd462451054630f7c4","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        super(BridgeLibTest, self).setUp()"},{"line_number":32,"context_line":"        is_ipv6_enabled_mock \u003d mock.patch("},{"line_number":33,"context_line":"            \u0027neutron.common.ipv6_utils.is_enabled_and_bind_by_default\u0027).start()"},{"line_number":34,"context_line":"        is_ipv6_enabled_mock.return_value \u003d True"},{"line_number":35,"context_line":"        self.addCleanup(is_ipv6_enabled_mock.stop)"},{"line_number":36,"context_line":"        ip_wrapper \u003d mock.patch(\u0027neutron.agent.linux.ip_lib.IPWrapper\u0027).start()"},{"line_number":37,"context_line":"        self.addCleanup(ip_wrapper.stop)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_99833faa","line":34,"range":{"start_line":34,"start_character":29,"end_line":34,"end_character":41},"in_reply_to":"5f7c97a3_19172fa6","updated":"2018-06-05 07:59:49.000000000","message":"Done","commit_id":"2056a3551b588708018924b39fd30385ff62e7a5"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"285a16b25bca561d79dadfe4d6085ffe776cbdf1","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        is_ipv6_enabled_mock \u003d mock.patch("},{"line_number":33,"context_line":"            \u0027neutron.common.ipv6_utils.is_enabled_and_bind_by_default\u0027).start()"},{"line_number":34,"context_line":"        is_ipv6_enabled_mock.return_value \u003d True"},{"line_number":35,"context_line":"        self.addCleanup(is_ipv6_enabled_mock.stop)"},{"line_number":36,"context_line":"        ip_wrapper \u003d mock.patch(\u0027neutron.agent.linux.ip_lib.IPWrapper\u0027).start()"},{"line_number":37,"context_line":"        self.addCleanup(ip_wrapper.stop)"},{"line_number":38,"context_line":"        self.execute \u003d ip_wrapper.return_value.netns.execute"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_591cc7c0","line":35,"updated":"2018-06-05 07:54:47.000000000","message":"This is done automatically in BaseTestCase: http://git.openstack.org/cgit/openstack/neutron/tree/neutron/tests/base.py#n193","commit_id":"2056a3551b588708018924b39fd30385ff62e7a5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a63bd8705f0fa787a9d237bd462451054630f7c4","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        is_ipv6_enabled_mock \u003d mock.patch("},{"line_number":33,"context_line":"            \u0027neutron.common.ipv6_utils.is_enabled_and_bind_by_default\u0027).start()"},{"line_number":34,"context_line":"        is_ipv6_enabled_mock.return_value \u003d True"},{"line_number":35,"context_line":"        self.addCleanup(is_ipv6_enabled_mock.stop)"},{"line_number":36,"context_line":"        ip_wrapper \u003d mock.patch(\u0027neutron.agent.linux.ip_lib.IPWrapper\u0027).start()"},{"line_number":37,"context_line":"        self.addCleanup(ip_wrapper.stop)"},{"line_number":38,"context_line":"        self.execute \u003d ip_wrapper.return_value.netns.execute"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_59dfe7d5","line":35,"in_reply_to":"5f7c97a3_591cc7c0","updated":"2018-06-05 07:59:49.000000000","message":"thx, I wasn\u0027t sure if it will be cleaned or not :)","commit_id":"2056a3551b588708018924b39fd30385ff62e7a5"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"285a16b25bca561d79dadfe4d6085ffe776cbdf1","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        is_ipv6_enabled_mock.return_value \u003d True"},{"line_number":35,"context_line":"        self.addCleanup(is_ipv6_enabled_mock.stop)"},{"line_number":36,"context_line":"        ip_wrapper \u003d mock.patch(\u0027neutron.agent.linux.ip_lib.IPWrapper\u0027).start()"},{"line_number":37,"context_line":"        self.addCleanup(ip_wrapper.stop)"},{"line_number":38,"context_line":"        self.execute \u003d ip_wrapper.return_value.netns.execute"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def _verify_bridge_mock(self, cmd):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_b9807bc1","line":37,"updated":"2018-06-05 07:54:47.000000000","message":"ditto","commit_id":"2056a3551b588708018924b39fd30385ff62e7a5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a63bd8705f0fa787a9d237bd462451054630f7c4","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        is_ipv6_enabled_mock.return_value \u003d True"},{"line_number":35,"context_line":"        self.addCleanup(is_ipv6_enabled_mock.stop)"},{"line_number":36,"context_line":"        ip_wrapper \u003d mock.patch(\u0027neutron.agent.linux.ip_lib.IPWrapper\u0027).start()"},{"line_number":37,"context_line":"        self.addCleanup(ip_wrapper.stop)"},{"line_number":38,"context_line":"        self.execute \u003d ip_wrapper.return_value.netns.execute"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def _verify_bridge_mock(self, cmd):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_598da7d1","line":37,"in_reply_to":"5f7c97a3_b9807bc1","updated":"2018-06-05 07:59:49.000000000","message":"Done","commit_id":"2056a3551b588708018924b39fd30385ff62e7a5"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"29cc1f307f85f38cc6b324698c600f8b9e12e4d8","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def setUp(self):"},{"line_number":31,"context_line":"        super(BridgeLibTest, self).setUp()"},{"line_number":32,"context_line":"        is_ipv6_enabled_mock \u003d mock.patch("},{"line_number":33,"context_line":"            \u0027neutron.common.ipv6_utils.is_enabled_and_bind_by_default\u0027,"},{"line_number":34,"context_line":"            return_value\u003dTrue).start()"},{"line_number":35,"context_line":"        ip_wrapper \u003d mock.patch(\u0027neutron.agent.linux.ip_lib.IPWrapper\u0027).start()"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_22f3d075","line":32,"range":{"start_line":32,"start_character":8,"end_line":32,"end_character":28},"updated":"2018-06-05 09:52:40.000000000","message":"is this used anywhere?","commit_id":"7baa9476782a0605f6fcd58b1ce4161d3bd9635a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3225899d49083ca6eae354b282185941a79ba924","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def setUp(self):"},{"line_number":31,"context_line":"        super(BridgeLibTest, self).setUp()"},{"line_number":32,"context_line":"        is_ipv6_enabled_mock \u003d mock.patch("},{"line_number":33,"context_line":"            \u0027neutron.common.ipv6_utils.is_enabled_and_bind_by_default\u0027,"},{"line_number":34,"context_line":"            return_value\u003dTrue).start()"},{"line_number":35,"context_line":"        ip_wrapper \u003d mock.patch(\u0027neutron.agent.linux.ip_lib.IPWrapper\u0027).start()"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_4daabd71","line":32,"range":{"start_line":32,"start_character":8,"end_line":32,"end_character":28},"in_reply_to":"5f7c97a3_0d828553","updated":"2018-06-05 10:21:41.000000000","message":"I also didn\u0027t see reason in pep8 job\u0027s output but I run pep8 locally and I found it there :)","commit_id":"7baa9476782a0605f6fcd58b1ce4161d3bd9635a"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"571b4e4ea4a3811414e15f2ceadad398d1640795","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def setUp(self):"},{"line_number":31,"context_line":"        super(BridgeLibTest, self).setUp()"},{"line_number":32,"context_line":"        is_ipv6_enabled_mock \u003d mock.patch("},{"line_number":33,"context_line":"            \u0027neutron.common.ipv6_utils.is_enabled_and_bind_by_default\u0027,"},{"line_number":34,"context_line":"            return_value\u003dTrue).start()"},{"line_number":35,"context_line":"        ip_wrapper \u003d mock.patch(\u0027neutron.agent.linux.ip_lib.IPWrapper\u0027).start()"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_0d828553","line":32,"range":{"start_line":32,"start_character":8,"end_line":32,"end_character":28},"in_reply_to":"5f7c97a3_2266702b","updated":"2018-06-05 10:07:09.000000000","message":"Hm, I couldn\u0027t find the reason in pep8 output, I didn\u0027t know we now run pep8 on unittests directory.","commit_id":"7baa9476782a0605f6fcd58b1ce4161d3bd9635a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"839c8a8f9caeb62236e0aba5bdb798a080fe4abe","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def setUp(self):"},{"line_number":31,"context_line":"        super(BridgeLibTest, self).setUp()"},{"line_number":32,"context_line":"        is_ipv6_enabled_mock \u003d mock.patch("},{"line_number":33,"context_line":"            \u0027neutron.common.ipv6_utils.is_enabled_and_bind_by_default\u0027,"},{"line_number":34,"context_line":"            return_value\u003dTrue).start()"},{"line_number":35,"context_line":"        ip_wrapper \u003d mock.patch(\u0027neutron.agent.linux.ip_lib.IPWrapper\u0027).start()"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_2266702b","line":32,"range":{"start_line":32,"start_character":8,"end_line":32,"end_character":28},"in_reply_to":"5f7c97a3_22f3d075","updated":"2018-06-05 10:02:36.000000000","message":"no and pep8 also complained about that :) Fixed now","commit_id":"7baa9476782a0605f6fcd58b1ce4161d3bd9635a"}]}