)]}'
{".idea/modules.xml":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"7788498878f8a3f4f82bf2b9bc3aa5072d5353e1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003c?xml version\u003d\"1.0\" encoding\u003d\"UTF-8\"?\u003e"},{"line_number":2,"context_line":"\u003cproject version\u003d\"4\"\u003e"},{"line_number":3,"context_line":"  \u003ccomponent name\u003d\"ProjectModuleManager\"\u003e"},{"line_number":4,"context_line":"    \u003cmodules\u003e"},{"line_number":5,"context_line":"      \u003cmodule fileurl\u003d\"file://$PROJECT_DIR$/.idea/neutron.iml\" filepath\u003d\"$PROJECT_DIR$/.idea/neutron.iml\" /\u003e"}],"source_content_type":"application/xml","patch_set":3,"id":"AAAATn%2F%2BdLY%3D","line":2,"updated":"2013-11-25 21:10:21.000000000","message":"Shouldn\u0027t IDE files be left out of tree?","commit_id":"b8b6b59a54cba3e3b94ed2055a0484cb3c264b85"},{"author":{"_account_id":6695,"name":"Dane LeBlanc","email":"leblancd@cisco.com","username":"leblancd"},"change_message_id":"d706d0c436ca6ea7223ef10afbd1306770df69c7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003c?xml version\u003d\"1.0\" encoding\u003d\"UTF-8\"?\u003e"},{"line_number":2,"context_line":"\u003cproject version\u003d\"4\"\u003e"},{"line_number":3,"context_line":"  \u003ccomponent name\u003d\"ProjectModuleManager\"\u003e"},{"line_number":4,"context_line":"    \u003cmodules\u003e"},{"line_number":5,"context_line":"      \u003cmodule fileurl\u003d\"file://$PROJECT_DIR$/.idea/neutron.iml\" filepath\u003d\"$PROJECT_DIR$/.idea/neutron.iml\" /\u003e"}],"source_content_type":"application/xml","patch_set":3,"id":"AAAATn%2F%2Bczg%3D","line":2,"in_reply_to":"AAAATn%2F%2BdLY%3D","updated":"2013-11-25 22:29:07.000000000","message":"Absolutely. I\u0027ll remove this. (This somehow got added inadvertently by PyCharm.)","commit_id":"b8b6b59a54cba3e3b94ed2055a0484cb3c264b85"}],"neutron/tests/unit/cisco/test_network_plugin.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c1047b12b5bec3437186f6d81996babd12fcdcd6","unresolved":false,"context_lines":[{"line_number":527,"context_line":"        within the plugin\u0027s create_port() method."},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"        \"\"\""},{"line_number":530,"context_line":"        def _bind_fail_rollback_test(vlan_deletion_expected\u003dTrue,"},{"line_number":531,"context_line":"                                     vlan_untrunk_expected\u003dTrue):"},{"line_number":532,"context_line":"            inserted_exc \u003d KeyError"},{"line_number":533,"context_line":"            with mock.patch.object(nexus_db_v2, \u0027add_nexusport_binding\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2B2Is%3D","line":530,"updated":"2013-11-19 12:48:10.000000000","message":"Suggestion on naming...\n\n_check_rollback_on_bind_failure()","commit_id":"5d2f573bdcbfa72c36181d27703ae4e690683e36"},{"author":{"_account_id":6695,"name":"Dane LeBlanc","email":"leblancd@cisco.com","username":"leblancd"},"change_message_id":"f29dd3f189f3916276f3542af2bf855abd556950","unresolved":false,"context_lines":[{"line_number":527,"context_line":"        within the plugin\u0027s create_port() method."},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"        \"\"\""},{"line_number":530,"context_line":"        def _bind_fail_rollback_test(vlan_deletion_expected\u003dTrue,"},{"line_number":531,"context_line":"                                     vlan_untrunk_expected\u003dTrue):"},{"line_number":532,"context_line":"            inserted_exc \u003d KeyError"},{"line_number":533,"context_line":"            with mock.patch.object(nexus_db_v2, \u0027add_nexusport_binding\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2B0zY%3D","line":530,"in_reply_to":"AAAATn%2F%2B2Is%3D","updated":"2013-11-19 18:35:42.000000000","message":"Yes, that would be clearer. I\u0027ll also change the main test name similarly.","commit_id":"5d2f573bdcbfa72c36181d27703ae4e690683e36"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c1047b12b5bec3437186f6d81996babd12fcdcd6","unresolved":false,"context_lines":[{"line_number":546,"context_line":""},{"line_number":547,"context_line":"        # Test rollback for non-provider vlan. Vlan should get untrunked"},{"line_number":548,"context_line":"        # from the interface and deleted from the switch."},{"line_number":549,"context_line":"        _bind_fail_rollback_test()"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"        # Test rollback for provider vlan with auto-create disabled."},{"line_number":552,"context_line":"        # Vlan should get untrunked from the interface, but not deleted"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2B2H4%3D","line":549,"updated":"2013-11-19 12:48:10.000000000","message":"I think it is clearer (for understanding the test operation), to explicitly indicate what conditions are being set, rather than relying on default values. IOW:\n\n_bind_fail_rollback_test(vlan_deletion_expected\u003dTrue, vlan_untrunk_expected\u003dTrue)\n\nThis way it is clear to the reader, without checking the function signature on each use.\n\nDitto for other calls to this function.","commit_id":"5d2f573bdcbfa72c36181d27703ae4e690683e36"},{"author":{"_account_id":6695,"name":"Dane LeBlanc","email":"leblancd@cisco.com","username":"leblancd"},"change_message_id":"f29dd3f189f3916276f3542af2bf855abd556950","unresolved":false,"context_lines":[{"line_number":546,"context_line":""},{"line_number":547,"context_line":"        # Test rollback for non-provider vlan. Vlan should get untrunked"},{"line_number":548,"context_line":"        # from the interface and deleted from the switch."},{"line_number":549,"context_line":"        _bind_fail_rollback_test()"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"        # Test rollback for provider vlan with auto-create disabled."},{"line_number":552,"context_line":"        # Vlan should get untrunked from the interface, but not deleted"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2B0x4%3D","line":549,"in_reply_to":"AAAATn%2F%2B2H4%3D","updated":"2013-11-19 18:35:42.000000000","message":"Yes, explicit is better than implicit. I\u0027ll also minimize the comments, since what\u0027s expected will be explicit in the method arguments.","commit_id":"5d2f573bdcbfa72c36181d27703ae4e690683e36"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"7a42859552f1b5526723e1c66d1b9081b031a0f1","unresolved":false,"context_lines":[{"line_number":519,"context_line":"            self._assertExpectedHTTP(res.status_int,"},{"line_number":520,"context_line":"                                     c_exc.NexusComputeHostNotConfigured)"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    def test_nexus_rollback_on_bind_failure(self):"},{"line_number":523,"context_line":"        \"\"\"Test for proper rollback following add Nexus DB binding failure."},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        Test that the Cisco Nexus plugin correctly rolls back the vlan"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BxaI%3D","line":522,"updated":"2013-11-20 12:13:35.000000000","message":"Suggestion: Consider breaking into 3 test cases for better isolation (it\u0027s a good idea to only test one thing per test case).\n\ne.g.\ntest_nexus_rollback_on_bind_failure_non_provider_vlan()\ntest_nexus_rollback_on_bind_failure_provider_vlan_no_auto_create()\ntest_nexus_rollback_on_bind_failure_provider_vlan_no_auto_trunk()","commit_id":"9f944ed77f6c58bf3cda8c7628ddcfb71e9ccabf"},{"author":{"_account_id":6695,"name":"Dane LeBlanc","email":"leblancd@cisco.com","username":"leblancd"},"change_message_id":"4a2a3412034d509665efe476e8c1a2a0df8464b7","unresolved":false,"context_lines":[{"line_number":519,"context_line":"            self._assertExpectedHTTP(res.status_int,"},{"line_number":520,"context_line":"                                     c_exc.NexusComputeHostNotConfigured)"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    def test_nexus_rollback_on_bind_failure(self):"},{"line_number":523,"context_line":"        \"\"\"Test for proper rollback following add Nexus DB binding failure."},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        Test that the Cisco Nexus plugin correctly rolls back the vlan"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BdQM%3D","line":522,"in_reply_to":"AAAATn%2F%2BxaI%3D","updated":"2013-11-25 20:53:40.000000000","message":"Done","commit_id":"9f944ed77f6c58bf3cda8c7628ddcfb71e9ccabf"}],"neutron/tests/unit/cisco/test_nexus_plugin.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c1047b12b5bec3437186f6d81996babd12fcdcd6","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        self.assertEqual(expected_instance_id, INSTANCE1)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def _create_delete_providernet(self, auto_create\u003dTrue, auto_trunk\u003dTrue):"},{"line_number":189,"context_line":"        cfg.CONF.set_override("},{"line_number":190,"context_line":"            \u0027provider_vlan_auto_create\u0027, auto_create, \u0027CISCO\u0027)"},{"line_number":191,"context_line":"        cfg.CONF.set_override("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2B2HA%3D","line":188,"updated":"2013-11-19 12:48:10.000000000","message":"Consider removing the default values so that future maintainers will always specify both parameters in calls to this function, making it explicit as to what combinations are being chosen.","commit_id":"5d2f573bdcbfa72c36181d27703ae4e690683e36"},{"author":{"_account_id":6695,"name":"Dane LeBlanc","email":"leblancd@cisco.com","username":"leblancd"},"change_message_id":"f29dd3f189f3916276f3542af2bf855abd556950","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        self.assertEqual(expected_instance_id, INSTANCE1)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def _create_delete_providernet(self, auto_create\u003dTrue, auto_trunk\u003dTrue):"},{"line_number":189,"context_line":"        cfg.CONF.set_override("},{"line_number":190,"context_line":"            \u0027provider_vlan_auto_create\u0027, auto_create, \u0027CISCO\u0027)"},{"line_number":191,"context_line":"        cfg.CONF.set_override("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2B0vc%3D","line":188,"in_reply_to":"AAAATn%2F%2B2HA%3D","updated":"2013-11-19 18:35:42.000000000","message":"Done","commit_id":"5d2f573bdcbfa72c36181d27703ae4e690683e36"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c1047b12b5bec3437186f6d81996babd12fcdcd6","unresolved":false,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def test_create_delete_providernet(self):"},{"line_number":210,"context_line":"        self._create_delete_providernet(auto_create\u003dTrue, auto_trunk\u003dTrue)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def test_create_delete_provider_vlan_network_cfg_auto_man(self):"},{"line_number":213,"context_line":"        self._create_delete_providernet(auto_create\u003dTrue, auto_trunk\u003dFalse)"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2B2Fs%3D","line":211,"updated":"2013-11-19 12:48:10.000000000","message":"I like the explicit argument passing you\u0027re doing in these functions. Makes it clear as to the combinations being employed.","commit_id":"5d2f573bdcbfa72c36181d27703ae4e690683e36"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"bdbdc1ddcd47ce329a12d81a5aa96da2d9504b13","unresolved":false,"context_lines":[{"line_number":196,"context_line":"            # Create a provider network"},{"line_number":197,"context_line":"            new_net_dict \u003d self._cisco_nexus_plugin.create_network("},{"line_number":198,"context_line":"                self.providernet, self.attachment1)"},{"line_number":199,"context_line":"            mock_db.assert_called_once()"},{"line_number":200,"context_line":"            for attr in NET_ATTRS:"},{"line_number":201,"context_line":"                self.assertEqual(new_net_dict[attr], self.providernet[attr])"},{"line_number":202,"context_line":"            # Delete the provider network"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BZz0%3D","line":199,"updated":"2013-11-26 13:57:59.000000000","message":"Deja vu here: I thought I commented on this same code in another review. Are there duplicate reviews going out?\n\nIn any case, if assert fails, will network be deleted?","commit_id":"26e9fad61f86bedd16179ede9736b56c4a9a5752"},{"author":{"_account_id":6695,"name":"Dane LeBlanc","email":"leblancd@cisco.com","username":"leblancd"},"change_message_id":"926e1261fa3684434d38b7b72a667844f2f62c6b","unresolved":false,"context_lines":[{"line_number":196,"context_line":"            # Create a provider network"},{"line_number":197,"context_line":"            new_net_dict \u003d self._cisco_nexus_plugin.create_network("},{"line_number":198,"context_line":"                self.providernet, self.attachment1)"},{"line_number":199,"context_line":"            mock_db.assert_called_once()"},{"line_number":200,"context_line":"            for attr in NET_ATTRS:"},{"line_number":201,"context_line":"                self.assertEqual(new_net_dict[attr], self.providernet[attr])"},{"line_number":202,"context_line":"            # Delete the provider network"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BYz4%3D","line":199,"in_reply_to":"AAAATn%2F%2BZz0%3D","updated":"2013-11-26 16:24:54.000000000","message":"This method is being modified in another bug fix (bug #1190620), and the fix for that bug will add a try/finally to take care of deleting the network for assert failures.","commit_id":"26e9fad61f86bedd16179ede9736b56c4a9a5752"}]}
