)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7882e6ecd9f271a3e96259acae03739a8c079a46","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sahid Orentino Ferdjaoui \u003csahid.ferdjaoui@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-05-30 16:43:56 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"doc: update doc to refer new trusted tag for SRI-OV"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It allows Virtual Functions to become “trusted” by the Physical"},{"line_number":10,"context_line":"Function and perform some privileged operations, such as enabling VF"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_73e805e1","line":7,"range":{"start_line":7,"start_character":45,"end_line":7,"end_character":51},"updated":"2018-05-31 18:40:38.000000000","message":"s/SR-IOV","commit_id":"ed6323631d367201919737efd21f20796176ac8a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3ef1e6da28bf3f47acb08f75be5752c74de1bdd3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sahid Orentino Ferdjaoui \u003csahid.ferdjaoui@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-06-01 11:32:27 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"doc: update doc to refer new trusted tag for SRI-OV"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It allows Virtual Functions to become “trusted” by the Physical"},{"line_number":10,"context_line":"Function and perform some privileged operations, such as enabling VF"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_13618305","line":7,"range":{"start_line":7,"start_character":45,"end_line":7,"end_character":51},"updated":"2018-06-01 12:26:28.000000000","message":"SR-IOV","commit_id":"ce413b54842a9f0ee39ec24417bb818aa2559e61"}],"doc/source/admin/config-sriov.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b4a5ee7bf53ef7d79a221cdcb837e21514082ad2","unresolved":false,"context_lines":[{"line_number":215,"context_line":"      the ``sysfsutils`` tool. However, this is not available by default on"},{"line_number":216,"context_line":"      many major distributions."},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"Whitelist PCI devices nova-compute (Compute)"},{"line_number":219,"context_line":"--------------------------------------------"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"#. Configure which PCI devices the ``nova-compute`` service may use. Edit"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_1301ac05","line":218,"updated":"2018-05-30 14:04:58.000000000","message":"I guess we have some overlap with the compute admin configuration docs:\n\nhttps://docs.openstack.org/nova/latest/admin/pci-passthrough.html#configure-pci-devices-compute","commit_id":"b459cb3eea694482a60b12e78cafd493d34b350e"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d9fe5f9adc6d928a56208de839b25f670ea7a903","unresolved":false,"context_lines":[{"line_number":215,"context_line":"      the ``sysfsutils`` tool. However, this is not available by default on"},{"line_number":216,"context_line":"      many major distributions."},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"Whitelist PCI devices nova-compute (Compute)"},{"line_number":219,"context_line":"--------------------------------------------"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"#. Configure which PCI devices the ``nova-compute`` service may use. Edit"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_b33b1836","line":218,"in_reply_to":"5f7c97a3_1301ac05","updated":"2018-05-30 14:42:48.000000000","message":"My understanding is that, our doc is a general one about PCI pass-through, that could be any kind of devices.\n\nThat one is specific of the network SR-IOV devices.","commit_id":"b459cb3eea694482a60b12e78cafd493d34b350e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b4a5ee7bf53ef7d79a221cdcb837e21514082ad2","unresolved":false,"context_lines":[{"line_number":257,"context_line":"   SR-IOV PF, all VFs under the PF will match the entry. Multiple"},{"line_number":258,"context_line":"   ``pci_passthrough_whitelist`` entries per host are supported."},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"   In order to enable SR-IOV to request \"trusted mode\", the"},{"line_number":261,"context_line":"   ``pci_passthrough_whitelist`` parameter also supports a ``trusted``"},{"line_number":262,"context_line":"   tag."},{"line_number":263,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_d3a254fc","line":260,"updated":"2018-05-30 14:04:58.000000000","message":"Somewhere in here, I would expect to see some additional notes:\n\n* security implications of enabling trusted ports\n* this capability is only supported starting with the 18.0.0 Rocky release of the compute service\n* this capability is only supported with the libvirt compute driver","commit_id":"b459cb3eea694482a60b12e78cafd493d34b350e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b4a5ee7bf53ef7d79a221cdcb837e21514082ad2","unresolved":false,"context_lines":[{"line_number":258,"context_line":"   ``pci_passthrough_whitelist`` entries per host are supported."},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"   In order to enable SR-IOV to request \"trusted mode\", the"},{"line_number":261,"context_line":"   ``pci_passthrough_whitelist`` parameter also supports a ``trusted``"},{"line_number":262,"context_line":"   tag."},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"   For example, to accept users to request SR-IOV devices with trusted"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_b30f982c","line":261,"range":{"start_line":261,"start_character":5,"end_line":261,"end_character":30},"updated":"2018-05-30 14:04:58.000000000","message":"This is the deprecated option name when it was in the DEFAULT group, you should now be using: ``[pci]/passthrough_whitelist``.","commit_id":"b459cb3eea694482a60b12e78cafd493d34b350e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b4a5ee7bf53ef7d79a221cdcb837e21514082ad2","unresolved":false,"context_lines":[{"line_number":261,"context_line":"   ``pci_passthrough_whitelist`` parameter also supports a ``trusted``"},{"line_number":262,"context_line":"   tag."},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"   For example, to accept users to request SR-IOV devices with trusted"},{"line_number":265,"context_line":"   capabilities on device eth3:"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"   .. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_d31fb458","line":264,"range":{"start_line":264,"start_character":19,"end_line":264,"end_character":25},"updated":"2018-05-30 14:04:58.000000000","message":"allow","commit_id":"b459cb3eea694482a60b12e78cafd493d34b350e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b4a5ee7bf53ef7d79a221cdcb837e21514082ad2","unresolved":false,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"   .. code-block:: ini"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"     pci_passthrough_whitelist \u003d { \"devname\": \"eth3\", \"physical_network\": \"physnet2\", trusted:\"true\" }"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"  The ports will have to be created with a binding profile to mach the"},{"line_number":272,"context_line":"  ``trusted`` tag, see \u0027Launching instances with SR-IOV ports\u0027."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_132a0c7e","line":269,"range":{"start_line":269,"start_character":5,"end_line":269,"end_character":30},"updated":"2018-05-30 14:04:58.000000000","message":"this should be:\n\n[pci]\npassthrough_whitelist \u003d ....","commit_id":"b459cb3eea694482a60b12e78cafd493d34b350e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b4a5ee7bf53ef7d79a221cdcb837e21514082ad2","unresolved":false,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"   .. code-block:: ini"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"     pci_passthrough_whitelist \u003d { \"devname\": \"eth3\", \"physical_network\": \"physnet2\", trusted:\"true\" }"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"  The ports will have to be created with a binding profile to mach the"},{"line_number":272,"context_line":"  ``trusted`` tag, see \u0027Launching instances with SR-IOV ports\u0027."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_d36d74cc","line":269,"range":{"start_line":269,"start_character":86,"end_line":269,"end_character":93},"updated":"2018-05-30 14:04:58.000000000","message":"trusted key needs to be in quotes","commit_id":"b459cb3eea694482a60b12e78cafd493d34b350e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b4a5ee7bf53ef7d79a221cdcb837e21514082ad2","unresolved":false,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":"     pci_passthrough_whitelist \u003d { \"devname\": \"eth3\", \"physical_network\": \"physnet2\", trusted:\"true\" }"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"  The ports will have to be created with a binding profile to mach the"},{"line_number":272,"context_line":"  ``trusted`` tag, see \u0027Launching instances with SR-IOV ports\u0027."},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"#. Restart the ``nova-compute`` service for the changes to go into effect."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_134f6c6b","line":271,"range":{"start_line":271,"start_character":62,"end_line":271,"end_character":66},"updated":"2018-05-30 14:04:58.000000000","message":"match","commit_id":"b459cb3eea694482a60b12e78cafd493d34b350e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b4a5ee7bf53ef7d79a221cdcb837e21514082ad2","unresolved":false,"context_lines":[{"line_number":269,"context_line":"     pci_passthrough_whitelist \u003d { \"devname\": \"eth3\", \"physical_network\": \"physnet2\", trusted:\"true\" }"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"  The ports will have to be created with a binding profile to mach the"},{"line_number":272,"context_line":"  ``trusted`` tag, see \u0027Launching instances with SR-IOV ports\u0027."},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"#. Restart the ``nova-compute`` service for the changes to go into effect."},{"line_number":275,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_732ee08c","line":272,"range":{"start_line":272,"start_character":23,"end_line":272,"end_character":63},"updated":"2018-05-30 14:04:58.000000000","message":"The section title is an implicit link, so you can do:\n\n`Launching instances with SR-IOV ports`_","commit_id":"b459cb3eea694482a60b12e78cafd493d34b350e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b4a5ee7bf53ef7d79a221cdcb837e21514082ad2","unresolved":false,"context_lines":[{"line_number":411,"context_line":""},{"line_number":412,"context_line":"      $ port_id\u003d`neutron port-create $net_id --name sriov_port --binding:vnic_type direct | grep \"\\ id\\ \" | awk \u0027{ print $4 }\u0027`"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"   To request that the SR-IOV port to accept trusted capabilities, the"},{"line_number":415,"context_line":"   binding profil should be enhanced with the ``trusted`` tag."},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"  .. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_f3575000","line":414,"range":{"start_line":414,"start_character":35,"end_line":414,"end_character":44},"updated":"2018-05-30 14:04:58.000000000","message":"accept","commit_id":"b459cb3eea694482a60b12e78cafd493d34b350e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b4a5ee7bf53ef7d79a221cdcb837e21514082ad2","unresolved":false,"context_lines":[{"line_number":412,"context_line":"      $ port_id\u003d`neutron port-create $net_id --name sriov_port --binding:vnic_type direct | grep \"\\ id\\ \" | awk \u0027{ print $4 }\u0027`"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"   To request that the SR-IOV port to accept trusted capabilities, the"},{"line_number":415,"context_line":"   binding profil should be enhanced with the ``trusted`` tag."},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"  .. code-block:: console"},{"line_number":418,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_93429c3d","line":415,"range":{"start_line":415,"start_character":11,"end_line":415,"end_character":17},"updated":"2018-05-30 14:04:58.000000000","message":"profile","commit_id":"b459cb3eea694482a60b12e78cafd493d34b350e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b4a5ee7bf53ef7d79a221cdcb837e21514082ad2","unresolved":false,"context_lines":[{"line_number":416,"context_line":""},{"line_number":417,"context_line":"  .. code-block:: console"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"    $ port_id\u003d`neutron port-create $net_id --name sriov_port --binding:vnic_type direct | grep \"\\ id\\ \" | awk \u0027{ print $4 }\u0027` --binding:profile type\u003ddict trusted\u003dtrue"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"#. Create the instance. Specify the SR-IOV port created in step two for the"},{"line_number":422,"context_line":"   NIC:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_1378cc8d","line":419,"range":{"start_line":419,"start_character":126,"end_line":419,"end_character":166},"updated":"2018-05-30 14:04:58.000000000","message":"This must be part of the port create call, but you\u0027ve added it to the part after the grep and awk to get the port ID.","commit_id":"b459cb3eea694482a60b12e78cafd493d34b350e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7882e6ecd9f271a3e96259acae03739a8c079a46","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"  .. note::"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"      This capability is only supported starting with the 18.0.0 Rocky"},{"line_number":267,"context_line":"      release of the compute service configured to use libvirt driver."},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"  .. note::"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f7c97a3_93912155","line":266,"range":{"start_line":266,"start_character":58,"end_line":266,"end_character":70},"updated":"2018-05-31 18:40:38.000000000","message":"s/version 18.0.0 (Rocky)\n\nOr just remove Rocky altogether.","commit_id":"ed6323631d367201919737efd21f20796176ac8a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7882e6ecd9f271a3e96259acae03739a8c079a46","unresolved":false,"context_lines":[{"line_number":264,"context_line":"  .. note::"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"      This capability is only supported starting with the 18.0.0 Rocky"},{"line_number":267,"context_line":"      release of the compute service configured to use libvirt driver."},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"  .. note::"},{"line_number":270,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f7c97a3_339ccd68","line":267,"range":{"start_line":267,"start_character":55,"end_line":267,"end_character":62},"updated":"2018-05-31 18:40:38.000000000","message":"s/the libvirt","commit_id":"ed6323631d367201919737efd21f20796176ac8a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"00ed0d58021a7e7b19fb4b29f841417bdc7d09f8","unresolved":false,"context_lines":[{"line_number":266,"context_line":"      This capability is only supported starting with the 18.0.0 Rocky"},{"line_number":267,"context_line":"      release of the compute service configured to use libvirt driver."},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"  .. note::"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"      There are security implications of enabling trusted ports. The"},{"line_number":272,"context_line":"      trusted VFs can be set into VF promiscuous mode which will"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f7c97a3_387eeaae","line":269,"updated":"2018-05-31 18:13:24.000000000","message":"This one should probably be:\n\n.. important::","commit_id":"ed6323631d367201919737efd21f20796176ac8a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"00ed0d58021a7e7b19fb4b29f841417bdc7d09f8","unresolved":false,"context_lines":[{"line_number":261,"context_line":"   ``[pci]/pci_passthrough_whitelist`` parameter also supports a ``trusted``"},{"line_number":262,"context_line":"   tag."},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"  .. note::"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"      This capability is only supported starting with the 18.0.0 Rocky"},{"line_number":267,"context_line":"      release of the compute service configured to use libvirt driver."},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"  .. note::"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"      There are security implications of enabling trusted ports. The"},{"line_number":272,"context_line":"      trusted VFs can be set into VF promiscuous mode which will"},{"line_number":273,"context_line":"      enable it to receive unmatched and multicast traffic sent to the"},{"line_number":274,"context_line":"      physical function."},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"   For example, to allow users to request SR-IOV devices with trusted"},{"line_number":277,"context_line":"   capabilities on device eth3:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f7c97a3_7878e2c2","line":274,"range":{"start_line":264,"start_character":2,"end_line":274,"end_character":24},"updated":"2018-05-31 18:13:24.000000000","message":"This needs to be indented, it doesn\u0027t render properly otherwise:\n\nhttp://logs.openstack.org/67/571167/3/check/build-openstack-sphinx-docs/1e2f332/html/admin/config-sriov.html#whitelist-pci-devices-nova-compute-compute","commit_id":"ed6323631d367201919737efd21f20796176ac8a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7882e6ecd9f271a3e96259acae03739a8c079a46","unresolved":false,"context_lines":[{"line_number":274,"context_line":"      physical function."},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"   For example, to allow users to request SR-IOV devices with trusted"},{"line_number":277,"context_line":"   capabilities on device eth3:"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"   .. code-block:: ini"},{"line_number":280,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f7c97a3_138f512a","line":277,"range":{"start_line":277,"start_character":26,"end_line":277,"end_character":30},"updated":"2018-05-31 18:40:38.000000000","message":"c/``eth3``","commit_id":"ed6323631d367201919737efd21f20796176ac8a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b3775a67090b862ded107b67de1cda3b5b233f36","unresolved":false,"context_lines":[{"line_number":279,"context_line":"   .. code-block:: ini"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"     [pci]"},{"line_number":282,"context_line":"     pci_passthrough_whitelist \u003d { \"devname\": \"eth3\", \"physical_network\": \"physnet2\", \"trusted\":\"true\" }"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"  The ports will have to be created with a binding profile to match the"},{"line_number":285,"context_line":"  ``trusted`` tag, see `Launching instances with SR-IOV ports`_."}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f7c97a3_38902aed","line":282,"range":{"start_line":282,"start_character":5,"end_line":282,"end_character":30},"updated":"2018-05-31 18:10:34.000000000","message":"passthrough_whitelist","commit_id":"ed6323631d367201919737efd21f20796176ac8a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b3775a67090b862ded107b67de1cda3b5b233f36","unresolved":false,"context_lines":[{"line_number":424,"context_line":""},{"line_number":425,"context_line":"      $ port_id\u003d`neutron port-create $net_id --name sriov_port --binding:vnic_type direct | grep \"\\ id\\ \" | awk \u0027{ print $4 }\u0027`"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"   To request that the SR-IOV port to accept trusted capabilities, the"},{"line_number":428,"context_line":"   binding profil should be enhanced with the ``trusted`` tag."},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"  .. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f7c97a3_18c3eeee","line":427,"range":{"start_line":427,"start_character":35,"end_line":427,"end_character":44},"updated":"2018-05-31 18:10:34.000000000","message":"s/to//","commit_id":"ed6323631d367201919737efd21f20796176ac8a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b3775a67090b862ded107b67de1cda3b5b233f36","unresolved":false,"context_lines":[{"line_number":425,"context_line":"      $ port_id\u003d`neutron port-create $net_id --name sriov_port --binding:vnic_type direct | grep \"\\ id\\ \" | awk \u0027{ print $4 }\u0027`"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"   To request that the SR-IOV port to accept trusted capabilities, the"},{"line_number":428,"context_line":"   binding profil should be enhanced with the ``trusted`` tag."},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"  .. code-block:: console"},{"line_number":431,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f7c97a3_588ba6be","line":428,"range":{"start_line":428,"start_character":11,"end_line":428,"end_character":17},"updated":"2018-05-31 18:10:34.000000000","message":"profile","commit_id":"ed6323631d367201919737efd21f20796176ac8a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"00ed0d58021a7e7b19fb4b29f841417bdc7d09f8","unresolved":false,"context_lines":[{"line_number":427,"context_line":"   To request that the SR-IOV port to accept trusted capabilities, the"},{"line_number":428,"context_line":"   binding profil should be enhanced with the ``trusted`` tag."},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"  .. code-block:: console"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    $ port_id\u003d`neutron port-create $net_id --name sriov_port --binding:vnic_type direct | grep \"\\ id\\ \" | awk \u0027{ print $4 }\u0027` --binding:profile type\u003ddict trusted\u003dtrue"},{"line_number":433,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f7c97a3_18368e04","line":430,"updated":"2018-05-31 18:13:24.000000000","message":"This needs to be aligned with the paragraph above:\n\nhttp://logs.openstack.org/67/571167/3/check/build-openstack-sphinx-docs/1e2f332/html/admin/config-sriov.html#launching-instances-with-sr-iov-ports","commit_id":"ed6323631d367201919737efd21f20796176ac8a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b3775a67090b862ded107b67de1cda3b5b233f36","unresolved":false,"context_lines":[{"line_number":429,"context_line":""},{"line_number":430,"context_line":"  .. code-block:: console"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    $ port_id\u003d`neutron port-create $net_id --name sriov_port --binding:vnic_type direct | grep \"\\ id\\ \" | awk \u0027{ print $4 }\u0027` --binding:profile type\u003ddict trusted\u003dtrue"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"#. Create the instance. Specify the SR-IOV port created in step two for the"},{"line_number":435,"context_line":"   NIC:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f7c97a3_d8b81676","line":432,"range":{"start_line":432,"start_character":126,"end_line":432,"end_character":166},"updated":"2018-05-31 18:10:34.000000000","message":"This must be part of the port create call, but you\u0027ve added it to the part after the grep and awk to get the port ID.","commit_id":"ed6323631d367201919737efd21f20796176ac8a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3ef1e6da28bf3f47acb08f75be5752c74de1bdd3","unresolved":false,"context_lines":[{"line_number":282,"context_line":"     [pci]"},{"line_number":283,"context_line":"     passthrough_whitelist \u003d { \"devname\": \"eth3\", \"physical_network\": \"physnet2\", \"trusted\":\"true\" }"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"  The ports will have to be created with a binding profile to match the"},{"line_number":286,"context_line":"  ``trusted`` tag, see `Launching instances with SR-IOV ports`_."},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"#. Restart the ``nova-compute`` service for the changes to go into effect."}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f7c97a3_f32647cb","line":285,"updated":"2018-06-01 12:26:28.000000000","message":"This needs to align with L277 above.","commit_id":"ce413b54842a9f0ee39ec24417bb818aa2559e61"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3ef1e6da28bf3f47acb08f75be5752c74de1bdd3","unresolved":false,"context_lines":[{"line_number":428,"context_line":"   To request that the SR-IOV port accept trusted capabilities, the"},{"line_number":429,"context_line":"   binding profile should be enhanced with the ``trusted`` tag."},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"  .. code-block:: console"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"     $ port_id\u003d`neutron port-create $net_id --name sriov_port --binding:vnic_type direct --binding:profile type\u003ddict trusted\u003dtrue | grep \"\\ id\\ \" | awk \u0027{ print $4 }\u0027`"},{"line_number":434,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f7c97a3_733b17e9","line":431,"updated":"2018-06-01 12:26:28.000000000","message":"This needs to align with the above.","commit_id":"ce413b54842a9f0ee39ec24417bb818aa2559e61"}]}
