)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b3362881418a5e2e2e1170d5b50157cd8abad6c7","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2018-06-01 12:39:35 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass network\u0027s dns_domain to dnsmasq conf"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I6120d504959631f084d63458f6e9dada0dc5cbdf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_0275a663","line":8,"updated":"2018-06-01 17:03:27.000000000","message":"A few comments here:\n1. please add a release note - this breaks backwards compatibility - the configuration file will be overwritten\n2. do you have a bug to track this","commit_id":"085461f008642da474e33dc17d313b6d00e7d161"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"47613b21ab8c82ec53c9ca4db872fee3cf46ebf1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2018-06-01 12:39:35 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass network\u0027s dns_domain to dnsmasq conf"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I6120d504959631f084d63458f6e9dada0dc5cbdf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_e26f4a5d","line":8,"in_reply_to":"5f7c97a3_0275a663","updated":"2018-06-01 17:10:25.000000000","message":"1) will do\n2) not yet :)\n\nI\u0027d like to see CI passing and then I\u0027ll whip the patch up.","commit_id":"085461f008642da474e33dc17d313b6d00e7d161"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0ae31db1bc4623adf8fc2b17ac39f120f36caaa1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2018-06-01 15:51:35 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass network\u0027s dns_domain to dnsmasq conf"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: 1774710"},{"line_number":10,"context_line":"Change-Id: I6120d504959631f084d63458f6e9dada0dc5cbdf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_ed5bae50","line":8,"updated":"2018-06-03 07:46:29.000000000","message":"Please add UpgradeImpact here - this will change the existing behavior - irrespective if you think or claim that it is wrong\n\nPlease also add some explanation in the commit message what you are doing here.","commit_id":"54c1e4596306088738bffad25983a30c1ec8a77a"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"62d60a1eda1c9228107b9e20eec4849f3218839a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2018-06-01 15:51:35 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass network\u0027s dns_domain to dnsmasq conf"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: 1774710"},{"line_number":10,"context_line":"Change-Id: I6120d504959631f084d63458f6e9dada0dc5cbdf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_b20740ca","line":8,"in_reply_to":"5f7c97a3_ed5bae50","updated":"2018-06-04 18:03:18.000000000","message":"Done","commit_id":"54c1e4596306088738bffad25983a30c1ec8a77a"}],"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b3362881418a5e2e2e1170d5b50157cd8abad6c7","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        self.conf \u003d conf"},{"line_number":132,"context_line":"        self.network \u003d network"},{"line_number":133,"context_line":"        self.dns_domain \u003d ("},{"line_number":134,"context_line":"            self.network.get(\u0027dns_domain\u0027) or self.conf.dns_domain)"},{"line_number":135,"context_line":"        self.process_monitor \u003d process_monitor"},{"line_number":136,"context_line":"        self.device_manager \u003d DeviceManager(self.conf, plugin)"},{"line_number":137,"context_line":"        self.version \u003d version"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_c26a4e7f","line":134,"range":{"start_line":134,"start_character":12,"end_line":134,"end_character":42},"updated":"2018-06-01 17:03:27.000000000","message":"so this overwrites the config value which may cause regressions. not nice when upgrading!","commit_id":"085461f008642da474e33dc17d313b6d00e7d161"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"47613b21ab8c82ec53c9ca4db872fee3cf46ebf1","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        self.conf \u003d conf"},{"line_number":132,"context_line":"        self.network \u003d network"},{"line_number":133,"context_line":"        self.dns_domain \u003d ("},{"line_number":134,"context_line":"            self.network.get(\u0027dns_domain\u0027) or self.conf.dns_domain)"},{"line_number":135,"context_line":"        self.process_monitor \u003d process_monitor"},{"line_number":136,"context_line":"        self.device_manager \u003d DeviceManager(self.conf, plugin)"},{"line_number":137,"context_line":"        self.version \u003d version"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_a28e322b","line":134,"range":{"start_line":134,"start_character":12,"end_line":134,"end_character":42},"in_reply_to":"5f7c97a3_c26a4e7f","updated":"2018-06-01 17:10:25.000000000","message":"You\u0027re right, it is a bug fix though.\n\nRight now when you set the dns_domain attribute on a network the reference implementation just ignores it... That\u0027s not nice either.\n\nWe have to strike a balance between retaining backwards comparability and our ability to fix behavior that we know is broken. I think that when judging the value the bug fix brings, and the introduced risk from backwards incompatability, and because the dns_domain attribute on the network model is fairly new, fixing broken behavior wins.","commit_id":"085461f008642da474e33dc17d313b6d00e7d161"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a4813cae07b2722db8ae5eae6f59958185350f63","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        self.conf \u003d conf"},{"line_number":132,"context_line":"        self.network \u003d network"},{"line_number":133,"context_line":"        self.dns_domain \u003d ("},{"line_number":134,"context_line":"            self.network.get(\u0027dns_domain\u0027) or self.conf.dns_domain)"},{"line_number":135,"context_line":"        self.process_monitor \u003d process_monitor"},{"line_number":136,"context_line":"        self.device_manager \u003d DeviceManager(self.conf, plugin)"},{"line_number":137,"context_line":"        self.version \u003d version"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_1e5acc4f","line":134,"updated":"2018-06-04 08:46:50.000000000","message":"maybe something like:\n\n    self.network.get(\"dns_domain\", self.conf.dns_domain)\n\nwill be enough?","commit_id":"54c1e4596306088738bffad25983a30c1ec8a77a"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"62d60a1eda1c9228107b9e20eec4849f3218839a","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        self.conf \u003d conf"},{"line_number":132,"context_line":"        self.network \u003d network"},{"line_number":133,"context_line":"        self.dns_domain \u003d ("},{"line_number":134,"context_line":"            self.network.get(\u0027dns_domain\u0027) or self.conf.dns_domain)"},{"line_number":135,"context_line":"        self.process_monitor \u003d process_monitor"},{"line_number":136,"context_line":"        self.device_manager \u003d DeviceManager(self.conf, plugin)"},{"line_number":137,"context_line":"        self.version \u003d version"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_520caceb","line":134,"in_reply_to":"5f7c97a3_1e5acc4f","updated":"2018-06-04 18:03:18.000000000","message":"Done","commit_id":"54c1e4596306088738bffad25983a30c1ec8a77a"}],"neutron/tests/unit/agent/linux/test_dhcp.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"26ab35ec1fb6bd7328ee54d94cb216d7c1912eaf","unresolved":false,"context_lines":[{"line_number":458,"context_line":"    dns_domain \u003d \u0027openstacklocal\u0027"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def get(self, attr, default\u003dNone):"},{"line_number":461,"context_line":"        return getattr(self, attr) or default"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"class FakeV4MultipleAgentsWithoutDnsProvided(FakeNetworkBase):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_bdbe31d2","line":461,"range":{"start_line":461,"start_character":8,"end_line":461,"end_character":34},"updated":"2018-06-04 19:02:44.000000000","message":"why not:\nreturn getattr(self, attr, default)","commit_id":"2442b694132b6847c040ec2d4e05cb95b0ef572a"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"b70b32bc5315367850e755a3c2d9f54aeb8ac27a","unresolved":false,"context_lines":[{"line_number":458,"context_line":"    dns_domain \u003d \u0027openstacklocal\u0027"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def get(self, attr, default\u003dNone):"},{"line_number":461,"context_line":"        return getattr(self, attr) or default"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"class FakeV4MultipleAgentsWithoutDnsProvided(FakeNetworkBase):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_fdbfc9a7","line":461,"range":{"start_line":461,"start_character":8,"end_line":461,"end_character":34},"in_reply_to":"5f7c97a3_bdbe31d2","updated":"2018-06-04 19:13:08.000000000","message":"Because getattr and a dict.get don\u0027t work the same way. Try it out :)","commit_id":"2442b694132b6847c040ec2d4e05cb95b0ef572a"}]}