)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"e7e5c354097c7d6936e6c92f971a21933d0c4bee","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Similar change is also done for methods which checks TCP"},{"line_number":24,"context_line":"connectivity using netcat helper class. It now uses"},{"line_number":25,"context_line":"common_utils.wait_until_true() helper function instead of"},{"line_number":26,"context_line":"fail immediatelly."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: I9e523d803e3c49d5d090ae5b9d36d43ce7311535"},{"line_number":29,"context_line":"Closes-Bug: #1774006"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_bb393dd9","line":26,"range":{"start_line":26,"start_character":4,"end_line":26,"end_character":18},"updated":"2018-06-05 20:46:29.000000000","message":"nit: immediately !","commit_id":"7464e7d95f246a1a975c047a8376cbc1a5666950"}],"neutron/tests/fullstack/test_securitygroup.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"c5c06856d85987df49b5be20d32ae616ff6f8de3","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        netcat \u003d net_helpers.NetcatTester(*args, **kwargs)"},{"line_number":64,"context_line":"        try:"},{"line_number":65,"context_line":"            common_utils.wait_until_true("},{"line_number":66,"context_line":"                lambda: netcat.test_connectivity())"},{"line_number":67,"context_line":"        finally:"},{"line_number":68,"context_line":"            netcat.stop_processes()"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_fd523f35","line":66,"updated":"2018-06-06 09:38:47.000000000","message":"I don\u0027t think this is gonna work as the method raises an exception when connection is not established. You\u0027re gonna need to wrap it with a function that catches the exception.","commit_id":"7464e7d95f246a1a975c047a8376cbc1a5666950"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3d4f580fa74db7a0cbdc66d98d2215512a4c3a3a","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        netcat \u003d net_helpers.NetcatTester(*args, **kwargs)"},{"line_number":64,"context_line":"        try:"},{"line_number":65,"context_line":"            common_utils.wait_until_true("},{"line_number":66,"context_line":"                lambda: netcat.test_connectivity())"},{"line_number":67,"context_line":"        finally:"},{"line_number":68,"context_line":"            netcat.stop_processes()"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_ec192b22","line":66,"in_reply_to":"5f7c97a3_4c44df19","updated":"2018-06-06 12:57:18.000000000","message":"thx for catch this. I will fix it asap","commit_id":"7464e7d95f246a1a975c047a8376cbc1a5666950"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"04d1016aa040b7c090a78db6129d25beff06e29e","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        netcat \u003d net_helpers.NetcatTester(*args, **kwargs)"},{"line_number":64,"context_line":"        try:"},{"line_number":65,"context_line":"            common_utils.wait_until_true("},{"line_number":66,"context_line":"                lambda: netcat.test_connectivity())"},{"line_number":67,"context_line":"        finally:"},{"line_number":68,"context_line":"            netcat.stop_processes()"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_4c44df19","line":66,"in_reply_to":"5f7c97a3_8ccd17b9","updated":"2018-06-06 12:54:27.000000000","message":"Only if your connection works. If you can\u0027t established connection, you\u0027re gonna get an exception at https://github.com/openstack/neutron/blob/master/neutron/tests/common/net_helpers.py#L514","commit_id":"7464e7d95f246a1a975c047a8376cbc1a5666950"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1044243fe738005a0d1d0b771e0c27b6cb888357","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        netcat \u003d net_helpers.NetcatTester(*args, **kwargs)"},{"line_number":64,"context_line":"        try:"},{"line_number":65,"context_line":"            common_utils.wait_until_true("},{"line_number":66,"context_line":"                lambda: netcat.test_connectivity())"},{"line_number":67,"context_line":"        finally:"},{"line_number":68,"context_line":"            netcat.stop_processes()"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_8ccd17b9","line":66,"in_reply_to":"5f7c97a3_fd523f35","updated":"2018-06-06 12:53:18.000000000","message":"NetcatTester.test_connectivity returns True/False values: https://github.com/openstack/neutron/blob/master/neutron/tests/common/net_helpers.py#L518","commit_id":"7464e7d95f246a1a975c047a8376cbc1a5666950"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d8ac0ba09822156458edceab8bcc1d719a98f607","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                return False"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        try:"},{"line_number":72,"context_line":"            common_utils.wait_until_true(lambda: test_connectivity())"},{"line_number":73,"context_line":"        finally:"},{"line_number":74,"context_line":"            netcat.stop_processes()"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_7726486b","line":72,"range":{"start_line":72,"start_character":41,"end_line":72,"end_character":68},"updated":"2018-06-06 13:32:07.000000000","message":"you don\u0027t need the lamba, just\n\n wait_until_true(test_connectivity)","commit_id":"aec5d42dc585d4f3bb49920febeea0b6ee25acce"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d8ac0ba09822156458edceab8bcc1d719a98f607","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        netcat \u003d net_helpers.NetcatTester(*args, **kwargs)"},{"line_number":78,"context_line":"        try:"},{"line_number":79,"context_line":"            common_utils.wait_until_true("},{"line_number":80,"context_line":"                lambda: netcat.test_no_connectivity())"},{"line_number":81,"context_line":"        finally:"},{"line_number":82,"context_line":"            netcat.stop_processes()"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_3720d049","line":80,"range":{"start_line":80,"start_character":16,"end_line":80,"end_character":24},"updated":"2018-06-06 13:32:07.000000000","message":"ditto","commit_id":"aec5d42dc585d4f3bb49920febeea0b6ee25acce"}]}
