)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b22dc4b174750abeb99b88d968d2ff7220c44017","unresolved":false,"context_lines":[{"line_number":11,"context_line":"finish their job."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"In TestHAL3Agent.test_ha_router_restart_agents_no_packet_lost"},{"line_number":14,"context_line":"there is 60 pings send with 1 second timeout so default"},{"line_number":15,"context_line":"wait_until_true timeout which is set to 60 seconds might not"},{"line_number":16,"context_line":"be enough in some cases."},{"line_number":17,"context_line":"Because of that wait_until_true timeout is now set as"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_ece28ba0","line":14,"range":{"start_line":14,"start_character":6,"end_line":14,"end_character":8},"updated":"2018-06-06 13:11:50.000000000","message":"are","commit_id":"b48f32649f7d67f76113a0c84a22e838f2040e57"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b22dc4b174750abeb99b88d968d2ff7220c44017","unresolved":false,"context_lines":[{"line_number":11,"context_line":"finish their job."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"In TestHAL3Agent.test_ha_router_restart_agents_no_packet_lost"},{"line_number":14,"context_line":"there is 60 pings send with 1 second timeout so default"},{"line_number":15,"context_line":"wait_until_true timeout which is set to 60 seconds might not"},{"line_number":16,"context_line":"be enough in some cases."},{"line_number":17,"context_line":"Because of that wait_until_true timeout is now set as"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_aceed388","line":14,"range":{"start_line":14,"start_character":18,"end_line":14,"end_character":22},"updated":"2018-06-06 13:11:50.000000000","message":"sent","commit_id":"b48f32649f7d67f76113a0c84a22e838f2040e57"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ce032795282f762b13f05102ed06b0ff2048fbc7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"finish their job."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"In TestHAL3Agent.test_ha_router_restart_agents_no_packet_lost"},{"line_number":14,"context_line":"there is 60 pings send with 1 second timeout so default"},{"line_number":15,"context_line":"wait_until_true timeout which is set to 60 seconds might not"},{"line_number":16,"context_line":"be enough in some cases."},{"line_number":17,"context_line":"Because of that wait_until_true timeout is now set as"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_d7eabc0c","line":14,"range":{"start_line":14,"start_character":18,"end_line":14,"end_character":22},"in_reply_to":"5f7c97a3_aceed388","updated":"2018-06-06 13:31:19.000000000","message":"Done","commit_id":"b48f32649f7d67f76113a0c84a22e838f2040e57"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ce032795282f762b13f05102ed06b0ff2048fbc7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"finish their job."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"In TestHAL3Agent.test_ha_router_restart_agents_no_packet_lost"},{"line_number":14,"context_line":"there is 60 pings send with 1 second timeout so default"},{"line_number":15,"context_line":"wait_until_true timeout which is set to 60 seconds might not"},{"line_number":16,"context_line":"be enough in some cases."},{"line_number":17,"context_line":"Because of that wait_until_true timeout is now set as"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_77f16801","line":14,"range":{"start_line":14,"start_character":6,"end_line":14,"end_character":8},"in_reply_to":"5f7c97a3_ece28ba0","updated":"2018-06-06 13:31:19.000000000","message":"Done","commit_id":"b48f32649f7d67f76113a0c84a22e838f2040e57"}],"neutron/tests/fullstack/base.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b22dc4b174750abeb99b88d968d2ff7220c44017","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            # happen only after RPC is established"},{"line_number":102,"context_line":"            common_utils.wait_until_true("},{"line_number":103,"context_line":"                done,"},{"line_number":104,"context_line":"                timeout\u003dcount * ping_timeout + 1,"},{"line_number":105,"context_line":"                exception\u003dRuntimeError(\"Could not ping the other VM, L2 agent \""},{"line_number":106,"context_line":"                                       \"restart leads to network disruption\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_ac933300","line":104,"range":{"start_line":104,"start_character":24,"end_line":104,"end_character":48},"updated":"2018-06-06 13:11:50.000000000","message":"Shouldn\u0027t we rather be on a safe side and set this timeout to double of what is expected? Hence:\n\n count * (ping_timeout + 1)\n\n?","commit_id":"b48f32649f7d67f76113a0c84a22e838f2040e57"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ce032795282f762b13f05102ed06b0ff2048fbc7","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            # happen only after RPC is established"},{"line_number":102,"context_line":"            common_utils.wait_until_true("},{"line_number":103,"context_line":"                done,"},{"line_number":104,"context_line":"                timeout\u003dcount * ping_timeout + 1,"},{"line_number":105,"context_line":"                exception\u003dRuntimeError(\"Could not ping the other VM, L2 agent \""},{"line_number":106,"context_line":"                                       \"restart leads to network disruption\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_6cb67b8d","line":104,"range":{"start_line":104,"start_character":24,"end_line":104,"end_character":48},"in_reply_to":"5f7c97a3_ac933300","updated":"2018-06-06 13:31:19.000000000","message":"we can :)","commit_id":"b48f32649f7d67f76113a0c84a22e838f2040e57"}]}
