)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"42cb04e363f312a2dfd98ef4f177eeb9ac86b8cd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add BEFORE notification event for subnet in ml2 plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements the BEFORE_CREATE notification event for the"},{"line_number":10,"context_line":"subnet resource in ml2 plugin."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related-Bug: #1766380"},{"line_number":13,"context_line":"Change-Id: I2ad73054b3b870314e8047e9a84ca60285c852e1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_fa72d349","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":29},"updated":"2018-06-11 22:10:37.000000000","message":"it actually adds BEFORE_CREATE notification to before_create_subnet method","commit_id":"3e3290da0de7314658dd9f1be257cb81f86d91dd"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"4c783ac3e320039d681cbe707e39f03cf7cb5279","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add BEFORE notification event for subnet in ml2 plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements the BEFORE_CREATE notification event for the"},{"line_number":10,"context_line":"subnet resource in ml2 plugin."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related-Bug: #1766380"},{"line_number":13,"context_line":"Change-Id: I2ad73054b3b870314e8047e9a84ca60285c852e1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_4dc22136","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":29},"in_reply_to":"5f7c97a3_fa72d349","updated":"2018-06-12 12:20:32.000000000","message":"Done","commit_id":"3e3290da0de7314658dd9f1be257cb81f86d91dd"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"42cb04e363f312a2dfd98ef4f177eeb9ac86b8cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5f7c97a3_da93574e","updated":"2018-06-11 22:10:37.000000000","message":"unit test is needed to assure notify with before_create event is called.","commit_id":"3e3290da0de7314658dd9f1be257cb81f86d91dd"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"4c783ac3e320039d681cbe707e39f03cf7cb5279","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5f7c97a3_0dde6910","in_reply_to":"5f7c97a3_da93574e","updated":"2018-06-12 12:20:32.000000000","message":"Done","commit_id":"3e3290da0de7314658dd9f1be257cb81f86d91dd"}],"neutron/tests/unit/plugins/ml2/test_plugin.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"d845d98d02f3c48cf7f825327d5c35bd1742ec8b","unresolved":false,"context_lines":[{"line_number":498,"context_line":"class TestMl2SubnetsV2(test_plugin.TestSubnetsV2,"},{"line_number":499,"context_line":"                       Ml2PluginV2TestCase):"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    def test_subnet_before_create_callback(self):"},{"line_number":502,"context_line":"        before_create \u003d mock.Mock()"},{"line_number":503,"context_line":"        registry.subscribe(before_create, resources.SUBNET,"},{"line_number":504,"context_line":"                           events.BEFORE_CREATE)"},{"line_number":505,"context_line":"        with self.subnet() as s:"},{"line_number":506,"context_line":"            before_create.assert_called_once_with("},{"line_number":507,"context_line":"                resources.SUBNET, events.BEFORE_CREATE, mock.ANY,"},{"line_number":508,"context_line":"                context\u003dmock.ANY, subnet\u003dmock.ANY)"},{"line_number":509,"context_line":"            kwargs \u003d before_create.mock_calls[0][2]"},{"line_number":510,"context_line":"            self.assertEqual(s[\u0027subnet\u0027][\u0027cidr\u0027], kwargs[\u0027subnet\u0027][\u0027cidr\u0027])"},{"line_number":511,"context_line":"            self.assertEqual(s[\u0027subnet\u0027][\u0027network_id\u0027],"},{"line_number":512,"context_line":"                             kwargs[\u0027subnet\u0027][\u0027network_id\u0027])"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"    def test_subnet_after_create_callback(self):"},{"line_number":515,"context_line":"        after_create \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_a5966148","line":512,"range":{"start_line":501,"start_character":4,"end_line":512,"end_character":60},"updated":"2018-06-12 20:18:21.000000000","message":"test looks good, but optionally if registry.notify is being called can also be asserted\nby having \nwith mock.patch.object(registry, \"notify\") as mock_n: before L505\nand then assert after L508 mock_n.assert_called_once_with(resources.SUBNET, \n                               events.BEFORE_CREATE, \n                               mock.ANY,\n                               context\u003dmock.ANY, \n                               subnet\u003ds[subnet])","commit_id":"19dccbf07e5234734dee7317bbb681413a1590cd"}]}