)]}'
{"neutron/agent/linux/polling.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"3f86d9c22b5c53fb83b435ebfb895c5e8779565d","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"@contextlib.contextmanager"},{"line_number":25,"context_line":"def get_polling_manager(minimize_polling\u003dFalse, root_helper\u003dNone,"},{"line_number":26,"context_line":"                        ovsdb_monitor_respawn_interval\u003d0):"},{"line_number":27,"context_line":"    if minimize_polling:"},{"line_number":28,"context_line":"        pm \u003d InterfacePollingMinimizer("},{"line_number":29,"context_line":"            root_helper\u003droot_helper,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BwUk%3D","line":26,"updated":"2013-11-20 16:24:59.000000000","message":"If default is 30, should this be set to 30? Here and below?","commit_id":"ef064c8bac2956a93d8b1c62ea47e8ee4fa97a13"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"99ce9109f89033d840ac3085f3ccc7c83f832d4a","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"@contextlib.contextmanager"},{"line_number":25,"context_line":"def get_polling_manager(minimize_polling\u003dFalse, root_helper\u003dNone,"},{"line_number":26,"context_line":"                        ovsdb_monitor_respawn_interval\u003d0):"},{"line_number":27,"context_line":"    if minimize_polling:"},{"line_number":28,"context_line":"        pm \u003d InterfacePollingMinimizer("},{"line_number":29,"context_line":"            root_helper\u003droot_helper,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BwRo%3D","line":26,"in_reply_to":"AAAATn%2F%2BwUk%3D","updated":"2013-11-20 16:33:47.000000000","message":"I wasn\u0027t sure, to be honest. I was looking off another patch related to minimize_polling (making it default to True) and they didn\u0027t update the default arguments in the function definitions so I followed suit. If it is better to define a constant and pass that as the argument default, I\u0027ll just do that.","commit_id":"ef064c8bac2956a93d8b1c62ea47e8ee4fa97a13"}],"neutron/plugins/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"3f86d9c22b5c53fb83b435ebfb895c5e8779565d","unresolved":false,"context_lines":[{"line_number":158,"context_line":"                 bridge_mappings, root_helper,"},{"line_number":159,"context_line":"                 polling_interval, tunnel_types\u003dNone,"},{"line_number":160,"context_line":"                 veth_mtu\u003dNone, l2_population\u003dFalse,"},{"line_number":161,"context_line":"                 minimize_polling\u003dFalse, ovsdb_monitor_respawn_interval\u003d0):"},{"line_number":162,"context_line":"        \u0027\u0027\u0027Constructor."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        :param integ_br: name of the integration bridge."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BwUI%3D","line":161,"updated":"2013-11-20 16:24:59.000000000","message":"Same question on default value. If is changed to 30, should you use a constant?","commit_id":"ef064c8bac2956a93d8b1c62ea47e8ee4fa97a13"}]}