)]}'
{"neutron/db/l3_dvr_db.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"46f471ab7c6130ef1f9f756ddc53b70175b3ebcd","unresolved":false,"context_lines":[{"line_number":1059,"context_line":"            if host is not None:"},{"line_number":1060,"context_line":"                l3_agent_on_host \u003d self.get_dvr_agent_on_host("},{"line_number":1061,"context_line":"                    context, host)"},{"line_number":1062,"context_line":"                if len(l3_agent_on_host):"},{"line_number":1063,"context_line":"                    if (self._get_agent_mode(l3_agent_on_host[0]) \u003d\u003d"},{"line_number":1064,"context_line":"                            const.L3_AGENT_MODE_DVR_NO_EXTERNAL):"},{"line_number":1065,"context_line":"                            # If the agent hosting the fixed port is in"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_1413b602","line":1062,"updated":"2018-06-13 13:42:41.000000000","message":"I would change this to \"if not l3_agent_on_host:\" and put the warning/return in it, that way you don\u0027t have to change the existing code.","commit_id":"9b281e8e520f78542dc25b9231e69afead694a01"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"601bbd7ad22b57d606e611094066d4d2d2d91d29","unresolved":false,"context_lines":[{"line_number":1059,"context_line":"            if host is not None:"},{"line_number":1060,"context_line":"                l3_agent_on_host \u003d self.get_dvr_agent_on_host("},{"line_number":1061,"context_line":"                    context, host)"},{"line_number":1062,"context_line":"                if len(l3_agent_on_host):"},{"line_number":1063,"context_line":"                    if (self._get_agent_mode(l3_agent_on_host[0]) \u003d\u003d"},{"line_number":1064,"context_line":"                            const.L3_AGENT_MODE_DVR_NO_EXTERNAL):"},{"line_number":1065,"context_line":"                            # If the agent hosting the fixed port is in"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_86ef941b","line":1062,"in_reply_to":"5f7c97a3_1413b602","updated":"2018-06-13 18:17:40.000000000","message":"Done","commit_id":"9b281e8e520f78542dc25b9231e69afead694a01"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"ad36c136a230995c26d64ca050d9758c44246f3a","unresolved":false,"context_lines":[{"line_number":1059,"context_line":"            if host is not None:"},{"line_number":1060,"context_line":"                l3_agent_on_host \u003d self.get_dvr_agent_on_host("},{"line_number":1061,"context_line":"                    context, host)"},{"line_number":1062,"context_line":"                if len(l3_agent_on_host):"},{"line_number":1063,"context_line":"                    if (self._get_agent_mode(l3_agent_on_host[0]) \u003d\u003d"},{"line_number":1064,"context_line":"                            const.L3_AGENT_MODE_DVR_NO_EXTERNAL):"},{"line_number":1065,"context_line":"                            # If the agent hosting the fixed port is in"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_4b3f4524","line":1062,"in_reply_to":"5f7c97a3_1413b602","updated":"2018-06-13 16:58:05.000000000","message":"Will do.","commit_id":"9b281e8e520f78542dc25b9231e69afead694a01"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"5ebb2c993d82c14986931f4699b59dfc710155f4","unresolved":false,"context_lines":[{"line_number":870,"context_line":"                context, const.AGENT_TYPE_L3, host)"},{"line_number":871,"context_line":"        except agent_exc.AgentNotFoundByTypeHost("},{"line_number":872,"context_line":"            agent_type\u003dconst.AGENT_TYPE_L3, host\u003dhost):"},{"line_number":873,"context_line":"            LOG.warning(\"L3 Agent not found for the given host: %s\", host)"},{"line_number":874,"context_line":"            return"},{"line_number":875,"context_line":"        l3_agent_mode \u003d self._get_agent_mode(l3_agent_db)"},{"line_number":876,"context_line":"        if l3_agent_mode \u003d\u003d const.L3_AGENT_MODE_DVR_NO_EXTERNAL:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_de00d405","line":873,"range":{"start_line":873,"start_character":25,"end_line":873,"end_character":33},"updated":"2018-06-14 23:16:55.000000000","message":"%s const.AGENT_TYPE_L3 can be used.\n\nNote: this comment doesn\u0027t contribute to -1, is totally author\u0027s choice","commit_id":"ec84bd1d421a88ef0e3027674a42b582b3f35ea9"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"4759d9f794be4301492a1749d663adb8ac4ab312","unresolved":false,"context_lines":[{"line_number":870,"context_line":"                context, const.AGENT_TYPE_L3, host)"},{"line_number":871,"context_line":"        except agent_exc.AgentNotFoundByTypeHost("},{"line_number":872,"context_line":"            agent_type\u003dconst.AGENT_TYPE_L3, host\u003dhost):"},{"line_number":873,"context_line":"            LOG.warning(\"L3 Agent not found for the given host: %s\", host)"},{"line_number":874,"context_line":"            return"},{"line_number":875,"context_line":"        l3_agent_mode \u003d self._get_agent_mode(l3_agent_db)"},{"line_number":876,"context_line":"        if l3_agent_mode \u003d\u003d const.L3_AGENT_MODE_DVR_NO_EXTERNAL:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_7bb41c83","line":873,"range":{"start_line":873,"start_character":25,"end_line":873,"end_character":33},"in_reply_to":"5f7c97a3_de00d405","updated":"2018-06-15 17:35:55.000000000","message":"Ok, I can use it.","commit_id":"ec84bd1d421a88ef0e3027674a42b582b3f35ea9"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"5ebb2c993d82c14986931f4699b59dfc710155f4","unresolved":false,"context_lines":[{"line_number":1060,"context_line":"                l3_agent_on_host \u003d self.get_dvr_agent_on_host("},{"line_number":1061,"context_line":"                    context, host)"},{"line_number":1062,"context_line":"                if not l3_agent_on_host:"},{"line_number":1063,"context_line":"                    LOG.warning(\"No valid agents found for the given host: \""},{"line_number":1064,"context_line":"                                \"%s\", host)"},{"line_number":1065,"context_line":"                    return"},{"line_number":1066,"context_line":"                agent_mode \u003d self._get_agent_mode(l3_agent_on_host[0])"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_c118f577","line":1063,"range":{"start_line":1063,"start_character":42,"end_line":1063,"end_character":48},"updated":"2018-06-14 23:16:55.000000000","message":"to be precise \u0027L3 agents\u0027","commit_id":"ec84bd1d421a88ef0e3027674a42b582b3f35ea9"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"4759d9f794be4301492a1749d663adb8ac4ab312","unresolved":false,"context_lines":[{"line_number":1060,"context_line":"                l3_agent_on_host \u003d self.get_dvr_agent_on_host("},{"line_number":1061,"context_line":"                    context, host)"},{"line_number":1062,"context_line":"                if not l3_agent_on_host:"},{"line_number":1063,"context_line":"                    LOG.warning(\"No valid agents found for the given host: \""},{"line_number":1064,"context_line":"                                \"%s\", host)"},{"line_number":1065,"context_line":"                    return"},{"line_number":1066,"context_line":"                agent_mode \u003d self._get_agent_mode(l3_agent_on_host[0])"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_5b8280a7","line":1063,"range":{"start_line":1063,"start_character":42,"end_line":1063,"end_character":48},"in_reply_to":"5f7c97a3_c118f577","updated":"2018-06-15 17:35:55.000000000","message":"Sure will address your concerns.","commit_id":"ec84bd1d421a88ef0e3027674a42b582b3f35ea9"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"4b46c10c4b972592004df17109ed483219d6e424","unresolved":false,"context_lines":[{"line_number":1062,"context_line":"                l3_agent_on_host \u003d self.get_dvr_agent_on_host("},{"line_number":1063,"context_line":"                    context, host)"},{"line_number":1064,"context_line":"                if not l3_agent_on_host:"},{"line_number":1065,"context_line":"                    LOG.warning(\"No valid dvr agent found for the given host: \""},{"line_number":1066,"context_line":"                                \"%s\", host)"},{"line_number":1067,"context_line":"                    return"},{"line_number":1068,"context_line":"                agent_mode \u003d self._get_agent_mode(l3_agent_on_host[0])"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_9f21dfff","line":1065,"range":{"start_line":1065,"start_character":42,"end_line":1065,"end_character":51},"updated":"2018-06-16 00:15:21.000000000","message":"its L3 agent ? or can say \u0027L3 dvr agent\u0027 since dvr agent may be confusing as the L3 and L2 agents are more common.","commit_id":"976f3ed5321cdc36c53a7e4ce0b58cb059e49844"}],"neutron/tests/functional/services/l3_router/test_l3_dvr_router_plugin.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"5ebb2c993d82c14986931f4699b59dfc710155f4","unresolved":false,"context_lines":[{"line_number":563,"context_line":"                            assert_called_once_with("},{"line_number":564,"context_line":"                                self.context, [router[\u0027id\u0027]], \u0027host1\u0027)"},{"line_number":565,"context_line":"                        self.assertFalse(l3_notif.routers_updated.called)"},{"line_number":566,"context_line":"                    if test_agent_mode is None:"},{"line_number":567,"context_line":"                        self.assertFalse("},{"line_number":568,"context_line":"                            l3_notif.routers_updated_on_host.called)"},{"line_number":569,"context_line":"                else:"},{"line_number":570,"context_line":"                    l3_notif.routers_updated.assert_called_once_with("},{"line_number":571,"context_line":"                        self.context, [router[\u0027id\u0027]], None)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_416ce5cf","line":568,"range":{"start_line":566,"start_character":19,"end_line":568,"end_character":68},"updated":"2018-06-14 23:16:55.000000000","message":"i wonder if this will ever get executed ? wouldn\u0027t it make sense to move L56 and L568 to else clause after L569 ?","commit_id":"ec84bd1d421a88ef0e3027674a42b582b3f35ea9"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"4759d9f794be4301492a1749d663adb8ac4ab312","unresolved":false,"context_lines":[{"line_number":563,"context_line":"                            assert_called_once_with("},{"line_number":564,"context_line":"                                self.context, [router[\u0027id\u0027]], \u0027host1\u0027)"},{"line_number":565,"context_line":"                        self.assertFalse(l3_notif.routers_updated.called)"},{"line_number":566,"context_line":"                    if test_agent_mode is None:"},{"line_number":567,"context_line":"                        self.assertFalse("},{"line_number":568,"context_line":"                            l3_notif.routers_updated_on_host.called)"},{"line_number":569,"context_line":"                else:"},{"line_number":570,"context_line":"                    l3_notif.routers_updated.assert_called_once_with("},{"line_number":571,"context_line":"                        self.context, [router[\u0027id\u0027]], None)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_1bf7285c","line":568,"range":{"start_line":566,"start_character":19,"end_line":568,"end_character":68},"in_reply_to":"5f7c97a3_416ce5cf","updated":"2018-06-15 17:35:55.000000000","message":"The else clause at #L569 is for the legacy routers and not for DVR routers. \nSo this code snippet should fit into the first if.","commit_id":"ec84bd1d421a88ef0e3027674a42b582b3f35ea9"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"4b46c10c4b972592004df17109ed483219d6e424","unresolved":false,"context_lines":[{"line_number":528,"context_line":"    def test_update_floating_ip_agent_notification_non_dvr(self):"},{"line_number":529,"context_line":"        self._test_update_floating_ip_agent_notification(dvr\u003dFalse)"},{"line_number":530,"context_line":""},{"line_number":531,"context_line":"    def test_delete_floating_ip_agent_with_no_agents(self):"},{"line_number":532,"context_line":"        with self.subnet() as ext_subnet,\\"},{"line_number":533,"context_line":"                self.subnet(cidr\u003d\u002720.0.0.0/24\u0027) as int_subnet,\\"},{"line_number":534,"context_line":"                self.port(subnet\u003dint_subnet,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_02033478","line":531,"range":{"start_line":531,"start_character":20,"end_line":531,"end_character":52},"updated":"2018-06-16 00:15:21.000000000","message":"\u0027floating_ip_with_no_agents\u0027","commit_id":"976f3ed5321cdc36c53a7e4ce0b58cb059e49844"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"4b46c10c4b972592004df17109ed483219d6e424","unresolved":false,"context_lines":[{"line_number":529,"context_line":"        self._test_update_floating_ip_agent_notification(dvr\u003dFalse)"},{"line_number":530,"context_line":""},{"line_number":531,"context_line":"    def test_delete_floating_ip_agent_with_no_agents(self):"},{"line_number":532,"context_line":"        with self.subnet() as ext_subnet,\\"},{"line_number":533,"context_line":"                self.subnet(cidr\u003d\u002720.0.0.0/24\u0027) as int_subnet,\\"},{"line_number":534,"context_line":"                self.port(subnet\u003dint_subnet,"},{"line_number":535,"context_line":"                          device_owner\u003dDEVICE_OWNER_COMPUTE) as int_port:"},{"line_number":536,"context_line":"            self.core_plugin.update_port("},{"line_number":537,"context_line":"                self.context, int_port[\u0027port\u0027][\u0027id\u0027],"},{"line_number":538,"context_line":"                {\u0027port\u0027: {portbindings.HOST_ID: \u0027host1\u0027}})"},{"line_number":539,"context_line":"            # and create l3 agents on corresponding hosts"},{"line_number":540,"context_line":"            helpers.register_l3_agent(host\u003d\u0027host1\u0027,"},{"line_number":541,"context_line":"                agent_mode\u003dconstants.L3_AGENT_MODE_DVR)"},{"line_number":542,"context_line":"            # make net external"},{"line_number":543,"context_line":"            ext_net_id \u003d ext_subnet[\u0027subnet\u0027][\u0027network_id\u0027]"},{"line_number":544,"context_line":"            self._update(\u0027networks\u0027, ext_net_id,"},{"line_number":545,"context_line":"                     {\u0027network\u0027: {extnet_apidef.EXTERNAL: True}})"},{"line_number":546,"context_line":""},{"line_number":547,"context_line":"            router \u003d self._create_router(distributed\u003dTrue)"},{"line_number":548,"context_line":"            self.l3_plugin.update_router("},{"line_number":549,"context_line":"                self.context, router[\u0027id\u0027],"},{"line_number":550,"context_line":"                {\u0027router\u0027: {"},{"line_number":551,"context_line":"                    \u0027external_gateway_info\u0027: {\u0027network_id\u0027: ext_net_id}}})"},{"line_number":552,"context_line":"            self.l3_plugin.add_router_interface("},{"line_number":553,"context_line":"                self.context, router[\u0027id\u0027],"},{"line_number":554,"context_line":"                {\u0027subnet_id\u0027: int_subnet[\u0027subnet\u0027][\u0027id\u0027]})"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"            floating_ip \u003d {\u0027floating_network_id\u0027: ext_net_id,"},{"line_number":557,"context_line":"                           \u0027router_id\u0027: router[\u0027id\u0027],"},{"line_number":558,"context_line":"                           \u0027port_id\u0027: int_port[\u0027port\u0027][\u0027id\u0027],"},{"line_number":559,"context_line":"                           \u0027tenant_id\u0027: int_port[\u0027port\u0027][\u0027tenant_id\u0027],"},{"line_number":560,"context_line":"                           \u0027dns_name\u0027: \u0027\u0027, \u0027dns_domain\u0027: \u0027\u0027}"},{"line_number":561,"context_line":"            floating_ip \u003d self.l3_plugin.create_floatingip("},{"line_number":562,"context_line":"                self.context, {\u0027floatingip\u0027: floating_ip})"},{"line_number":563,"context_line":"            with mock.patch.object("},{"line_number":564,"context_line":"                    self.l3_plugin, \u0027get_dvr_agent_on_host\u0027) as dvr_host,\\"},{"line_number":565,"context_line":"                    mock.patch.object(self.l3_plugin,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_c20a1c78","line":562,"range":{"start_line":532,"start_character":8,"end_line":562,"end_character":58},"updated":"2018-06-16 00:15:21.000000000","message":"except L540 and L541 this code is repeated from previous test, can be moved to a common helper ?","commit_id":"976f3ed5321cdc36c53a7e4ce0b58cb059e49844"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"4ecebcb0442b4d13c1130fb333ea3e9857939076","unresolved":false,"context_lines":[{"line_number":361,"context_line":"                        l3_notif.routers_updated_on_host.\\"},{"line_number":362,"context_line":"                            assert_called_once_with("},{"line_number":363,"context_line":"                                self.context, [router[\u0027id\u0027]], \u0027host1\u0027)"},{"line_number":364,"context_line":"                        self.assertFalse(l3_notif.routers_updated.called)"},{"line_number":365,"context_line":"                else:"},{"line_number":366,"context_line":"                    l3_notif.routers_updated.assert_called_once_with("},{"line_number":367,"context_line":"                        self.context, [router[\u0027id\u0027]], None)"},{"line_number":368,"context_line":"                    self.assertFalse("},{"line_number":369,"context_line":"                        l3_notif.routers_updated_on_host.called)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def test_create_floating_ip_agent_notification(self):"},{"line_number":372,"context_line":"        self._test_create_floating_ip_agent_notification()"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_064d683a","side":"PARENT","line":369,"range":{"start_line":364,"start_character":17,"end_line":369,"end_character":64},"updated":"2018-06-18 19:48:30.000000000","message":"is this removal intentional ? I think its modifying existing tests ?","commit_id":"c9b99ae1e1939bb1803370316582de082f10a837"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"1fd1203618cdb2441b0483629d4c029f90cae56d","unresolved":false,"context_lines":[{"line_number":361,"context_line":"                        l3_notif.routers_updated_on_host.\\"},{"line_number":362,"context_line":"                            assert_called_once_with("},{"line_number":363,"context_line":"                                self.context, [router[\u0027id\u0027]], \u0027host1\u0027)"},{"line_number":364,"context_line":"                        self.assertFalse(l3_notif.routers_updated.called)"},{"line_number":365,"context_line":"                else:"},{"line_number":366,"context_line":"                    l3_notif.routers_updated.assert_called_once_with("},{"line_number":367,"context_line":"                        self.context, [router[\u0027id\u0027]], None)"},{"line_number":368,"context_line":"                    self.assertFalse("},{"line_number":369,"context_line":"                        l3_notif.routers_updated_on_host.called)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def test_create_floating_ip_agent_notification(self):"},{"line_number":372,"context_line":"        self._test_create_floating_ip_agent_notification()"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_d7ff1cfe","side":"PARENT","line":369,"range":{"start_line":364,"start_character":17,"end_line":369,"end_character":64},"in_reply_to":"5f7c97a3_064d683a","updated":"2018-06-18 21:31:26.000000000","message":"Sorry, it was not intentional. Something might have messed up things.\nI will push in a fix for it.","commit_id":"c9b99ae1e1939bb1803370316582de082f10a837"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8fc9c547038a1bd844790c49c763ec64f5ffa172","unresolved":false,"context_lines":[{"line_number":561,"context_line":"                        l3_notif.routers_updated_on_host.called)"},{"line_number":562,"context_line":"                    return"},{"line_number":563,"context_line":"            with mock.patch.object("},{"line_number":564,"context_line":"                        self.l3_plugin, \u0027_l3_rpc_notifier\u0027) as l3_notif:"},{"line_number":565,"context_line":"                self.l3_plugin.delete_floatingip("},{"line_number":566,"context_line":"                    self.context, floating_ip[\u0027id\u0027])"},{"line_number":567,"context_line":"                if dvr:"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_47fd7e06","line":564,"updated":"2018-06-19 19:33:01.000000000","message":"nit: random whitespace change","commit_id":"5ceca4d9d1041345ccfeab675c8e8216050f7135"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"6525e0486bb00df7e91d9ae9fd55ab9bbb695479","unresolved":false,"context_lines":[{"line_number":561,"context_line":"                        l3_notif.routers_updated_on_host.called)"},{"line_number":562,"context_line":"                    return"},{"line_number":563,"context_line":"            with mock.patch.object("},{"line_number":564,"context_line":"                        self.l3_plugin, \u0027_l3_rpc_notifier\u0027) as l3_notif:"},{"line_number":565,"context_line":"                self.l3_plugin.delete_floatingip("},{"line_number":566,"context_line":"                    self.context, floating_ip[\u0027id\u0027])"},{"line_number":567,"context_line":"                if dvr:"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_7585c458","line":564,"in_reply_to":"5f7c97a3_47fd7e06","updated":"2018-06-19 21:38:23.000000000","message":"Do you want me to push another patch to fix this whitespace","commit_id":"5ceca4d9d1041345ccfeab675c8e8216050f7135"}],"neutron/tests/unit/db/test_l3_dvr_db.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"46f471ab7c6130ef1f9f756ddc53b70175b3ebcd","unresolved":false,"context_lines":[{"line_number":482,"context_line":"                    self.mixin.create_fip_agent_gw_port_if_not_exists,"},{"line_number":483,"context_line":"                    self.ctx,"},{"line_number":484,"context_line":"                    \u0027network_id\u0027,"},{"line_number":485,"context_line":"                    \u0027myhost\u0027)"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"    def test_create_fip_agent_gw_port_if_not_exists_with_l3_agent(self):"},{"line_number":488,"context_line":"        fport_db \u003d {\u0027id\u0027: _uuid()}"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_b4bc42dc","line":485,"updated":"2018-06-13 13:42:41.000000000","message":"block indented too much","commit_id":"9b281e8e520f78542dc25b9231e69afead694a01"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"ad36c136a230995c26d64ca050d9758c44246f3a","unresolved":false,"context_lines":[{"line_number":482,"context_line":"                    self.mixin.create_fip_agent_gw_port_if_not_exists,"},{"line_number":483,"context_line":"                    self.ctx,"},{"line_number":484,"context_line":"                    \u0027network_id\u0027,"},{"line_number":485,"context_line":"                    \u0027myhost\u0027)"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"    def test_create_fip_agent_gw_port_if_not_exists_with_l3_agent(self):"},{"line_number":488,"context_line":"        fport_db \u003d {\u0027id\u0027: _uuid()}"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_eb7c11ec","line":485,"in_reply_to":"5f7c97a3_b4bc42dc","updated":"2018-06-13 16:58:05.000000000","message":"will fix it.","commit_id":"9b281e8e520f78542dc25b9231e69afead694a01"}]}
