)]}'
{"neutron/agent/l3/dvr_local_router.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"71093bf2491bbf63f671a4c6ae8e7a1a6b5881b6","unresolved":false,"context_lines":[{"line_number":604,"context_line":"    def connect_rtr_2_fip(self):"},{"line_number":605,"context_line":"        fip_ns_name \u003d self.fip_ns.get_name()"},{"line_number":606,"context_line":"        fip_2_rtr_name \u003d self.fip_ns.get_int_device_name(self.router_id)"},{"line_number":607,"context_line":"        if ip_lib.network_namespace_exists(fip_ns_name):"},{"line_number":608,"context_line":"            # NOTE: This check for the internal \u0027fpr\u0027 port in the fip"},{"line_number":609,"context_line":"            # namespace will ensure that the connection from router to fip"},{"line_number":610,"context_line":"            # namespace is intact."}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_f924b3b4","line":607,"updated":"2018-06-15 19:50:30.000000000","message":"What about when the namespace doesn\u0027t exist?","commit_id":"9556b49ec8ed6fd6ef44bfb3f0188fb961cc2c0c"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"7d098ff204f0c1c4b6c72c2b75a78581c5e5f999","unresolved":false,"context_lines":[{"line_number":604,"context_line":"    def connect_rtr_2_fip(self):"},{"line_number":605,"context_line":"        fip_ns_name \u003d self.fip_ns.get_name()"},{"line_number":606,"context_line":"        fip_2_rtr_name \u003d self.fip_ns.get_int_device_name(self.router_id)"},{"line_number":607,"context_line":"        if ip_lib.network_namespace_exists(fip_ns_name):"},{"line_number":608,"context_line":"            # NOTE: This check for the internal \u0027fpr\u0027 port in the fip"},{"line_number":609,"context_line":"            # namespace will ensure that the connection from router to fip"},{"line_number":610,"context_line":"            # namespace is intact."}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_fc80214c","line":607,"in_reply_to":"5f7c97a3_f924b3b4","updated":"2018-06-15 20:56:40.000000000","message":"If the code path comes in here, then it would be after the namespace was created.\nBecause in #L600 it calls \u0027create_dvr_external_gateway_on_agent\u0027 for the configured gateway.\n\nDo you think we still need to handle a case here?","commit_id":"9556b49ec8ed6fd6ef44bfb3f0188fb961cc2c0c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"71093bf2491bbf63f671a4c6ae8e7a1a6b5881b6","unresolved":false,"context_lines":[{"line_number":609,"context_line":"            # namespace will ensure that the connection from router to fip"},{"line_number":610,"context_line":"            # namespace is intact."},{"line_number":611,"context_line":"            fip_ns_name \u003d self.fip_ns.get_name()"},{"line_number":612,"context_line":"            fip_2_rtr_name \u003d self.fip_ns.get_int_device_name(self.router_id)"},{"line_number":613,"context_line":"            device \u003d ip_lib.IPDevice(fip_2_rtr_name, namespace\u003dfip_ns_name)"},{"line_number":614,"context_line":"            if not device.exists():"},{"line_number":615,"context_line":"                self.rtr_fip_connect \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_916eb9fe","line":612,"updated":"2018-06-15 19:50:30.000000000","message":"These seem duplicates of L605/606","commit_id":"9556b49ec8ed6fd6ef44bfb3f0188fb961cc2c0c"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"7d098ff204f0c1c4b6c72c2b75a78581c5e5f999","unresolved":false,"context_lines":[{"line_number":609,"context_line":"            # namespace will ensure that the connection from router to fip"},{"line_number":610,"context_line":"            # namespace is intact."},{"line_number":611,"context_line":"            fip_ns_name \u003d self.fip_ns.get_name()"},{"line_number":612,"context_line":"            fip_2_rtr_name \u003d self.fip_ns.get_int_device_name(self.router_id)"},{"line_number":613,"context_line":"            device \u003d ip_lib.IPDevice(fip_2_rtr_name, namespace\u003dfip_ns_name)"},{"line_number":614,"context_line":"            if not device.exists():"},{"line_number":615,"context_line":"                self.rtr_fip_connect \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_1c863d67","line":612,"in_reply_to":"5f7c97a3_916eb9fe","updated":"2018-06-15 20:56:40.000000000","message":"Yes will clean it up.","commit_id":"9556b49ec8ed6fd6ef44bfb3f0188fb961cc2c0c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"71093bf2491bbf63f671a4c6ae8e7a1a6b5881b6","unresolved":false,"context_lines":[{"line_number":611,"context_line":"            fip_ns_name \u003d self.fip_ns.get_name()"},{"line_number":612,"context_line":"            fip_2_rtr_name \u003d self.fip_ns.get_int_device_name(self.router_id)"},{"line_number":613,"context_line":"            device \u003d ip_lib.IPDevice(fip_2_rtr_name, namespace\u003dfip_ns_name)"},{"line_number":614,"context_line":"            if not device.exists():"},{"line_number":615,"context_line":"                self.rtr_fip_connect \u003d False"},{"line_number":616,"context_line":"        if self.fip_ns.agent_gateway_port and not self.rtr_fip_connect:"},{"line_number":617,"context_line":"            ex_gw_port \u003d self.get_ex_gw_port()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_3121e5b6","line":614,"updated":"2018-06-15 19:50:30.000000000","message":"Can remove L613 and just do:\n\nif not ip_lib.device_exists(fip_2_rtr_name, namespace\u003dfip_ns_name):","commit_id":"9556b49ec8ed6fd6ef44bfb3f0188fb961cc2c0c"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"7d098ff204f0c1c4b6c72c2b75a78581c5e5f999","unresolved":false,"context_lines":[{"line_number":611,"context_line":"            fip_ns_name \u003d self.fip_ns.get_name()"},{"line_number":612,"context_line":"            fip_2_rtr_name \u003d self.fip_ns.get_int_device_name(self.router_id)"},{"line_number":613,"context_line":"            device \u003d ip_lib.IPDevice(fip_2_rtr_name, namespace\u003dfip_ns_name)"},{"line_number":614,"context_line":"            if not device.exists():"},{"line_number":615,"context_line":"                self.rtr_fip_connect \u003d False"},{"line_number":616,"context_line":"        if self.fip_ns.agent_gateway_port and not self.rtr_fip_connect:"},{"line_number":617,"context_line":"            ex_gw_port \u003d self.get_ex_gw_port()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_bc7aa974","line":614,"in_reply_to":"5f7c97a3_3121e5b6","updated":"2018-06-15 20:56:40.000000000","message":"Sure.","commit_id":"9556b49ec8ed6fd6ef44bfb3f0188fb961cc2c0c"}]}
