)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"837785bffb6fc57aacc60324209f43db40afc4a5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"And converts vpn agent as a reference. Later, further conversion patches"},{"line_number":12,"context_line":"will follow."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Further step:"},{"line_number":15,"context_line":"- devstack"},{"line_number":16,"context_line":"- refactoring for agent framework"},{"line_number":17,"context_line":"  https://etherpad.openstack.org/p/icehouse-neutron-agent-framework-refactor"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"AAAAUX%2F%2Bvgw%3D","line":14,"updated":"2014-02-19 13:24:30.000000000","message":"nit: steps","commit_id":"32ded054b8b55124e88d41dda11fa6f92a3136c5"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"e3ce520e857c3192634ddc85ce54d1c4653ace32","unresolved":false,"context_lines":[{"line_number":11,"context_line":"And converts vpn agent as a reference. Later, further conversion patches"},{"line_number":12,"context_line":"will follow."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Further step:"},{"line_number":15,"context_line":"- devstack"},{"line_number":16,"context_line":"- refactoring for agent framework"},{"line_number":17,"context_line":"  https://etherpad.openstack.org/p/icehouse-neutron-agent-framework-refactor"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"AAAAUX%2F%2BoM0%3D","line":14,"in_reply_to":"AAAAUX%2F%2Bvgw%3D","updated":"2014-02-20 05:29:18.000000000","message":"Done","commit_id":"32ded054b8b55124e88d41dda11fa6f92a3136c5"}],"etc/service_agent.ini":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"61a7223923687d466595cbf441b73f4f4634a537","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[serviceagent]"},{"line_number":5,"context_line":"# service agent drivers which service agent will spawn"},{"line_number":6,"context_line":"# each agent driver may have its own ini file."},{"line_number":7,"context_line":"# If multiple drivers are wanted,  this option needs to be defined multiple"},{"line_number":8,"context_line":"# times."},{"line_number":9,"context_line":"#service_agent_driver\u003dneutron.agent.service.driver_noop.AgentDriverNoop"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAATn%2F%2BtLc%3D","line":6,"updated":"2013-11-21 10:13:54.000000000","message":"I think it\u0027s better to have either 1 ini file at all (this one), or separate file for particular driver configuration.\nAnother option could be to gather driver configuration in etc/services.conf","commit_id":"df82da4de9ee2b2d13f4147aaeddd3eca386f902"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"ae928cb913fef7cafa1b6fe82dde4315624564b1","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[serviceagent]"},{"line_number":5,"context_line":"# service agent drivers which service agent will spawn"},{"line_number":6,"context_line":"# each agent driver may have its own ini file."},{"line_number":7,"context_line":"# If multiple drivers are wanted,  this option needs to be defined multiple"},{"line_number":8,"context_line":"# times."},{"line_number":9,"context_line":"#service_agent_driver\u003dneutron.agent.service.driver_noop.AgentDriverNoop"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAATn%2F%2BpSk%3D","line":6,"in_reply_to":"AAAATn%2F%2BtLc%3D","updated":"2013-11-22 02:39:10.000000000","message":"Which do you recommend? 1 ini file or separated for each driver?\nAnyway separated ini file will be supported during transition because the current service agents uses its own ini file.\n\nIf single ini file is the way to go, it will be addressed as another patch.\nI prefer to give drivers freedom to use this ini file or its own ini file, given all the agent (not only service agents, but also core plugin agents and others) would be consolidated into single agent.","commit_id":"df82da4de9ee2b2d13f4147aaeddd3eca386f902"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"61a7223923687d466595cbf441b73f4f4634a537","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# each agent driver may have its own ini file."},{"line_number":7,"context_line":"# If multiple drivers are wanted,  this option needs to be defined multiple"},{"line_number":8,"context_line":"# times."},{"line_number":9,"context_line":"#service_agent_driver\u003dneutron.agent.service.driver_noop.AgentDriverNoop"},{"line_number":10,"context_line":"#service_agent_driver\u003dneutron.service.vpn.agent.AgentDriverVPN"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAATn%2F%2BtMI%3D","line":9,"updated":"2013-11-21 10:13:54.000000000","message":"Per discussion on design sessions: it\u0027s better not to mention noop drivers in configuration and also keep them in unit test tree","commit_id":"df82da4de9ee2b2d13f4147aaeddd3eca386f902"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"ae928cb913fef7cafa1b6fe82dde4315624564b1","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# each agent driver may have its own ini file."},{"line_number":7,"context_line":"# If multiple drivers are wanted,  this option needs to be defined multiple"},{"line_number":8,"context_line":"# times."},{"line_number":9,"context_line":"#service_agent_driver\u003dneutron.agent.service.driver_noop.AgentDriverNoop"},{"line_number":10,"context_line":"#service_agent_driver\u003dneutron.service.vpn.agent.AgentDriverVPN"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAATn%2F%2BpTQ%3D","line":9,"in_reply_to":"AAAATn%2F%2BtMI%3D","updated":"2013-11-22 02:39:10.000000000","message":"Done","commit_id":"df82da4de9ee2b2d13f4147aaeddd3eca386f902"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c81e02aacd10a9d24aec59a581d6fd020dd6d8cc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"# Service-Agent configuration file"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[serviceagent]"},{"line_number":5,"context_line":"# (ListOpt) Ordered list of agent drivers entry points"},{"line_number":6,"context_line":"# to be loaded from neutron.agent.service.agent_drivers namespace."},{"line_number":7,"context_line":"# each agent driver may have its own ini file."}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAATn%2F%2BCVQ%3D","line":4,"updated":"2013-12-03 07:37:41.000000000","message":"consider service_agent","commit_id":"65ea2658f133600370eadc84b131795e9dc32c1e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"6e9e71b54f69c62db4054c4b3fea5e7e5248827a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"# Service-Agent configuration file"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[serviceagent]"},{"line_number":5,"context_line":"# (ListOpt) Ordered list of agent drivers entry points"},{"line_number":6,"context_line":"# to be loaded from neutron.agent.service.agent_drivers namespace."},{"line_number":7,"context_line":"# each agent driver may have its own ini file."}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAATn%2F98yU%3D","line":4,"in_reply_to":"AAAATn%2F%2BCVQ%3D","updated":"2013-12-04 05:20:24.000000000","message":"Done","commit_id":"65ea2658f133600370eadc84b131795e9dc32c1e"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c81e02aacd10a9d24aec59a581d6fd020dd6d8cc","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Service-Agent configuration file"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[serviceagent]"},{"line_number":5,"context_line":"# (ListOpt) Ordered list of agent drivers entry points"},{"line_number":6,"context_line":"# to be loaded from neutron.agent.service.agent_drivers namespace."},{"line_number":7,"context_line":"# each agent driver may have its own ini file."},{"line_number":8,"context_line":"# service_agent_drivers \u003d"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAATn%2F%2BCU8%3D","line":5,"updated":"2013-12-03 07:37:41.000000000","message":"comma separated?","commit_id":"65ea2658f133600370eadc84b131795e9dc32c1e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"6e9e71b54f69c62db4054c4b3fea5e7e5248827a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Service-Agent configuration file"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[serviceagent]"},{"line_number":5,"context_line":"# (ListOpt) Ordered list of agent drivers entry points"},{"line_number":6,"context_line":"# to be loaded from neutron.agent.service.agent_drivers namespace."},{"line_number":7,"context_line":"# each agent driver may have its own ini file."},{"line_number":8,"context_line":"# service_agent_drivers \u003d"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAATn%2F98x8%3D","line":5,"in_reply_to":"AAAATn%2F%2BCU8%3D","updated":"2013-12-04 05:20:24.000000000","message":"Done","commit_id":"65ea2658f133600370eadc84b131795e9dc32c1e"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"225562f23ecd552f8981c3eaa5eb2a5ec870bffd","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# (ListOpt) Ordered list of agent drivers entry points"},{"line_number":6,"context_line":"# to be loaded from neutron.agent.service.agent_drivers namespace."},{"line_number":7,"context_line":"# each agent driver may have its own ini file."},{"line_number":8,"context_line":"# service_agent_drivers \u003d"},{"line_number":9,"context_line":"# Example: service_agent_drivers \u003d vpnagent"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAATn%2F%2BBSU%3D","line":8,"updated":"2013-12-03 12:35:35.000000000","message":"Is implication that if no driver is specified the noop driver will be used? Should we mention that?","commit_id":"65ea2658f133600370eadc84b131795e9dc32c1e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"6e9e71b54f69c62db4054c4b3fea5e7e5248827a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# (ListOpt) Ordered list of agent drivers entry points"},{"line_number":6,"context_line":"# to be loaded from neutron.agent.service.agent_drivers namespace."},{"line_number":7,"context_line":"# each agent driver may have its own ini file."},{"line_number":8,"context_line":"# service_agent_drivers \u003d"},{"line_number":9,"context_line":"# Example: service_agent_drivers \u003d vpnagent"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAATn%2F98us%3D","line":8,"in_reply_to":"AAAATn%2F%2BBSU%3D","updated":"2013-12-04 05:20:24.000000000","message":"Done","commit_id":"65ea2658f133600370eadc84b131795e9dc32c1e"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"ec6ca60f993b39e822e5b48cf869514ae2a6ed28","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Service-Agent configuration file"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[service_agent]"},{"line_number":5,"context_line":"# (ListOpt) list of agent drivers entry points to be loaded from"},{"line_number":6,"context_line":"# neutron.agent.service.agent_drivers namespace."},{"line_number":7,"context_line":"# each agent driver may have its own ini file."},{"line_number":8,"context_line":"# If no driver is specified, nothing will be loaded."}],"source_content_type":"text/x-properties","patch_set":4,"id":"AAAATn%2F97TA%3D","line":5,"updated":"2013-12-04 11:55:09.000000000","message":"it\u0027s a multi str opt now, so please update the description, please mention that multiple entries can be specified (one per line)","commit_id":"d21bb2b839489a4cf498b07171f10d727cada611"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"a79b77bcb54e500e43ae464d40090ea8054c1a7b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Service-Agent configuration file"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[service_agent]"},{"line_number":5,"context_line":"# (ListOpt) list of agent drivers entry points to be loaded from"},{"line_number":6,"context_line":"# neutron.agent.service.agent_drivers namespace."},{"line_number":7,"context_line":"# each agent driver may have its own ini file."},{"line_number":8,"context_line":"# If no driver is specified, nothing will be loaded."}],"source_content_type":"text/x-properties","patch_set":4,"id":"AAAATn%2F92QI%3D","line":5,"in_reply_to":"AAAATn%2F97TA%3D","updated":"2013-12-05 09:52:16.000000000","message":"Done","commit_id":"d21bb2b839489a4cf498b07171f10d727cada611"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"ec6ca60f993b39e822e5b48cf869514ae2a6ed28","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[service_agent]"},{"line_number":5,"context_line":"# (ListOpt) list of agent drivers entry points to be loaded from"},{"line_number":6,"context_line":"# neutron.agent.service.agent_drivers namespace."},{"line_number":7,"context_line":"# each agent driver may have its own ini file."},{"line_number":8,"context_line":"# If no driver is specified, nothing will be loaded."},{"line_number":9,"context_line":"# service_agent_drivers \u003d"}],"source_content_type":"text/x-properties","patch_set":4,"id":"AAAATn%2F97UA%3D","line":6,"updated":"2013-12-04 11:55:09.000000000","message":"I don\u0027t think this is valuable info in a config file","commit_id":"d21bb2b839489a4cf498b07171f10d727cada611"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"a79b77bcb54e500e43ae464d40090ea8054c1a7b","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[service_agent]"},{"line_number":5,"context_line":"# (ListOpt) list of agent drivers entry points to be loaded from"},{"line_number":6,"context_line":"# neutron.agent.service.agent_drivers namespace."},{"line_number":7,"context_line":"# each agent driver may have its own ini file."},{"line_number":8,"context_line":"# If no driver is specified, nothing will be loaded."},{"line_number":9,"context_line":"# service_agent_drivers \u003d"}],"source_content_type":"text/x-properties","patch_set":4,"id":"AAAATn%2F92QE%3D","line":6,"in_reply_to":"AAAATn%2F97UA%3D","updated":"2013-12-05 09:52:16.000000000","message":"Done","commit_id":"d21bb2b839489a4cf498b07171f10d727cada611"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"0d55cb03d86395700ea5ee3464711bda5b27d311","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Service-Agent configuration file"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[service_agent]"},{"line_number":5,"context_line":"# (MultiStrOpt) agent driver entry point to be loaded."},{"line_number":6,"context_line":"# Multiple entries can be specified."},{"line_number":7,"context_line":"# If no driver is specified, nothing will be loaded."},{"line_number":8,"context_line":"# each agent driver may have its own ini file."}],"source_content_type":"text/x-properties","patch_set":5,"id":"AAAATn%2F91nU%3D","line":5,"updated":"2013-12-05 12:00:06.000000000","message":"Just wondering if we should be calling is device_driver instead of agent_driver. Thoughts?","commit_id":"a3822c38ce613724ddd1c148a298e044f1896ef6"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"33867e273a22983bb147d42f94597ffe5edb1bad","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Service-Agent configuration file"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[service_agent]"},{"line_number":5,"context_line":"# (MultiStrOpt) agent driver entry point to be loaded."},{"line_number":6,"context_line":"# Multiple entries can be specified."},{"line_number":7,"context_line":"# If no driver is specified, nothing will be loaded."},{"line_number":8,"context_line":"# each agent driver may have its own ini file."}],"source_content_type":"text/x-properties","patch_set":5,"id":"AAAAUX%2F%2Fms4%3D","line":5,"in_reply_to":"AAAATn%2F91nU%3D","updated":"2014-02-12 02:54:42.000000000","message":"Done","commit_id":"a3822c38ce613724ddd1c148a298e044f1896ef6"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"79c5e93e2a7441c3f2857110a521e4e4478f22c2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"# Service-Agent configuration file"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[service_agent]"},{"line_number":5,"context_line":"# (MultiStrOpt) device driver entry point to be loaded."},{"line_number":6,"context_line":"# Multiple entries can be specified."},{"line_number":7,"context_line":"# If no driver is specified, nothing will be loaded."}],"source_content_type":"text/x-properties","patch_set":8,"id":"AAAAUX%2F%2FcaQ%3D","line":4,"updated":"2014-02-13 06:30:25.000000000","message":"Let\u0027s say l3 and dhcp are converted to this framework.  Will it still be possible to run them in separate processes that can be managed individually by using different copies of this config file?  Now, these two agents run separately and they do not contend on any namespaces in common.  This consolidation will not prevent that, right?","commit_id":"c5c3bf4c6b734dfc207b31ef563b369e604b7fdb"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"503bd499e7e73fa053044b813cdfcd07851a526d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"# Service-Agent configuration file"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[service_agent]"},{"line_number":5,"context_line":"# (MultiStrOpt) device driver entry point to be loaded."},{"line_number":6,"context_line":"# Multiple entries can be specified."},{"line_number":7,"context_line":"# If no driver is specified, nothing will be loaded."}],"source_content_type":"text/x-properties","patch_set":8,"id":"AAAAUX%2F%2FTmY%3D","line":4,"in_reply_to":"AAAAUX%2F%2FcaQ%3D","updated":"2014-02-14 03:28:53.000000000","message":"Yes and No.\nThey can be run independently.","commit_id":"c5c3bf4c6b734dfc207b31ef563b369e604b7fdb"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"837785bffb6fc57aacc60324209f43db40afc4a5","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# Show debugging output in log (sets DEBUG log level output)."},{"line_number":4,"context_line":"# debug \u003d False"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# LBaas requires an interface driver be set. Choose the one that best"},{"line_number":7,"context_line":"# matches your plugin."},{"line_number":8,"context_line":"# interface_driver \u003d"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-properties","patch_set":10,"id":"AAAAUX%2F%2BvgQ%3D","line":6,"updated":"2014-02-19 13:24:30.000000000","message":"does only LBaaS require interface driver?","commit_id":"32ded054b8b55124e88d41dda11fa6f92a3136c5"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"8e936c6f9511613c0dd825b10bd2c433ef5fa35d","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# Show debugging output in log (sets DEBUG log level output)."},{"line_number":4,"context_line":"# debug \u003d False"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# LBaas requires an interface driver be set. Choose the one that best"},{"line_number":7,"context_line":"# matches your plugin."},{"line_number":8,"context_line":"# interface_driver \u003d"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-properties","patch_set":10,"id":"AAAAUX%2F%2Bmcs%3D","line":6,"in_reply_to":"AAAAUX%2F%2Bmmk%3D","updated":"2014-02-20 09:16:14.000000000","message":"Done","commit_id":"32ded054b8b55124e88d41dda11fa6f92a3136c5"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c5d13530ad209dcce923f46b7a581c0fd473f1be","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# Show debugging output in log (sets DEBUG log level output)."},{"line_number":4,"context_line":"# debug \u003d False"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# LBaas requires an interface driver be set. Choose the one that best"},{"line_number":7,"context_line":"# matches your plugin."},{"line_number":8,"context_line":"# interface_driver \u003d"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-properties","patch_set":10,"id":"AAAAUX%2F%2Bmmk%3D","line":6,"in_reply_to":"AAAAUX%2F%2BoMM%3D","updated":"2014-02-20 08:58:14.000000000","message":"My question was more about if it\u0027s only LBaaS agent that requires interface driver. I think at least l3 agent also requires it. So probably it makes sense to replace \u0027LBaaS\u0027-\u003e\u0027Some agents\u0027 on this line.","commit_id":"32ded054b8b55124e88d41dda11fa6f92a3136c5"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"e3ce520e857c3192634ddc85ce54d1c4653ace32","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# Show debugging output in log (sets DEBUG log level output)."},{"line_number":4,"context_line":"# debug \u003d False"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# LBaas requires an interface driver be set. Choose the one that best"},{"line_number":7,"context_line":"# matches your plugin."},{"line_number":8,"context_line":"# interface_driver \u003d"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-properties","patch_set":10,"id":"AAAAUX%2F%2BoMM%3D","line":6,"in_reply_to":"AAAAUX%2F%2BvgQ%3D","updated":"2014-02-20 05:29:18.000000000","message":"Yes, haproxy driver requires it.\nPlease see neutron/services/loadbalancer/drivers/haproxy/namespace_driver.py","commit_id":"32ded054b8b55124e88d41dda11fa6f92a3136c5"}],"neutron/agent/service/agent.py":[{"author":{"_account_id":7987,"name":"Ivar Lazzaro","email":"ivarlazzaro@gmail.com","username":"Ivar"},"change_message_id":"dcaca522d1e63761d71638a43ec7045263e71016","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":16,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":17,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":18,"context_line":"#    under the License."},{"line_number":19,"context_line":"import eventlet"},{"line_number":20,"context_line":"from oslo.config import cfg"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BeJk%3D","line":18,"updated":"2013-11-25 18:35:32.000000000","message":"nit: blank line","commit_id":"df82da4de9ee2b2d13f4147aaeddd3eca386f902"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"0984e0732e6979aad03c3e2469c1d376870711ae","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":16,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":17,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":18,"context_line":"#    under the License."},{"line_number":19,"context_line":"import eventlet"},{"line_number":20,"context_line":"from oslo.config import cfg"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Bb4w%3D","line":18,"in_reply_to":"AAAATn%2F%2BeJk%3D","updated":"2013-11-26 05:14:19.000000000","message":"Done","commit_id":"df82da4de9ee2b2d13f4147aaeddd3eca386f902"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"f5ffb9f82936348d78274151e27498f0827264a8","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    def _setup(self):"},{"line_number":50,"context_line":"        self._drivers \u003d [importutils.import_object(driver, self.host)"},{"line_number":51,"context_line":"                         for driver in"},{"line_number":52,"context_line":"                         cfg.CONF.serviceagent.service_agetn_driver]"},{"line_number":53,"context_line":"        for driver in self._drivers:"},{"line_number":54,"context_line":"            driver.config(self.conf)"},{"line_number":55,"context_line":"        legacy.modernize_quantum_config(self.conf)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Bf1U%3D","line":52,"updated":"2013-11-25 13:43:21.000000000","message":"agetn-\u003eagent","commit_id":"df82da4de9ee2b2d13f4147aaeddd3eca386f902"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"0984e0732e6979aad03c3e2469c1d376870711ae","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    def _setup(self):"},{"line_number":50,"context_line":"        self._drivers \u003d [importutils.import_object(driver, self.host)"},{"line_number":51,"context_line":"                         for driver in"},{"line_number":52,"context_line":"                         cfg.CONF.serviceagent.service_agetn_driver]"},{"line_number":53,"context_line":"        for driver in self._drivers:"},{"line_number":54,"context_line":"            driver.config(self.conf)"},{"line_number":55,"context_line":"        legacy.modernize_quantum_config(self.conf)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Bb4s%3D","line":52,"in_reply_to":"AAAATn%2F%2Bf1U%3D","updated":"2013-11-26 05:14:19.000000000","message":"Done","commit_id":"df82da4de9ee2b2d13f4147aaeddd3eca386f902"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"61a7223923687d466595cbf441b73f4f4634a537","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                         for driver in"},{"line_number":52,"context_line":"                         cfg.CONF.serviceagent.service_agetn_driver]"},{"line_number":53,"context_line":"        for driver in self._drivers:"},{"line_number":54,"context_line":"            driver.config(self.conf)"},{"line_number":55,"context_line":"        legacy.modernize_quantum_config(self.conf)"},{"line_number":56,"context_line":"        for driver in self._drivers:"},{"line_number":57,"context_line":"            driver.setup(self.conf)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BtH4%3D","line":54,"updated":"2013-11-21 10:13:54.000000000","message":"question: why .config() and .setup() are separate calls? Why .config() is being called before modernize_quantum_config() ?","commit_id":"df82da4de9ee2b2d13f4147aaeddd3eca386f902"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"ae928cb913fef7cafa1b6fe82dde4315624564b1","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                         for driver in"},{"line_number":52,"context_line":"                         cfg.CONF.serviceagent.service_agetn_driver]"},{"line_number":53,"context_line":"        for driver in self._drivers:"},{"line_number":54,"context_line":"            driver.config(self.conf)"},{"line_number":55,"context_line":"        legacy.modernize_quantum_config(self.conf)"},{"line_number":56,"context_line":"        for driver in self._drivers:"},{"line_number":57,"context_line":"            driver.setup(self.conf)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BpT0%3D","line":54,"in_reply_to":"AAAATn%2F%2BtH4%3D","updated":"2013-11-22 02:39:10.000000000","message":"Please see the comment in driver_base.py","commit_id":"df82da4de9ee2b2d13f4147aaeddd3eca386f902"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"61a7223923687d466595cbf441b73f4f4634a537","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        super(ServiceAgent, self).wait()"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"cfg.CONF.register_opts(ServiceAgent.OPTS, \u0027serviceagent\u0027)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"# TODO(yamahata): state reporting agent"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BtHQ%3D","line":71,"updated":"2013-11-21 10:13:54.000000000","message":"please move it into main(): that will help to avoid some issues with duplicating options in unit tests","commit_id":"df82da4de9ee2b2d13f4147aaeddd3eca386f902"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"ae928cb913fef7cafa1b6fe82dde4315624564b1","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        super(ServiceAgent, self).wait()"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"cfg.CONF.register_opts(ServiceAgent.OPTS, \u0027serviceagent\u0027)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"# TODO(yamahata): state reporting agent"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BpUE%3D","line":71,"in_reply_to":"AAAATn%2F%2BtHQ%3D","updated":"2013-11-22 02:39:10.000000000","message":"Done","commit_id":"df82da4de9ee2b2d13f4147aaeddd3eca386f902"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"57c545bc8247ed9d50390b2ea83d374eaefa00c1","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"def main():"},{"line_number":78,"context_line":"    eventlet.monkey_patch()"},{"line_number":79,"context_line":"    conf \u003d cfg.CONF"},{"line_number":80,"context_line":"    config.register_agent_state_opts_helper(conf)"},{"line_number":81,"context_line":"    config.register_root_helper(conf)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BeYQ%3D","line":78,"updated":"2013-11-25 21:16:26.000000000","message":"Do monkey patching earlier.  See this link:\n\nhttp://eventlet.net/doc/patching.html#monkeypatching-the-standard-library","commit_id":"df82da4de9ee2b2d13f4147aaeddd3eca386f902"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"0984e0732e6979aad03c3e2469c1d376870711ae","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"def main():"},{"line_number":78,"context_line":"    eventlet.monkey_patch()"},{"line_number":79,"context_line":"    conf \u003d cfg.CONF"},{"line_number":80,"context_line":"    config.register_agent_state_opts_helper(conf)"},{"line_number":81,"context_line":"    config.register_root_helper(conf)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Bb24%3D","line":78,"in_reply_to":"AAAATn%2F%2BeYQ%3D","updated":"2013-11-26 05:14:19.000000000","message":"I\u0027d like to leave this as is because it follows the other main modules in Neutron. Nova also adopted similar style.\n\nIf we concern this, it should be addressed consistently over Neutron.\nmonkey_patch should be done at neutron.__init__.\nSo if it really matters, can you please file a bug and raise this issue?","commit_id":"df82da4de9ee2b2d13f4147aaeddd3eca386f902"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"79dee27b08d5588d71d9263d3f1820cf22961522","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        self._setup()"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _setup(self):"},{"line_number":81,"context_line":"        \"\"\"Setting up device drivers."},{"line_number":82,"context_line":"        \"\"\""},{"line_number":83,"context_line":"        self._driver_manager \u003d AgentDriverManager()"},{"line_number":84,"context_line":"        for driver in self._driver_manager.get_drivers():"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BHXI%3D","line":81,"updated":"2013-12-02 13:17:58.000000000","message":"Nit: For single line docstring, place end quotes on same line. Here and L91, L98","commit_id":"2ea99d3281c11c442c6db81595ee77fbc7922e90"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5bec44fe994635b83268a755567b604e753b4553","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        self._setup()"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _setup(self):"},{"line_number":81,"context_line":"        \"\"\"Setting up device drivers."},{"line_number":82,"context_line":"        \"\"\""},{"line_number":83,"context_line":"        self._driver_manager \u003d AgentDriverManager()"},{"line_number":84,"context_line":"        for driver in self._driver_manager.get_drivers():"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BC00%3D","line":81,"in_reply_to":"AAAATn%2F%2BHXI%3D","updated":"2013-12-03 05:13:24.000000000","message":"Done","commit_id":"2ea99d3281c11c442c6db81595ee77fbc7922e90"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c81e02aacd10a9d24aec59a581d6fd020dd6d8cc","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#    under the License."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import eventlet"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo.config import cfg"},{"line_number":23,"context_line":"import stevedore"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BCUw%3D","line":21,"updated":"2013-12-03 07:37:41.000000000","message":"no blank line as eventlet is third party","commit_id":"65ea2658f133600370eadc84b131795e9dc32c1e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"6e9e71b54f69c62db4054c4b3fea5e7e5248827a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#    under the License."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import eventlet"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo.config import cfg"},{"line_number":23,"context_line":"import stevedore"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F98yA%3D","line":21,"in_reply_to":"AAAATn%2F%2BCUw%3D","updated":"2013-12-04 05:20:24.000000000","message":"Done","commit_id":"65ea2658f133600370eadc84b131795e9dc32c1e"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c81e02aacd10a9d24aec59a581d6fd020dd6d8cc","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class AgentDriverManager(stevedore.named.NamedExtensionManager):"},{"line_number":38,"context_line":"    \"\"\"Manage agent drivers.\"\"\""},{"line_number":39,"context_line":"    OPTS \u003d ["},{"line_number":40,"context_line":"        cfg.ListOpt("},{"line_number":41,"context_line":"            \u0027service_agent_drivers\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BCUk%3D","line":38,"updated":"2013-12-03 07:37:41.000000000","message":"nit: docstring doesn\u0027t tell anything more than class name","commit_id":"65ea2658f133600370eadc84b131795e9dc32c1e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"6e9e71b54f69c62db4054c4b3fea5e7e5248827a","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class AgentDriverManager(stevedore.named.NamedExtensionManager):"},{"line_number":38,"context_line":"    \"\"\"Manage agent drivers.\"\"\""},{"line_number":39,"context_line":"    OPTS \u003d ["},{"line_number":40,"context_line":"        cfg.ListOpt("},{"line_number":41,"context_line":"            \u0027service_agent_drivers\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F98xQ%3D","line":38,"in_reply_to":"AAAATn%2F%2BCUk%3D","updated":"2013-12-04 05:20:24.000000000","message":"Done","commit_id":"65ea2658f133600370eadc84b131795e9dc32c1e"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"225562f23ecd552f8981c3eaa5eb2a5ec870bffd","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class AgentDriverManager(stevedore.named.NamedExtensionManager):"},{"line_number":38,"context_line":"    \"\"\"Manage agent drivers.\"\"\""},{"line_number":39,"context_line":"    OPTS \u003d ["},{"line_number":40,"context_line":"        cfg.ListOpt("},{"line_number":41,"context_line":"            \u0027service_agent_drivers\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BBR4%3D","line":38,"in_reply_to":"AAAATn%2F%2BCUk%3D","updated":"2013-12-03 12:35:35.000000000","message":"PEP257: Put a blank line before and after class docstring.","commit_id":"65ea2658f133600370eadc84b131795e9dc32c1e"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"e763d050df1f73d983c1fe048de2192e7c3684a0","unresolved":false,"context_lines":[{"line_number":37,"context_line":"class AgentDriverManager(stevedore.named.NamedExtensionManager):"},{"line_number":38,"context_line":"    \"\"\"Manage agent drivers.\"\"\""},{"line_number":39,"context_line":"    OPTS \u003d ["},{"line_number":40,"context_line":"        cfg.ListOpt("},{"line_number":41,"context_line":"            \u0027service_agent_drivers\u0027,"},{"line_number":42,"context_line":"            default\u003d[\u0027neutron.agent.service.driver_noop.AgentDriverNoop\u0027],"},{"line_number":43,"context_line":"            help\u003d_(\"List of agent drivers Neutron service agent will use\")),"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BAts%3D","line":40,"updated":"2013-12-03 14:27:02.000000000","message":"it might be better to use MultiStrOpt here","commit_id":"65ea2658f133600370eadc84b131795e9dc32c1e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"6e9e71b54f69c62db4054c4b3fea5e7e5248827a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"class AgentDriverManager(stevedore.named.NamedExtensionManager):"},{"line_number":38,"context_line":"    \"\"\"Manage agent drivers.\"\"\""},{"line_number":39,"context_line":"    OPTS \u003d ["},{"line_number":40,"context_line":"        cfg.ListOpt("},{"line_number":41,"context_line":"            \u0027service_agent_drivers\u0027,"},{"line_number":42,"context_line":"            default\u003d[\u0027neutron.agent.service.driver_noop.AgentDriverNoop\u0027],"},{"line_number":43,"context_line":"            help\u003d_(\"List of agent drivers Neutron service agent will use\")),"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F98wk%3D","line":40,"in_reply_to":"AAAATn%2F%2BAts%3D","updated":"2013-12-04 05:20:24.000000000","message":"Done","commit_id":"65ea2658f133600370eadc84b131795e9dc32c1e"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"e763d050df1f73d983c1fe048de2192e7c3684a0","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    OPTS \u003d ["},{"line_number":40,"context_line":"        cfg.ListOpt("},{"line_number":41,"context_line":"            \u0027service_agent_drivers\u0027,"},{"line_number":42,"context_line":"            default\u003d[\u0027neutron.agent.service.driver_noop.AgentDriverNoop\u0027],"},{"line_number":43,"context_line":"            help\u003d_(\"List of agent drivers Neutron service agent will use\")),"},{"line_number":44,"context_line":"    ]"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BAtY%3D","line":42,"updated":"2013-12-03 14:27:02.000000000","message":"At the summit we agreed to not to include Noop Drivers as drivers for production to avoid confusion.","commit_id":"65ea2658f133600370eadc84b131795e9dc32c1e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"6e9e71b54f69c62db4054c4b3fea5e7e5248827a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    OPTS \u003d ["},{"line_number":40,"context_line":"        cfg.ListOpt("},{"line_number":41,"context_line":"            \u0027service_agent_drivers\u0027,"},{"line_number":42,"context_line":"            default\u003d[\u0027neutron.agent.service.driver_noop.AgentDriverNoop\u0027],"},{"line_number":43,"context_line":"            help\u003d_(\"List of agent drivers Neutron service agent will use\")),"},{"line_number":44,"context_line":"    ]"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F98wg%3D","line":42,"in_reply_to":"AAAATn%2F%2BAtY%3D","updated":"2013-12-04 05:20:24.000000000","message":"Done","commit_id":"65ea2658f133600370eadc84b131795e9dc32c1e"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"ec6ca60f993b39e822e5b48cf869514ae2a6ed28","unresolved":false,"context_lines":[{"line_number":36,"context_line":"class AgentDriverManager(stevedore.named.NamedExtensionManager):"},{"line_number":37,"context_line":"    OPTS \u003d ["},{"line_number":38,"context_line":"        cfg.MultiStrOpt("},{"line_number":39,"context_line":"            \u0027service_agent_drivers\u0027,"},{"line_number":40,"context_line":"            default\u003d[],"},{"line_number":41,"context_line":"            help\u003d_(\"Agent drivers Neutron service agent will use\")),"},{"line_number":42,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F97TQ%3D","line":39,"updated":"2013-12-04 11:55:09.000000000","message":"better to use single form as it will be separate line for each service agent driver in the config file:\n service_agent_driver \u003d \u003cdriver1\u003e\n service_agent_driver \u003d \u003cdriver2\u003e","commit_id":"d21bb2b839489a4cf498b07171f10d727cada611"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"a79b77bcb54e500e43ae464d40090ea8054c1a7b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"class AgentDriverManager(stevedore.named.NamedExtensionManager):"},{"line_number":37,"context_line":"    OPTS \u003d ["},{"line_number":38,"context_line":"        cfg.MultiStrOpt("},{"line_number":39,"context_line":"            \u0027service_agent_drivers\u0027,"},{"line_number":40,"context_line":"            default\u003d[],"},{"line_number":41,"context_line":"            help\u003d_(\"Agent drivers Neutron service agent will use\")),"},{"line_number":42,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F92No%3D","line":39,"in_reply_to":"AAAATn%2F97TQ%3D","updated":"2013-12-05 09:52:16.000000000","message":"Done","commit_id":"d21bb2b839489a4cf498b07171f10d727cada611"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"9e74574d1a2ff4cfa43f2233d3df6a6a0a2a2132","unresolved":false,"context_lines":[{"line_number":36,"context_line":"class AgentDriverManager(stevedore.named.NamedExtensionManager):"},{"line_number":37,"context_line":"    OPTS \u003d ["},{"line_number":38,"context_line":"        cfg.MultiStrOpt("},{"line_number":39,"context_line":"            \u0027service_agent_drivers\u0027,"},{"line_number":40,"context_line":"            default\u003d[],"},{"line_number":41,"context_line":"            help\u003d_(\"Agent drivers Neutron service agent will use\")),"},{"line_number":42,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F96wI%3D","line":39,"in_reply_to":"AAAATn%2F97TQ%3D","updated":"2013-12-04 14:08:57.000000000","message":"I\u0027d prefer \u0027agent_driver\u0027 since the option is under [service_agent]","commit_id":"d21bb2b839489a4cf498b07171f10d727cada611"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"e5cd84d97ce1ad41b60278ace8eb8d21703d7222","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2013, 2014 Intel"},{"line_number":4,"context_line":"# Copyright 2013, 2014 Isaku Yamahata \u003cisaku.yamahata at intel com\u003e"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUX%2F%2FaXg%3D","line":1,"updated":"2014-02-13 11:55:32.000000000","message":"Remove VIM line.","commit_id":"c5c3bf4c6b734dfc207b31ef563b369e604b7fdb"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"503bd499e7e73fa053044b813cdfcd07851a526d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2013, 2014 Intel"},{"line_number":4,"context_line":"# Copyright 2013, 2014 Isaku Yamahata \u003cisaku.yamahata at intel com\u003e"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUX%2F%2FTmM%3D","line":1,"in_reply_to":"AAAAUX%2F%2FaXg%3D","updated":"2014-02-14 03:28:53.000000000","message":"Done","commit_id":"c5c3bf4c6b734dfc207b31ef563b369e604b7fdb"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"e5cd84d97ce1ad41b60278ace8eb8d21703d7222","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            invoke_on_load\u003dTrue)"},{"line_number":49,"context_line":"        self._register_drivers()"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def _register_drivers(self):"},{"line_number":52,"context_line":"        for ext in self:"},{"line_number":53,"context_line":"            type_ \u003d ext.obj.get_type()"},{"line_number":54,"context_line":"            if type_ in self._drivers:"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUX%2F%2FaW4%3D","line":51,"updated":"2014-02-13 11:55:32.000000000","message":"Is this limiting the number of device drivers for a particular agent (e.g. VPN) to one?\n\nHow will provider device drivers be handled (service type framework)?","commit_id":"c5c3bf4c6b734dfc207b31ef563b369e604b7fdb"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"503bd499e7e73fa053044b813cdfcd07851a526d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            invoke_on_load\u003dTrue)"},{"line_number":49,"context_line":"        self._register_drivers()"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def _register_drivers(self):"},{"line_number":52,"context_line":"        for ext in self:"},{"line_number":53,"context_line":"            type_ \u003d ext.obj.get_type()"},{"line_number":54,"context_line":"            if type_ in self._drivers:"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUX%2F%2FTlw%3D","line":51,"in_reply_to":"AAAAUX%2F%2FaW4%3D","updated":"2014-02-14 03:28:53.000000000","message":"No. You are talking about different type of driver.\nThe driver here is for subagent corresponds to lbaas-agent, vpn-agent...\nNot for provider device drivers.","commit_id":"c5c3bf4c6b734dfc207b31ef563b369e604b7fdb"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"837785bffb6fc57aacc60324209f43db40afc4a5","unresolved":false,"context_lines":[{"line_number":31,"context_line":"class AgentDriverManager(stevedore.named.NamedExtensionManager):"},{"line_number":32,"context_line":"    OPTS \u003d ["},{"line_number":33,"context_line":"        cfg.MultiStrOpt("},{"line_number":34,"context_line":"            \u0027device_driver\u0027,"},{"line_number":35,"context_line":"            default\u003d[],"},{"line_number":36,"context_line":"            help\u003d_(\"Device drivers Neutron service agent will use\")),"},{"line_number":37,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUX%2F%2BvCk%3D","line":34,"updated":"2014-02-19 13:24:30.000000000","message":"given the opt name can you please clarify what is \u0027device\u0027 in this context? (for ex LBaaS agent has device_drivers which mean drivers for particular loadbalancer devices)","commit_id":"32ded054b8b55124e88d41dda11fa6f92a3136c5"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c5d13530ad209dcce923f46b7a581c0fd473f1be","unresolved":false,"context_lines":[{"line_number":31,"context_line":"class AgentDriverManager(stevedore.named.NamedExtensionManager):"},{"line_number":32,"context_line":"    OPTS \u003d ["},{"line_number":33,"context_line":"        cfg.MultiStrOpt("},{"line_number":34,"context_line":"            \u0027device_driver\u0027,"},{"line_number":35,"context_line":"            default\u003d[],"},{"line_number":36,"context_line":"            help\u003d_(\"Device drivers Neutron service agent will use\")),"},{"line_number":37,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUX%2F%2Bml4%3D","line":34,"in_reply_to":"AAAAUX%2F%2BoLo%3D","updated":"2014-02-20 08:58:14.000000000","message":"that will be less confusing","commit_id":"32ded054b8b55124e88d41dda11fa6f92a3136c5"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"e3ce520e857c3192634ddc85ce54d1c4653ace32","unresolved":false,"context_lines":[{"line_number":31,"context_line":"class AgentDriverManager(stevedore.named.NamedExtensionManager):"},{"line_number":32,"context_line":"    OPTS \u003d ["},{"line_number":33,"context_line":"        cfg.MultiStrOpt("},{"line_number":34,"context_line":"            \u0027device_driver\u0027,"},{"line_number":35,"context_line":"            default\u003d[],"},{"line_number":36,"context_line":"            help\u003d_(\"Device drivers Neutron service agent will use\")),"},{"line_number":37,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUX%2F%2BoLo%3D","line":34,"in_reply_to":"AAAAUX%2F%2BvCk%3D","updated":"2014-02-20 05:29:18.000000000","message":"how about service_driver?","commit_id":"32ded054b8b55124e88d41dda11fa6f92a3136c5"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"837785bffb6fc57aacc60324209f43db40afc4a5","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        for ext in self:"},{"line_number":49,"context_line":"            type_ \u003d ext.obj.get_type()"},{"line_number":50,"context_line":"            if type_ in self._drivers:"},{"line_number":51,"context_line":"                msg \u003d _(\"agent driver \u0027%(new_driver)s\u0027 ignored because \""},{"line_number":52,"context_line":"                        \"agent driver \u0027%(old_driver)s\u0027 is already \""},{"line_number":53,"context_line":"                        \"registered for agent \u0027%(type)s\u0027\") % {"},{"line_number":54,"context_line":"                            \u0027new_driver\u0027: ext.name,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUX%2F%2BvaE%3D","line":51,"updated":"2014-02-19 13:24:30.000000000","message":"nit: \u0027ignored\u0027 is a bit confusing as it usually means that the app will continue working, in this case we have systemexit.","commit_id":"32ded054b8b55124e88d41dda11fa6f92a3136c5"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"e3ce520e857c3192634ddc85ce54d1c4653ace32","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        for ext in self:"},{"line_number":49,"context_line":"            type_ \u003d ext.obj.get_type()"},{"line_number":50,"context_line":"            if type_ in self._drivers:"},{"line_number":51,"context_line":"                msg \u003d _(\"agent driver \u0027%(new_driver)s\u0027 ignored because \""},{"line_number":52,"context_line":"                        \"agent driver \u0027%(old_driver)s\u0027 is already \""},{"line_number":53,"context_line":"                        \"registered for agent \u0027%(type)s\u0027\") % {"},{"line_number":54,"context_line":"                            \u0027new_driver\u0027: ext.name,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUX%2F%2BoL0%3D","line":51,"in_reply_to":"AAAAUX%2F%2BvaE%3D","updated":"2014-02-20 05:29:18.000000000","message":"Done","commit_id":"32ded054b8b55124e88d41dda11fa6f92a3136c5"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"adf133c2f6045abd4781c4e3d1921fc492c13653","unresolved":false,"context_lines":[{"line_number":31,"context_line":"class AgentServiceDriverManager(stevedore.named.NamedExtensionManager):"},{"line_number":32,"context_line":"    OPTS \u003d ["},{"line_number":33,"context_line":"        cfg.MultiStrOpt("},{"line_number":34,"context_line":"            \u0027service_driver\u0027,"},{"line_number":35,"context_line":"            default\u003d[],"},{"line_number":36,"context_line":"            help\u003d_(\"Device drivers Neutron service agent will use\")),"},{"line_number":37,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUX%2F%2BfXw%3D","line":34,"updated":"2014-02-20 22:01:27.000000000","message":"My understanding of all this, is that we have plugins with their companion service drivers (per provider) and agents with their device drivers (again per provider). The plugin calls the service driver, which is paired up with a device driver to take action for a specific provider.\n\nIs this for the device driver that will be called by the service driver to perform actions? If so, then device driver makes sense to me.\n\nIn any case the option and the help on L36 seem to contradict.","commit_id":"c99a778c4a28c67702c2a7fca71a7cae667f51b3"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"aad0e82f83a59146ccedd246a90bbb0c5b569800","unresolved":false,"context_lines":[{"line_number":31,"context_line":"class AgentServiceDriverManager(stevedore.named.NamedExtensionManager):"},{"line_number":32,"context_line":"    OPTS \u003d ["},{"line_number":33,"context_line":"        cfg.MultiStrOpt("},{"line_number":34,"context_line":"            \u0027service_driver\u0027,"},{"line_number":35,"context_line":"            default\u003d[],"},{"line_number":36,"context_line":"            help\u003d_(\"Device drivers Neutron service agent will use\")),"},{"line_number":37,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUX%2F%2Bckk%3D","line":34,"in_reply_to":"AAAAUX%2F%2BfXw%3D","updated":"2014-02-21 04:23:16.000000000","message":"Right.\ns/device/service/g","commit_id":"c99a778c4a28c67702c2a7fca71a7cae667f51b3"}],"neutron/agent/service/driver_base.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"61a7223923687d466595cbf441b73f4f4634a537","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        super(ServiceAgentDriverBase, self).__init__()"},{"line_number":27,"context_line":"        self.host \u003d host"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def config(self, conf):"},{"line_number":30,"context_line":"        pass"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def setup(self, conf):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BtGc%3D","line":29,"updated":"2013-11-21 10:13:54.000000000","message":"If it\u0027s indeed needed, please name it \u0027configure\u0027","commit_id":"df82da4de9ee2b2d13f4147aaeddd3eca386f902"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"ae928cb913fef7cafa1b6fe82dde4315624564b1","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        super(ServiceAgentDriverBase, self).__init__()"},{"line_number":27,"context_line":"        self.host \u003d host"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def config(self, conf):"},{"line_number":30,"context_line":"        pass"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def setup(self, conf):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BpUo%3D","line":29,"in_reply_to":"AAAATn%2F%2BtGc%3D","updated":"2013-11-22 02:39:10.000000000","message":"Done","commit_id":"df82da4de9ee2b2d13f4147aaeddd3eca386f902"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"61a7223923687d466595cbf441b73f4f4634a537","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    def config(self, conf):"},{"line_number":30,"context_line":"        pass"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def setup(self, conf):"},{"line_number":33,"context_line":"        self.conf \u003d conf"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def start(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BtGk%3D","line":32,"updated":"2013-11-21 10:13:54.000000000","message":"so, what\u0027s the difference between config() and setup()?\nI think there should be setup() only.","commit_id":"df82da4de9ee2b2d13f4147aaeddd3eca386f902"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"ae928cb913fef7cafa1b6fe82dde4315624564b1","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    def config(self, conf):"},{"line_number":30,"context_line":"        pass"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def setup(self, conf):"},{"line_number":33,"context_line":"        self.conf \u003d conf"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def start(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BpUI%3D","line":32,"in_reply_to":"AAAATn%2F%2BtGk%3D","updated":"2013-11-22 02:39:10.000000000","message":"configure is to read config files. \nsetup is to actual initialization.\n\nMaybe the splitting isn\u0027t necessary. We will see the result during converting service agent.","commit_id":"df82da4de9ee2b2d13f4147aaeddd3eca386f902"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"79dee27b08d5588d71d9263d3f1820cf22961522","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# @author: Isaku Yamahata, Intel"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class ServiceAgentDriverBase(object):"},{"line_number":24,"context_line":"    \"\"\"Base class for actual task for each services.\"\"\""},{"line_number":25,"context_line":"    def __init__(self, host):"},{"line_number":26,"context_line":"        super(ServiceAgentDriverBase, self).__init__()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BHWU%3D","line":23,"updated":"2013-12-02 13:17:58.000000000","message":"Should this class be abstract?","commit_id":"2ea99d3281c11c442c6db81595ee77fbc7922e90"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5bec44fe994635b83268a755567b604e753b4553","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# @author: Isaku Yamahata, Intel"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class ServiceAgentDriverBase(object):"},{"line_number":24,"context_line":"    \"\"\"Base class for actual task for each services.\"\"\""},{"line_number":25,"context_line":"    def __init__(self, host):"},{"line_number":26,"context_line":"        super(ServiceAgentDriverBase, self).__init__()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BCzs%3D","line":23,"in_reply_to":"AAAATn%2F%2BHWU%3D","updated":"2013-12-03 05:13:24.000000000","message":"This is not abstract class. Since all methods are valid in this class, what\u0027s the point for abstract class?","commit_id":"2ea99d3281c11c442c6db81595ee77fbc7922e90"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"79dee27b08d5588d71d9263d3f1820cf22961522","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        self.host \u003d host"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def configure(self, conf):"},{"line_number":30,"context_line":"        \"\"\"read driver specific configuration file(.ini file).\"\"\""},{"line_number":31,"context_line":"        pass"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def setup(self, conf):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BHWc%3D","line":30,"updated":"2013-12-02 13:17:58.000000000","message":"nit: Capatalize first work L30, L34, L38, L42.","commit_id":"2ea99d3281c11c442c6db81595ee77fbc7922e90"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5bec44fe994635b83268a755567b604e753b4553","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        self.host \u003d host"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def configure(self, conf):"},{"line_number":30,"context_line":"        \"\"\"read driver specific configuration file(.ini file).\"\"\""},{"line_number":31,"context_line":"        pass"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def setup(self, conf):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BC0g%3D","line":30,"in_reply_to":"AAAATn%2F%2BHWc%3D","updated":"2013-12-03 05:13:24.000000000","message":"Done","commit_id":"2ea99d3281c11c442c6db81595ee77fbc7922e90"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"79dee27b08d5588d71d9263d3f1820cf22961522","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        pass"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def setup(self, conf):"},{"line_number":34,"context_line":"        \"\"\"setup actual configurations based on config.\"\"\""},{"line_number":35,"context_line":"        self.conf \u003d conf"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def start(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BHWY%3D","line":34,"updated":"2013-12-02 13:17:58.000000000","message":"\"...based on config file.\"?","commit_id":"2ea99d3281c11c442c6db81595ee77fbc7922e90"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5bec44fe994635b83268a755567b604e753b4553","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        pass"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def setup(self, conf):"},{"line_number":34,"context_line":"        \"\"\"setup actual configurations based on config.\"\"\""},{"line_number":35,"context_line":"        self.conf \u003d conf"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def start(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BC0c%3D","line":34,"in_reply_to":"AAAATn%2F%2BHWY%3D","updated":"2013-12-03 05:13:24.000000000","message":"Done","commit_id":"2ea99d3281c11c442c6db81595ee77fbc7922e90"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"79dee27b08d5588d71d9263d3f1820cf22961522","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        pass"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def wait(self):"},{"line_number":42,"context_line":"        \"\"\"wait for driver completion. Typically wait forever for"},{"line_number":43,"context_line":"        a dedicated thread which does infinite loop."},{"line_number":44,"context_line":"        \"\"\""},{"line_number":45,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BHWI%3D","line":42,"updated":"2013-12-02 13:17:58.000000000","message":"PEP257: single line summary with period, and then rest of docstring on subsequent lines, separated by a blank line.","commit_id":"2ea99d3281c11c442c6db81595ee77fbc7922e90"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5bec44fe994635b83268a755567b604e753b4553","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        pass"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def wait(self):"},{"line_number":42,"context_line":"        \"\"\"wait for driver completion. Typically wait forever for"},{"line_number":43,"context_line":"        a dedicated thread which does infinite loop."},{"line_number":44,"context_line":"        \"\"\""},{"line_number":45,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BCzw%3D","line":42,"in_reply_to":"AAAATn%2F%2BHWI%3D","updated":"2013-12-03 05:13:24.000000000","message":"Done","commit_id":"2ea99d3281c11c442c6db81595ee77fbc7922e90"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"225562f23ecd552f8981c3eaa5eb2a5ec870bffd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright 2013 Intel"},{"line_number":3,"context_line":"# Copyright 2013 Isaku Yamahata \u003cisaku.yamahata at intel com\u003e"},{"line_number":4,"context_line":"#                               \u003cisaku.yamahata at gmail com\u003e"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BBN4%3D","line":1,"updated":"2013-12-03 12:35:35.000000000","message":"I don\u0027t know if convention is to have VIM line at top, but if so, it\u0027s missing in this file (I don\u0027t use VIM :)","commit_id":"65ea2658f133600370eadc84b131795e9dc32c1e"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c81e02aacd10a9d24aec59a581d6fd020dd6d8cc","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# @author: Isaku Yamahata, Intel"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class ServiceAgentDriverBase(object):"},{"line_number":24,"context_line":"    \"\"\"Base class for actual task for each services.\"\"\""},{"line_number":25,"context_line":"    def __init__(self, host):"},{"line_number":26,"context_line":"        super(ServiceAgentDriverBase, self).__init__()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BCTI%3D","line":23,"updated":"2013-12-03 07:37:41.000000000","message":"please use abc for abstract class.","commit_id":"65ea2658f133600370eadc84b131795e9dc32c1e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"6e9e71b54f69c62db4054c4b3fea5e7e5248827a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# @author: Isaku Yamahata, Intel"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class ServiceAgentDriverBase(object):"},{"line_number":24,"context_line":"    \"\"\"Base class for actual task for each services.\"\"\""},{"line_number":25,"context_line":"    def __init__(self, host):"},{"line_number":26,"context_line":"        super(ServiceAgentDriverBase, self).__init__()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F98wU%3D","line":23,"in_reply_to":"AAAATn%2F%2BCTI%3D","updated":"2013-12-04 05:20:24.000000000","message":"Done","commit_id":"65ea2658f133600370eadc84b131795e9dc32c1e"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c81e02aacd10a9d24aec59a581d6fd020dd6d8cc","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class ServiceAgentDriverBase(object):"},{"line_number":24,"context_line":"    \"\"\"Base class for actual task for each services.\"\"\""},{"line_number":25,"context_line":"    def __init__(self, host):"},{"line_number":26,"context_line":"        super(ServiceAgentDriverBase, self).__init__()"},{"line_number":27,"context_line":"        self.host \u003d host"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BCTo%3D","line":24,"updated":"2013-12-03 07:37:41.000000000","message":"nit: each service","commit_id":"65ea2658f133600370eadc84b131795e9dc32c1e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"6e9e71b54f69c62db4054c4b3fea5e7e5248827a","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class ServiceAgentDriverBase(object):"},{"line_number":24,"context_line":"    \"\"\"Base class for actual task for each services.\"\"\""},{"line_number":25,"context_line":"    def __init__(self, host):"},{"line_number":26,"context_line":"        super(ServiceAgentDriverBase, self).__init__()"},{"line_number":27,"context_line":"        self.host \u003d host"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F98wQ%3D","line":24,"in_reply_to":"AAAATn%2F%2BCTo%3D","updated":"2013-12-04 05:20:24.000000000","message":"Done","commit_id":"65ea2658f133600370eadc84b131795e9dc32c1e"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"e5cd84d97ce1ad41b60278ace8eb8d21703d7222","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2013 Intel"},{"line_number":4,"context_line":"# Copyright 2013 Isaku Yamahata \u003cisaku.yamahata at intel com\u003e"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUX%2F%2FaWo%3D","line":1,"updated":"2014-02-13 11:55:32.000000000","message":"vim line","commit_id":"c5c3bf4c6b734dfc207b31ef563b369e604b7fdb"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"503bd499e7e73fa053044b813cdfcd07851a526d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2013 Intel"},{"line_number":4,"context_line":"# Copyright 2013 Isaku Yamahata \u003cisaku.yamahata at intel com\u003e"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUX%2F%2FTmU%3D","line":1,"in_reply_to":"AAAAUX%2F%2FaWo%3D","updated":"2014-02-14 03:28:53.000000000","message":"Done","commit_id":"c5c3bf4c6b734dfc207b31ef563b369e604b7fdb"}],"neutron/agent/service/driver_neutron_service.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"79dee27b08d5588d71d9263d3f1820cf22961522","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":27,"context_line":"class ServiceAgentDriver(driver_base.ServiceAgentDriverBase):"},{"line_number":28,"context_line":"    \"\"\"Agent Driver based on openstack.common.service.Service."},{"line_number":29,"context_line":"    (or its derived classes. e.g. neutron.service.Service,"},{"line_number":30,"context_line":"    neutron.manager.Manager)"},{"line_number":31,"context_line":"    This is for conversion purpose of existing service agents."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BHVw%3D","line":28,"updated":"2013-12-02 13:17:58.000000000","message":"PEP257: Class docstring, blank line before and after, single line summary with period, subsequent lines separated by a blank line.","commit_id":"2ea99d3281c11c442c6db81595ee77fbc7922e90"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5bec44fe994635b83268a755567b604e753b4553","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":27,"context_line":"class ServiceAgentDriver(driver_base.ServiceAgentDriverBase):"},{"line_number":28,"context_line":"    \"\"\"Agent Driver based on openstack.common.service.Service."},{"line_number":29,"context_line":"    (or its derived classes. e.g. neutron.service.Service,"},{"line_number":30,"context_line":"    neutron.manager.Manager)"},{"line_number":31,"context_line":"    This is for conversion purpose of existing service agents."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BCzo%3D","line":28,"in_reply_to":"AAAATn%2F%2BHVw%3D","updated":"2013-12-03 05:13:24.000000000","message":"Done","commit_id":"2ea99d3281c11c442c6db81595ee77fbc7922e90"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"3e448d0ffbccad8f1c4233906156a669b203bb3d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    \"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def __init__(self):"},{"line_number":37,"context_line":"        self._service \u003d None"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @abc.abstractmethod"},{"line_number":40,"context_line":"    def _create_service(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F97OI%3D","line":37,"updated":"2013-12-04 12:13:24.000000000","message":"Should this be calling super()?","commit_id":"d21bb2b839489a4cf498b07171f10d727cada611"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"a79b77bcb54e500e43ae464d40090ea8054c1a7b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    \"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def __init__(self):"},{"line_number":37,"context_line":"        self._service \u003d None"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @abc.abstractmethod"},{"line_number":40,"context_line":"    def _create_service(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F92MU%3D","line":37,"in_reply_to":"AAAATn%2F97OI%3D","updated":"2013-12-05 09:52:16.000000000","message":"Done","commit_id":"d21bb2b839489a4cf498b07171f10d727cada611"}],"neutron/agent/service/driver_noop.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"e763d050df1f73d983c1fe048de2192e7c3684a0","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.agent.service import driver_base"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class AgentDriverNoop(driver_base.ServiceAgentDriverBase):"},{"line_number":26,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BAvE%3D","line":25,"updated":"2013-12-03 14:27:02.000000000","message":"it\u0027s better to move this class to UTs","commit_id":"65ea2658f133600370eadc84b131795e9dc32c1e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"6e9e71b54f69c62db4054c4b3fea5e7e5248827a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.agent.service import driver_base"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class AgentDriverNoop(driver_base.ServiceAgentDriverBase):"},{"line_number":26,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F98vw%3D","line":25,"in_reply_to":"AAAATn%2F%2BAvE%3D","updated":"2013-12-04 05:20:24.000000000","message":"Done","commit_id":"65ea2658f133600370eadc84b131795e9dc32c1e"}],"neutron/services/loadbalancer/drivers/haproxy/agent.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"837785bffb6fc57aacc60324209f43db40afc4a5","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"class LBaasAgentDriver(driver_base.ServiceAgentDriverBase):"},{"line_number":77,"context_line":"    def get_type(self):"},{"line_number":78,"context_line":"        return \u0027lbaas_haproxy\u0027"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def configure(self, conf):"},{"line_number":81,"context_line":"        conf.register_opts(OPTS)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUX%2F%2BvU4%3D","line":78,"updated":"2014-02-19 13:24:30.000000000","message":"please note that lbaas agent now is not haproxy specific, following patch finalizes the blueprint: https://review.openstack.org/#/c/61339/","commit_id":"32ded054b8b55124e88d41dda11fa6f92a3136c5"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"e3ce520e857c3192634ddc85ce54d1c4653ace32","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"class LBaasAgentDriver(driver_base.ServiceAgentDriverBase):"},{"line_number":77,"context_line":"    def get_type(self):"},{"line_number":78,"context_line":"        return \u0027lbaas_haproxy\u0027"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def configure(self, conf):"},{"line_number":81,"context_line":"        conf.register_opts(OPTS)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUX%2F%2BoJ8%3D","line":78,"in_reply_to":"AAAAUX%2F%2BvU4%3D","updated":"2014-02-20 05:29:18.000000000","message":"Thanks for reminder.","commit_id":"32ded054b8b55124e88d41dda11fa6f92a3136c5"}],"neutron/services/vpn/agent.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"79dee27b08d5588d71d9263d3f1820cf22961522","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def _create_service(self):"},{"line_number":166,"context_line":"        return neutron_service.Service.create("},{"line_number":167,"context_line":"            binary\u003d\u0027neutorn-l3-agent\u0027,"},{"line_number":168,"context_line":"            topic\u003dtopics.L3_AGENT,"},{"line_number":169,"context_line":"            report_interval\u003dcfg.CONF.AGENT.report_interval,"},{"line_number":170,"context_line":"            manager\u003d_VPNAGENT_MANAGER)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BHVI%3D","line":167,"updated":"2013-12-02 13:17:58.000000000","message":"neutron-l3-agent","commit_id":"2ea99d3281c11c442c6db81595ee77fbc7922e90"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5bec44fe994635b83268a755567b604e753b4553","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def _create_service(self):"},{"line_number":166,"context_line":"        return neutron_service.Service.create("},{"line_number":167,"context_line":"            binary\u003d\u0027neutorn-l3-agent\u0027,"},{"line_number":168,"context_line":"            topic\u003dtopics.L3_AGENT,"},{"line_number":169,"context_line":"            report_interval\u003dcfg.CONF.AGENT.report_interval,"},{"line_number":170,"context_line":"            manager\u003d_VPNAGENT_MANAGER)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BCzk%3D","line":167,"in_reply_to":"AAAATn%2F%2BHVI%3D","updated":"2013-12-03 05:13:24.000000000","message":"Done","commit_id":"2ea99d3281c11c442c6db81595ee77fbc7922e90"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c81e02aacd10a9d24aec59a581d6fd020dd6d8cc","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"def main():"},{"line_number":155,"context_line":"    l3_agent.main("},{"line_number":156,"context_line":"        manager\u003d_VPNAGENT_MANAGER)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"class VPNAgentDriver(driver_neutron_service.ServiceAgentDriver):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BCSc%3D","line":156,"updated":"2013-12-03 07:37:41.000000000","message":"nit: no need for new line","commit_id":"65ea2658f133600370eadc84b131795e9dc32c1e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"6e9e71b54f69c62db4054c4b3fea5e7e5248827a","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"def main():"},{"line_number":155,"context_line":"    l3_agent.main("},{"line_number":156,"context_line":"        manager\u003d_VPNAGENT_MANAGER)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"class VPNAgentDriver(driver_neutron_service.ServiceAgentDriver):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F98u0%3D","line":156,"in_reply_to":"AAAATn%2F%2BCSc%3D","updated":"2013-12-04 05:20:24.000000000","message":"Done","commit_id":"65ea2658f133600370eadc84b131795e9dc32c1e"}],"neutron/tests/unit/services/agent/test_device_driver.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"e5cd84d97ce1ad41b60278ace8eb8d21703d7222","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2013,2014 Intel"},{"line_number":4,"context_line":"# Copyright 2013,2014 Isaku Yamahata \u003cisaku.yamahata at intel com\u003e"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUX%2F%2FaYQ%3D","line":1,"updated":"2014-02-13 11:55:32.000000000","message":"Remove VIM line (new requirement being applied)","commit_id":"c5c3bf4c6b734dfc207b31ef563b369e604b7fdb"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"503bd499e7e73fa053044b813cdfcd07851a526d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2013,2014 Intel"},{"line_number":4,"context_line":"# Copyright 2013,2014 Isaku Yamahata \u003cisaku.yamahata at intel com\u003e"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUX%2F%2FTmQ%3D","line":1,"in_reply_to":"AAAAUX%2F%2FaYQ%3D","updated":"2014-02-14 03:28:53.000000000","message":"Done","commit_id":"c5c3bf4c6b734dfc207b31ef563b369e604b7fdb"}],"setup.cfg":[{"author":{"_account_id":7987,"name":"Ivar Lazzaro","email":"ivarlazzaro@gmail.com","username":"Ivar"},"change_message_id":"dcaca522d1e63761d71638a43ec7045263e71016","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    quantum-check-nvp-config \u003d neutron.plugins.nicira.check_nvp_config:main"},{"line_number":98,"context_line":"    quantum-db-manage \u003d neutron.db.migration.cli:main"},{"line_number":99,"context_line":"    neutron-vpn-agent \u003d neutron.services.vpn.agent:main"},{"line_number":100,"context_line":"    neutron-service-agent \u003d enutron.agent.service.agent:main"},{"line_number":101,"context_line":"    quantum-debug \u003d neutron.debug.shell:main"},{"line_number":102,"context_line":"    quantum-dhcp-agent \u003d neutron.agent.dhcp_agent:main"},{"line_number":103,"context_line":"    quantum-hyperv-agent \u003d neutron.plugins.hyperv.agent.hyperv_neutron_agent:main"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"AAAATn%2F%2BeHA%3D","line":100,"updated":"2013-11-25 18:35:32.000000000","message":"enutron -\u003e neutron","commit_id":"df82da4de9ee2b2d13f4147aaeddd3eca386f902"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"0984e0732e6979aad03c3e2469c1d376870711ae","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    quantum-check-nvp-config \u003d neutron.plugins.nicira.check_nvp_config:main"},{"line_number":98,"context_line":"    quantum-db-manage \u003d neutron.db.migration.cli:main"},{"line_number":99,"context_line":"    neutron-vpn-agent \u003d neutron.services.vpn.agent:main"},{"line_number":100,"context_line":"    neutron-service-agent \u003d enutron.agent.service.agent:main"},{"line_number":101,"context_line":"    quantum-debug \u003d neutron.debug.shell:main"},{"line_number":102,"context_line":"    quantum-dhcp-agent \u003d neutron.agent.dhcp_agent:main"},{"line_number":103,"context_line":"    quantum-hyperv-agent \u003d neutron.plugins.hyperv.agent.hyperv_neutron_agent:main"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"AAAATn%2F%2Bb20%3D","line":100,"in_reply_to":"AAAATn%2F%2BeHA%3D","updated":"2013-11-26 05:14:19.000000000","message":"Done","commit_id":"df82da4de9ee2b2d13f4147aaeddd3eca386f902"}]}
