)]}'
{"neutron/db/api.py":[{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"9be65642d3398015f102714ab832aeb3f626f083","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"_retry_db_errors \u003d oslo_db_api.wrap_db_retry("},{"line_number":72,"context_line":"    max_retries\u003dMAX_RETRIES,"},{"line_number":73,"context_line":"    retry_interval\u003d0.5,"},{"line_number":74,"context_line":"    inc_retry_interval\u003dTrue,"},{"line_number":75,"context_line":"    exception_checker\u003dis_retriable"},{"line_number":76,"context_line":")"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_a0dbafe7","line":73,"range":{"start_line":73,"start_character":19,"end_line":73,"end_character":22},"updated":"2018-06-25 19:17:27.000000000","message":"It looks the old interval and max_reties were already tuned in https://review.openstack.org/#/c/330312/ . I am not sure if it is a good idea to re-tune these values.\n\nIt seems what you need is tuning these values for create_allocation? Perhaps, there is a way to customize the interval and max_retries for allocation related operations and leave the rest of the operations untouched?","commit_id":"4c4392b9e533d02d594c64138960cc160db884ad"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"22b18d13461f818096f98d7ff1922913d31f47ad","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"_retry_db_errors \u003d oslo_db_api.wrap_db_retry("},{"line_number":72,"context_line":"    max_retries\u003dMAX_RETRIES,"},{"line_number":73,"context_line":"    retry_interval\u003d0.5,"},{"line_number":74,"context_line":"    inc_retry_interval\u003dTrue,"},{"line_number":75,"context_line":"    exception_checker\u003dis_retriable"},{"line_number":76,"context_line":")"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_433d778c","line":73,"range":{"start_line":73,"start_character":19,"end_line":73,"end_character":22},"in_reply_to":"5f7c97a3_062b2395","updated":"2018-07-02 14:05:23.000000000","message":"But doesn\u0027t the inc_retry_interval\u003dTrue cause a doubling of the interval every failure?","commit_id":"4c4392b9e533d02d594c64138960cc160db884ad"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0a54656a6e07ab035130a56c6863efc1fea64625","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"_retry_db_errors \u003d oslo_db_api.wrap_db_retry("},{"line_number":72,"context_line":"    max_retries\u003dMAX_RETRIES,"},{"line_number":73,"context_line":"    retry_interval\u003d0.5,"},{"line_number":74,"context_line":"    inc_retry_interval\u003dTrue,"},{"line_number":75,"context_line":"    exception_checker\u003dis_retriable"},{"line_number":76,"context_line":")"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_f8c36d38","line":73,"range":{"start_line":73,"start_character":19,"end_line":73,"end_character":22},"in_reply_to":"5f7c97a3_0f03ab11","updated":"2018-06-27 15:01:45.000000000","message":"I also feel this could have other consequences, as now the max timeout is going to be much larger (over a minute?) since there is a doubling of the interval each failure.  Unless my math is wrong?","commit_id":"4c4392b9e533d02d594c64138960cc160db884ad"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a10fee8df3a58d31340ecfa78318478564063ff5","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"_retry_db_errors \u003d oslo_db_api.wrap_db_retry("},{"line_number":72,"context_line":"    max_retries\u003dMAX_RETRIES,"},{"line_number":73,"context_line":"    retry_interval\u003d0.5,"},{"line_number":74,"context_line":"    inc_retry_interval\u003dTrue,"},{"line_number":75,"context_line":"    exception_checker\u003dis_retriable"},{"line_number":76,"context_line":")"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_859e12b5","line":73,"range":{"start_line":73,"start_character":19,"end_line":73,"end_character":22},"in_reply_to":"5f7c97a3_430569c0","updated":"2018-07-03 19:59:47.000000000","message":"But won\u0027t the retry interval look something like this:\n\n[0.5, 1, 2, 4, 8, 10, 10, ... 10]\n\nSo after the 5th retry it will sleep 10 seconds between?\n\nAnd with the old values it would be:\n\n[0.1, 0.2, 0.4, 0.8, 1.6, 3.2, 6.4, 10, 10, 10]\n\nI must be doing the math wrong?","commit_id":"4c4392b9e533d02d594c64138960cc160db884ad"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"8f95c36cb03cbbfb714a8390fb28293057a9df60","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"_retry_db_errors \u003d oslo_db_api.wrap_db_retry("},{"line_number":72,"context_line":"    max_retries\u003dMAX_RETRIES,"},{"line_number":73,"context_line":"    retry_interval\u003d0.5,"},{"line_number":74,"context_line":"    inc_retry_interval\u003dTrue,"},{"line_number":75,"context_line":"    exception_checker\u003dis_retriable"},{"line_number":76,"context_line":")"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_430569c0","line":73,"range":{"start_line":73,"start_character":19,"end_line":73,"end_character":22},"in_reply_to":"5f7c97a3_433d778c","updated":"2018-07-03 01:59:10.000000000","message":"Yes, it will reach the max_retry_interval more quickly.","commit_id":"4c4392b9e533d02d594c64138960cc160db884ad"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"358e3480d86785715291a712e8343ab48cca9f85","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"_retry_db_errors \u003d oslo_db_api.wrap_db_retry("},{"line_number":72,"context_line":"    max_retries\u003dMAX_RETRIES,"},{"line_number":73,"context_line":"    retry_interval\u003d0.5,"},{"line_number":74,"context_line":"    inc_retry_interval\u003dTrue,"},{"line_number":75,"context_line":"    exception_checker\u003dis_retriable"},{"line_number":76,"context_line":")"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_39af27e1","line":73,"range":{"start_line":73,"start_character":19,"end_line":73,"end_character":22},"in_reply_to":"5f7c97a3_859e12b5","updated":"2018-07-04 01:05:26.000000000","message":"Your math are prefectly. : )\nOK, my turn, let me do the math. So, for the new value 20 and 0.5, in the worst case the total time cost will be 165.5s. For the old config, it\u0027s  42.7s. It\u0027s not too radical for the new retry input params. right?","commit_id":"4c4392b9e533d02d594c64138960cc160db884ad"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"1f948a79131e89833436c06b74783eb0b3d46009","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"_retry_db_errors \u003d oslo_db_api.wrap_db_retry("},{"line_number":72,"context_line":"    max_retries\u003dMAX_RETRIES,"},{"line_number":73,"context_line":"    retry_interval\u003d0.5,"},{"line_number":74,"context_line":"    inc_retry_interval\u003dTrue,"},{"line_number":75,"context_line":"    exception_checker\u003dis_retriable"},{"line_number":76,"context_line":")"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_0f03ab11","line":73,"range":{"start_line":73,"start_character":19,"end_line":73,"end_character":22},"in_reply_to":"5f7c97a3_a0dbafe7","updated":"2018-06-26 01:14:43.000000000","message":"\u003e It looks the old interval and max_reties were already tuned in\n \u003e https://review.openstack.org/#/c/330312/ . I am not sure if it is a\n \u003e good idea to re-tune these values.\n \u003e \n\nThe default value here is `retry_interval\u003d1, max_retries\u003d20`. The patch you mentioned here set retry_interval to 0.1, it seems a bit fast for the neutron db to rety.\n\n \u003e It seems what you need is tuning these values for create_allocation?\n \u003e Perhaps, there is a way to customize the interval and max_retries\n \u003e for allocation related operations and leave the rest of the\n \u003e operations untouched?\n\nYes, you are right, I\u0027ve that thought too, but it really needs to change a lot of code path.","commit_id":"4c4392b9e533d02d594c64138960cc160db884ad"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"adbc1d2b8cd1a3feee2128c3936cbb2f5ac08eeb","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"_retry_db_errors \u003d oslo_db_api.wrap_db_retry("},{"line_number":72,"context_line":"    max_retries\u003dMAX_RETRIES,"},{"line_number":73,"context_line":"    retry_interval\u003d0.5,"},{"line_number":74,"context_line":"    inc_retry_interval\u003dTrue,"},{"line_number":75,"context_line":"    exception_checker\u003dis_retriable"},{"line_number":76,"context_line":")"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_062b2395","line":73,"range":{"start_line":73,"start_character":19,"end_line":73,"end_character":22},"in_reply_to":"5f7c97a3_f8c36d38","updated":"2018-06-30 02:03:10.000000000","message":"20 * 0.5s \u003d 10s？\nWe have run such code locally, everything seems OK for now.","commit_id":"4c4392b9e533d02d594c64138960cc160db884ad"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"496b2ee04dc924a2274abe425ed8d57d5bdb8aae","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"_retry_db_errors \u003d oslo_db_api.wrap_db_retry("},{"line_number":72,"context_line":"    max_retries\u003dMAX_RETRIES,"},{"line_number":73,"context_line":"    retry_interval\u003d0.5,"},{"line_number":74,"context_line":"    inc_retry_interval\u003dTrue,"},{"line_number":75,"context_line":"    exception_checker\u003dis_retriable"},{"line_number":76,"context_line":")"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_88cd3a94","line":73,"updated":"2018-07-11 10:40:19.000000000","message":"this means that we will wait 1/2 a second between each retry? worst case 10 seconds to get a failure. Why?","commit_id":"a935b46ebda5c50565eff0bc072fc61aaa4897c5"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"e5357d75d75c8fe5cc0be5416f1bc64973e218c7","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"_retry_db_errors \u003d oslo_db_api.wrap_db_retry("},{"line_number":72,"context_line":"    max_retries\u003dMAX_RETRIES,"},{"line_number":73,"context_line":"    retry_interval\u003d0.5,"},{"line_number":74,"context_line":"    inc_retry_interval\u003dTrue,"},{"line_number":75,"context_line":"    exception_checker\u003dis_retriable"},{"line_number":76,"context_line":")"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_a3d29932","line":73,"in_reply_to":"5f7c97a3_88cd3a94","updated":"2018-07-11 11:16:54.000000000","message":"It\u0027s not a simple `0.5 * 20 \u003d10` here. Maybe you can read the comments in patch set 1 [1]. It will increase gradually.\n\n[1] https://review.openstack.org/#/c/577739/1/neutron/db/api.py","commit_id":"a935b46ebda5c50565eff0bc072fc61aaa4897c5"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"e658281abb4b92820dba2984cbe8b35b8ba8855b","unresolved":false,"context_lines":[{"line_number":53,"context_line":"context_manager.append_on_engine_create(set_hook)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"MAX_RETRIES \u003d 20"},{"line_number":57,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_02a7bdaa","line":56,"updated":"2018-07-11 18:42:49.000000000","message":"Does further randomizing the selection of IP addresses on it\u0027s own perform well enough? I\u0027m wondering if this line and L73 really need to be adjusted.","commit_id":"c26d80d62ba3524e4a300c7a710a871b818168d1"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"81279e2c281d611f19f3d97c6aa8383de61a9035","unresolved":false,"context_lines":[{"line_number":53,"context_line":"context_manager.append_on_engine_create(set_hook)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"MAX_RETRIES \u003d 20"},{"line_number":57,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_fcd7c1f3","line":56,"in_reply_to":"5f7c97a3_02a7bdaa","updated":"2018-07-12 04:18:33.000000000","message":"This is really a nice question. Acctually we\u0027ve done such test locally. When only changing the IP selection, it still has many errors, and finally the quantity of API failures are much more than such change here.","commit_id":"c26d80d62ba3524e4a300c7a710a871b818168d1"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"d2aa25ab54beab034143d5da720724eb7c0e34b4","unresolved":false,"context_lines":[{"line_number":52,"context_line":"context_manager.append_on_engine_create(set_hook)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"MAX_RETRIES \u003d 10"},{"line_number":56,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_48ec6691","side":"PARENT","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":16},"updated":"2018-07-18 09:18:05.000000000","message":"Seems the patch https://review.openstack.org/#/c/570016/ forget this line, I just remove this.","commit_id":"d8a58b96ffb10b7110cf483d3cb2401c78f9951c"}],"neutron/ipam/drivers/neutrondb_ipam/driver.py":[{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"e658281abb4b92820dba2984cbe8b35b8ba8855b","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                window \u003d 1"},{"line_number":168,"context_line":"            else:"},{"line_number":169,"context_line":"                # Compute a value for the selection window"},{"line_number":170,"context_line":"                window \u003d min(av_set.size, 30)"},{"line_number":171,"context_line":"            ip_index \u003d random.randint(1, window)"},{"line_number":172,"context_line":"            candidate_ips \u003d list(itertools.islice(av_set, ip_index))"},{"line_number":173,"context_line":"            allocated_ip \u003d candidate_ips["}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_a2aa8981","line":170,"updated":"2018-07-11 18:42:49.000000000","message":"Expanding the window here seems reasonable to me. The idea behind having the window in the first place was to reduce contention for specific IP\u0027s. If we\u0027re finding an unacceptable number of retries it only seems logical to expand the window in an attempt to reduce the contention.","commit_id":"c26d80d62ba3524e4a300c7a710a871b818168d1"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"81279e2c281d611f19f3d97c6aa8383de61a9035","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                window \u003d 1"},{"line_number":168,"context_line":"            else:"},{"line_number":169,"context_line":"                # Compute a value for the selection window"},{"line_number":170,"context_line":"                window \u003d min(av_set.size, 30)"},{"line_number":171,"context_line":"            ip_index \u003d random.randint(1, window)"},{"line_number":172,"context_line":"            candidate_ips \u003d list(itertools.islice(av_set, ip_index))"},{"line_number":173,"context_line":"            allocated_ip \u003d candidate_ips["}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_9cc80d4e","line":170,"in_reply_to":"5f7c97a3_a2aa8981","updated":"2018-07-12 04:18:33.000000000","message":"Thanks for clarify this, it will help other reviewers.","commit_id":"c26d80d62ba3524e4a300c7a710a871b818168d1"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"e658281abb4b92820dba2984cbe8b35b8ba8855b","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            ip_index \u003d random.randint(1, window)"},{"line_number":172,"context_line":"            candidate_ips \u003d list(itertools.islice(av_set, ip_index))"},{"line_number":173,"context_line":"            allocated_ip \u003d candidate_ips["},{"line_number":174,"context_line":"                random.randint(0, len(candidate_ips) - 1)]"},{"line_number":175,"context_line":"            return str(allocated_ip), ip_pool.id"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        raise ipam_exc.IpAddressGenerationFailure("}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_c289c51e","line":174,"updated":"2018-07-11 18:42:49.000000000","message":"This seems like a nice touch. My initial thinking with this was just to use the last of the candidate IP\u0027s since the index used for slicing is randomized. Randomizing again among the candidate IP\u0027s to select the final one should further reduce contention.","commit_id":"c26d80d62ba3524e4a300c7a710a871b818168d1"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"81279e2c281d611f19f3d97c6aa8383de61a9035","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            ip_index \u003d random.randint(1, window)"},{"line_number":172,"context_line":"            candidate_ips \u003d list(itertools.islice(av_set, ip_index))"},{"line_number":173,"context_line":"            allocated_ip \u003d candidate_ips["},{"line_number":174,"context_line":"                random.randint(0, len(candidate_ips) - 1)]"},{"line_number":175,"context_line":"            return str(allocated_ip), ip_pool.id"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        raise ipam_exc.IpAddressGenerationFailure("}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_3cd539e7","line":174,"in_reply_to":"5f7c97a3_c289c51e","updated":"2018-07-12 04:18:33.000000000","message":"Thanks for clarify this, it will help other reviewers.","commit_id":"c26d80d62ba3524e4a300c7a710a871b818168d1"}],"neutron/tests/unit/db/test_api.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0a54656a6e07ab035130a56c6863efc1fea64625","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        e \u003d db_exc.DBConnectionError()"},{"line_number":92,"context_line":"        mock.patch(\u0027time.sleep\u0027).start()"},{"line_number":93,"context_line":"        with testtools.ExpectedException(db_exc.DBConnectionError):"},{"line_number":94,"context_line":"            # after 10 failures, the inner retry should give up and"},{"line_number":95,"context_line":"            # the exception should be tagged to prevent the outer retry"},{"line_number":96,"context_line":"            self._alt_context_function(context, 21, e)"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_d51f5c6f","line":94,"range":{"start_line":94,"start_character":20,"end_line":94,"end_character":22},"updated":"2018-06-27 15:01:45.000000000","message":"this comment is wrong now","commit_id":"4c4392b9e533d02d594c64138960cc160db884ad"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"adbc1d2b8cd1a3feee2128c3936cbb2f5ac08eeb","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        e \u003d db_exc.DBConnectionError()"},{"line_number":92,"context_line":"        mock.patch(\u0027time.sleep\u0027).start()"},{"line_number":93,"context_line":"        with testtools.ExpectedException(db_exc.DBConnectionError):"},{"line_number":94,"context_line":"            # after 10 failures, the inner retry should give up and"},{"line_number":95,"context_line":"            # the exception should be tagged to prevent the outer retry"},{"line_number":96,"context_line":"            self._alt_context_function(context, 21, e)"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_26265fcd","line":94,"range":{"start_line":94,"start_character":20,"end_line":94,"end_character":22},"in_reply_to":"5f7c97a3_d51f5c6f","updated":"2018-06-30 02:03:10.000000000","message":"Done","commit_id":"4c4392b9e533d02d594c64138960cc160db884ad"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0a54656a6e07ab035130a56c6863efc1fea64625","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        with testtools.ExpectedException(db_exc.DBConnectionError):"},{"line_number":94,"context_line":"            # after 10 failures, the inner retry should give up and"},{"line_number":95,"context_line":"            # the exception should be tagged to prevent the outer retry"},{"line_number":96,"context_line":"            self._alt_context_function(context, 21, e)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def test_retry_if_session_inactive_args_not_mutated_after_retries(self):"},{"line_number":99,"context_line":"        context \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_751a087d","line":96,"range":{"start_line":96,"start_character":48,"end_line":96,"end_character":50},"updated":"2018-06-27 15:01:45.000000000","message":"if we\u0027re going to change this we should just use db_api.MAX_RETRIES + 1","commit_id":"4c4392b9e533d02d594c64138960cc160db884ad"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"adbc1d2b8cd1a3feee2128c3936cbb2f5ac08eeb","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        with testtools.ExpectedException(db_exc.DBConnectionError):"},{"line_number":94,"context_line":"            # after 10 failures, the inner retry should give up and"},{"line_number":95,"context_line":"            # the exception should be tagged to prevent the outer retry"},{"line_number":96,"context_line":"            self._alt_context_function(context, 21, e)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def test_retry_if_session_inactive_args_not_mutated_after_retries(self):"},{"line_number":99,"context_line":"        context \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_c6168b59","line":96,"range":{"start_line":96,"start_character":48,"end_line":96,"end_character":50},"in_reply_to":"5f7c97a3_751a087d","updated":"2018-06-30 02:03:10.000000000","message":"Done","commit_id":"4c4392b9e533d02d594c64138960cc160db884ad"}]}
