)]}'
{"neutron/agent/dhcp_agent.py":[{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"639a6966d99d614fa994d29b6723e27264b3a0d1","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"            getattr(driver, action)(**action_kwargs)"},{"line_number":129,"context_line":"            return True"},{"line_number":130,"context_line":"        except exceptions.Conflict:"},{"line_number":131,"context_line":"            # No need to resync here, the agent will receive"},{"line_number":132,"context_line":"            # the event related to a status update for the"},{"line_number":133,"context_line":"            # network"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BhKo%3D","line":130,"updated":"2013-11-25 08:29:46.000000000","message":"Don\u0027 you write an unit test code?","commit_id":"01c16b7c9565dbd019c8e7b826a98f60dad97ed4"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e632a6fe268cb51b448af2cd5a5ba53feabba286","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"            getattr(driver, action)(**action_kwargs)"},{"line_number":129,"context_line":"            return True"},{"line_number":130,"context_line":"        except exceptions.Conflict:"},{"line_number":131,"context_line":"            # No need to resync here, the agent will receive"},{"line_number":132,"context_line":"            # the event related to a status update for the"},{"line_number":133,"context_line":"            # network"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BZJc%3D","line":130,"in_reply_to":"AAAATn%2F%2BhKo%3D","updated":"2013-11-26 15:40:52.000000000","message":"I will add one.","commit_id":"01c16b7c9565dbd019c8e7b826a98f60dad97ed4"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"3ee39f0e5a76f461fdde83e46011ff2d2869aca9","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            # the event related to a status update for the"},{"line_number":133,"context_line":"            # network"},{"line_number":134,"context_line":"            LOG.warn(_(\u0027Unable to %(action)s dhcp for %(net_id)s: \u0027"},{"line_number":135,"context_line":"                       \u0027there is a conflict with its current state.\u0027)"},{"line_number":136,"context_line":"                     % {\u0027net_id\u0027: network.id, \u0027action\u0027: action})"},{"line_number":137,"context_line":"        except Exception as e:"},{"line_number":138,"context_line":"            self.needs_resync \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BY4w%3D","line":135,"updated":"2013-11-26 16:14:34.000000000","message":"The code starts with a very specific error \"subnet not found\" and by the time this log message is written it is very generic \"conflict with current state.\"  If I saw this message in a log file, I would scratch my head and wonder where to go to figure out what really happened.  Is there any way to preserve the specificity of the original problem that was encountered?","commit_id":"01c16b7c9565dbd019c8e7b826a98f60dad97ed4"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2186dbcb3dbf95fa3b5593c7bd209f1fd46e4abb","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            # the event related to a status update for the"},{"line_number":133,"context_line":"            # network"},{"line_number":134,"context_line":"            LOG.warn(_(\u0027Unable to %(action)s dhcp for %(net_id)s: \u0027"},{"line_number":135,"context_line":"                       \u0027there is a conflict with its current state.\u0027)"},{"line_number":136,"context_line":"                     % {\u0027net_id\u0027: network.id, \u0027action\u0027: action})"},{"line_number":137,"context_line":"        except Exception as e:"},{"line_number":138,"context_line":"            self.needs_resync \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BYuA%3D","line":135,"in_reply_to":"AAAATn%2F%2BY4w%3D","updated":"2013-11-26 16:36:28.000000000","message":"Next sensible thing to do is to check the \u0027status\u0027 of the resource, and correlate this message with the server-side log. The admin will not be completely clueless. That said, I\u0027ll try to address your concern in a follow-up patch.","commit_id":"01c16b7c9565dbd019c8e7b826a98f60dad97ed4"}],"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"79fe44cb9c2061df0a8c29b702f3f2c000d8f349","unresolved":false,"context_lines":[{"line_number":691,"context_line":"                fixed_ips\u003d[dict(subnet_id\u003ds) for s in dhcp_enabled_subnet_ids])"},{"line_number":692,"context_line":"            dhcp_port \u003d self.plugin.create_dhcp_port({\u0027port\u0027: port_dict})"},{"line_number":693,"context_line":""},{"line_number":694,"context_line":"        if not dhcp_port:"},{"line_number":695,"context_line":"            raise exceptions.Conflict()"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"        # Convert subnet_id to subnet dict"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Bnf4%3D","line":694,"updated":"2013-11-22 12:21:55.000000000","message":"should this be indented over one line? Guess it really doesn\u0027t matter to much though having it out here as well.","commit_id":"01c16b7c9565dbd019c8e7b826a98f60dad97ed4"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"47fdd6945c39a2bf34cc141814cea8e183a935e6","unresolved":false,"context_lines":[{"line_number":691,"context_line":"                fixed_ips\u003d[dict(subnet_id\u003ds) for s in dhcp_enabled_subnet_ids])"},{"line_number":692,"context_line":"            dhcp_port \u003d self.plugin.create_dhcp_port({\u0027port\u0027: port_dict})"},{"line_number":693,"context_line":""},{"line_number":694,"context_line":"        if not dhcp_port:"},{"line_number":695,"context_line":"            raise exceptions.Conflict()"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"        # Convert subnet_id to subnet dict"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Bm%2BI%3D","line":694,"in_reply_to":"AAAATn%2F%2Bnf4%3D","updated":"2013-11-22 14:48:57.000000000","message":"same difference for the control flow of this method","commit_id":"01c16b7c9565dbd019c8e7b826a98f60dad97ed4"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"32dedced7673a257ade0439a6ff9c859fbe6998c","unresolved":false,"context_lines":[{"line_number":692,"context_line":"            dhcp_port \u003d self.plugin.create_dhcp_port({\u0027port\u0027: port_dict})"},{"line_number":693,"context_line":""},{"line_number":694,"context_line":"        if not dhcp_port:"},{"line_number":695,"context_line":"            raise exceptions.Conflict()"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"        # Convert subnet_id to subnet dict"},{"line_number":698,"context_line":"        fixed_ips \u003d [dict(subnet_id\u003dfixed_ip.subnet_id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F97FY%3D","line":695,"updated":"2013-12-04 15:34:51.000000000","message":"(Suggestion only) I see that this message is only intended to be caught by dhcp_agent.py, but consider at least adding a message indicating what went wrong for the benefit of future maintainers.  A docstring in sphinx format might also help:\n\n:raises Conflict: ???","commit_id":"bff120a4775a1b1f3846a27c38d8eff4a678fd24"}],"neutron/db/dhcp_rpc_base.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"40fb0913f4be02441d0a5e7357064a77cfffc111","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                    raise"},{"line_number":66,"context_line":"            network_id \u003d port[\u0027port\u0027][\u0027network_id\u0027]"},{"line_number":67,"context_line":"            LOG.warn(_(\"Port for network %(net_id)s could not be created: \""},{"line_number":68,"context_line":"                       \"%(reason)s\") % {\"net_id\": network_id, \u0027reason\u0027: e})"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def get_active_networks(self, context, **kwargs):"},{"line_number":71,"context_line":"        \"\"\"Retrieve and return a list of the active network ids.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2BPKk%3D","line":68,"updated":"2013-11-28 13:47:04.000000000","message":"Is it worth logging this even if we raise at 64?","commit_id":"e397005124a5343f4fbdd1ea877cecc45e7934b0"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"29d81a2986825886d38cdc1b9ef162a8b67a7259","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                    raise"},{"line_number":66,"context_line":"            network_id \u003d port[\u0027port\u0027][\u0027network_id\u0027]"},{"line_number":67,"context_line":"            LOG.warn(_(\"Port for network %(net_id)s could not be created: \""},{"line_number":68,"context_line":"                       \"%(reason)s\") % {\"net_id\": network_id, \u0027reason\u0027: e})"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def get_active_networks(self, context, **kwargs):"},{"line_number":71,"context_line":"        \"\"\"Retrieve and return a list of the active network ids.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2BOcc%3D","line":68,"in_reply_to":"AAAATn%2F%2BPKk%3D","updated":"2013-11-28 17:00:10.000000000","message":"we log the warning if we go to line 63 or if we skip line 55, no?","commit_id":"e397005124a5343f4fbdd1ea877cecc45e7934b0"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"262e53ae5929f6f00a6170c862e2f8cfda69278e","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                    subnet_id \u003d port[\u0027port\u0027][\u0027fixed_ips\u0027][0][\u0027subnet_id\u0027]"},{"line_number":65,"context_line":"                    plugin.get_subnet(context, subnet_id)"},{"line_number":66,"context_line":"                except n_exc.SubnetNotFound:"},{"line_number":67,"context_line":"                    pass"},{"line_number":68,"context_line":"                else:"},{"line_number":69,"context_line":"                    raise"},{"line_number":70,"context_line":"            network_id \u003d port[\u0027port\u0027][\u0027network_id\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2BBwA%3D","line":67,"updated":"2013-12-03 10:07:18.000000000","message":"maybe add add a LOG.warn here as you do for dhcp_agent.py ?","commit_id":"b251f6239fb014949c8c9c349d90df3f05de5be9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"26b690995218cd0baa96f51559c5309d29873a8a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                    subnet_id \u003d port[\u0027port\u0027][\u0027fixed_ips\u0027][0][\u0027subnet_id\u0027]"},{"line_number":65,"context_line":"                    plugin.get_subnet(context, subnet_id)"},{"line_number":66,"context_line":"                except n_exc.SubnetNotFound:"},{"line_number":67,"context_line":"                    pass"},{"line_number":68,"context_line":"                else:"},{"line_number":69,"context_line":"                    raise"},{"line_number":70,"context_line":"            network_id \u003d port[\u0027port\u0027][\u0027network_id\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2BAng%3D","line":67,"in_reply_to":"AAAATn%2F%2BBwA%3D","updated":"2013-12-03 15:47:40.000000000","message":"Even if we get here, we log at line 71. Since we log the reason there, adding a trace here does not add any further information.","commit_id":"b251f6239fb014949c8c9c349d90df3f05de5be9"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d2cf74c3863f1e80a8551fa2c0289cb45bb5572a","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                except n_exc.SubnetNotFound:"},{"line_number":67,"context_line":"                    pass"},{"line_number":68,"context_line":"                else:"},{"line_number":69,"context_line":"                    raise"},{"line_number":70,"context_line":"            network_id \u003d port[\u0027port\u0027][\u0027network_id\u0027]"},{"line_number":71,"context_line":"            LOG.warn(_(\"Port for network %(net_id)s could not be created: \""},{"line_number":72,"context_line":"                       \"%(reason)s\") % {\"net_id\": network_id, \u0027reason\u0027: e})"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2BBkY%3D","line":69,"updated":"2013-12-03 10:46:14.000000000","message":"I think it is better to use excutils.save_and_reraise_exception when reraising an caught exception.","commit_id":"b251f6239fb014949c8c9c349d90df3f05de5be9"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0dd5e5fb3ee75ce78265e674d345597ee6f403bc","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                except n_exc.SubnetNotFound:"},{"line_number":67,"context_line":"                    pass"},{"line_number":68,"context_line":"                else:"},{"line_number":69,"context_line":"                    raise"},{"line_number":70,"context_line":"            network_id \u003d port[\u0027port\u0027][\u0027network_id\u0027]"},{"line_number":71,"context_line":"            LOG.warn(_(\"Port for network %(net_id)s could not be created: \""},{"line_number":72,"context_line":"                       \"%(reason)s\") % {\"net_id\": network_id, \u0027reason\u0027: e})"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F97%2Bg%3D","line":69,"in_reply_to":"AAAATn%2F%2BAS4%3D","updated":"2013-12-04 09:12:48.000000000","message":"Ah, I got it. save_and_reraise_exception always raises some kind of exception and there is no way not to raise an exception.\n\nWhat I am afraid is the code at L.63-67 matches the cases described in save_and_reraise_exception docstring: \"when running an exception handler, code raises and catches an exception.\". I am not sure it exactly hits the case though.","commit_id":"b251f6239fb014949c8c9c349d90df3f05de5be9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"26b690995218cd0baa96f51559c5309d29873a8a","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                except n_exc.SubnetNotFound:"},{"line_number":67,"context_line":"                    pass"},{"line_number":68,"context_line":"                else:"},{"line_number":69,"context_line":"                    raise"},{"line_number":70,"context_line":"            network_id \u003d port[\u0027port\u0027][\u0027network_id\u0027]"},{"line_number":71,"context_line":"            LOG.warn(_(\"Port for network %(net_id)s could not be created: \""},{"line_number":72,"context_line":"                       \"%(reason)s\") % {\"net_id\": network_id, \u0027reason\u0027: e})"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2BAS4%3D","line":69,"in_reply_to":"AAAATn%2F%2BBkY%3D","updated":"2013-12-03 15:47:40.000000000","message":"The exception is raised only if a specific circumstance is met, so I wasn\u0027t sure how I could use it. Could you elaborate?","commit_id":"b251f6239fb014949c8c9c349d90df3f05de5be9"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d2cf74c3863f1e80a8551fa2c0289cb45bb5572a","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            retval \u003d self._port_action(plugin, context, {\u0027port\u0027: port_dict},"},{"line_number":193,"context_line":"                                       \u0027create_port\u0027)"},{"line_number":194,"context_line":"            if not retval:"},{"line_number":195,"context_line":"                return"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        # Convert subnet_id to subnet dict"},{"line_number":198,"context_line":"        for fixed_ip in retval[\u0027fixed_ips\u0027]:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2BBi8%3D","line":195,"updated":"2013-12-03 10:46:14.000000000","message":"This commit changes the return value of RPC API. It is worth documented in docstring of the method.\n\nDo we need to increment DHCP RPC minor version?","commit_id":"b251f6239fb014949c8c9c349d90df3f05de5be9"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0dd5e5fb3ee75ce78265e674d345597ee6f403bc","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            retval \u003d self._port_action(plugin, context, {\u0027port\u0027: port_dict},"},{"line_number":193,"context_line":"                                       \u0027create_port\u0027)"},{"line_number":194,"context_line":"            if not retval:"},{"line_number":195,"context_line":"                return"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        # Convert subnet_id to subnet dict"},{"line_number":198,"context_line":"        for fixed_ip in retval[\u0027fixed_ips\u0027]:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F979g%3D","line":195,"in_reply_to":"AAAATn%2F%2BASM%3D","updated":"2013-12-04 09:12:48.000000000","message":"Agree with you. The incompatiblity happens in a case this patch deals with and even for such case dhcp-agent raises another type of exception from DictModel and it will be caught in call_driver. I think it is acceptable.","commit_id":"b251f6239fb014949c8c9c349d90df3f05de5be9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"26b690995218cd0baa96f51559c5309d29873a8a","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            retval \u003d self._port_action(plugin, context, {\u0027port\u0027: port_dict},"},{"line_number":193,"context_line":"                                       \u0027create_port\u0027)"},{"line_number":194,"context_line":"            if not retval:"},{"line_number":195,"context_line":"                return"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        # Convert subnet_id to subnet dict"},{"line_number":198,"context_line":"        for fixed_ip in retval[\u0027fixed_ips\u0027]:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2BASM%3D","line":195,"in_reply_to":"AAAATn%2F%2BBi8%3D","updated":"2013-12-03 15:47:40.000000000","message":"Strictly speaking the change is not backward compatible, but without it the exception is propagated all the way to the client disrupting its control flow, so I figured it was not worth preserving a \u0027broken\u0027 behavior anyway.\n\nAs for the docstring, I\u0027ll add a comment.","commit_id":"b251f6239fb014949c8c9c349d90df3f05de5be9"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"32dedced7673a257ade0439a6ff9c859fbe6998c","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        return nets"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def _port_action(self, plugin, context, port, action):"},{"line_number":50,"context_line":"        \"\"\"Perform port operations taking care of concurrency issues.\"\"\""},{"line_number":51,"context_line":"        try:"},{"line_number":52,"context_line":"            if action \u003d\u003d \u0027create_port\u0027:"},{"line_number":53,"context_line":"                return plugin.create_port(context, port)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F97II%3D","line":50,"updated":"2013-12-04 15:34:51.000000000","message":"(Suggestion only) Wrap invocation of port operations to add error handling.","commit_id":"bff120a4775a1b1f3846a27c38d8eff4a678fd24"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"32dedced7673a257ade0439a6ff9c859fbe6998c","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                return plugin.create_port(context, port)"},{"line_number":54,"context_line":"            else:"},{"line_number":55,"context_line":"                msg \u003d _(\u0027Unrecognized action\u0027)"},{"line_number":56,"context_line":"                raise n_exc.Invalid(message\u003dmsg)"},{"line_number":57,"context_line":"        except (db_exc.DBError, n_exc.NetworkNotFound,"},{"line_number":58,"context_line":"                n_exc.SubnetNotFound, n_exc.IpAddressGenerationFailure) as e:"},{"line_number":59,"context_line":"            if isinstance(e, n_exc.IpAddressGenerationFailure):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F97JY%3D","line":56,"updated":"2013-12-04 15:34:51.000000000","message":"(Suggestion only) It\u0027s a little bit strange to be raising an untrapped exception from within a try block.  Consider something like the following instead:\n\nif action \u003d\u003d \u0027create_port\u0027:\n   action_func \u003d plugin.create_port\nelse:\n   raise\n\ntry:\n   action_func()\nexcept:\n   pass","commit_id":"bff120a4775a1b1f3846a27c38d8eff4a678fd24"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"32dedced7673a257ade0439a6ff9c859fbe6998c","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        This method will re-use an existing port if one already exists.  When a"},{"line_number":126,"context_line":"        port is re-used, the fixed_ip allocation will be updated to the current"},{"line_number":127,"context_line":"        network state. If an expected failure occurs, a None port is returned."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        \"\"\""},{"line_number":130,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F97MA%3D","line":127,"updated":"2013-12-04 15:34:51.000000000","message":"(Suggestion only) a None port -\u003e None","commit_id":"bff120a4775a1b1f3846a27c38d8eff4a678fd24"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"32dedced7673a257ade0439a6ff9c859fbe6998c","unresolved":false,"context_lines":[{"line_number":251,"context_line":"    def create_dhcp_port(self, context, **kwargs):"},{"line_number":252,"context_line":"        \"\"\"Create and return dhcp port information."},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"        If an expected failure occurs, a None port is returned."},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        \"\"\""},{"line_number":257,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F97K4%3D","line":254,"updated":"2013-12-04 15:34:51.000000000","message":"(Suggestion only) Consider using sphinx format to document the return value, e.g.\n\n\"\"\"\nCreate the dhcp port.\n\n:returns: A DictModel for the created port on success, None otherwise. \n\"\"\"","commit_id":"bff120a4775a1b1f3846a27c38d8eff4a678fd24"}]}
