)]}'
{"neutron/agent/l3_agent.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"7fd6d84ce634208fe1a288461ce0279ef9f9b461","unresolved":false,"context_lines":[{"line_number":369,"context_line":"        ip_wrapper \u003d ip_lib.IPWrapper(root_helper\u003dself.root_helper,"},{"line_number":370,"context_line":"                                      namespace\u003dri.ns_name())"},{"line_number":371,"context_line":"        ip_devs \u003d ip_wrapper.get_devices(exclude_loopback\u003dTrue)"},{"line_number":372,"context_line":"        retval \u003d [ip_dev.name for ip_dev in ip_devs if"},{"line_number":373,"context_line":"                  ip_dev.name.startswith(INTERNAL_DEV_PREFIX)]"},{"line_number":374,"context_line":"        return retval"},{"line_number":375,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BmVQ%3D","line":372,"updated":"2013-11-22 17:28:17.000000000","message":"could eliminate temp variable retval and just return [...]","commit_id":"02511634445915154e868cfea9f937bb3069489e"},{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"bcf36c51d022387733943360dc57f713b4620209","unresolved":false,"context_lines":[{"line_number":369,"context_line":"        ip_wrapper \u003d ip_lib.IPWrapper(root_helper\u003dself.root_helper,"},{"line_number":370,"context_line":"                                      namespace\u003dri.ns_name())"},{"line_number":371,"context_line":"        ip_devs \u003d ip_wrapper.get_devices(exclude_loopback\u003dTrue)"},{"line_number":372,"context_line":"        retval \u003d [ip_dev.name for ip_dev in ip_devs if"},{"line_number":373,"context_line":"                  ip_dev.name.startswith(INTERNAL_DEV_PREFIX)]"},{"line_number":374,"context_line":"        return retval"},{"line_number":375,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BldQ%3D","line":372,"in_reply_to":"AAAATn%2F%2BmVQ%3D","updated":"2013-11-22 19:39:01.000000000","message":"Done","commit_id":"02511634445915154e868cfea9f937bb3069489e"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"86a8ed22366732181af43797f118f15a69d04416","unresolved":false,"context_lines":[{"line_number":394,"context_line":"            ri.internal_ports.remove(p)"},{"line_number":395,"context_line":"            self.internal_network_removed(ri, p[\u0027id\u0027], p[\u0027ip_cidr\u0027])"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        current_internal_devs \u003d set(self._get_current_internal_devices(ri))"},{"line_number":398,"context_line":"        good_port_devs \u003d set([self.get_internal_device_name(id) for"},{"line_number":399,"context_line":"                              id in current_port_ids])"},{"line_number":400,"context_line":"        stale_devs \u003d current_internal_devs - good_port_devs"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F99ak%3D","line":397,"updated":"2013-12-04 00:23:41.000000000","message":"existing_internal_devs?","commit_id":"d830fdf56832642be4e70a2466b225af8a384ac6"},{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"20bd5c8c6b0f5f6fb043c4f429acb7cacbdf1ced","unresolved":false,"context_lines":[{"line_number":394,"context_line":"            ri.internal_ports.remove(p)"},{"line_number":395,"context_line":"            self.internal_network_removed(ri, p[\u0027id\u0027], p[\u0027ip_cidr\u0027])"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        current_internal_devs \u003d set(self._get_current_internal_devices(ri))"},{"line_number":398,"context_line":"        good_port_devs \u003d set([self.get_internal_device_name(id) for"},{"line_number":399,"context_line":"                              id in current_port_ids])"},{"line_number":400,"context_line":"        stale_devs \u003d current_internal_devs - good_port_devs"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F96Ww%3D","line":397,"in_reply_to":"AAAATn%2F99ak%3D","updated":"2013-12-04 15:36:42.000000000","message":"Done","commit_id":"d830fdf56832642be4e70a2466b225af8a384ac6"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"86a8ed22366732181af43797f118f15a69d04416","unresolved":false,"context_lines":[{"line_number":395,"context_line":"            self.internal_network_removed(ri, p[\u0027id\u0027], p[\u0027ip_cidr\u0027])"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        current_internal_devs \u003d set(self._get_current_internal_devices(ri))"},{"line_number":398,"context_line":"        good_port_devs \u003d set([self.get_internal_device_name(id) for"},{"line_number":399,"context_line":"                              id in current_port_ids])"},{"line_number":400,"context_line":"        stale_devs \u003d current_internal_devs - good_port_devs"},{"line_number":401,"context_line":"        for stale_dev in stale_devs:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F99ao%3D","line":398,"updated":"2013-12-04 00:23:41.000000000","message":"current_port_devs?","commit_id":"d830fdf56832642be4e70a2466b225af8a384ac6"},{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"20bd5c8c6b0f5f6fb043c4f429acb7cacbdf1ced","unresolved":false,"context_lines":[{"line_number":395,"context_line":"            self.internal_network_removed(ri, p[\u0027id\u0027], p[\u0027ip_cidr\u0027])"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        current_internal_devs \u003d set(self._get_current_internal_devices(ri))"},{"line_number":398,"context_line":"        good_port_devs \u003d set([self.get_internal_device_name(id) for"},{"line_number":399,"context_line":"                              id in current_port_ids])"},{"line_number":400,"context_line":"        stale_devs \u003d current_internal_devs - good_port_devs"},{"line_number":401,"context_line":"        for stale_dev in stale_devs:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F98pk%3D","line":398,"in_reply_to":"AAAATn%2F99ao%3D","updated":"2013-12-04 15:36:42.000000000","message":"Good idea.","commit_id":"d830fdf56832642be4e70a2466b225af8a384ac6"},{"author":{"_account_id":9073,"name":"Yuanchao Sun","email":"yuanchao.sun@gmail.com","username":"yuanchao"},"change_message_id":"40c54f05ed28137e63b26b4107f8de8ac3b479a3","unresolved":false,"context_lines":[{"line_number":377,"context_line":"        prefixlen \u003d netaddr.IPNetwork(port[\u0027subnet\u0027][\u0027cidr\u0027]).prefixlen"},{"line_number":378,"context_line":"        port[\u0027ip_cidr\u0027] \u003d \"%s/%s\" % (ips[0][\u0027ip_address\u0027], prefixlen)"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    def _get_current_internal_devices(self, ri):"},{"line_number":381,"context_line":"        ip_wrapper \u003d ip_lib.IPWrapper(root_helper\u003dself.root_helper,"},{"line_number":382,"context_line":"                                      namespace\u003dri.ns_name())"},{"line_number":383,"context_line":"        ip_devs \u003d ip_wrapper.get_devices(exclude_loopback\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2F9s4%3D","line":380,"updated":"2013-12-26 07:24:55.000000000","message":"_get_existing_internal_devices(...) or _get_internal_devices(...)?  feel free to ignore this comment.","commit_id":"bd39d4c3063f9dcb5d62ede24dcc885714a80dee"},{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"7a2392990f11334b57136621d3360b1cee4ce3f5","unresolved":false,"context_lines":[{"line_number":377,"context_line":"        prefixlen \u003d netaddr.IPNetwork(port[\u0027subnet\u0027][\u0027cidr\u0027]).prefixlen"},{"line_number":378,"context_line":"        port[\u0027ip_cidr\u0027] \u003d \"%s/%s\" % (ips[0][\u0027ip_address\u0027], prefixlen)"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    def _get_current_internal_devices(self, ri):"},{"line_number":381,"context_line":"        ip_wrapper \u003d ip_lib.IPWrapper(root_helper\u003dself.root_helper,"},{"line_number":382,"context_line":"                                      namespace\u003dri.ns_name())"},{"line_number":383,"context_line":"        ip_devs \u003d ip_wrapper.get_devices(exclude_loopback\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2Fnv0%3D","line":380,"in_reply_to":"AAAAT3%2F%2F9s4%3D","updated":"2014-02-13 15:14:59.000000000","message":"CHanging the function name to _get_existing_internal_devices in the next patch.","commit_id":"bd39d4c3063f9dcb5d62ede24dcc885714a80dee"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"a6339915caf1c6de7ab914df3ffed42d54f7aa49","unresolved":false,"context_lines":[{"line_number":406,"context_line":"            ri.internal_ports.remove(p)"},{"line_number":407,"context_line":"            self.internal_network_removed(ri, p[\u0027id\u0027], p[\u0027ip_cidr\u0027])"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        existing_internal_devs \u003d set(self._get_current_internal_devices(ri))"},{"line_number":410,"context_line":"        current_port_devs \u003d set([self.get_internal_device_name(id) for"},{"line_number":411,"context_line":"                                 id in current_port_ids])"},{"line_number":412,"context_line":"        stale_devs \u003d existing_internal_devs - current_port_devs"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F9UbM%3D","line":409,"updated":"2014-02-07 19:31:22.000000000","message":"to echo the previous comment, perhaps just call this variable current_internal_devs","commit_id":"bd39d4c3063f9dcb5d62ede24dcc885714a80dee"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"a5547b2f719e319be06f041a93fefe388aba12e4","unresolved":false,"context_lines":[{"line_number":406,"context_line":"            ri.internal_ports.remove(p)"},{"line_number":407,"context_line":"            self.internal_network_removed(ri, p[\u0027id\u0027], p[\u0027ip_cidr\u0027])"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        existing_internal_devs \u003d set(self._get_current_internal_devices(ri))"},{"line_number":410,"context_line":"        current_port_devs \u003d set([self.get_internal_device_name(id) for"},{"line_number":411,"context_line":"                                 id in current_port_ids])"},{"line_number":412,"context_line":"        stale_devs \u003d existing_internal_devs - current_port_devs"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2F47c%3D","line":409,"in_reply_to":"AAAAUH%2F9UbM%3D","updated":"2014-02-10 06:08:27.000000000","message":"+1","commit_id":"bd39d4c3063f9dcb5d62ede24dcc885714a80dee"},{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"7a2392990f11334b57136621d3360b1cee4ce3f5","unresolved":false,"context_lines":[{"line_number":406,"context_line":"            ri.internal_ports.remove(p)"},{"line_number":407,"context_line":"            self.internal_network_removed(ri, p[\u0027id\u0027], p[\u0027ip_cidr\u0027])"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        existing_internal_devs \u003d set(self._get_current_internal_devices(ri))"},{"line_number":410,"context_line":"        current_port_devs \u003d set([self.get_internal_device_name(id) for"},{"line_number":411,"context_line":"                                 id in current_port_ids])"},{"line_number":412,"context_line":"        stale_devs \u003d existing_internal_devs - current_port_devs"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2Fnvc%3D","line":409,"in_reply_to":"AAAAUX%2F%2F47c%3D","updated":"2014-02-13 15:14:59.000000000","message":"The function name is changed to _get_existing_internal_devices() in the next patch.","commit_id":"bd39d4c3063f9dcb5d62ede24dcc885714a80dee"},{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"6fc78ffb67aa23cd7b84524a3cd9172780b83909","unresolved":false,"context_lines":[{"line_number":406,"context_line":"            ri.internal_ports.remove(p)"},{"line_number":407,"context_line":"            self.internal_network_removed(ri, p[\u0027id\u0027], p[\u0027ip_cidr\u0027])"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        existing_internal_devs \u003d set(self._get_current_internal_devices(ri))"},{"line_number":410,"context_line":"        current_port_devs \u003d set([self.get_internal_device_name(id) for"},{"line_number":411,"context_line":"                                 id in current_port_ids])"},{"line_number":412,"context_line":"        stale_devs \u003d existing_internal_devs - current_port_devs"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2FTnI%3D","line":409,"in_reply_to":"AAAAUX%2F%2Fnvc%3D","updated":"2014-02-14 03:52:49.000000000","message":"Replaced existing_internal_devs to current_internal_devs.","commit_id":"bd39d4c3063f9dcb5d62ede24dcc885714a80dee"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c328e3bb566c8f934e2f9c51908492038bb3f5b5","unresolved":false,"context_lines":[{"line_number":423,"context_line":"                      stale_dev)"},{"line_number":424,"context_line":"            self.driver.unplug(stale_dev,"},{"line_number":425,"context_line":"                               namespace\u003dri.ns_name(),"},{"line_number":426,"context_line":"                               prefix\u003dINTERNAL_DEV_PREFIX)"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        internal_cidrs \u003d [p[\u0027ip_cidr\u0027] for p in ri.internal_ports]"},{"line_number":429,"context_line":"        # TODO(salv-orlando): RouterInfo would be a better place for"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVn%2F%2FIGI%3D","line":426,"updated":"2014-03-08 18:51:18.000000000","message":"Isn\u0027t it better to remove stale devices before adding new ports? I think we can avoid the issue reported in the bug report completely by doing so. (If so current_internal_devs are different and we need to take into account old/new_ports.)","commit_id":"b0306a93645ea6475a2bc045d8fc8bc4bd6f00a5"}],"neutron/tests/unit/test_l3_agent.py":[{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"6ab4e142b792be43a0b515d39600e37f9990ab99","unresolved":false,"context_lines":[{"line_number":600,"context_line":"                         FakeDev(\u0027qr-b2c3d4e5-f6\u0027)]"},{"line_number":601,"context_line":"        stale_devnames \u003d [dev.name for dev in stale_devlist]"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"        get_devices_return \u003d []"},{"line_number":604,"context_line":"        get_devices_return.extend(stale_devlist)"},{"line_number":605,"context_line":"        get_devices_return.extend([FakeDev(\u0027qg-a1b2c3d4-e5\u0027),"},{"line_number":606,"context_line":"                                   FakeDev(\u0027qg-b2c3d4e5-f6\u0027)])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BmUc%3D","line":603,"updated":"2013-11-22 16:39:07.000000000","message":"get_devices_return \u003d [FakeDev(\u0027qg-a1b2c3d4-e5\u0027),...]","commit_id":"02511634445915154e868cfea9f937bb3069489e"},{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"bcf36c51d022387733943360dc57f713b4620209","unresolved":false,"context_lines":[{"line_number":600,"context_line":"                         FakeDev(\u0027qr-b2c3d4e5-f6\u0027)]"},{"line_number":601,"context_line":"        stale_devnames \u003d [dev.name for dev in stale_devlist]"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"        get_devices_return \u003d []"},{"line_number":604,"context_line":"        get_devices_return.extend(stale_devlist)"},{"line_number":605,"context_line":"        get_devices_return.extend([FakeDev(\u0027qg-a1b2c3d4-e5\u0027),"},{"line_number":606,"context_line":"                                   FakeDev(\u0027qg-b2c3d4e5-f6\u0027)])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Bldc%3D","line":603,"in_reply_to":"AAAATn%2F%2BmUc%3D","updated":"2013-11-22 19:39:01.000000000","message":"Done","commit_id":"02511634445915154e868cfea9f937bb3069489e"},{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"6ab4e142b792be43a0b515d39600e37f9990ab99","unresolved":false,"context_lines":[{"line_number":603,"context_line":"        get_devices_return \u003d []"},{"line_number":604,"context_line":"        get_devices_return.extend(stale_devlist)"},{"line_number":605,"context_line":"        get_devices_return.extend([FakeDev(\u0027qg-a1b2c3d4-e5\u0027),"},{"line_number":606,"context_line":"                                   FakeDev(\u0027qg-b2c3d4e5-f6\u0027)])"},{"line_number":607,"context_line":"        self.mock_ip.get_devices.return_value \u003d get_devices_return"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"        agent.internal_network_removed \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BmUY%3D","line":606,"updated":"2013-11-22 16:39:07.000000000","message":"Set the list in line 603.","commit_id":"02511634445915154e868cfea9f937bb3069489e"},{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"bcf36c51d022387733943360dc57f713b4620209","unresolved":false,"context_lines":[{"line_number":603,"context_line":"        get_devices_return \u003d []"},{"line_number":604,"context_line":"        get_devices_return.extend(stale_devlist)"},{"line_number":605,"context_line":"        get_devices_return.extend([FakeDev(\u0027qg-a1b2c3d4-e5\u0027),"},{"line_number":606,"context_line":"                                   FakeDev(\u0027qg-b2c3d4e5-f6\u0027)])"},{"line_number":607,"context_line":"        self.mock_ip.get_devices.return_value \u003d get_devices_return"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"        agent.internal_network_removed \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BldY%3D","line":606,"in_reply_to":"AAAATn%2F%2BmUY%3D","updated":"2013-11-22 19:39:01.000000000","message":"Done","commit_id":"02511634445915154e868cfea9f937bb3069489e"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"a5547b2f719e319be06f041a93fefe388aba12e4","unresolved":false,"context_lines":[{"line_number":630,"context_line":"        get_devices_return.extend(stale_devlist)"},{"line_number":631,"context_line":"        self.mock_ip.get_devices.return_value \u003d get_devices_return"},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"        agent.internal_network_removed \u003d mock.Mock()"},{"line_number":634,"context_line":"        agent.internal_network_added \u003d mock.Mock()"},{"line_number":635,"context_line":"        agent.external_gateway_removed \u003d mock.Mock()"},{"line_number":636,"context_line":"        agent.external_gateway_added \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2F46I%3D","line":633,"updated":"2014-02-10 06:08:27.000000000","message":"Please patch() instead of manually patching the instance.","commit_id":"bd39d4c3063f9dcb5d62ede24dcc885714a80dee"},{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"7a2392990f11334b57136621d3360b1cee4ce3f5","unresolved":false,"context_lines":[{"line_number":630,"context_line":"        get_devices_return.extend(stale_devlist)"},{"line_number":631,"context_line":"        self.mock_ip.get_devices.return_value \u003d get_devices_return"},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"        agent.internal_network_removed \u003d mock.Mock()"},{"line_number":634,"context_line":"        agent.internal_network_added \u003d mock.Mock()"},{"line_number":635,"context_line":"        agent.external_gateway_removed \u003d mock.Mock()"},{"line_number":636,"context_line":"        agent.external_gateway_added \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2Fnuo%3D","line":633,"in_reply_to":"AAAAUX%2F%2F46I%3D","updated":"2014-02-13 15:14:59.000000000","message":"This will be done in the next patch.","commit_id":"bd39d4c3063f9dcb5d62ede24dcc885714a80dee"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"a5547b2f719e319be06f041a93fefe388aba12e4","unresolved":false,"context_lines":[{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        self.assertEqual(self.mock_driver.unplug.call_count,"},{"line_number":660,"context_line":"                         len(stale_devnames))"},{"line_number":661,"context_line":"        calls \u003d []"},{"line_number":662,"context_line":"        for stale_devname in stale_devnames:"},{"line_number":663,"context_line":"            calls.append(mock.call(stale_devname,"},{"line_number":664,"context_line":"                                   namespace\u003dri.ns_name(),"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2F47I%3D","line":661,"updated":"2014-02-10 06:08:27.000000000","message":"reaplce 661-665 with a list comprehension:\n\ncalls \u003d [\n    mock.call(\n        stale_devname,\n        namespace\u003dri.ns_name(),\n        prefix\u003dl3_agent.INTERNAL_DEV_PREFIX)\n    for stale_devname in stale_devnames\n]","commit_id":"bd39d4c3063f9dcb5d62ede24dcc885714a80dee"},{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"7a2392990f11334b57136621d3360b1cee4ce3f5","unresolved":false,"context_lines":[{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        self.assertEqual(self.mock_driver.unplug.call_count,"},{"line_number":660,"context_line":"                         len(stale_devnames))"},{"line_number":661,"context_line":"        calls \u003d []"},{"line_number":662,"context_line":"        for stale_devname in stale_devnames:"},{"line_number":663,"context_line":"            calls.append(mock.call(stale_devname,"},{"line_number":664,"context_line":"                                   namespace\u003dri.ns_name(),"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2FnuY%3D","line":661,"in_reply_to":"AAAAUX%2F%2F47I%3D","updated":"2014-02-13 15:14:59.000000000","message":"Thanks, this will be done in the next patch.","commit_id":"bd39d4c3063f9dcb5d62ede24dcc885714a80dee"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"cd5445c069cbca8831a1839b3db014451dd92bcd","unresolved":false,"context_lines":[{"line_number":753,"context_line":"        self.assertEqual(len(internal_ports), 1)"},{"line_number":754,"context_line":"        internal_port \u003d internal_ports[0]"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"        with mock.patch.object("},{"line_number":757,"context_line":"            l3_agent.L3NATAgent,"},{"line_number":758,"context_line":"            \u0027internal_network_removed\u0027) as internal_network_removed:"},{"line_number":759,"context_line":"            with mock.patch.object("}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2FQxQ%3D","line":756,"updated":"2014-02-14 12:44:10.000000000","message":"Can a nested with be used here to reduce indentation?","commit_id":"3562b559cd0050ac592d057bf35da1b18af98657"},{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"ff631185241f014c5b497677e5a7b6ae024efbb4","unresolved":false,"context_lines":[{"line_number":753,"context_line":"        self.assertEqual(len(internal_ports), 1)"},{"line_number":754,"context_line":"        internal_port \u003d internal_ports[0]"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"        with mock.patch.object("},{"line_number":757,"context_line":"            l3_agent.L3NATAgent,"},{"line_number":758,"context_line":"            \u0027internal_network_removed\u0027) as internal_network_removed:"},{"line_number":759,"context_line":"            with mock.patch.object("}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2FGwQ%3D","line":756,"in_reply_to":"AAAAUX%2F%2FQxQ%3D","updated":"2014-02-17 05:01:52.000000000","message":"I will use contextlib.nested(...) in the next patch.","commit_id":"3562b559cd0050ac592d057bf35da1b18af98657"}]}
