)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d26714c0c6f62a673f9c071d04d5a02808a6d17d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"cost of running the more expensive _recycle_ip operation for every"},{"line_number":20,"context_line":"port delete."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"IP allocation behaves a bit differently with this patch.  Instead of"},{"line_number":23,"context_line":"giving out the first IP available in a pool, the entire pool will be"},{"line_number":24,"context_line":"allocated before wrapping around and recycling ip addresses that have"},{"line_number":25,"context_line":"been released.  This is a desirable feature as it puts ip addresses in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"AAAAUH%2F%2Fou8%3D","line":22,"updated":"2014-01-10 08:43:34.000000000","message":"In light of this change of semantics, is it worth revising docstrings in models_v2, especially for IPAvailabilityRange?","commit_id":"66b5a500f63202157faecfeca6ef0eef73fbd70b"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"d8ca7d1c0a78047fae1519e02b47d5c84a90be4f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"cost of running the more expensive _recycle_ip operation for every"},{"line_number":20,"context_line":"port delete."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"IP allocation behaves a bit differently with this patch.  Instead of"},{"line_number":23,"context_line":"giving out the first IP available in a pool, the entire pool will be"},{"line_number":24,"context_line":"allocated before wrapping around and recycling ip addresses that have"},{"line_number":25,"context_line":"been released.  This is a desirable feature as it puts ip addresses in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"AAAAUH%2F%2FbKc%3D","line":22,"in_reply_to":"AAAAUH%2F%2Fou8%3D","updated":"2014-01-13 22:40:04.000000000","message":"Yes.  I will do so.  Thank you for bringing those to my attention.","commit_id":"66b5a500f63202157faecfeca6ef0eef73fbd70b"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0aba513f8476fde62a40b020dda86ae77b8f719e","unresolved":false,"context_lines":[{"line_number":364,"context_line":"    @staticmethod"},{"line_number":365,"context_line":"    def _generate_ip(context, subnets):"},{"line_number":366,"context_line":"        try:"},{"line_number":367,"context_line":"            return NeutronDbPluginV2._generate_ip_work(context, subnets)"},{"line_number":368,"context_line":"        except q_exc.IpAddressGenerationFailure:"},{"line_number":369,"context_line":"            NeutronDbPluginV2._rebuild_availability_ranges(context, subnets)"},{"line_number":370,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2BDao%3D","line":367,"updated":"2013-12-03 02:03:32.000000000","message":"I prefer _try_generate_ip","commit_id":"1880bdbf1f6ce88fdd39f06c42ef55720368207c"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"fe73291ff6d54a1040f63fdcff9be094cf8b4743","unresolved":false,"context_lines":[{"line_number":364,"context_line":"    @staticmethod"},{"line_number":365,"context_line":"    def _generate_ip(context, subnets):"},{"line_number":366,"context_line":"        try:"},{"line_number":367,"context_line":"            return NeutronDbPluginV2._generate_ip_work(context, subnets)"},{"line_number":368,"context_line":"        except q_exc.IpAddressGenerationFailure:"},{"line_number":369,"context_line":"            NeutronDbPluginV2._rebuild_availability_ranges(context, subnets)"},{"line_number":370,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9%2FVo%3D","line":367,"in_reply_to":"AAAATn%2F%2BDao%3D","updated":"2013-12-03 18:21:50.000000000","message":"Done","commit_id":"1880bdbf1f6ce88fdd39f06c42ef55720368207c"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"20cab435b53885e03926166806ca3674f4cb9971","unresolved":false,"context_lines":[{"line_number":417,"context_line":"            allocations \u003d netaddr.IPSet([netaddr.IPAddress(i[\u0027ip_address\u0027])"},{"line_number":418,"context_line":"                                        for i in ip_qry_results])"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"            for pool in pool_qry.filter_by(subnet_id\u003dsubnet[\u0027id\u0027]):"},{"line_number":421,"context_line":"                # Create a set of all addresses in the pool"},{"line_number":422,"context_line":"                poolset \u003d netaddr.IPSet(netaddr.iter_iprange(pool[\u0027first_ip\u0027],"},{"line_number":423,"context_line":"                                                             pool[\u0027last_ip\u0027]))"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F9f1U%3D","line":420,"updated":"2013-12-10 22:13:51.000000000","message":"Tempest tests are throwing exception here.\n\n2013-12-03 23:51:40.399 594 ERROR neutron.api.v2.resource [req-3513c7da-78ad-4567-9224-ccd97de3f08d 133907a96d1f4b869cf28c673155b87a b7061f9894ef4c54a2b53daad1370efe] create failed\n...\n2013-12-03 23:51:40.399 594 TRACE neutron.api.v2.resource NotSupportedError: (NotSupportedError) SELECT FOR UPDATE/SHARE cannot be applied to the nullable side of an outer join\n2013-12-03 23:51:40.399 594 TRACE neutron.api.v2.resource  \u0027SELECT ipallocationpools.id AS ipallocationpools_id, ipallocationpools.subnet_id AS ipallocationpools_subnet_id, ipallocationpools.first_ip AS ipallocationpools_first_ip, ipallocationpools.last_ip AS ipallocationpools_last_ip, ipavailabilityranges_1.allocation_pool_id AS ipavailabilityranges_1_allocation_pool_id, ipavailabilityranges_1.first_ip AS ipavailabilityranges_1_first_ip, ipavailabilityranges_1.last_ip AS ipavailabilityranges_1_last_ip \\nFROM ipallocationpools LEFT OUTER JOIN ipavailabilityranges AS ipavailabilityranges_1 ON ipallocationpools.id \u003d ipavailabilityranges_1.allocation_pool_id \\nWHERE ipallocationpools.subnet_id \u003d %(subnet_id_1)s FOR UPDATE\u0027 {\u0027subnet_id_1\u0027: u\u0027862c6d7a-9aec-489b-aa23-09e4ef27ab9a\u0027}","commit_id":"55e6d2f1343976f847f8c3ef9824c514a0dfe8c7"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"661344d714cbc26e6f13a4a4d89081dfc47d4392","unresolved":false,"context_lines":[{"line_number":417,"context_line":"            allocations \u003d netaddr.IPSet([netaddr.IPAddress(i[\u0027ip_address\u0027])"},{"line_number":418,"context_line":"                                        for i in ip_qry_results])"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"            for pool in pool_qry.filter_by(subnet_id\u003dsubnet[\u0027id\u0027]):"},{"line_number":421,"context_line":"                # Create a set of all addresses in the pool"},{"line_number":422,"context_line":"                poolset \u003d netaddr.IPSet(netaddr.iter_iprange(pool[\u0027first_ip\u0027],"},{"line_number":423,"context_line":"                                                             pool[\u0027last_ip\u0027]))"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F9frI%3D","line":420,"in_reply_to":"AAAATn%2F9f1U%3D","updated":"2013-12-10 22:40:26.000000000","message":"I see a pretty complex work-around for the same query in _recycle_ip (deleted by this patch).  It was for bug 1215350.  Looks like the same issue here with essentially the same query.\n\nI\u0027m wondering if this code here needs .with_lockmode(\u0027update\u0027) at all.  IPAllocationPool is not changing but we\u0027re inserting into IPAvailabilityRange.  Feedback would be welcome.  I\u0027ll give it some more thought.","commit_id":"55e6d2f1343976f847f8c3ef9824c514a0dfe8c7"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"c932bc772523b29dc1b7c8cec051f21ef5e4e16b","unresolved":false,"context_lines":[{"line_number":411,"context_line":"        # No join is needed here."},{"line_number":412,"context_line":"        pool_qry \u003d context.session.query("},{"line_number":413,"context_line":"            models_v2.IPAllocationPool).options("},{"line_number":414,"context_line":"                orm.noload(\u0027available_ranges\u0027)).with_lockmode(\u0027update\u0027)"},{"line_number":415,"context_line":"        for subnet in subnets:"},{"line_number":416,"context_line":"            LOG.debug(_(\"Rebuilding availability ranges for subnet %s\")"},{"line_number":417,"context_line":"                      % subnet)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F9a%2B0%3D","line":414,"updated":"2013-12-11 17:43:27.000000000","message":"In case you\u0027re wondering.  An inner join won\u0027t work here.  We got here because available_ranges is empty.  An inner join would also come up empty.","commit_id":"2096d06c51e570829164c509bec7acd8960d2660"},{"author":{"_account_id":7930,"name":"jun xie","email":"easonxie160@163.com","username":"jeffreycoho"},"change_message_id":"174fafebf9c497a29e9ba713a34ae9d30a11dd27","unresolved":false,"context_lines":[{"line_number":324,"context_line":"        \"\"\"Return an IP address to the pool of free IP\u0027s on the network"},{"line_number":325,"context_line":"        subnet."},{"line_number":326,"context_line":"        \"\"\""},{"line_number":327,"context_line":"        NeutronDbPluginV2._delete_ip_allocation(context, network_id, subnet_id,"},{"line_number":328,"context_line":"                                                ip_address)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def update_fixed_ip_lease_expiration(self, context, network_id,"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAT3%2F%2Fzbg%3D","line":327,"updated":"2013-12-31 06:16:35.000000000","message":"then I think we should also modify the logic near Line 1397-1414(in _delete_port()), since calling _recycle_ip() is basically the same with _delete_ip_allocation(). Or we could just delete\n_recycle_ip() and use  _delete_ip_allocation() instead","commit_id":"ec8b7375113f63a8967305d27aba7f93ad84b05d"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"20bd581cfd078c82dd573726c4af9d40be51c7af","unresolved":false,"context_lines":[{"line_number":324,"context_line":"        \"\"\"Return an IP address to the pool of free IP\u0027s on the network"},{"line_number":325,"context_line":"        subnet."},{"line_number":326,"context_line":"        \"\"\""},{"line_number":327,"context_line":"        NeutronDbPluginV2._delete_ip_allocation(context, network_id, subnet_id,"},{"line_number":328,"context_line":"                                                ip_address)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def update_fixed_ip_lease_expiration(self, context, network_id,"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAT3%2F%2Fuc8%3D","line":327,"in_reply_to":"AAAAT3%2F%2Fzbg%3D","updated":"2014-01-02 22:20:16.000000000","message":"I had considered this.  I chose not to remove _recycle_ip because it changes the interface which is used in at least one plugin.  I wanted to limit the scope of this change.  I\u0027ll post a follow-on patch to remove _recycle_ip as a pure refactor.","commit_id":"ec8b7375113f63a8967305d27aba7f93ad84b05d"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"779add7e81e9261f002a871d1a8c7f05c519bc76","unresolved":false,"context_lines":[{"line_number":412,"context_line":"        pool_qry \u003d context.session.query("},{"line_number":413,"context_line":"            models_v2.IPAllocationPool).options("},{"line_number":414,"context_line":"                orm.noload(\u0027available_ranges\u0027)).with_lockmode(\u0027update\u0027)"},{"line_number":415,"context_line":"        for subnet in subnets:"},{"line_number":416,"context_line":"            LOG.debug(_(\"Rebuilding availability ranges for subnet %s\")"},{"line_number":417,"context_line":"                      % subnet)"},{"line_number":418,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAT3%2F%2F7CM%3D","line":415,"updated":"2013-12-27 03:22:17.000000000","message":"sorted(subnets) instead of subnets to avoid deadlock?","commit_id":"ec8b7375113f63a8967305d27aba7f93ad84b05d"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"20bd581cfd078c82dd573726c4af9d40be51c7af","unresolved":false,"context_lines":[{"line_number":412,"context_line":"        pool_qry \u003d context.session.query("},{"line_number":413,"context_line":"            models_v2.IPAllocationPool).options("},{"line_number":414,"context_line":"                orm.noload(\u0027available_ranges\u0027)).with_lockmode(\u0027update\u0027)"},{"line_number":415,"context_line":"        for subnet in subnets:"},{"line_number":416,"context_line":"            LOG.debug(_(\"Rebuilding availability ranges for subnet %s\")"},{"line_number":417,"context_line":"                      % subnet)"},{"line_number":418,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAT3%2F%2Fuac%3D","line":415,"in_reply_to":"AAAAT3%2F%2F7CM%3D","updated":"2014-01-02 22:20:16.000000000","message":"Done","commit_id":"ec8b7375113f63a8967305d27aba7f93ad84b05d"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"88f0d3dbf4c02e91adc99319fe9a11d645be1e37","unresolved":false,"context_lines":[{"line_number":430,"context_line":"                available \u003d poolset - allocations"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"                # Compact the cidrs from the set in to contiguous ranges"},{"line_number":433,"context_line":"                ranges \u003d []"},{"line_number":434,"context_line":"                for cidr in available.iter_cidrs():"},{"line_number":435,"context_line":"                    if ranges and cidr.first \u003d\u003d ranges[-1][1] + 1:"},{"line_number":436,"context_line":"                        ranges[-1][1] \u003d cidr.last"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAT3%2F%2F0Wo%3D","line":433,"updated":"2013-12-30 22:17:10.000000000","message":"if we used a dict for ranges instead of a list I think the following snippet of code would be a lot more readable.","commit_id":"ec8b7375113f63a8967305d27aba7f93ad84b05d"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"20bd581cfd078c82dd573726c4af9d40be51c7af","unresolved":false,"context_lines":[{"line_number":430,"context_line":"                available \u003d poolset - allocations"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"                # Compact the cidrs from the set in to contiguous ranges"},{"line_number":433,"context_line":"                ranges \u003d []"},{"line_number":434,"context_line":"                for cidr in available.iter_cidrs():"},{"line_number":435,"context_line":"                    if ranges and cidr.first \u003d\u003d ranges[-1][1] + 1:"},{"line_number":436,"context_line":"                        ranges[-1][1] \u003d cidr.last"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAT3%2F%2FuKM%3D","line":433,"in_reply_to":"AAAAT3%2F%2F0Wo%3D","updated":"2014-01-02 22:20:16.000000000","message":"I don\u0027t see that using a dict makes it more readable.  It seems unnatural to use a dict to me which would make it less readable.\n\nNonetheless, your point is taken that readability could be improved here.","commit_id":"ec8b7375113f63a8967305d27aba7f93ad84b05d"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d26714c0c6f62a673f9c071d04d5a02808a6d17d","unresolved":false,"context_lines":[{"line_number":430,"context_line":"                available \u003d poolset - allocations"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"                # Generator compacts an ip set into contiguous ranges"},{"line_number":433,"context_line":"                def ipset_to_ranges(ipset):"},{"line_number":434,"context_line":"                    first, last \u003d None, None"},{"line_number":435,"context_line":"                    for cidr in ipset.iter_cidrs():"},{"line_number":436,"context_line":"                        if last and last + 1 !\u003d cidr.first:"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAUH%2F%2Fowc%3D","line":433,"updated":"2014-01-10 08:43:34.000000000","message":"Feel free to ignore: is it worth considering making this a non-nested method and test it separately?","commit_id":"66b5a500f63202157faecfeca6ef0eef73fbd70b"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"d8ca7d1c0a78047fae1519e02b47d5c84a90be4f","unresolved":false,"context_lines":[{"line_number":430,"context_line":"                available \u003d poolset - allocations"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"                # Generator compacts an ip set into contiguous ranges"},{"line_number":433,"context_line":"                def ipset_to_ranges(ipset):"},{"line_number":434,"context_line":"                    first, last \u003d None, None"},{"line_number":435,"context_line":"                    for cidr in ipset.iter_cidrs():"},{"line_number":436,"context_line":"                        if last and last + 1 !\u003d cidr.first:"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAUH%2F%2FbGw%3D","line":433,"in_reply_to":"AAAAUH%2F%2Fowc%3D","updated":"2014-01-13 22:40:04.000000000","message":"I will take a look as time constraints permit.  I think you make a good point.","commit_id":"66b5a500f63202157faecfeca6ef0eef73fbd70b"}],"neutron/tests/unit/nicira/test_networkgw.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"cb84e399b9b1ed27f1192a985984b1a7932db5f3","unresolved":false,"context_lines":[{"line_number":521,"context_line":"                                     \u0027vlan\u0027, 555,"},{"line_number":522,"context_line":"                                     expected_status\u003dexc.HTTPBadRequest.code)"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"    def test_connect_network_does_not_waste_ips(self):"},{"line_number":525,"context_line":"        # Ensure address is immediately recycled"},{"line_number":526,"context_line":"        cfg.CONF.set_override(\u0027dhcp_lease_duration\u0027, -1)"},{"line_number":527,"context_line":"        with self._network_gateway() as gw:"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAUH%2F%2Fw%2Fw%3D","side":"PARENT","line":524,"updated":"2014-01-08 18:17:03.000000000","message":"why did you remove this test?","commit_id":"bf8bf46cbbe7428c9a12886604fe5aa10019aaec"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"d8ca7d1c0a78047fae1519e02b47d5c84a90be4f","unresolved":false,"context_lines":[{"line_number":521,"context_line":"                                     \u0027vlan\u0027, 555,"},{"line_number":522,"context_line":"                                     expected_status\u003dexc.HTTPBadRequest.code)"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"    def test_connect_network_does_not_waste_ips(self):"},{"line_number":525,"context_line":"        # Ensure address is immediately recycled"},{"line_number":526,"context_line":"        cfg.CONF.set_override(\u0027dhcp_lease_duration\u0027, -1)"},{"line_number":527,"context_line":"        with self._network_gateway() as gw:"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAUH%2F%2FbIw%3D","side":"PARENT","line":524,"in_reply_to":"AAAAUH%2F%2Fq6g%3D","updated":"2014-01-13 22:40:04.000000000","message":"Agree with enikanorov","commit_id":"bf8bf46cbbe7428c9a12886604fe5aa10019aaec"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"8ec0f28d815010244f804396fc3df0b1ce9a0773","unresolved":false,"context_lines":[{"line_number":521,"context_line":"                                     \u0027vlan\u0027, 555,"},{"line_number":522,"context_line":"                                     expected_status\u003dexc.HTTPBadRequest.code)"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"    def test_connect_network_does_not_waste_ips(self):"},{"line_number":525,"context_line":"        # Ensure address is immediately recycled"},{"line_number":526,"context_line":"        cfg.CONF.set_override(\u0027dhcp_lease_duration\u0027, -1)"},{"line_number":527,"context_line":"        with self._network_gateway() as gw:"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAUH%2F%2Fq6g%3D","side":"PARENT","line":524,"in_reply_to":"AAAAUH%2F%2Fw%2Fw%3D","updated":"2014-01-09 20:06:26.000000000","message":"that test explicitly awaits released ip to be reused in the following allocation. with the new allocation logic it is not the case anymore.","commit_id":"bf8bf46cbbe7428c9a12886604fe5aa10019aaec"}],"neutron/tests/unit/test_db_plugin.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"88f0d3dbf4c02e91adc99319fe9a11d645be1e37","unresolved":false,"context_lines":[{"line_number":3513,"context_line":"        self.assertEqual(actual_repr_output, final_exp)"},{"line_number":3514,"context_line":""},{"line_number":3515,"context_line":""},{"line_number":3516,"context_line":"class TestNeutronDbPluginV2(base.BaseTestCase):"},{"line_number":3517,"context_line":"    \"\"\"Tests for NeutronDbPluginV2 that are not based on WebTestCase"},{"line_number":3518,"context_line":""},{"line_number":3519,"context_line":"    While NeutronDbPluginV2TestCase checks NeutronDbPlugin and all plugins as"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAT3%2F%2F0UE%3D","line":3516,"updated":"2013-12-30 22:17:10.000000000","message":"Wouldn\u0027t it be more intuitive if we called this testcase IPAMLogicTestCase or similar? That would make a docstring less useful to understand why this class name does not follow the usual naming convention.","commit_id":"ec8b7375113f63a8967305d27aba7f93ad84b05d"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"88f0d3dbf4c02e91adc99319fe9a11d645be1e37","unresolved":false,"context_lines":[{"line_number":3569,"context_line":"                       {\u0027ip_address\u0027: \u0027192.168.1.4\u0027},"},{"line_number":3570,"context_line":"                       {\u0027ip_address\u0027: \u0027192.168.1.111\u0027}]"},{"line_number":3571,"context_line":""},{"line_number":3572,"context_line":"        ip_qry \u003d mock.Mock()"},{"line_number":3573,"context_line":"        ip_qry.with_lockmode.return_value \u003d ip_qry"},{"line_number":3574,"context_line":"        ip_qry.filter_by.return_value \u003d allocations"},{"line_number":3575,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAT3%2F%2F0P8%3D","line":3572,"updated":"2013-12-30 22:17:10.000000000","message":"why mocking the db queries? Have you considered using an actual db backend as other db related tests do?","commit_id":"ec8b7375113f63a8967305d27aba7f93ad84b05d"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"9922170e0358e5cd55113d1c5938c184554d8963","unresolved":false,"context_lines":[{"line_number":3569,"context_line":"                       {\u0027ip_address\u0027: \u0027192.168.1.4\u0027},"},{"line_number":3570,"context_line":"                       {\u0027ip_address\u0027: \u0027192.168.1.111\u0027}]"},{"line_number":3571,"context_line":""},{"line_number":3572,"context_line":"        ip_qry \u003d mock.Mock()"},{"line_number":3573,"context_line":"        ip_qry.with_lockmode.return_value \u003d ip_qry"},{"line_number":3574,"context_line":"        ip_qry.filter_by.return_value \u003d allocations"},{"line_number":3575,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F%2FbOA%3D","line":3572,"in_reply_to":"AAAAT3%2F%2F0P8%3D","updated":"2014-01-13 22:29:11.000000000","message":"I had a couple of reasons.  First was that the purpose for this test was to test the logic in the method, not necessarily the database queries.  Second is that I\u0027m much more familiar with this style of testing than I am testing against an actual db backend.  It would take me quite a bit of work to convert it.","commit_id":"ec8b7375113f63a8967305d27aba7f93ad84b05d"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d26714c0c6f62a673f9c071d04d5a02808a6d17d","unresolved":false,"context_lines":[{"line_number":3513,"context_line":"        self.assertEqual(actual_repr_output, final_exp)"},{"line_number":3514,"context_line":""},{"line_number":3515,"context_line":""},{"line_number":3516,"context_line":"class TestNeutronDbPluginV2(base.BaseTestCase):"},{"line_number":3517,"context_line":"    \"\"\"Unit Tests for NeutronDbPluginV2 IPAM Logic.\"\"\""},{"line_number":3518,"context_line":""},{"line_number":3519,"context_line":"    def test_generate_ip(self):"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAUH%2F%2Foss%3D","line":3516,"updated":"2014-01-10 08:43:34.000000000","message":"Would you mind going over my unaddressed questions on patchset 11? As for using actual DB ops, I think the benefit there is that you\u0027ll end up needing a lot less mock-ing.","commit_id":"66b5a500f63202157faecfeca6ef0eef73fbd70b"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"d8ca7d1c0a78047fae1519e02b47d5c84a90be4f","unresolved":false,"context_lines":[{"line_number":3513,"context_line":"        self.assertEqual(actual_repr_output, final_exp)"},{"line_number":3514,"context_line":""},{"line_number":3515,"context_line":""},{"line_number":3516,"context_line":"class TestNeutronDbPluginV2(base.BaseTestCase):"},{"line_number":3517,"context_line":"    \"\"\"Unit Tests for NeutronDbPluginV2 IPAM Logic.\"\"\""},{"line_number":3518,"context_line":""},{"line_number":3519,"context_line":"    def test_generate_ip(self):"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAUH%2F%2Fa%2F0%3D","line":3516,"in_reply_to":"AAAAUH%2F%2Foss%3D","updated":"2014-01-13 22:40:04.000000000","message":"Not at all.  Very sorry I did not respond to that.  My response is on patch 11.","commit_id":"66b5a500f63202157faecfeca6ef0eef73fbd70b"}]}
