)]}'
{"neutron/agent/l3_agent.py":[{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"4cda992dcca81a1f1be4e7f21a2a6ad103f33108","unresolved":false,"context_lines":[{"line_number":484,"context_line":"    def _get_ex_gw_port(self, ri):"},{"line_number":485,"context_line":"        return ri.router.get(\u0027gw_port\u0027)"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"    def _arping(self, ri, interface_name, ip_address):"},{"line_number":488,"context_line":"        arping_cmd \u003d [\u0027arping\u0027, \u0027-A\u0027,"},{"line_number":489,"context_line":"                      \u0027-I\u0027, interface_name,"},{"line_number":490,"context_line":"                      \u0027-c\u0027, self.conf.send_arp_for_ha,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BWT8%3D","side":"PARENT","line":487,"updated":"2013-11-27 03:12:10.000000000","message":"I\u0027m not really following why this was deleted and folded into _send_gratuitous_arp_packet. Was this patch extracted from an earlier version of Neutron, perhaps a merge conflict solved incorrectly?","commit_id":"c655156b98a0a25568a3745e114a0bae41bc49d1"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"66919e571b4154ce5f2517dc71f338540c235c56","unresolved":false,"context_lines":[{"line_number":418,"context_line":"        ri.iptables_manager.defer_apply_off()"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    # Shixiong"},{"line_number":422,"context_line":"    def _handle_router_snat_rules(self, ri, ex_gw_port, internal_cidrs,"},{"line_number":423,"context_line":"                                  interface_name, action):"},{"line_number":424,"context_line":"        # Remove all the rules"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BhKw%3D","line":421,"updated":"2013-11-25 08:36:47.000000000","message":"Please remove this line","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"},{"author":{"_account_id":9464,"name":"Shixiong Shang","email":"sparkofwisdom.cloud@gmail.com","username":"sparkofwisdom.cloud"},"change_message_id":"faeb8e94ff7ce1d1b65a497cd9bb4fce3e5f8c1b","unresolved":false,"context_lines":[{"line_number":418,"context_line":"        ri.iptables_manager.defer_apply_off()"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    # Shixiong"},{"line_number":422,"context_line":"    def _handle_router_snat_rules(self, ri, ex_gw_port, internal_cidrs,"},{"line_number":423,"context_line":"                                  interface_name, action):"},{"line_number":424,"context_line":"        # Remove all the rules"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BXDE%3D","line":421,"in_reply_to":"AAAATn%2F%2BhKw%3D","updated":"2013-11-26 23:22:34.000000000","message":"Apologize...I will remove all of these comments.","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"4cda992dcca81a1f1be4e7f21a2a6ad103f33108","unresolved":false,"context_lines":[{"line_number":434,"context_line":"        # And add them back if the action if add_rules"},{"line_number":435,"context_line":"        if action \u003d\u003d \u0027add_rules\u0027 and ex_gw_port:"},{"line_number":436,"context_line":"            # ex_gw_port should not be None in this case"},{"line_number":437,"context_line":"            #ex_gw_ip \u003d ex_gw_port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"            net \u003d netaddr.IPNetwork(internal_cidrs)"},{"line_number":440,"context_line":"            if net.version \u003d\u003d 4:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BWUg%3D","line":437,"updated":"2013-11-27 03:12:10.000000000","message":"Delete instead of commenting out","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"7d257b7a54a8fb3bab19b9e506d389aeac17a073","unresolved":false,"context_lines":[{"line_number":517,"context_line":"        return (EXTERNAL_DEV_PREFIX + port_id)[:self.driver.DEV_NAME_LEN]"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"    # Randy"},{"line_number":521,"context_line":"    def external_gateway_added(self, ri, ex_gw_port,"},{"line_number":522,"context_line":"                               interface_name, internal_cidrs):"},{"line_number":523,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BgbA%3D","line":520,"updated":"2013-11-25 11:48:20.000000000","message":"Several of these comment lines should be pulled. 614, L627","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"},{"author":{"_account_id":9464,"name":"Shixiong Shang","email":"sparkofwisdom.cloud@gmail.com","username":"sparkofwisdom.cloud"},"change_message_id":"faeb8e94ff7ce1d1b65a497cd9bb4fce3e5f8c1b","unresolved":false,"context_lines":[{"line_number":517,"context_line":"        return (EXTERNAL_DEV_PREFIX + port_id)[:self.driver.DEV_NAME_LEN]"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"    # Randy"},{"line_number":521,"context_line":"    def external_gateway_added(self, ri, ex_gw_port,"},{"line_number":522,"context_line":"                               interface_name, internal_cidrs):"},{"line_number":523,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BXC8%3D","line":520,"in_reply_to":"AAAATn%2F%2BgbA%3D","updated":"2013-11-26 23:22:34.000000000","message":"Hi, Paul, sorry about the comments. I will remove all of them.","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"7d257b7a54a8fb3bab19b9e506d389aeac17a073","unresolved":false,"context_lines":[{"line_number":533,"context_line":"        self.driver.init_l3(interface_name, [ex_gw_port[\u0027ip_cidr\u0027]],"},{"line_number":534,"context_line":"                            namespace\u003dri.ns_name())"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"        parm \u003d \"net.ipv6.conf.%s.accept_ra\u003d2\" % str(interface_name)"},{"line_number":537,"context_line":"        cmd \u003d [\u0027sysctl\u0027, parm]"},{"line_number":538,"context_line":"        if self.conf.use_namespaces:"},{"line_number":539,"context_line":"           ip_wrapper \u003d ip_lib.IPWrapper(self.conf.root_helper,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BgaY%3D","line":536,"updated":"2013-11-25 11:48:20.000000000","message":"In L536-566 and 643-671, the code looks the same (except for parm). Extract out a helper function and used it in these places.","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"},{"author":{"_account_id":9464,"name":"Shixiong Shang","email":"sparkofwisdom.cloud@gmail.com","username":"sparkofwisdom.cloud"},"change_message_id":"faeb8e94ff7ce1d1b65a497cd9bb4fce3e5f8c1b","unresolved":false,"context_lines":[{"line_number":533,"context_line":"        self.driver.init_l3(interface_name, [ex_gw_port[\u0027ip_cidr\u0027]],"},{"line_number":534,"context_line":"                            namespace\u003dri.ns_name())"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"        parm \u003d \"net.ipv6.conf.%s.accept_ra\u003d2\" % str(interface_name)"},{"line_number":537,"context_line":"        cmd \u003d [\u0027sysctl\u0027, parm]"},{"line_number":538,"context_line":"        if self.conf.use_namespaces:"},{"line_number":539,"context_line":"           ip_wrapper \u003d ip_lib.IPWrapper(self.conf.root_helper,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BXCc%3D","line":536,"in_reply_to":"AAAATn%2F%2BgaY%3D","updated":"2013-11-26 23:22:34.000000000","message":"You are right. I will build a method and pass \"parm\" as input.","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"}],"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"66919e571b4154ce5f2517dc71f338540c235c56","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# Shixiong"},{"line_number":41,"context_line":"OPTS \u003d ["},{"line_number":42,"context_line":"    cfg.StrOpt(\u0027dhcp_confs\u0027,"},{"line_number":43,"context_line":"               default\u003d\u0027$state_path/dhcp\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BhN4%3D","line":40,"updated":"2013-11-25 08:36:47.000000000","message":"Please remove this line","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"},{"author":{"_account_id":9464,"name":"Shixiong Shang","email":"sparkofwisdom.cloud@gmail.com","username":"sparkofwisdom.cloud"},"change_message_id":"faeb8e94ff7ce1d1b65a497cd9bb4fce3e5f8c1b","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# Shixiong"},{"line_number":41,"context_line":"OPTS \u003d ["},{"line_number":42,"context_line":"    cfg.StrOpt(\u0027dhcp_confs\u0027,"},{"line_number":43,"context_line":"               default\u003d\u0027$state_path/dhcp\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BXLI%3D","line":40,"in_reply_to":"AAAATn%2F%2BhN4%3D","updated":"2013-11-26 23:22:34.000000000","message":"Sorry, I left those markers. Will remove them all.","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"7d257b7a54a8fb3bab19b9e506d389aeac17a073","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            self.interface_name \u003d interface_name"},{"line_number":176,"context_line":"            self.spawn_process()"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    # Shixiong"},{"line_number":179,"context_line":"    def disable(self, retain_port\u003dFalse):"},{"line_number":180,"context_line":"        \"\"\"Disable DHCP for this network by killing the local process.\"\"\""},{"line_number":181,"context_line":"        pid \u003d self.pid"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BgaQ%3D","line":178,"updated":"2013-11-25 11:48:20.000000000","message":"Moire comments to remove.","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"},{"author":{"_account_id":9464,"name":"Shixiong Shang","email":"sparkofwisdom.cloud@gmail.com","username":"sparkofwisdom.cloud"},"change_message_id":"faeb8e94ff7ce1d1b65a497cd9bb4fce3e5f8c1b","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            self.interface_name \u003d interface_name"},{"line_number":176,"context_line":"            self.spawn_process()"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    # Shixiong"},{"line_number":179,"context_line":"    def disable(self, retain_port\u003dFalse):"},{"line_number":180,"context_line":"        \"\"\"Disable DHCP for this network by killing the local process.\"\"\""},{"line_number":181,"context_line":"        pid \u003d self.pid"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BXK8%3D","line":178,"in_reply_to":"AAAATn%2F%2BgaQ%3D","updated":"2013-11-26 23:22:34.000000000","message":"Hi, Paul, apologize, I left those comments here. Will remove them all.","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"66919e571b4154ce5f2517dc71f338540c235c56","unresolved":false,"context_lines":[{"line_number":327,"context_line":"            else:"},{"line_number":328,"context_line":"                set_tag \u003d \u0027\u0027"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"            if subnet.ip_version \u003d\u003d 4:"},{"line_number":331,"context_line":"                cmd \u003d ["},{"line_number":332,"context_line":"                \u0027dnsmasq\u0027,"},{"line_number":333,"context_line":"                \u0027--no-hosts\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BhNk%3D","line":330,"updated":"2013-11-25 08:36:47.000000000","message":"I think the same cmd properties between 4 and 6 can be  merged together.","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"},{"author":{"_account_id":9464,"name":"Shixiong Shang","email":"sparkofwisdom.cloud@gmail.com","username":"sparkofwisdom.cloud"},"change_message_id":"faeb8e94ff7ce1d1b65a497cd9bb4fce3e5f8c1b","unresolved":false,"context_lines":[{"line_number":327,"context_line":"            else:"},{"line_number":328,"context_line":"                set_tag \u003d \u0027\u0027"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"            if subnet.ip_version \u003d\u003d 4:"},{"line_number":331,"context_line":"                cmd \u003d ["},{"line_number":332,"context_line":"                \u0027dnsmasq\u0027,"},{"line_number":333,"context_line":"                \u0027--no-hosts\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BXFs%3D","line":330,"in_reply_to":"AAAATn%2F%2BhNk%3D","updated":"2013-11-26 23:22:34.000000000","message":"Yes, you are right. I will create common command line and append IP version specific commands.","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"66919e571b4154ce5f2517dc71f338540c235c56","unresolved":false,"context_lines":[{"line_number":348,"context_line":"                       (set_tag, self._TAG_PREFIX % i,"},{"line_number":349,"context_line":"                        netaddr.IPNetwork(subnet.cidr).network,"},{"line_number":350,"context_line":"                        mode,"},{"line_number":351,"context_line":"                        self.conf.dhcp_lease_time))"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"                cmd.append(\u0027--conf-file\u003d%s\u0027 % self.conf.dnsmasq_config_file)"},{"line_number":354,"context_line":"                if self.conf.dnsmasq_dns_server:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BhNI%3D","line":351,"updated":"2013-11-25 08:36:47.000000000","message":"this code from line 347-351 also can be put together with line 391-395","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"66919e571b4154ce5f2517dc71f338540c235c56","unresolved":false,"context_lines":[{"line_number":386,"context_line":"                \u0027--leasefile-ro\u0027,"},{"line_number":387,"context_line":"                \u0027--enable-ra\u0027,"},{"line_number":388,"context_line":"                ]"},{"line_number":389,"context_line":"                mode \u003d \u0027slaac\u0027"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"                cmd.append(\u0027--dhcp-range\u003d%s%s,%s,%s,%ss\u0027 %"},{"line_number":392,"context_line":"                       (set_tag, self._TAG_PREFIX % i,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BhM8%3D","line":389,"updated":"2013-11-25 08:36:47.000000000","message":"you just consider the dhcp mode as slaac, what about ra-only, ra-stateless and ra-names?","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"},{"author":{"_account_id":9464,"name":"Shixiong Shang","email":"sparkofwisdom.cloud@gmail.com","username":"sparkofwisdom.cloud"},"change_message_id":"faeb8e94ff7ce1d1b65a497cd9bb4fce3e5f8c1b","unresolved":false,"context_lines":[{"line_number":386,"context_line":"                \u0027--leasefile-ro\u0027,"},{"line_number":387,"context_line":"                \u0027--enable-ra\u0027,"},{"line_number":388,"context_line":"                ]"},{"line_number":389,"context_line":"                mode \u003d \u0027slaac\u0027"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"                cmd.append(\u0027--dhcp-range\u003d%s%s,%s,%s,%ss\u0027 %"},{"line_number":392,"context_line":"                       (set_tag, self._TAG_PREFIX % i,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BXEs%3D","line":389,"in_reply_to":"AAAATn%2F%2BhM8%3D","updated":"2013-11-26 23:22:34.000000000","message":"We were testing SLAAC only without any DHCP or DNS servers. I believe \"ra-only\" also works too. However, I don\u0027t believe we have CLI command to allow customer to specify different variety yet. So only left \"slaac\" in the code...","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"66919e571b4154ce5f2517dc71f338540c235c56","unresolved":false,"context_lines":[{"line_number":397,"context_line":"                cmd.append(\u0027--dhcp-range\u003d%s%s,%s,%s,%ss\u0027 %"},{"line_number":398,"context_line":"                       (set_tag, self._TAG_PREFIX % i,"},{"line_number":399,"context_line":"                        \u00271.1.1.1\u0027,"},{"line_number":400,"context_line":"                        \u0027static\u0027,"},{"line_number":401,"context_line":"                        self.conf.dhcp_lease_time))"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"                if self.network.namespace:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BhMU%3D","line":400,"updated":"2013-11-25 08:36:47.000000000","message":"why did you add an additional ipv4 dhcp-range, I made some test in dnsmasq 2.66, and found pure ipv6 dhcp-range can be work.","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"},{"author":{"_account_id":9464,"name":"Shixiong Shang","email":"sparkofwisdom.cloud@gmail.com","username":"sparkofwisdom.cloud"},"change_message_id":"faeb8e94ff7ce1d1b65a497cd9bb4fce3e5f8c1b","unresolved":false,"context_lines":[{"line_number":397,"context_line":"                cmd.append(\u0027--dhcp-range\u003d%s%s,%s,%s,%ss\u0027 %"},{"line_number":398,"context_line":"                       (set_tag, self._TAG_PREFIX % i,"},{"line_number":399,"context_line":"                        \u00271.1.1.1\u0027,"},{"line_number":400,"context_line":"                        \u0027static\u0027,"},{"line_number":401,"context_line":"                        self.conf.dhcp_lease_time))"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"                if self.network.namespace:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BXGw%3D","line":400,"in_reply_to":"AAAATn%2F%2BhMU%3D","updated":"2013-11-26 23:22:34.000000000","message":"Hi, DaZhao, I tested it with dnsmasq version 2.65. The latest stable release, 2.66 has a bug on IPv6 with single interface running ra mode\n# http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/2013q4/007572.html. When I tested it, dnsmasq actually crashed. So I have to add this dummy subnet to stabilize it.","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"}],"neutron/agent/linux/iptables_firewall.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"7d257b7a54a8fb3bab19b9e506d389aeac17a073","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        return [\u0027-p udp -m udp --sport 67 --dport 68 -j DROP\u0027]"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    # Shixiong"},{"line_number":248,"context_line":"    def _add_rule_by_security_group(self, port, direction):"},{"line_number":249,"context_line":"        chain_name \u003d self._port_chain_name(port, direction)"},{"line_number":250,"context_line":"        # select rules for current direction"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BgZc%3D","line":247,"updated":"2013-11-25 11:48:20.000000000","message":"remove","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"7d257b7a54a8fb3bab19b9e506d389aeac17a073","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        ipv6_iptables_rule \u003d []"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        ipv6_ndp_rules \u003d []"},{"line_number":261,"context_line":"        rule_rs \u003d (\u0027-p ipv6-icmp --icmpv6-type router-solicitation -j ACCEPT\u0027)"},{"line_number":262,"context_line":"        rule_ra \u003d (\u0027-p ipv6-icmp --icmpv6-type router-advertisement -j ACCEPT\u0027)"},{"line_number":263,"context_line":"        rule_ns \u003d (\u0027-p ipv6-icmp --icmpv6-type neighbour-solicitation -j ACCEPT\u0027)"},{"line_number":264,"context_line":"        rule_na \u003d (\u0027-p ipv6-icmp --icmpv6-type neighbour-advertisement -j ACCEPT\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BgYo%3D","line":261,"updated":"2013-11-25 11:48:20.000000000","message":"Suggestion, could remove some duplication, by having an array with just the type (router-solicitation, router-advertisement, ...) and then call append() in a loop using the base string and the array entries applied. E.g. (only with better names :)\n\nfor v6_rule_type in v6_rule_types:\n    ipv6_ndp_rules.append(\u0027-p ipv6-icmp --icmpv6-type %s -j ACCEPT\u0027 % v6_rule_type)","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"},{"author":{"_account_id":9464,"name":"Shixiong Shang","email":"sparkofwisdom.cloud@gmail.com","username":"sparkofwisdom.cloud"},"change_message_id":"faeb8e94ff7ce1d1b65a497cd9bb4fce3e5f8c1b","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        ipv6_iptables_rule \u003d []"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        ipv6_ndp_rules \u003d []"},{"line_number":261,"context_line":"        rule_rs \u003d (\u0027-p ipv6-icmp --icmpv6-type router-solicitation -j ACCEPT\u0027)"},{"line_number":262,"context_line":"        rule_ra \u003d (\u0027-p ipv6-icmp --icmpv6-type router-advertisement -j ACCEPT\u0027)"},{"line_number":263,"context_line":"        rule_ns \u003d (\u0027-p ipv6-icmp --icmpv6-type neighbour-solicitation -j ACCEPT\u0027)"},{"line_number":264,"context_line":"        rule_na \u003d (\u0027-p ipv6-icmp --icmpv6-type neighbour-advertisement -j ACCEPT\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BXCI%3D","line":261,"in_reply_to":"AAAATn%2F%2BgYo%3D","updated":"2013-11-26 23:22:34.000000000","message":"Very good suggestion. I will update the date. Thanks, Paul!","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d785f45a5f464ffc99e8d9c04aea39ac99a36ac3","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        rule_rd \u003d (\u0027-p ipv6-icmp --icmpv6-type redirect -j ACCEPT\u0027)"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        rule_echo_request \u003d (\u0027-p ipv6-icmp --icmpv6-type 128 -j ACCEPT\u0027)"},{"line_number":268,"context_line":"        rule_echo_reply \u003d (\u0027-p ipv6-icmp --icmpv6-type 129 -j ACCEPT\u0027)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        ipv6_ndp_rules.append(rule_rs)"},{"line_number":271,"context_line":"        ipv6_ndp_rules.append(rule_ra)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BdmE%3D","line":268,"updated":"2013-11-25 20:11:23.000000000","message":"Why are you adding rules for Echo?  They\u0027re not necessary for ND.  Also, is the redirect necessary for it either?","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"},{"author":{"_account_id":9464,"name":"Shixiong Shang","email":"sparkofwisdom.cloud@gmail.com","username":"sparkofwisdom.cloud"},"change_message_id":"faeb8e94ff7ce1d1b65a497cd9bb4fce3e5f8c1b","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        rule_rd \u003d (\u0027-p ipv6-icmp --icmpv6-type redirect -j ACCEPT\u0027)"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        rule_echo_request \u003d (\u0027-p ipv6-icmp --icmpv6-type 128 -j ACCEPT\u0027)"},{"line_number":268,"context_line":"        rule_echo_reply \u003d (\u0027-p ipv6-icmp --icmpv6-type 129 -j ACCEPT\u0027)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        ipv6_ndp_rules.append(rule_rs)"},{"line_number":271,"context_line":"        ipv6_ndp_rules.append(rule_ra)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BXBw%3D","line":268,"in_reply_to":"AAAATn%2F%2BdmE%3D","updated":"2013-11-26 23:22:34.000000000","message":"Hi, Brian, sorry for leaving the Echo rules there. It is only for our own testing purpose. I will remove it. For Redirect msg, I would rather prefer leave it here, unless we know for sure router will not issue Redirect msg.","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d785f45a5f464ffc99e8d9c04aea39ac99a36ac3","unresolved":false,"context_lines":[{"line_number":273,"context_line":"        ipv6_ndp_rules.append(rule_na)"},{"line_number":274,"context_line":"        ipv6_ndp_rules.append(rule_rd)"},{"line_number":275,"context_line":"        ipv6_ndp_rules.append(rule_echo_request)"},{"line_number":276,"context_line":"        ipv6_ndp_rules.append(rule_echo_reply)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"        ipv6_iptables_rule +\u003d ipv6_ndp_rules"},{"line_number":279,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BdjI%3D","line":276,"updated":"2013-11-25 20:11:23.000000000","message":"You should be adding these rules in a sub-method, like _spoofing_rule(), and you shouldn\u0027t allow everything in/out, just a subset.\n\nOn input you should allow: RA, NS, and NA, and they should be inserted with a \u0027-j RETURN\u0027, not \u0027-j ACCEPT\u0027.\n\nOn output you really don\u0027t need to do anything, as all packets are allowed by default, but if you want to stop someone from sending an RA you could add a rule to drop that, like the DHCPv4 rule does.","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"},{"author":{"_account_id":9464,"name":"Shixiong Shang","email":"sparkofwisdom.cloud@gmail.com","username":"sparkofwisdom.cloud"},"change_message_id":"faeb8e94ff7ce1d1b65a497cd9bb4fce3e5f8c1b","unresolved":false,"context_lines":[{"line_number":273,"context_line":"        ipv6_ndp_rules.append(rule_na)"},{"line_number":274,"context_line":"        ipv6_ndp_rules.append(rule_rd)"},{"line_number":275,"context_line":"        ipv6_ndp_rules.append(rule_echo_request)"},{"line_number":276,"context_line":"        ipv6_ndp_rules.append(rule_echo_reply)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"        ipv6_iptables_rule +\u003d ipv6_ndp_rules"},{"line_number":279,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BW%2F0%3D","line":276,"in_reply_to":"AAAATn%2F%2BdjI%3D","updated":"2013-11-26 23:22:34.000000000","message":"Very good suggestion, Brian! Will only allow RA, NS, and NA at inbound direction. For _spoofing_rule, if I understand it correctly, it is only used at Egress direction....So maybe we create a separate method?","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"66919e571b4154ce5f2517dc71f338540c235c56","unresolved":false,"context_lines":[{"line_number":476,"context_line":"    # Shixiong"},{"line_number":477,"context_line":"    @staticmethod"},{"line_number":478,"context_line":"    def _generate_ip_v4v6(context, subnets, mac_address):"},{"line_number":479,"context_line":"        \"\"\"Generate an IP address.                          "},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"        The IP address will be generated from one of the subnets defined on"},{"line_number":482,"context_line":"        the network.                 "}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BhLo%3D","line":479,"updated":"2013-11-25 08:36:47.000000000","message":"Remove these blanks","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"},{"author":{"_account_id":9464,"name":"Shixiong Shang","email":"sparkofwisdom.cloud@gmail.com","username":"sparkofwisdom.cloud"},"change_message_id":"faeb8e94ff7ce1d1b65a497cd9bb4fce3e5f8c1b","unresolved":false,"context_lines":[{"line_number":476,"context_line":"    # Shixiong"},{"line_number":477,"context_line":"    @staticmethod"},{"line_number":478,"context_line":"    def _generate_ip_v4v6(context, subnets, mac_address):"},{"line_number":479,"context_line":"        \"\"\"Generate an IP address.                          "},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"        The IP address will be generated from one of the subnets defined on"},{"line_number":482,"context_line":"        the network.                 "}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BXVA%3D","line":479,"in_reply_to":"AAAATn%2F%2BhLo%3D","updated":"2013-11-26 23:22:34.000000000","message":"Thanks, Dazhao! I will remove all of these blanks.","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"66919e571b4154ce5f2517dc71f338540c235c56","unresolved":false,"context_lines":[{"line_number":479,"context_line":"        \"\"\"Generate an IP address.                          "},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"        The IP address will be generated from one of the subnets defined on"},{"line_number":482,"context_line":"        the network.                 "},{"line_number":483,"context_line":"        \"\"\""},{"line_number":484,"context_line":"        range_qry \u003d context.session.query( "},{"line_number":485,"context_line":"            models_v2.IPAvailabilityRange).join("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BhLk%3D","line":482,"updated":"2013-11-25 08:36:47.000000000","message":"as above","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"},{"author":{"_account_id":9464,"name":"Shixiong Shang","email":"sparkofwisdom.cloud@gmail.com","username":"sparkofwisdom.cloud"},"change_message_id":"faeb8e94ff7ce1d1b65a497cd9bb4fce3e5f8c1b","unresolved":false,"context_lines":[{"line_number":479,"context_line":"        \"\"\"Generate an IP address.                          "},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"        The IP address will be generated from one of the subnets defined on"},{"line_number":482,"context_line":"        the network.                 "},{"line_number":483,"context_line":"        \"\"\""},{"line_number":484,"context_line":"        range_qry \u003d context.session.query( "},{"line_number":485,"context_line":"            models_v2.IPAvailabilityRange).join("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BXNU%3D","line":482,"in_reply_to":"AAAATn%2F%2BhLk%3D","updated":"2013-11-26 23:22:34.000000000","message":"Done","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"66919e571b4154ce5f2517dc71f338540c235c56","unresolved":false,"context_lines":[{"line_number":481,"context_line":"        The IP address will be generated from one of the subnets defined on"},{"line_number":482,"context_line":"        the network.                 "},{"line_number":483,"context_line":"        \"\"\""},{"line_number":484,"context_line":"        range_qry \u003d context.session.query( "},{"line_number":485,"context_line":"            models_v2.IPAvailabilityRange).join("},{"line_number":486,"context_line":"                models_v2.IPAllocationPool).with_lockmode(\u0027update\u0027)"},{"line_number":487,"context_line":"        for subnet in subnets:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BhLc%3D","line":484,"updated":"2013-11-25 08:36:47.000000000","message":"as above","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"66919e571b4154ce5f2517dc71f338540c235c56","unresolved":false,"context_lines":[{"line_number":499,"context_line":"                               \u0027first_ip\u0027: range[\u0027first_ip\u0027],"},{"line_number":500,"context_line":"                               \u0027last_ip\u0027: range[\u0027last_ip\u0027]})"},{"line_number":501,"context_line":"                if range[\u0027first_ip\u0027] \u003d\u003d range[\u0027last_ip\u0027]:"},{"line_number":502,"context_line":"                    # No more free indices on subnet \u003d\u003e delete           "},{"line_number":503,"context_line":"                    LOG.debug(_(\"No more free IP\u0027s in slice. Deleting allocation \""},{"line_number":504,"context_line":"                               \"pool.\"))"},{"line_number":505,"context_line":"                    context.session.delete(range)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BhLU%3D","line":502,"updated":"2013-11-25 08:36:47.000000000","message":"as above","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"7d257b7a54a8fb3bab19b9e506d389aeac17a073","unresolved":false,"context_lines":[{"line_number":513,"context_line":"                tmp \u003d cidr.split(\u0027:\u0027)"},{"line_number":514,"context_line":"                subnet_prefix \u003d \":\".join(tmp[:4])"},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"                tmp \u003d mac_address.split(\u0027:\u0027)"},{"line_number":517,"context_line":"                tmp0_int \u003d int(\"0x\" + tmp[0], 16) \u0026 253"},{"line_number":518,"context_line":"                tmp0_hex \u003d hex(tmp0_int)[2:]"},{"line_number":519,"context_line":"                new_tmp \u003d [tmp0_hex+tmp[1], tmp[2]+\u0027ff\u0027, \u0027fe\u0027+tmp[3], tmp[4]+tmp[5]]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BgYA%3D","line":516,"updated":"2013-11-25 11:48:20.000000000","message":"May wait to add a comment explaining what manipulation is being done here.","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"},{"author":{"_account_id":9464,"name":"Shixiong Shang","email":"sparkofwisdom.cloud@gmail.com","username":"sparkofwisdom.cloud"},"change_message_id":"faeb8e94ff7ce1d1b65a497cd9bb4fce3e5f8c1b","unresolved":false,"context_lines":[{"line_number":513,"context_line":"                tmp \u003d cidr.split(\u0027:\u0027)"},{"line_number":514,"context_line":"                subnet_prefix \u003d \":\".join(tmp[:4])"},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"                tmp \u003d mac_address.split(\u0027:\u0027)"},{"line_number":517,"context_line":"                tmp0_int \u003d int(\"0x\" + tmp[0], 16) \u0026 253"},{"line_number":518,"context_line":"                tmp0_hex \u003d hex(tmp0_int)[2:]"},{"line_number":519,"context_line":"                new_tmp \u003d [tmp0_hex+tmp[1], tmp[2]+\u0027ff\u0027, \u0027fe\u0027+tmp[3], tmp[4]+tmp[5]]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BXNY%3D","line":516,"in_reply_to":"AAAATn%2F%2BgYA%3D","updated":"2013-11-26 23:22:34.000000000","message":"Paul, here we tried to calculate IPv6 address assigned to a VM based on SLAAC standard using pre-defined unique MAC address. Below you can find more details: \n\nRFC2327 defines a two-steps process to translate interface 48-bit interface MAC address to 64-bit extended unique identifier (EUI). \n\nThe first step is to convert 48-bit MAC address to 64-bit value. As you may already know, a MAC address is composed of Organizationally Unique Identifier (OUI) and the NIC specific part. Each is 24-bit long. A 16-bit hex value 0xFFFE is inserted between these two halves to form a 64-bit value.\n\nThe second step is to invert the universal/local (U/L) flag, the 7th bit, in the OUI portion of the address. Globally unique addresses should have this bit set to zero and local addresses should have this bit set to one.","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"7d257b7a54a8fb3bab19b9e506d389aeac17a073","unresolved":false,"context_lines":[{"line_number":522,"context_line":"                ip_address \u003d subnet_prefix.lower() + \u0027:\u0027 + eui64.lower()"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"                return {\u0027ip_address\u0027: ip_address, \u0027subnet_id\u0027: subnet[\u0027id\u0027]}"},{"line_number":525,"context_line":" "},{"line_number":526,"context_line":"        raise q_exc.IpAddressGenerationFailure(net_id\u003dsubnets[0][\u0027network_id\u0027])"},{"line_number":527,"context_line":""},{"line_number":528,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BgYQ%3D","line":525,"updated":"2013-11-25 11:48:20.000000000","message":"extra white space.","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"7d257b7a54a8fb3bab19b9e506d389aeac17a073","unresolved":false,"context_lines":[{"line_number":785,"context_line":"                                                           p[\u0027fixed_ips\u0027])"},{"line_number":786,"context_line":"            ips \u003d self._allocate_fixed_ips(context, network, configured_ips)"},{"line_number":787,"context_line":"        else:"},{"line_number":788,"context_line":"            filter \u003d {\u0027network_id\u0027: [p[\u0027network_id\u0027]]}             "},{"line_number":789,"context_line":"            subnets \u003d self.get_subnets(context, filters\u003dfilter)"},{"line_number":790,"context_line":"            # Split into v4 and v6 subnets"},{"line_number":791,"context_line":"            v4 \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BgXs%3D","line":788,"updated":"2013-11-25 11:48:20.000000000","message":"Extra whitespace on L788, 795, 798, 802, 803. Run pep8 to pick up these issues.","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"},{"author":{"_account_id":9464,"name":"Shixiong Shang","email":"sparkofwisdom.cloud@gmail.com","username":"sparkofwisdom.cloud"},"change_message_id":"faeb8e94ff7ce1d1b65a497cd9bb4fce3e5f8c1b","unresolved":false,"context_lines":[{"line_number":785,"context_line":"                                                           p[\u0027fixed_ips\u0027])"},{"line_number":786,"context_line":"            ips \u003d self._allocate_fixed_ips(context, network, configured_ips)"},{"line_number":787,"context_line":"        else:"},{"line_number":788,"context_line":"            filter \u003d {\u0027network_id\u0027: [p[\u0027network_id\u0027]]}             "},{"line_number":789,"context_line":"            subnets \u003d self.get_subnets(context, filters\u003dfilter)"},{"line_number":790,"context_line":"            # Split into v4 and v6 subnets"},{"line_number":791,"context_line":"            v4 \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BXP8%3D","line":788,"in_reply_to":"AAAATn%2F%2BgXs%3D","updated":"2013-11-26 23:22:34.000000000","message":"Hi, Paul, thanks for pointing out the whitespace issues. Will remove them all.","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"7d257b7a54a8fb3bab19b9e506d389aeac17a073","unresolved":false,"context_lines":[{"line_number":1388,"context_line":"    def create_port_bulk(self, context, ports):"},{"line_number":1389,"context_line":"        return self._create_bulk(\u0027port\u0027, context, ports)"},{"line_number":1390,"context_line":""},{"line_number":1391,"context_line":"    # Shixiong"},{"line_number":1392,"context_line":"    def create_port(self, context, port):"},{"line_number":1393,"context_line":"        p \u003d port[\u0027port\u0027]"},{"line_number":1394,"context_line":"        port_id \u003d p.get(\u0027id\u0027) or uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BgXg%3D","line":1391,"updated":"2013-11-25 11:48:20.000000000","message":"remove","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"66919e571b4154ce5f2517dc71f338540c235c56","unresolved":false,"context_lines":[{"line_number":1415,"context_line":"                                                mac\u003dmac_address)"},{"line_number":1416,"context_line":""},{"line_number":1417,"context_line":"            # Returns the IP\u0027s for the port"},{"line_number":1418,"context_line":"            ips \u003d self._allocate_ips_v4v6_for_port(context, network, port, mac_address)"},{"line_number":1419,"context_line":""},{"line_number":1420,"context_line":"            if \u0027status\u0027 not in p:"},{"line_number":1421,"context_line":"                status \u003d constants.PORT_STATUS_ACTIVE"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BhK4%3D","line":1418,"updated":"2013-11-25 08:36:47.000000000","message":"It seems the \"_allocate_ips_for_port\" method is unused","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"},{"author":{"_account_id":9464,"name":"Shixiong Shang","email":"sparkofwisdom.cloud@gmail.com","username":"sparkofwisdom.cloud"},"change_message_id":"faeb8e94ff7ce1d1b65a497cd9bb4fce3e5f8c1b","unresolved":false,"context_lines":[{"line_number":1415,"context_line":"                                                mac\u003dmac_address)"},{"line_number":1416,"context_line":""},{"line_number":1417,"context_line":"            # Returns the IP\u0027s for the port"},{"line_number":1418,"context_line":"            ips \u003d self._allocate_ips_v4v6_for_port(context, network, port, mac_address)"},{"line_number":1419,"context_line":""},{"line_number":1420,"context_line":"            if \u0027status\u0027 not in p:"},{"line_number":1421,"context_line":"                status \u003d constants.PORT_STATUS_ACTIVE"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BXMA%3D","line":1418,"in_reply_to":"AAAATn%2F%2BhK4%3D","updated":"2013-11-26 23:22:34.000000000","message":"Hi, Dazhao, yes, in this case, this method is not used. I didn\u0027t remove it since I am not sure whether there are other methods using it or not...","commit_id":"f31cf566bcea2d152bc3577b1ab788c599956cce"}]}
