)]}'
{"neutron/context.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"586f292ed7f1c3cebd98b8e6aae5044a6280e87d","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                \u0027request_id\u0027: self.request_id,"},{"line_number":128,"context_line":"                \u0027tenant\u0027: self.tenant,"},{"line_number":129,"context_line":"                \u0027user\u0027: self.user,"},{"line_number":130,"context_line":"                \u0027tenant_name\u0027: self.tenant_name,"},{"line_number":131,"context_line":"                \u0027project_name\u0027: self.tenant_name,"},{"line_number":132,"context_line":"                \u0027user_name\u0027: self.user_name,"},{"line_number":133,"context_line":"                }"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BbZk%3D","line":130,"updated":"2013-11-26 08:04:10.000000000","message":"is \u0027tenant_name\u0027 still needed?","commit_id":"a0b8f2cacae2ba436e5cb9922d2e668e924e443d"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"3161aadcfa07a13df87adb586ede745a27ef3d2b","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                \u0027request_id\u0027: self.request_id,"},{"line_number":128,"context_line":"                \u0027tenant\u0027: self.tenant,"},{"line_number":129,"context_line":"                \u0027user\u0027: self.user,"},{"line_number":130,"context_line":"                \u0027tenant_name\u0027: self.tenant_name,"},{"line_number":131,"context_line":"                \u0027project_name\u0027: self.tenant_name,"},{"line_number":132,"context_line":"                \u0027user_name\u0027: self.user_name,"},{"line_number":133,"context_line":"                }"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BYno%3D","line":130,"in_reply_to":"AAAATn%2F%2BbZk%3D","updated":"2013-11-26 16:53:55.000000000","message":"I think I\u0027d prefer to leave the tenant_name reference in pending Akihiro\u0027s review.  I\u0027m not sure if he meant to use project_name instead of tenant_name or simply omitted it.\n\nThat said, your question reminds us of the need to remove usage of the term \u0027tenant\u0027 in favor of \u0027project\u0027, and I\u0027ve filed a blueprint to track such an effort (volunteers welcome): https://blueprints.launchpad.net/neutron/+spec/rename-tenant-to-project","commit_id":"a0b8f2cacae2ba436e5cb9922d2e668e924e443d"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"79f91944c745f284664836d86d1d62973d957ffa","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                \u0027request_id\u0027: self.request_id,"},{"line_number":128,"context_line":"                \u0027tenant\u0027: self.tenant,"},{"line_number":129,"context_line":"                \u0027user\u0027: self.user,"},{"line_number":130,"context_line":"                \u0027tenant_name\u0027: self.tenant_name,"},{"line_number":131,"context_line":"                \u0027project_name\u0027: self.tenant_name,"},{"line_number":132,"context_line":"                \u0027user_name\u0027: self.user_name,"},{"line_number":133,"context_line":"                }"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BYbE%3D","line":130,"updated":"2013-11-26 17:22:28.000000000","message":"to add more context to what\u0027s being discussed on IRC and mailing list should we also remove tenant_name?","commit_id":"911acc91765eed959758a193973a7b976baea6c1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4baf778b4211dabbbf665022e9809811f05ffd2c","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        # Log only once the context has been configured to prevent"},{"line_number":81,"context_line":"        # format errors."},{"line_number":82,"context_line":"        if kwargs:"},{"line_number":83,"context_line":"            # Don\u0027t warn about kwargs that don\u0027t have a value"},{"line_number":84,"context_line":"            kwargs_with_value \u003d dict((x, y) for x, y in kwargs.iteritems()"},{"line_number":85,"context_line":"                                     if y is not None)"},{"line_number":86,"context_line":"            if kwargs_with_value:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BXUs%3D","line":83,"updated":"2013-11-26 21:52:44.000000000","message":"(question) why do we  need to exclude a parameter with None? is there any problem?","commit_id":"41307e217a55dc3dde235903d1148631b1267540"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f2cb84214ad97b82d661df147c104a318ffded31","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        # Log only once the context has been configured to prevent"},{"line_number":81,"context_line":"        # format errors."},{"line_number":82,"context_line":"        if kwargs:"},{"line_number":83,"context_line":"            # Don\u0027t warn about kwargs that don\u0027t have a value"},{"line_number":84,"context_line":"            kwargs_with_value \u003d dict((x, y) for x, y in kwargs.iteritems()"},{"line_number":85,"context_line":"                                     if y is not None)"},{"line_number":86,"context_line":"            if kwargs_with_value:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BWCU%3D","line":83,"in_reply_to":"AAAATn%2F%2BXQs%3D","updated":"2013-11-27 05:31:04.000000000","message":"I got it. It really makes sense.","commit_id":"41307e217a55dc3dde235903d1148631b1267540"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"d93a8c2273c6bc3222cf18e12d83df7c5cd57c2b","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        # Log only once the context has been configured to prevent"},{"line_number":81,"context_line":"        # format errors."},{"line_number":82,"context_line":"        if kwargs:"},{"line_number":83,"context_line":"            # Don\u0027t warn about kwargs that don\u0027t have a value"},{"line_number":84,"context_line":"            kwargs_with_value \u003d dict((x, y) for x, y in kwargs.iteritems()"},{"line_number":85,"context_line":"                                     if y is not None)"},{"line_number":86,"context_line":"            if kwargs_with_value:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BXQs%3D","line":83,"in_reply_to":"AAAATn%2F%2BXUs%3D","updated":"2013-11-26 22:04:31.000000000","message":"If parameters without a value are not ignored, the quantum service log ends up with unnecessary log chatter at the warn level (every second on devstack) since the agent rpc communication constantly sends tenant\u003dNone in the context.","commit_id":"41307e217a55dc3dde235903d1148631b1267540"}]}
