)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"862a5e807f3c8949c6468145841b7e2da1f986f8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Docs] Add note about Floating IP QoS"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As it might be confusing for users that ID of QoS policy"},{"line_number":10,"context_line":"attached to FIP will be also visible in port\u0027s attributes"},{"line_number":11,"context_line":"after associate FIP with port this patch adds small note"},{"line_number":12,"context_line":"about that in QoS documentation."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Additionally this commit fixes also one typo found in"},{"line_number":15,"context_line":"qos configs document."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_6b98eeca","line":12,"range":{"start_line":9,"start_character":40,"end_line":12,"end_character":31},"updated":"2018-07-20 22:10:06.000000000","message":"for some reason, after reading this commit message I thought policy would be visible to port\u0027s and what confusing the users is opposite of this. :)","commit_id":"0cf384111754c782299e2b9ef4f1d0361d01102a"}],"doc/source/admin/config-qos.rst":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"fb4fac0b47c77d0dda77181543169d43a5e16f8e","unresolved":false,"context_lines":[{"line_number":500,"context_line":""},{"line_number":501,"context_line":".. note::"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"   QoS policy id attached to floating IP will not be automatically associated"},{"line_number":504,"context_line":"   and visible in port\u0027s qos_policy_id field after associate floatin IP to a"},{"line_number":505,"context_line":"   port."},{"line_number":506,"context_line":"   ID of QoS policy attached to floating IP is visible only in floating IP"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_55013638","line":503,"range":{"start_line":503,"start_character":26,"end_line":503,"end_character":28},"updated":"2018-07-19 18:38:49.000000000","message":"s/to a","commit_id":"50b7ea426e545e1409e87f444bec56739acc15c6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"fb4fac0b47c77d0dda77181543169d43a5e16f8e","unresolved":false,"context_lines":[{"line_number":501,"context_line":".. note::"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"   QoS policy id attached to floating IP will not be automatically associated"},{"line_number":504,"context_line":"   and visible in port\u0027s qos_policy_id field after associate floatin IP to a"},{"line_number":505,"context_line":"   port."},{"line_number":506,"context_line":"   ID of QoS policy attached to floating IP is visible only in floating IP"},{"line_number":507,"context_line":"   attributes."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_d59226fc","line":504,"range":{"start_line":504,"start_character":51,"end_line":504,"end_character":68},"updated":"2018-07-19 18:38:49.000000000","message":"s/associating a floating","commit_id":"50b7ea426e545e1409e87f444bec56739acc15c6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"fb4fac0b47c77d0dda77181543169d43a5e16f8e","unresolved":false,"context_lines":[{"line_number":503,"context_line":"   QoS policy id attached to floating IP will not be automatically associated"},{"line_number":504,"context_line":"   and visible in port\u0027s qos_policy_id field after associate floatin IP to a"},{"line_number":505,"context_line":"   port."},{"line_number":506,"context_line":"   ID of QoS policy attached to floating IP is visible only in floating IP"},{"line_number":507,"context_line":"   attributes."},{"line_number":508,"context_line":""},{"line_number":509,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_95982e1a","line":506,"range":{"start_line":506,"start_character":3,"end_line":506,"end_character":8},"updated":"2018-07-19 18:38:49.000000000","message":"s/The ID of a","commit_id":"50b7ea426e545e1409e87f444bec56739acc15c6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"fb4fac0b47c77d0dda77181543169d43a5e16f8e","unresolved":false,"context_lines":[{"line_number":503,"context_line":"   QoS policy id attached to floating IP will not be automatically associated"},{"line_number":504,"context_line":"   and visible in port\u0027s qos_policy_id field after associate floatin IP to a"},{"line_number":505,"context_line":"   port."},{"line_number":506,"context_line":"   ID of QoS policy attached to floating IP is visible only in floating IP"},{"line_number":507,"context_line":"   attributes."},{"line_number":508,"context_line":""},{"line_number":509,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_f5be4262","line":506,"range":{"start_line":506,"start_character":47,"end_line":506,"end_character":62},"updated":"2018-07-19 18:38:49.000000000","message":"s/only visible in the","commit_id":"50b7ea426e545e1409e87f444bec56739acc15c6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"fb4fac0b47c77d0dda77181543169d43a5e16f8e","unresolved":false,"context_lines":[{"line_number":503,"context_line":"   QoS policy id attached to floating IP will not be automatically associated"},{"line_number":504,"context_line":"   and visible in port\u0027s qos_policy_id field after associate floatin IP to a"},{"line_number":505,"context_line":"   port."},{"line_number":506,"context_line":"   ID of QoS policy attached to floating IP is visible only in floating IP"},{"line_number":507,"context_line":"   attributes."},{"line_number":508,"context_line":""},{"line_number":509,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_7581d29f","line":506,"range":{"start_line":506,"start_character":29,"end_line":506,"end_character":31},"updated":"2018-07-19 18:38:49.000000000","message":"s/to a","commit_id":"50b7ea426e545e1409e87f444bec56739acc15c6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c07a417d2a20d7022e59801ea7901c028a76d3c1","unresolved":false,"context_lines":[{"line_number":503,"context_line":"   QoS policy id attached to floating IP will not be automatically associated"},{"line_number":504,"context_line":"   and visible in port\u0027s qos_policy_id field after associate floatin IP to a"},{"line_number":505,"context_line":"   port."},{"line_number":506,"context_line":"   ID of QoS policy attached to floating IP is visible only in floating IP"},{"line_number":507,"context_line":"   attributes."},{"line_number":508,"context_line":""},{"line_number":509,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_7080edf6","line":506,"range":{"start_line":506,"start_character":47,"end_line":506,"end_character":62},"in_reply_to":"5f7c97a3_f5be4262","updated":"2018-07-20 11:54:24.000000000","message":"All done. Thx Brian","commit_id":"50b7ea426e545e1409e87f444bec56739acc15c6"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"88bb19451718a0b60eb71c876422bbc305d9b517","unresolved":false,"context_lines":[{"line_number":500,"context_line":""},{"line_number":501,"context_line":".. note::"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"   QoS policy id attached to a floating IP will not be automatically associated"},{"line_number":504,"context_line":"   and visible in port\u0027s qos_policy_id field after associating a floating IP to"},{"line_number":505,"context_line":"   a port."},{"line_number":506,"context_line":"   The ID of a QoS policy attached to a floating IP is only visible in the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_b4c2ec52","line":503,"updated":"2018-07-20 20:29:56.000000000","message":"nit: \"The ID of a QoS policy attached...\"","commit_id":"4a90c7b116fd64a132464aa731cd466521dd8b68"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"98b0d0fdbf2d0d3404be5df05adf227924b0c1b1","unresolved":false,"context_lines":[{"line_number":500,"context_line":""},{"line_number":501,"context_line":".. note::"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"   QoS policy id attached to a floating IP will not be automatically associated"},{"line_number":504,"context_line":"   and visible in port\u0027s qos_policy_id field after associating a floating IP to"},{"line_number":505,"context_line":"   a port."},{"line_number":506,"context_line":"   The ID of a QoS policy attached to a floating IP is only visible in the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_d4e768d6","line":503,"in_reply_to":"5f7c97a3_b4c2ec52","updated":"2018-07-20 20:42:22.000000000","message":"Done","commit_id":"4a90c7b116fd64a132464aa731cd466521dd8b68"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"435c32f7d57ca354795e21ef34bb97b3962346d3","unresolved":false,"context_lines":[{"line_number":501,"context_line":".. note::"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"   QoS policy id attached to a floating IP will not be automatically associated"},{"line_number":504,"context_line":"   and visible in port\u0027s qos_policy_id field after associating a floating IP to"},{"line_number":505,"context_line":"   a port."},{"line_number":506,"context_line":"   The ID of a QoS policy attached to a floating IP is only visible in the"},{"line_number":507,"context_line":"   floating IP attributes."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_2206a222","line":504,"range":{"start_line":504,"start_character":25,"end_line":504,"end_character":38},"updated":"2018-07-20 16:30:15.000000000","message":"Formatting nit: ``qos_policy_id``","commit_id":"4a90c7b116fd64a132464aa731cd466521dd8b68"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"98b0d0fdbf2d0d3404be5df05adf227924b0c1b1","unresolved":false,"context_lines":[{"line_number":501,"context_line":".. note::"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"   QoS policy id attached to a floating IP will not be automatically associated"},{"line_number":504,"context_line":"   and visible in port\u0027s qos_policy_id field after associating a floating IP to"},{"line_number":505,"context_line":"   a port."},{"line_number":506,"context_line":"   The ID of a QoS policy attached to a floating IP is only visible in the"},{"line_number":507,"context_line":"   floating IP attributes."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_7428d4ec","line":504,"range":{"start_line":504,"start_character":25,"end_line":504,"end_character":38},"in_reply_to":"5f7c97a3_2206a222","updated":"2018-07-20 20:42:22.000000000","message":"Done","commit_id":"4a90c7b116fd64a132464aa731cd466521dd8b68"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"88bb19451718a0b60eb71c876422bbc305d9b517","unresolved":false,"context_lines":[{"line_number":503,"context_line":"   QoS policy id attached to a floating IP will not be automatically associated"},{"line_number":504,"context_line":"   and visible in port\u0027s qos_policy_id field after associating a floating IP to"},{"line_number":505,"context_line":"   a port."},{"line_number":506,"context_line":"   The ID of a QoS policy attached to a floating IP is only visible in the"},{"line_number":507,"context_line":"   floating IP attributes."},{"line_number":508,"context_line":""},{"line_number":509,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_d4bd28d1","line":506,"updated":"2018-07-20 20:29:56.000000000","message":"+1 to Bernard\u0027s suggestion.","commit_id":"4a90c7b116fd64a132464aa731cd466521dd8b68"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"c82b4237d2221dc28b09784e7ecd405e51f7dd98","unresolved":false,"context_lines":[{"line_number":503,"context_line":"   QoS policy id attached to a floating IP will not be automatically associated"},{"line_number":504,"context_line":"   and visible in port\u0027s qos_policy_id field after associating a floating IP to"},{"line_number":505,"context_line":"   a port."},{"line_number":506,"context_line":"   The ID of a QoS policy attached to a floating IP is only visible in the"},{"line_number":507,"context_line":"   floating IP attributes."},{"line_number":508,"context_line":""},{"line_number":509,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_42c5de8e","line":506,"range":{"start_line":506,"start_character":3,"end_line":506,"end_character":51},"updated":"2018-07-20 15:58:44.000000000","message":"That\u0027s the same ID as previous sentence \u0027QoS policy id attached to a floating IP\u0027? If so, maybe shorten to \"This ID\" or even It (initial reading I had to double check as I thought this was another parameter)\n(also nitty nit ID/id)","commit_id":"4a90c7b116fd64a132464aa731cd466521dd8b68"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"98b0d0fdbf2d0d3404be5df05adf227924b0c1b1","unresolved":false,"context_lines":[{"line_number":503,"context_line":"   QoS policy id attached to a floating IP will not be automatically associated"},{"line_number":504,"context_line":"   and visible in port\u0027s qos_policy_id field after associating a floating IP to"},{"line_number":505,"context_line":"   a port."},{"line_number":506,"context_line":"   The ID of a QoS policy attached to a floating IP is only visible in the"},{"line_number":507,"context_line":"   floating IP attributes."},{"line_number":508,"context_line":""},{"line_number":509,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_d43c482e","line":506,"in_reply_to":"5f7c97a3_d4bd28d1","updated":"2018-07-20 20:42:22.000000000","message":"Done","commit_id":"4a90c7b116fd64a132464aa731cd466521dd8b68"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"88bb19451718a0b60eb71c876422bbc305d9b517","unresolved":false,"context_lines":[{"line_number":508,"context_line":""},{"line_number":509,"context_line":".. note::"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"   For now, the L3 agent floating IP QoS extension only uses"},{"line_number":512,"context_line":"   ``bandwidth_limit`` rules. Other rule types (like DSCP marking) will be"},{"line_number":513,"context_line":"   silently ignored for floating IPs. A QoS policy that does not contain any"},{"line_number":514,"context_line":"   ``bandwidth_limit`` rules will have no effect when attached to a"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_749e9469","line":511,"updated":"2018-07-20 20:29:56.000000000","message":"s/uses/supports/\n\nOnly make that edit if you think it fits in with the rest of hte patch.","commit_id":"4a90c7b116fd64a132464aa731cd466521dd8b68"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"98b0d0fdbf2d0d3404be5df05adf227924b0c1b1","unresolved":false,"context_lines":[{"line_number":508,"context_line":""},{"line_number":509,"context_line":".. note::"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"   For now, the L3 agent floating IP QoS extension only uses"},{"line_number":512,"context_line":"   ``bandwidth_limit`` rules. Other rule types (like DSCP marking) will be"},{"line_number":513,"context_line":"   silently ignored for floating IPs. A QoS policy that does not contain any"},{"line_number":514,"context_line":"   ``bandwidth_limit`` rules will have no effect when attached to a"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_142080f7","line":511,"in_reply_to":"5f7c97a3_749e9469","updated":"2018-07-20 20:42:22.000000000","message":"I think it is not necessary to do separate patch to fix this one word so I do it here also :)","commit_id":"4a90c7b116fd64a132464aa731cd466521dd8b68"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"fd99f5a3b9d1f94d944074fefbb636c8a22682e8","unresolved":false,"context_lines":[{"line_number":500,"context_line":""},{"line_number":501,"context_line":".. note::"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"   The ID of QoS policy attached to a floating IP will not be automatically"},{"line_number":504,"context_line":"   associated and visible in port\u0027s ``qos_policy_id`` field after associating a"},{"line_number":505,"context_line":"   floating IP to a port."},{"line_number":506,"context_line":"   It is only visible in the floating IP attributes."}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f7c97a3_1a622fa8","line":503,"range":{"start_line":503,"start_character":10,"end_line":503,"end_character":12},"updated":"2018-07-30 17:17:23.000000000","message":"s/of a","commit_id":"0cf384111754c782299e2b9ef4f1d0361d01102a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"31ae4700f20b3989e2be9ce0b29b049481c0e88a","unresolved":false,"context_lines":[{"line_number":500,"context_line":""},{"line_number":501,"context_line":".. note::"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"   The ID of QoS policy attached to a floating IP will not be automatically"},{"line_number":504,"context_line":"   associated and visible in port\u0027s ``qos_policy_id`` field after associating a"},{"line_number":505,"context_line":"   floating IP to a port."},{"line_number":506,"context_line":"   It is only visible in the floating IP attributes."}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f7c97a3_c029263a","line":503,"range":{"start_line":503,"start_character":10,"end_line":503,"end_character":12},"in_reply_to":"5f7c97a3_1a622fa8","updated":"2018-07-30 18:35:32.000000000","message":"Done","commit_id":"0cf384111754c782299e2b9ef4f1d0361d01102a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"fd99f5a3b9d1f94d944074fefbb636c8a22682e8","unresolved":false,"context_lines":[{"line_number":501,"context_line":".. note::"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"   The ID of QoS policy attached to a floating IP will not be automatically"},{"line_number":504,"context_line":"   associated and visible in port\u0027s ``qos_policy_id`` field after associating a"},{"line_number":505,"context_line":"   floating IP to a port."},{"line_number":506,"context_line":"   It is only visible in the floating IP attributes."},{"line_number":507,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f7c97a3_3af4cbcf","line":504,"range":{"start_line":504,"start_character":26,"end_line":504,"end_character":28},"updated":"2018-07-30 17:17:23.000000000","message":"s/in a","commit_id":"0cf384111754c782299e2b9ef4f1d0361d01102a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"31ae4700f20b3989e2be9ce0b29b049481c0e88a","unresolved":false,"context_lines":[{"line_number":501,"context_line":".. note::"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"   The ID of QoS policy attached to a floating IP will not be automatically"},{"line_number":504,"context_line":"   associated and visible in port\u0027s ``qos_policy_id`` field after associating a"},{"line_number":505,"context_line":"   floating IP to a port."},{"line_number":506,"context_line":"   It is only visible in the floating IP attributes."},{"line_number":507,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f7c97a3_e02ea240","line":504,"range":{"start_line":504,"start_character":26,"end_line":504,"end_character":28},"in_reply_to":"5f7c97a3_3af4cbcf","updated":"2018-07-30 18:35:32.000000000","message":"Done","commit_id":"0cf384111754c782299e2b9ef4f1d0361d01102a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"fd99f5a3b9d1f94d944074fefbb636c8a22682e8","unresolved":false,"context_lines":[{"line_number":502,"context_line":""},{"line_number":503,"context_line":"   The ID of QoS policy attached to a floating IP will not be automatically"},{"line_number":504,"context_line":"   associated and visible in port\u0027s ``qos_policy_id`` field after associating a"},{"line_number":505,"context_line":"   floating IP to a port."},{"line_number":506,"context_line":"   It is only visible in the floating IP attributes."},{"line_number":507,"context_line":""},{"line_number":508,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f7c97a3_da2ef740","line":505,"range":{"start_line":505,"start_character":18,"end_line":505,"end_character":19},"updated":"2018-07-30 17:17:23.000000000","message":"s/the","commit_id":"0cf384111754c782299e2b9ef4f1d0361d01102a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"31ae4700f20b3989e2be9ce0b29b049481c0e88a","unresolved":false,"context_lines":[{"line_number":502,"context_line":""},{"line_number":503,"context_line":"   The ID of QoS policy attached to a floating IP will not be automatically"},{"line_number":504,"context_line":"   associated and visible in port\u0027s ``qos_policy_id`` field after associating a"},{"line_number":505,"context_line":"   floating IP to a port."},{"line_number":506,"context_line":"   It is only visible in the floating IP attributes."},{"line_number":507,"context_line":""},{"line_number":508,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f7c97a3_401d160e","line":505,"range":{"start_line":505,"start_character":18,"end_line":505,"end_character":19},"in_reply_to":"5f7c97a3_da2ef740","updated":"2018-07-30 18:35:32.000000000","message":"Done","commit_id":"0cf384111754c782299e2b9ef4f1d0361d01102a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"fd99f5a3b9d1f94d944074fefbb636c8a22682e8","unresolved":false,"context_lines":[{"line_number":503,"context_line":"   The ID of QoS policy attached to a floating IP will not be automatically"},{"line_number":504,"context_line":"   associated and visible in port\u0027s ``qos_policy_id`` field after associating a"},{"line_number":505,"context_line":"   floating IP to a port."},{"line_number":506,"context_line":"   It is only visible in the floating IP attributes."},{"line_number":507,"context_line":""},{"line_number":508,"context_line":".. note::"},{"line_number":509,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f7c97a3_1a10eff3","line":506,"updated":"2018-07-30 17:17:23.000000000","message":"I think this can just be added to L505 and doesn\u0027t need a newline.","commit_id":"0cf384111754c782299e2b9ef4f1d0361d01102a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"31ae4700f20b3989e2be9ce0b29b049481c0e88a","unresolved":false,"context_lines":[{"line_number":503,"context_line":"   The ID of QoS policy attached to a floating IP will not be automatically"},{"line_number":504,"context_line":"   associated and visible in port\u0027s ``qos_policy_id`` field after associating a"},{"line_number":505,"context_line":"   floating IP to a port."},{"line_number":506,"context_line":"   It is only visible in the floating IP attributes."},{"line_number":507,"context_line":""},{"line_number":508,"context_line":".. note::"},{"line_number":509,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f7c97a3_20101af4","line":506,"in_reply_to":"5f7c97a3_1a10eff3","updated":"2018-07-30 18:35:32.000000000","message":"Done","commit_id":"0cf384111754c782299e2b9ef4f1d0361d01102a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"622982d16d8d5400c89a054dd65276d128998fac","unresolved":false,"context_lines":[{"line_number":499,"context_line":"       0eeb1f8a-de96-4cd9-a0f6-3f535c409558"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":".. note::"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"   The ID of a QoS policy attached to a floating IP will not be automatically"},{"line_number":504,"context_line":"   associated and visible in a port\u0027s ``qos_policy_id`` field after associating"},{"line_number":505,"context_line":"   a floating IP to the port. It is only visible in the floating IP attributes."}],"source_content_type":"text/x-rst","patch_set":5,"id":"5f7c97a3_6031170a","line":502,"updated":"2018-07-31 17:30:20.000000000","message":"I think it is better to explain that QoS policy attached to a floating IP affects not a port but a floating IP only. How about the following?\n\n  The QoS policy attached to a floating IP is not applied to a port.\n  It is applied to an associated floating IP only.\n  Thus the ID of QoS policy attached to a floating IP will not be visible\n  in a port\u0027s ``qos_policy_id`` field after asscoating a floating IP to\n  the port. It is only visible in the floating IP attributes.\n\n(The last two sentences are untouched.)","commit_id":"4ab2f97f227af93a875b691a88ad4b95b2348215"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"56884e62a0df16897618daddaf4aa381dc641a09","unresolved":false,"context_lines":[{"line_number":499,"context_line":"       0eeb1f8a-de96-4cd9-a0f6-3f535c409558"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":".. note::"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"   The ID of a QoS policy attached to a floating IP will not be automatically"},{"line_number":504,"context_line":"   associated and visible in a port\u0027s ``qos_policy_id`` field after associating"},{"line_number":505,"context_line":"   a floating IP to the port. It is only visible in the floating IP attributes."}],"source_content_type":"text/x-rst","patch_set":5,"id":"5f7c97a3_6fc33f3a","line":502,"in_reply_to":"5f7c97a3_6031170a","updated":"2018-07-31 21:22:04.000000000","message":"Thx. Changed :)","commit_id":"4ab2f97f227af93a875b691a88ad4b95b2348215"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"622982d16d8d5400c89a054dd65276d128998fac","unresolved":false,"context_lines":[{"line_number":514,"context_line":""},{"line_number":515,"context_line":"   If floating IP is bound to a port, and both have binding QoS bandwidth"},{"line_number":516,"context_line":"   rules, the L3 agent floating IP QoS extension ignores the behavior of"},{"line_number":517,"context_line":"   the port QoS, and installs the rules on the appropriate device in the"},{"line_number":518,"context_line":"   router namespace."},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"Each project can have at most one default QoS policy, although it is not"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5f7c97a3_e0052716","line":517,"range":{"start_line":517,"start_character":30,"end_line":517,"end_character":40},"updated":"2018-07-31 17:30:20.000000000","message":"(this comment is not directly related to this patch)\n\nI think it is a bit confusing. I think \"the rules\" means \"the rules from QoS policy associated to the floating IP\".","commit_id":"4ab2f97f227af93a875b691a88ad4b95b2348215"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"56884e62a0df16897618daddaf4aa381dc641a09","unresolved":false,"context_lines":[{"line_number":514,"context_line":""},{"line_number":515,"context_line":"   If floating IP is bound to a port, and both have binding QoS bandwidth"},{"line_number":516,"context_line":"   rules, the L3 agent floating IP QoS extension ignores the behavior of"},{"line_number":517,"context_line":"   the port QoS, and installs the rules on the appropriate device in the"},{"line_number":518,"context_line":"   router namespace."},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"Each project can have at most one default QoS policy, although it is not"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5f7c97a3_4f24430e","line":517,"range":{"start_line":517,"start_character":30,"end_line":517,"end_character":40},"in_reply_to":"5f7c97a3_e0052716","updated":"2018-07-31 21:22:04.000000000","message":"You\u0027re right. I updated this also. I don\u0027t think that doing it in separate commit is really necessary :)","commit_id":"4ab2f97f227af93a875b691a88ad4b95b2348215"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"52406b42580aac9df1648eadb50447f83da7410b","unresolved":false,"context_lines":[{"line_number":500,"context_line":""},{"line_number":501,"context_line":".. note::"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"   The QoS policy attached to a floating IP is not applied to a port."},{"line_number":504,"context_line":"   It is applied to an associated floating IP only."},{"line_number":505,"context_line":"   Thus the ID of QoS policy attached to a floating IP will not be visible"},{"line_number":506,"context_line":"   in a port\u0027s ``qos_policy_id`` field after asscoating a floating IP to"},{"line_number":507,"context_line":"   the port. It is only visible in the floating IP attributes."}],"source_content_type":"text/x-rst","patch_set":7,"id":"5f7c97a3_d04c6141","line":504,"range":{"start_line":503,"start_character":68,"end_line":504,"end_character":5},"updated":"2018-08-01 17:07:58.000000000","message":"s/, it","commit_id":"7df8a6df3e90871aae825c4cd9cfa5f1e6d09800"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e218ede1c5f819f71e8482e5b49b3cd99e1e605c","unresolved":false,"context_lines":[{"line_number":500,"context_line":""},{"line_number":501,"context_line":".. note::"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"   The QoS policy attached to a floating IP is not applied to a port."},{"line_number":504,"context_line":"   It is applied to an associated floating IP only."},{"line_number":505,"context_line":"   Thus the ID of QoS policy attached to a floating IP will not be visible"},{"line_number":506,"context_line":"   in a port\u0027s ``qos_policy_id`` field after asscoating a floating IP to"},{"line_number":507,"context_line":"   the port. It is only visible in the floating IP attributes."}],"source_content_type":"text/x-rst","patch_set":7,"id":"5f7c97a3_ce5fdee1","line":504,"range":{"start_line":503,"start_character":68,"end_line":504,"end_character":5},"in_reply_to":"5f7c97a3_d04c6141","updated":"2018-08-01 18:41:27.000000000","message":"Done","commit_id":"7df8a6df3e90871aae825c4cd9cfa5f1e6d09800"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"52406b42580aac9df1648eadb50447f83da7410b","unresolved":false,"context_lines":[{"line_number":516,"context_line":""},{"line_number":517,"context_line":"   If floating IP is bound to a port, and both have binding QoS bandwidth"},{"line_number":518,"context_line":"   rules, the L3 agent floating IP QoS extension ignores the behavior of"},{"line_number":519,"context_line":"   the port QoS, and installs the rules from QoS policy associated to the"},{"line_number":520,"context_line":"   floating IP on the appropriate device in the router namespace."},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"Each project can have at most one default QoS policy, although it is not"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5f7c97a3_10473920","line":519,"range":{"start_line":519,"start_character":40,"end_line":519,"end_character":44},"updated":"2018-08-01 17:07:58.000000000","message":"s/from the","commit_id":"7df8a6df3e90871aae825c4cd9cfa5f1e6d09800"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e218ede1c5f819f71e8482e5b49b3cd99e1e605c","unresolved":false,"context_lines":[{"line_number":516,"context_line":""},{"line_number":517,"context_line":"   If floating IP is bound to a port, and both have binding QoS bandwidth"},{"line_number":518,"context_line":"   rules, the L3 agent floating IP QoS extension ignores the behavior of"},{"line_number":519,"context_line":"   the port QoS, and installs the rules from QoS policy associated to the"},{"line_number":520,"context_line":"   floating IP on the appropriate device in the router namespace."},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"Each project can have at most one default QoS policy, although it is not"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5f7c97a3_8e5566c3","line":519,"range":{"start_line":519,"start_character":40,"end_line":519,"end_character":44},"in_reply_to":"5f7c97a3_10473920","updated":"2018-08-01 18:41:27.000000000","message":"Done","commit_id":"7df8a6df3e90871aae825c4cd9cfa5f1e6d09800"}]}
