)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"af7f0380dd262d33d8a6f1e8876bd54349286860","unresolved":false,"context_lines":[{"line_number":10,"context_line":"multiple MAC addresses for the bulk added ports.  This change leverages"},{"line_number":11,"context_line":"the code added in [1] to make bulk MAC creation available."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Note that [1] was not included in neutron-lib 1.18.0, so this will be"},{"line_number":14,"context_line":"blocked until the next neutron-lib release.  This note will be removed"},{"line_number":15,"context_line":"once a new release is in progress."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1] https://review.openstack.org/510830"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3f79a3b5_0c5b6bf9","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":34},"updated":"2018-10-06 00:12:20.000000000","message":"We need to update this since 1.19.0 was released https://review.openstack.org/#/c/604908/","commit_id":"4de1eaab90fee89fcf6b425353e6853d9245dbb9"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"86f5fd58a4da2bb0cb76c44373c0ff99be6e35c2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"multiple MAC addresses for the bulk added ports.  This change leverages"},{"line_number":11,"context_line":"the code added in [1] to make bulk MAC creation available."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Note that [1] was not included in neutron-lib 1.18.0, so this will be"},{"line_number":14,"context_line":"blocked until the next neutron-lib release.  This note will be removed"},{"line_number":15,"context_line":"once a new release is in progress."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1] https://review.openstack.org/510830"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3f79a3b5_c36504e4","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":34},"in_reply_to":"3f79a3b5_0c5b6bf9","updated":"2018-10-09 20:57:56.000000000","message":"Done","commit_id":"4de1eaab90fee89fcf6b425353e6853d9245dbb9"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"275b8b5f23fa130205d3a2dd42eb70eb66431d7b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"[1] https://review.openstack.org/510830"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Implements: blueprint speed-up-neutron-bulk-creation"},{"line_number":16,"context_line":"Depends-On: https://review.openstack.org/613149"},{"line_number":17,"context_line":"Change-Id: Ia769dadf69781ba511a19c52998949b668963a19"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"3f79a3b5_15b84710","line":16,"updated":"2018-10-31 23:38:51.000000000","message":"we need to release new neutron-lib version to move on with this patch","commit_id":"f4c8db01219c65faf6a276d237c4817b2192d04b"}],"neutron/db/db_base_plugin_common.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"af7f0380dd262d33d8a6f1e8876bd54349286860","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    \"\"\""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @staticmethod"},{"line_number":91,"context_line":"    def _generate_mac(mac_count\u003d1):"},{"line_number":92,"context_line":"        if mac_count \u003d\u003d 1:"},{"line_number":93,"context_line":"            return net.get_random_mac(cfg.CONF.base_mac.split(\u0027:\u0027))"},{"line_number":94,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_ec406f09","line":91,"range":{"start_line":91,"start_character":8,"end_line":91,"end_character":21},"updated":"2018-10-06 00:12:20.000000000","message":"I think it should be renamed _generate_macs","commit_id":"4de1eaab90fee89fcf6b425353e6853d9245dbb9"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"86f5fd58a4da2bb0cb76c44373c0ff99be6e35c2","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    \"\"\""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @staticmethod"},{"line_number":91,"context_line":"    def _generate_mac(mac_count\u003d1):"},{"line_number":92,"context_line":"        if mac_count \u003d\u003d 1:"},{"line_number":93,"context_line":"            return net.get_random_mac(cfg.CONF.base_mac.split(\u0027:\u0027))"},{"line_number":94,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_437254b2","line":91,"range":{"start_line":91,"start_character":8,"end_line":91,"end_character":21},"in_reply_to":"3f79a3b5_ec406f09","updated":"2018-10-09 20:57:56.000000000","message":"Done","commit_id":"4de1eaab90fee89fcf6b425353e6853d9245dbb9"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e795904f3a1a9d7fcc3eac56fe469ddf413f5e3a","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    @staticmethod"},{"line_number":91,"context_line":"    def _generate_mac(mac_count\u003d1):"},{"line_number":92,"context_line":"        if mac_count \u003d\u003d 1:"},{"line_number":93,"context_line":"            return net.get_random_mac(cfg.CONF.base_mac.split(\u0027:\u0027))"},{"line_number":94,"context_line":"        else:"},{"line_number":95,"context_line":"            mac_maker \u003d net.random_mac_generator(cfg.CONF.base_mac.split(\u0027:\u0027))"},{"line_number":96,"context_line":"            return [next(mac_maker) for x in range(mac_count)]"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_1314df9e","line":93,"updated":"2018-10-07 09:53:32.000000000","message":"Can\u0027t it return list with 1 mac if mac_count\u003d1? do we need to special handling this case and return different type of value in such case?\nAnd also, I agree with Miguel that this should be named \"_generate_macs\" now.","commit_id":"4de1eaab90fee89fcf6b425353e6853d9245dbb9"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"86f5fd58a4da2bb0cb76c44373c0ff99be6e35c2","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    @staticmethod"},{"line_number":91,"context_line":"    def _generate_mac(mac_count\u003d1):"},{"line_number":92,"context_line":"        if mac_count \u003d\u003d 1:"},{"line_number":93,"context_line":"            return net.get_random_mac(cfg.CONF.base_mac.split(\u0027:\u0027))"},{"line_number":94,"context_line":"        else:"},{"line_number":95,"context_line":"            mac_maker \u003d net.random_mac_generator(cfg.CONF.base_mac.split(\u0027:\u0027))"},{"line_number":96,"context_line":"            return [next(mac_maker) for x in range(mac_count)]"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_a341e838","line":93,"in_reply_to":"3f79a3b5_1314df9e","updated":"2018-10-09 20:57:56.000000000","message":"Done","commit_id":"4de1eaab90fee89fcf6b425353e6853d9245dbb9"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"91c5f6ab2c3c3fe57f742427c00dbf8417c9dbf1","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @staticmethod"},{"line_number":91,"context_line":"    def _generate_mac(mac_count\u003d1):"},{"line_number":92,"context_line":"        if mac_count \u003d\u003d 1:"},{"line_number":93,"context_line":"            return net.get_random_mac(cfg.CONF.base_mac.split(\u0027:\u0027))"},{"line_number":94,"context_line":"        else:"},{"line_number":95,"context_line":"            mac_maker \u003d net.random_mac_generator(cfg.CONF.base_mac.split(\u0027:\u0027))"},{"line_number":96,"context_line":"            return [next(mac_maker) for x in range(mac_count)]"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_fe2b3598","line":94,"range":{"start_line":92,"start_character":7,"end_line":94,"end_character":13},"updated":"2018-10-05 22:01:45.000000000","message":"this can be removed ?, _mac_generator will take care of it even if the count is 1 ? although type of result may vary so might need updates wherever its used.","commit_id":"4de1eaab90fee89fcf6b425353e6853d9245dbb9"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"86f5fd58a4da2bb0cb76c44373c0ff99be6e35c2","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @staticmethod"},{"line_number":91,"context_line":"    def _generate_mac(mac_count\u003d1):"},{"line_number":92,"context_line":"        if mac_count \u003d\u003d 1:"},{"line_number":93,"context_line":"            return net.get_random_mac(cfg.CONF.base_mac.split(\u0027:\u0027))"},{"line_number":94,"context_line":"        else:"},{"line_number":95,"context_line":"            mac_maker \u003d net.random_mac_generator(cfg.CONF.base_mac.split(\u0027:\u0027))"},{"line_number":96,"context_line":"            return [next(mac_maker) for x in range(mac_count)]"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_63751097","line":94,"range":{"start_line":92,"start_character":7,"end_line":94,"end_character":13},"in_reply_to":"3f79a3b5_0c328bc1","updated":"2018-10-09 20:57:56.000000000","message":"Done.  Updated everywhere in Neutron so that the return form is considered a list.  But @mlavalle, does this mean it needs a release note?","commit_id":"4de1eaab90fee89fcf6b425353e6853d9245dbb9"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"af7f0380dd262d33d8a6f1e8876bd54349286860","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @staticmethod"},{"line_number":91,"context_line":"    def _generate_mac(mac_count\u003d1):"},{"line_number":92,"context_line":"        if mac_count \u003d\u003d 1:"},{"line_number":93,"context_line":"            return net.get_random_mac(cfg.CONF.base_mac.split(\u0027:\u0027))"},{"line_number":94,"context_line":"        else:"},{"line_number":95,"context_line":"            mac_maker \u003d net.random_mac_generator(cfg.CONF.base_mac.split(\u0027:\u0027))"},{"line_number":96,"context_line":"            return [next(mac_maker) for x in range(mac_count)]"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_0c328bc1","line":94,"range":{"start_line":92,"start_character":7,"end_line":94,"end_character":13},"in_reply_to":"3f79a3b5_fe2b3598","updated":"2018-10-06 00:12:20.000000000","message":"Yes, I think manjeets is on to something:\n\n1) Looking at codesearch, _generate_mac is used only a handful times in Neutron and a couple of times in networking-h3c. This latter project doesn\u0027t seem active (https://review.openstack.org/#/q/project:openstack/networking-h3c), so I don\u0027t think we don\u0027t need to worry about it. The uses in Neutron should be very easy to fix\n\n2) It seems off to call a method _generate_mac to generate several macs. I think it should be renamed _generate_macs","commit_id":"4de1eaab90fee89fcf6b425353e6853d9245dbb9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c31f3eb41218d04a1f44233facb99ad81fd393e7","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    @staticmethod"},{"line_number":93,"context_line":"    def _generate_macs(mac_count\u003d1):"},{"line_number":94,"context_line":"        mac_maker \u003d net.random_mac_generator(cfg.CONF.base_mac.split(\u0027:\u0027))"},{"line_number":95,"context_line":"        print \"mac 1 is \" + six.next(mac_maker)"},{"line_number":96,"context_line":"        return [six.next(mac_maker) for x in range(mac_count)]"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    @db_api.context_manager.reader"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_2abe8eae","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":13},"updated":"2018-10-27 16:05:45.000000000","message":"Is this for debug porpouses?","commit_id":"ceb8f1d902a09b4066b9022861bbf9240cd4529f"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"a8f7c9606e00b8ebf83b54e60697b7d58e9bf4b5","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    @staticmethod"},{"line_number":93,"context_line":"    def _generate_macs(mac_count\u003d1):"},{"line_number":94,"context_line":"        mac_maker \u003d net.random_mac_generator(cfg.CONF.base_mac.split(\u0027:\u0027))"},{"line_number":95,"context_line":"        print \"mac 1 is \" + six.next(mac_maker)"},{"line_number":96,"context_line":"        return [six.next(mac_maker) for x in range(mac_count)]"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    @db_api.context_manager.reader"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_dff75028","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":13},"in_reply_to":"3f79a3b5_2abe8eae","updated":"2018-10-31 20:43:07.000000000","message":"Oops!  Missed that.","commit_id":"ceb8f1d902a09b4066b9022861bbf9240cd4529f"}]}